Andy Brett
7ad165ee3c
remove migration
2021-02-10 18:45:58 +01:00
Pau Perez
3c8aa875a0
Update db/schema's timestamp after migration
2021-02-09 14:53:52 +01:00
Andy Brett
49c8cb82c7
use #destroy_all
2021-02-09 14:53:49 +01:00
Andy Brett
ef70bfdc3c
remove variants with no product
2021-02-09 14:53:44 +01:00
Pau Perez
5832bce1e4
Update all locales with the latest Transifex translations
2021-02-05 11:28:29 +01:00
Pau Pérez Fabregat
6ccf4b0245
Merge pull request #6817 from openfoodfoundation/transifex
...
Transifex
2021-02-05 11:24:00 +01:00
Transifex-Openfoodnetwork
dd2baf7e96
Updating translations for config/locales/en_FR.yml
2021-02-05 20:23:24 +11:00
Transifex-Openfoodnetwork
4a619e596e
Updating translations for config/locales/fr.yml
2021-02-05 20:22:32 +11:00
Pau Pérez Fabregat
aee56f6331
Merge pull request #6812 from openfoodfoundation/transifex
...
Transifex
2021-02-05 08:45:46 +01:00
Andy Brett
d3ad997964
Merge pull request #6792 from andrewpbrett/migrate-variant-unit-values
...
Migrate variants with nil unit_value
2021-02-04 18:00:23 -08:00
Andy Brett
f746dec537
update spec
2021-02-04 13:52:45 -08:00
Andy Brett
1e863c6e65
Merge branch 'master' into migrate-variant-unit-values
2021-02-04 13:27:30 -08:00
Andy Brett
9c135ee0f7
add default to unit_value and weight
2021-02-04 13:17:43 -08:00
Pau Pérez Fabregat
3ab6da03e7
Merge pull request #6296 from luisramos0/remove_migs
...
Remove Migs payment gateway
2021-02-04 22:07:35 +01:00
Pau Pérez Fabregat
4b892d408e
Merge pull request #6809 from andrewpbrett/remove-bogus-providers
...
Remove "Bogus" payment providers from staging and production
2021-02-04 21:09:16 +01:00
Pau Pérez Fabregat
35a76a313a
Merge pull request #6807 from jibees/6798-new-product-form-fill-all-space
...
New Product Form: Fill all space available
2021-02-04 21:08:56 +01:00
Andy Brett
212186e059
check all variants, not just where we use 'items'
2021-02-04 11:45:36 -08:00
Andy Brett
d642984261
add db constraint; check for existing nil/nan in migration
2021-02-04 11:24:35 -08:00
Pau Pérez Fabregat
f6e6b6041c
Merge pull request #6734 from coopdevs/disable-ui-mail-settings
...
Disable mail methods form so no one can edit
2021-02-04 17:57:32 +01:00
Andy Brett
91245ae6ab
also set weight to default to 0.0
2021-02-04 08:05:48 -08:00
Pau Pérez Fabregat
76fa63fd71
Merge pull request #6789 from coopdevs/authorize-only-changed-vos
...
Authorize only changed vos
2021-02-04 15:22:50 +01:00
Transifex-Openfoodnetwork
6c4f74e4e4
Updating translations for config/locales/es.yml
2021-02-04 20:06:10 +11:00
Transifex-Openfoodnetwork
3505ced3c2
Updating translations for config/locales/ca.yml
2021-02-04 20:05:50 +11:00
Pau Pérez Fabregat
4d7b29ca33
Merge pull request #6811 from openfoodfoundation/transifex
...
Transifex
2021-02-04 10:05:07 +01:00
Transifex-Openfoodnetwork
ea134d4600
Updating translations for config/locales/en_FR.yml
2021-02-04 19:07:08 +11:00
Transifex-Openfoodnetwork
e3b7736c68
Updating translations for config/locales/fr.yml
2021-02-04 19:06:37 +11:00
Transifex-Openfoodnetwork
439280d046
Updating translations for config/locales/de_DE.yml
2021-02-04 10:52:26 +11:00
Andy Brett
51630ac77b
remove "Bogus" payment providers from staging and production
2021-02-03 14:03:13 -08:00
Luis Ramos
e5e2402a7c
Add migrate to rename Migs payments to check
2021-02-03 21:53:15 +00:00
Luis Ramos
60667e23d9
Remove en.yml migs entry
2021-02-03 21:47:37 +00:00
Luis Ramos
e69eefdc0f
Remove Migs payment gateway
2021-02-03 21:41:40 +00:00
Jean-Baptiste Bellet
4cb98dd4ac
Fill all space available
...
These two fields (Display As, and Unit Names) are mutually exclusive: they are never displayed at the same time. Use all the available space.
2021-02-03 21:44:33 +01:00
Andy Brett
50074aae9d
update db schema
2021-02-03 08:45:42 -08:00
Pau Pérez Fabregat
79f98bdfa7
Merge pull request #6770 from Matt-Yorkley/more-dead-code
...
Dead code: Spree::Order#clear_adjustments
2021-02-03 09:37:42 +01:00
Pau Pérez Fabregat
fbab5120f1
Merge pull request #6771 from Matt-Yorkley/touch-updated-at
...
Touch updated_at column when updating records via #update_column
2021-02-03 09:33:37 +01:00
Andy Brett
4ba5d9dafc
Merge pull request #6779 from openfoodfoundation/dependabot/bundler/test-unit-3.4.0
...
Bump test-unit from 3.3.9 to 3.4.0
2021-02-02 14:50:23 -08:00
Andy Brett
142af0055c
use #find_each instead of #each
2021-02-02 09:40:17 -08:00
Andy Brett
109a3da104
use more efficient query; enforce not null at db level
2021-02-02 09:32:47 -08:00
Pau Pérez Fabregat
19636c687e
Merge pull request #6796 from openfoodfoundation/transifex
...
Transifex
2021-02-02 15:50:15 +01:00
Pau Pérez Fabregat
32892b7ae5
Merge pull request #6793 from openfoodfoundation/dependabot/bundler/rubocop-1.9.1
...
Bump rubocop from 1.9.0 to 1.9.1
2021-02-02 15:49:48 +01:00
Pau Pérez Fabregat
9bb2970a07
Merge pull request #6782 from jibees/6766-manage-hover-on-account-tabs
...
User profile tabs: specify :hover rule only for devices that can effectively handle it
2021-02-02 15:47:03 +01:00
Pau Perez
a19aceae8c
Replace spree_put with put in controller tests
...
This removes the following annoying deprecation warnings that happen in
each test.
```
DEPRECATION WARNING: You are trying to generate the URL for a named route called :main_app but no such route was found. In the future, this will result in an `ActionController::UrlGenerationError` exception. (called from process_action_with_route at /usr/s
rc/app/spec/support/controller_requests_helper.rb:49)
DEPRECATION WARNING: Passing the `use_route` option in functional tests are deprecated. Support for this option in the `process` method (and the related `get`, `head`, `post`, `patch`, `put` and `delete` helpers) will be removed in the next version without
replacement. Functional tests are essentially unit tests for controllers and they should not require knowledge to how the application's routes are configured. Instead, you should explicitly pass the appropiate params to the `process` method. Previously th
e engines guide also contained an incorrect example that recommended using this option to test an engine's controllers within the dummy application. That recommendation was incorrect and has since been corrected. Instead, you should override the `@routes`
variable in the test case with `Foo::Engine.routes`. See the updated engines guide for details. (called from process_action_with_route at /usr/src/app/spec/support/controller_requests_helper.rb:49)
```
2021-02-02 15:39:24 +01:00
Pau Perez
aef0d28dd1
Do not load unmodified VOs from DB
...
Closes #6727 .
This avoids the authorization of all the VOs of the hub, which will go
through VOs that may have become invalid due to their underlying product
not belonging to the supplier the hub has permissions with (or any other
data integrity issue).
This is utterly confusing for the user who is only given a generic error
and doesn't understand what's wrong with the particular VO they changed,
while it may be fine after all. What's more, this often results in
a customer support request, which then may end up with a dev finding out
which VO is broken.
Also, there's no point in loading them from DB if the users didn't touch
them.
2021-02-02 15:39:23 +01:00
Pau Pérez Fabregat
d48aa4a73f
Merge pull request #6748 from coopdevs/dont-fetch-vos-with-deleted-variant
...
Do not fetch VOs with deleted variant
2021-02-02 15:38:29 +01:00
Matt-Yorkley
d7b130d293
Update all locales with the latest Transifex translations
2021-02-02 12:23:25 +00:00
Matt-Yorkley
617d914835
Merge pull request #6788 from jibees/6783-align-new-product-form
...
Use full width for "new product" form
2021-02-02 13:11:12 +01:00
Matt-Yorkley
b1349306f9
Merge pull request #6787 from jibees/6784-align-items-on-shipping-and-payment-methods-forms
...
Align items on shipping and payment methods forms
2021-02-02 13:08:28 +01:00
Pau Perez
cdcda46bff
Re-enable mail_bcc field in mail method settings
...
This feels safer because we don't risk messing up with any instance's
operations while still moving us towards removing this page.
2021-02-02 12:16:55 +01:00
Transifex-Openfoodnetwork
596e8a6828
Updating translations for config/locales/ru.yml
2021-02-02 20:48:36 +11:00
dependabot[bot]
1613c2e6fb
Bump rubocop from 1.9.0 to 1.9.1
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.9.0...v1.9.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-02 05:34:32 +00:00
Andy Brett
850dfd776a
migrate variants with nil unit_value
2021-02-01 21:27:32 -08:00
Pau Pérez Fabregat
9db9d2d138
Merge pull request #6786 from jibees/6781-align-packages-selection-on-registration
...
Package selection: use "columns" system to display 3 items on same line
2021-02-01 21:06:00 +01:00
Pau Pérez Fabregat
bcbd1ce8bc
Merge pull request #6790 from openfoodfoundation/transifex
...
Transifex
2021-02-01 21:05:16 +01:00
Pau Perez
20b9ac89b8
Fix missing translation
...
The used key doesn't exist.
2021-02-01 18:45:02 +01:00
Pau Perez
063d44fecc
Disable mail methods form fields except mails_from
...
This moves a step closer to having a simple and straightforward way to
configure the app's mail delivery which doesn't require to be a nuclear
engineer to troubleshoot mail issues.
It happens way too often that servers have mail config broken when
restarted or redeployed and it takes too much brain power to fix it. No
doubt; it's way too complex.
I chose to leave this page's form fields but "Send mails as" as
read-only. This other field is still used by instance manager to
troubleshoot mail issues.
2021-02-01 18:45:02 +01:00
Jean-Baptiste Bellet
370a108b3d
Add stripe account owner selector as a new row
...
Otherwise, not displayed.
2021-02-01 18:00:28 +01:00
Transifex-Openfoodnetwork
38dde5e063
Updating translations for config/locales/es.yml
2021-02-02 03:04:56 +11:00
Transifex-Openfoodnetwork
fe79186bec
Updating translations for config/locales/ca.yml
2021-02-02 03:03:33 +11:00
Pau Pérez Fabregat
d5413224b7
Merge pull request #6769 from openfoodfoundation/transifex
...
Transifex
2021-02-01 16:57:45 +01:00
Pau Pérez Fabregat
90466e19dc
Merge pull request #6776 from Matt-Yorkley/dead-argument
...
Dead code: superfluous argument in CartService#populate
2021-02-01 16:49:02 +01:00
Pau Perez
0ee1e2cd72
Eager load taggings related to variant overrides
...
This removes an N+1 with taggings but doesn't solve the one with tags.
Using `includes(taggings: :base_tags)` based on
47da5036de/lib/acts_as_taggable_on/taggable.rb (L83-L84)
wasn't enough to solve it and I got to stop here. This is scope-creeping
too much.
2021-02-01 16:38:40 +01:00
Pau Perez
ee4f2a7b02
Remove N+1 on variants and products
...
We get from an initial INNER JOIN with variants and products to fetch
the variant overrides + N queries like:
```sql
SELECT "spree_variants".* FROM "spree_variants" WHERE
"spree_variants"."deleted_at" IS NULL AND "spree_variants"."id" = $1
LIMIT 1 [["id", 1545]]
SELECT "spree_products".* FROM "spree_products" WHERE
"spree_products"."id" = $1 LIMIT 1 [["id", 604]]
```
to the same initial INNER JOIN + just 2 queries like:
```sql
SELECT "spree_variants".* FROM "spree_variants" WHERE
"spree_variants"."deleted_at" IS NULL AND "spree_variants"."id" IN
(1551, 1554)
SELECT "spree_products".* FROM "spree_products" WHERE
"spree_products"."deleted_at" IS NULL AND "spree_products"."id" IN (606,
607)
```
2021-02-01 16:38:40 +01:00
Pau Perez
6584f510e8
Remove now dead code
2021-02-01 16:38:40 +01:00
Jean-Baptiste Bellet
acbe0faa1e
use full width for new product form
...
- use the sixteen full width: eight + eight or eight + four + four, ...
2021-02-01 16:35:55 +01:00
Pau Pérez Fabregat
1420c43a0a
Merge pull request #6778 from openfoodfoundation/dependabot/bundler/database_cleaner-1.99.0
...
Bump database_cleaner from 1.8.5 to 1.99.0
2021-02-01 16:06:51 +01:00
Jean-Baptiste Bellet
adf67475be
special aligment for stripe form
2021-02-01 15:39:51 +01:00
Jean-Baptiste Bellet
c44ce85f30
alignment for specific provider settings form in payment method
2021-02-01 15:31:39 +01:00
Jean-Baptiste Bellet
46e6bc6179
align payment method form
...
- enlarge the form to be "full size" (four + twelve = 16 columns)
2021-02-01 15:18:45 +01:00
Jean-Baptiste Bellet
e57acd3163
align shipping method form (editing)
...
- use `row` and no more `field` to be consistent
- enlarge the form to be "full size" (four + twelve = 16 columns)
- enlarge "hubs sidebar"
2021-02-01 15:11:47 +01:00
Pau Pérez Fabregat
0878db70fe
Merge pull request #6780 from openfoodfoundation/dependabot/bundler/webmock-3.11.2
...
Bump webmock from 3.11.1 to 3.11.2
2021-02-01 14:57:45 +01:00
Pau Pérez Fabregat
640681d664
Merge pull request #6719 from coopdevs/stop-using-spree-req-helpers-in-users-controller-spec
...
[Rails 5] Stop using deprecated req. helpers in users specs
2021-02-01 14:56:28 +01:00
Pau Perez
060530cda8
Do not fetch VOs with deleted variant
...
In the line below we filter them out in Ruby so it's a waste of
resources. The fundamental difference is that `#includes` and
`#references` results in LEFT JOINs, whereas `#joins` results in INNER
JOIN, and because there's a default scope on `deleted_at IS NULL`, these
are not included in the result set.
This however, requires us to move away from the current algorithm but
unfortunately we can't refactor it completely yet.
Before:
```sql
SELECT *
FROM "variant_overrides"
LEFT OUTER
JOIN "spree_variants"
ON "spree_variants"."id" = "variant_overrides"."variant_id"
AND "spree_variants"."deleted_at" IS NULL
LEFT OUTER
JOIN "spree_products"
ON "spree_products"."id" = "spree_variants"."product_id"
AND "spree_products"."deleted_at" IS NULL
WHERE "variant_overrides"."permission_revoked_at" IS NULL
AND "variant_overrides"."hub_id" IN (
SELECT "enterprises"."id"
FROM "enterprises"
INNER
JOIN "enterprise_roles"
ON "enterprise_roles"."enterprise_id" = "enterprises"."id"
WHERE (enterprise_roles.user_id = ?)
AND (sells != 'none')
ORDER BY name)
```
After:
```sql
SELECT "variant_overrides".*
FROM "variant_overrides"
INNER
JOIN "spree_variants"
ON "spree_variants"."id" = "variant_overrides"."variant_id"
AND "spree_variants"."deleted_at" IS NULL
INNER
JOIN "spree_products"
ON "spree_products"."id" = "spree_variants"."product_id"
AND "spree_products"."deleted_at" IS NULL
WHERE "variant_overrides"."permission_revoked_at" IS NULL
AND "variant_overrides"."hub_id" IN (
SELECT "enterprises"."id"
FROM "enterprises"
INNER
JOIN "enterprise_roles"
ON "enterprise_roles"."enterprise_id" = "enterprises"."id"
WHERE (enterprise_roles.user_id = ?)
AND (sells != 'none')
ORDER BY name)
```
This is covered in the test suite by
spec/controllers/admin/variant_overrides_controller_spec.rb:72. It keeps
passing so we're good to go.
2021-02-01 14:47:51 +01:00
Jean-Baptiste Bellet
b7e23a7401
user "columns" system to display 3 items on same line
2021-02-01 14:15:50 +01:00
Jean-Baptiste Bellet
fcd304182b
specify :hover rule only for devices that can handle it
...
Since mobile device cannot handle :hover rule (hover is non sense for touch devices), specify css for only devices that effectivly handle it.
see https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/
and https://caniuse.com/mdn-css_at-rules_media_hover for compatibility (quite good)
2021-02-01 10:53:34 +01:00
dependabot[bot]
863a7ec688
Bump webmock from 3.11.1 to 3.11.2
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.1...v3.11.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 06:29:04 +00:00
dependabot[bot]
6f4b18a7d5
Bump test-unit from 3.3.9 to 3.4.0
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.3.9 to 3.4.0.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.3.9...3.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 06:23:46 +00:00
dependabot[bot]
e9c789a459
Bump database_cleaner from 1.8.5 to 1.99.0
...
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner ) from 1.8.5 to 1.99.0.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases )
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/master/History.rdoc )
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v1.8.5...v1.99.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 06:20:51 +00:00
Matt-Yorkley
3da21ce2bd
Add historical note to CartService
...
Useful background when applying upstream fixes from Spree::OrderPopulator, and means grepping for OrderPopulator doesn't come up empty.
2021-01-30 16:57:05 +00:00
Matt-Yorkley
d39468013e
Clarify CartService#populate arguments
...
This method doesn't use :products anywhere, it doesn't need to be passed in as part of the argument.
2021-01-30 16:52:59 +00:00
Matt-Yorkley
2de54e5ae2
Fix updated_at issue in RemoveTransientData spec
...
The value in the test setup was not what was expected after the updates to touching the updated_at columns.
2021-01-30 13:10:38 +00:00
Matt-Yorkley
0e82160b76
Touch the updated_at column when updating records via #update_column
...
#update_column(s) skips callbacks (which is useful), but it doesn't change the updated_at field on the record by default (which we should be doing in these cases).
This change is made in Spree 2.2 here: b367c629ce
2021-01-30 12:49:38 +00:00
Andy Brett
87bce505ec
Merge pull request #6765 from openfoodfoundation/dependabot/bundler/rack-mini-profiler-2.3.1
...
Bump rack-mini-profiler from 2.3.0 to 2.3.1
2021-01-29 20:04:13 -08:00
Andy Brett
fb5668afa6
Merge pull request #6764 from openfoodfoundation/dependabot/bundler/rubocop-1.9.0
...
Bump rubocop from 1.8.1 to 1.9.0
2021-01-29 20:03:56 -08:00
Matt-Yorkley
fc06e5e4c3
Remove dead code Spree::Order#clear_adjustments
2021-01-29 19:58:05 +00:00
Transifex-Openfoodnetwork
8f163cf5b5
Updating translations for config/locales/en_CA.yml
2021-01-30 06:08:22 +11:00
Matt-Yorkley
b97734d918
Merge pull request #6720 from cillian/cancel-email-for-shop
...
When an order is cancelled by a customer send an email to the shop.
2021-01-29 18:30:28 +01:00
Cillian O'Ruanaidh
0cfd7de8a8
Fix the link to the order in the order cancelled email.
2021-01-29 14:14:11 +00:00
Matt-Yorkley
d03be3b8dc
Update all locales with the latest Transifex translations
2021-01-29 11:42:09 +00:00
Matt-Yorkley
e4d7e03903
Merge pull request #6740 from Matt-Yorkley/carts-cleanup
...
Remove old abandoned carts
2021-01-29 12:32:16 +01:00
Cillian O'Ruanaidh
899dffec96
When an order is cancelled by a customer send an email to the shop.
...
Fixes #6435 i.e. If the customer paid for their order by Stripe/Paypal then the Enterprise needs to know that the order was cancelled in order to arrange a refund. Refunds are not automatically processed when an order is cancelled.
This will send a very basic email to the shop, it only includes a link to view the cancelled order in the admin area initially.
I created a CustomerOrderCancellation object here because orders can be cancelled in two ways (1) by the customer, so an email should be sent to the shop. (2) by the shop, so an email doesn't need to be sent. However the code for cancelling order happens in Order#cancel via the state machine. Rather than passing some sort of parameter into #cancel to indicate whether it is a customer or shop cancelled order it might be clearer to have a CustomerOrderCancellation object, there could be other differences between customer or shop cancelled orders in future maybe.
2021-01-29 11:23:05 +00:00
Pau Pérez Fabregat
818dfc0399
Merge pull request #6751 from jibees/4971-profile-tabs-back-forward-buttons
...
Make user's profile tabs aware of location change event
2021-01-29 10:01:58 +01:00
dependabot[bot]
32761baa68
Bump rack-mini-profiler from 2.3.0 to 2.3.1
...
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases )
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.3.0...v2.3.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-29 05:38:38 +00:00
dependabot[bot]
36380414a4
Bump rubocop from 1.8.1 to 1.9.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.8.1...v1.9.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-29 05:35:09 +00:00
Matt-Yorkley
9791287712
Run data cleanup job at 4:30am
2021-01-28 21:51:50 +00:00
Matt-Yorkley
4f7c8062a1
Create class to map join table and simplify code
2021-01-28 21:51:50 +00:00
Matt-Yorkley
d502320b14
Enable cascading deletes
2021-01-28 21:51:47 +00:00
Andy Brett
6fea2dbe46
Merge pull request #6760 from openfoodfoundation/dependabot/bundler/rswag-2.3.2
...
Bump rswag from 2.3.1 to 2.3.2
2021-01-28 13:11:33 -08:00
Pau Pérez Fabregat
45573dc522
Merge pull request #6753 from jibees/6746-epic-fullwdith-admin-layout-quick-wins
...
FullWidth admin layout quick wins
2021-01-28 21:10:06 +01:00
Pau Pérez Fabregat
0a1d4873e3
Merge pull request #6736 from jibees/6707-remove-anchor-jump
...
Remove anchor in URL so avoid browser scrolling to the top of the page when editing order
2021-01-28 21:09:08 +01:00
Pau Pérez Fabregat
abe2cb9fac
Merge pull request #6728 from emclaughlin1215/add_tax_rates_i18n_key
...
Adding a tax_rates key to en.yml to match the key used everywhere.
2021-01-28 21:04:22 +01:00
Matt-Yorkley
dcbe9c4011
Merge pull request #6756 from andrewpbrett/fix-sca-regression
...
Fix SCA regression
2021-01-28 19:45:08 +01:00
Pau Pérez Fabregat
d4f6f903c9
Merge pull request #6759 from openfoodfoundation/dependabot/bundler/ddtrace-0.45.0
...
Bump ddtrace from 0.44.0 to 0.45.0
2021-01-28 16:40:29 +01:00
Pau Pérez Fabregat
6cc19ac6d5
Merge pull request #6726 from filipefurtad0/shipping_methods_spec_pending_fix
...
Fixes a pending test case and improves the spec run time
2021-01-28 16:39:39 +01:00
Pau Pérez Fabregat
2668747237
Merge pull request #6723 from luisramos0/spree_routes_2
...
Move spree orders routes out of the spree engine routes into the main app routes
2021-01-28 16:31:49 +01:00
Matt-Yorkley
57f429db58
Merge pull request #6606 from mkllnk/6081-add-to-cart
...
Add quantity input to shop front
2021-01-28 15:51:08 +01:00
Matt-Yorkley
de530c2a46
Merge pull request #6750 from mkllnk/6749-i18n-in-assets
...
Use JS I18n function in assets to avoid parsing error
2021-01-28 15:50:22 +01:00
Jean-Baptiste Bellet
553053bad1
use find instead of click_link because <a> element no longer has href attribute
...
- click_link only looks for <a> element with href attribute
- Use a regexp for a case-insensitive search (as CSS use a uppercase transform)
2021-01-28 09:45:24 +01:00
dependabot[bot]
55cddbbc1a
Bump rswag from 2.3.1 to 2.3.2
...
Bumps [rswag](https://github.com/rswag/rswag ) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.3.1...2.3.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-28 05:46:19 +00:00
dependabot[bot]
0a128d83d0
Bump ddtrace from 0.44.0 to 0.45.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.44.0...v0.45.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-28 05:41:53 +00:00
Luis Ramos
7cea4138c2
Fix spec setup
2021-01-27 22:44:52 +00:00
Matt-Yorkley
85c489d303
Ignore carts with failed payments in cleanup
2021-01-27 22:40:23 +00:00
Matt-Yorkley
e6c59fbd96
Update data retention periods
...
Sessions and cart data are removed if older than 3 months, instead of 6.
2021-01-27 22:40:23 +00:00
Matt-Yorkley
3fddaba4bf
Extract private methods
2021-01-27 22:40:23 +00:00
Matt-Yorkley
0a88712926
Clear orphaned records in join table spree_option_value_line_items
2021-01-27 22:40:23 +00:00
Matt-Yorkley
4230d46a06
Remove carts older than 6 months
2021-01-27 22:40:23 +00:00
Maikel
8a757812e7
Merge pull request #6735 from coopdevs/enable-mail-delivery-always
...
Enable mail delivery always
2021-01-28 09:31:12 +11:00
Matt-Yorkley
f49355e5d3
Merge pull request #6724 from Matt-Yorkley/remove-price-adjustments
...
Delete dead code Spree::Order#price_adjustments
2021-01-27 23:29:38 +01:00
Luis Ramos
12dac82b8a
Delete dead route
2021-01-27 22:08:06 +00:00
Luis Ramos
c604f4c0c6
Remove dead endpoint
2021-01-27 22:05:04 +00:00
Jean-Baptiste Bellet
bb21543ae0
remove useless brackets
2021-01-27 21:35:55 +01:00
Pau Pérez Fabregat
c3897dd3df
Merge pull request #6643 from coopdevs/customer-balance-frontoffice
...
Customer balance frontoffice
2021-01-27 19:55:56 +01:00
Andy Brett
e6e20309aa
Revert "don't try to process a payment if it's pending auth"
...
This reverts commit bba9e55006 .
2021-01-27 08:06:20 -08:00
Jean-Baptiste Bellet
9b1c0e6806
avoid inserting div in the columns grid system
...
it break the css selectors (as :first-child, ...)
fixe: #6747
2021-01-27 15:05:48 +01:00
Jean-Baptiste Bellet
c5edd74d05
remove useless wrapper and align items (both right and left)
...
Fixe: #6747
2021-01-27 15:04:45 +01:00
Jean-Baptiste Bellet
a6fba8a065
Put content into grid columns system
...
Two columns of three + a ten column rather than empty column + content outside column system
correct #6745
2021-01-27 14:40:50 +01:00
Matt-Yorkley
7525620d6c
Merge pull request #6070 from Matt-Yorkley/responsive-admin
...
Full-width admin layout
2021-01-27 12:45:06 +01:00
Matt-Yorkley
feca9e7838
Improve hubs sidebar in payment methods edit
2021-01-27 11:38:01 +00:00
Matt-Yorkley
398b4a09a1
Improve enterprise fees calculator fields
2021-01-27 11:38:01 +00:00
Matt-Yorkley
366588de95
Improve <legend> element centering
2021-01-27 11:38:01 +00:00
Matt-Yorkley
b5ab6cbf69
Improve button spacing in enterprises submenu
2021-01-27 11:38:01 +00:00
Matt-Yorkley
e762c1d02f
Adjust buttons layout on enterprise shipping and payment methods page
2021-01-27 11:38:01 +00:00
Matt-Yorkley
f72cd6222f
Adjust variant columns in inventory pages
2021-01-27 11:38:01 +00:00
Matt-Yorkley
79316560d6
Remove skeleton.css from /vendor/assets
...
This was recently imported from spree_core
2021-01-27 11:38:01 +00:00
Matt-Yorkley
539ff228e0
Adjust form layout on order cycle edit form (simple view)
2021-01-27 11:38:01 +00:00
Matt-Yorkley
afdb5e8c6f
Add a max-width of 1400px for huge monitors (1600px or more)
2021-01-27 11:38:01 +00:00
Matt-Yorkley
d40ec2d63c
Adjust order cycle edit form layout
2021-01-27 11:38:01 +00:00
Matt-Yorkley
0d99656b1b
Adjust dashboard layout
2021-01-27 11:38:01 +00:00
Matt-Yorkley
52cfa0a103
Remove old Javascript hacks for the main menu and replace with flex-based CSS properties
2021-01-27 11:38:01 +00:00
Matt-Yorkley
d886b1dcea
Tweak some styles and layout classes
2021-01-27 11:38:01 +00:00
Matt-Yorkley
29e74017a6
Replace fixed 960 grid
2021-01-27 11:38:01 +00:00
Pau Pérez Fabregat
9fe2cb1a30
Merge pull request #6681 from luisramos0/css
...
[Rails 5] Make the app work in rails 5
2021-01-27 12:08:27 +01:00
Jean-Baptiste Bellet
0242e1a0c9
avoid unnecessary javascript:void(0)
2021-01-27 10:26:05 +01:00
Jean-Baptiste Bellet
48c667d2dd
add onLocationChangeSuccess event handler
...
watch this event and toggle class if needed.
2021-01-27 10:25:05 +01:00
Maikel Linke
06983c4dc7
Use JS I18n function in asset, avoid parsing error
...
A deployment to the French server failed because a translation contained
an apostrophe `'` and we were rendering it without escaping in
Javascript. We don't have that problem and avoid other issues by using
the javascript translate function. That way the error message is
translated in the browser with the user's language and we don't have to
do any additional escaping.
2021-01-27 14:12:25 +11:00
Maikel Linke
0393e902c4
Update translations from Transifex
2021-01-27 08:28:37 +11:00
Luis Ramos
ab135e30c0
Fix order_path in stripe connect spec
2021-01-25 20:25:13 +00:00
Luis Ramos
11fdbe5e9f
Switch spree from namespace to scope in routes so helpers like order_path keep working
2021-01-25 20:01:08 +00:00
Luis Ramos
34ae3ca24d
Replace spree_order_url with order_url so we can use scope in the routes file
2021-01-25 19:56:25 +00:00
Luis Ramos
f3da7afd55
Replace spree_order_path with order_path so we can use scope in the routes file
2021-01-25 19:55:42 +00:00
Luis Ramos
dbef7b60a6
Adapt spec to new orders url
2021-01-25 19:52:48 +00:00
Luis Ramos
21f48b52c8
Fix cancel order route
2021-01-25 19:52:48 +00:00
Luis Ramos
592474189d
Fix order route in paypal controller
2021-01-25 19:52:48 +00:00
Luis Ramos
d52661fe0a
Fix admin order form to use admin orders route
2021-01-25 19:52:48 +00:00
Luis Ramos
00fcb89af1
Fix order_url routes in a few places
2021-01-25 19:52:48 +00:00
Luis Ramos
dd4ca8a8e6
Fix order path in subs emailer view
2021-01-25 19:52:48 +00:00
Luis Ramos
f25e06ddb6
Fix order path route in payments controller
2021-01-25 19:52:48 +00:00
Luis Ramos
3813b80615
Adapt order path route in order details view
2021-01-25 19:52:48 +00:00
Luis Ramos
88c21ef82e
Fix order path
2021-01-25 19:52:48 +00:00
Luis Ramos
60c3557c2d
Fix checkout form order path
2021-01-25 19:52:48 +00:00
Luis Ramos
6e7ee02191
Change spree.order_path to spree_order_path everywhere
2021-01-25 19:52:48 +00:00
Luis Ramos
e98d97ae0d
Move spree orders routes out of the spree engine routes into the main app routes, still inside the spree namespace
2021-01-25 19:52:48 +00:00
Pau Pérez Fabregat
10a60b1f72
Merge pull request #6729 from openfoodfoundation/dependabot/bundler/shoulda-matchers-4.5.1
...
Bump shoulda-matchers from 4.5.0 to 4.5.1
2021-01-25 16:34:13 +01:00
Jean-Baptiste Bellet
686dcaaa1b
remove '#' as path for link_to
...
Adding '#' to the current url makes most of browser jump to the top of the page. Avoid this by deleting this added # (meaningless) and replacing it by empty string.
2021-01-25 16:09:12 +01:00
Pau Perez
5677c86f9b
Remove enable_mail_delivery preference from DB
...
It's no longer used.
2021-01-25 13:34:13 +01:00
Pau Perez
4a5869b60c
Remove ability to toggle mail delivery
...
OFN requires mails to work so there's no point in having this
conditional with the maintenance cost it entails.
2021-01-25 13:27:44 +01:00
Pau Pérez Fabregat
efd2c81877
Merge pull request #6722 from luisramos0/spree_routes
...
Replace spree_get with simple get
2021-01-25 09:12:51 +01:00
dependabot[bot]
70bd81430d
Bump shoulda-matchers from 4.5.0 to 4.5.1
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.5.0...v4.5.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-25 06:13:04 +00:00
filipefurtad0
c5c9e803ab
Fixes a pending test case and improves the spec run time
2021-01-24 13:32:04 +00:00
Erin McLaughlin
609db647bb
Adding a tax_rates key to en.yml to match the key used everywhere.
2021-01-23 22:07:07 -05:00
Matt-Yorkley
0247386f82
Delete dead code Spree::Order#price_adjustments
...
This method returns the same thing as the Spree::Order#line_items_adjustments scope, but in a slightly less useful format (an array instead of a relation). The method's name is also totally inaccurate, as currently the only adjustments that appear on line items are tax adjustments for inclusive tax rates, which by definition have no effect on the price whatsoever...
2021-01-23 00:05:56 +00:00
Luis Ramos
1643636d43
Replace spree_get with simple call to get
2021-01-22 22:32:48 +00:00
Luis Ramos
d6a53cb84f
Replace spree_get with simple call to get
2021-01-22 22:30:11 +00:00
Luis Ramos
94275eedfb
Replace spree_get with simple call to get
2021-01-22 22:28:53 +00:00
Luis Ramos
59e900826e
Replace spree_get with get
...
Spree helper method is not needed
2021-01-22 22:22:50 +00:00
Luis Ramos
be9ee376a3
Use get instead of spree_get
...
spree_get is not needed in these cases
2021-01-22 22:20:52 +00:00
Pau Perez
cc2e46890e
Stop using deprecated req. helpers in users specs
...
This removes the following two deprecation warnings that we are getting
by millions (the two for each controller action test):
```
DEPRECATION WARNING: You are trying to generate the URL for a named route called "main_app" but no such route was found. In the future, this will result in an `ActionController::UrlGenerationError` exception. (called from process_action_with_route at /usr/
src/app/spec/support/controller_requests_helper.rb:49)
DEPRECATION WARNING: Passing the `use_route` option in functional tests are deprecated. Support for this option in the `process` method (and the related `get`, `head`, `post`, `patch`, `put` and `delete` helpers) will be removed in the next version without
replacement. Functional tests are essentially unit tests for controllers and they should not require knowledge to how the application's routes are configured. Instead, you should explicitly pass the appropiate params to the `process` method. Previously th
e engines guide also contained an incorrect example that recommended using this option to test an engine's controllers within the dummy application. That recommendation was incorrect and has since been corrected. Instead, you should override the `@routes`
variable in the test case with `Foo::Engine.routes`. See the updated engines guide for details. (called from process_action_with_route at /usr/src/app/spec/support/controller_requests_helper.rb:49)
```
It slows down our test suite and clutters the output a lot. As per my
investigation, this is something that arose in
https://github.com/rails/rails/pull/17453 and addressed in
https://github.com/rails/rails/pull/17725 . TL;DR: Engines need to define
their routes in controller tests as shown in
https://github.com/discourse/discourse/pull/3011 .
This, however, revealed a much complex reality in our case. We're still
using a `Spree::Core::Engine` with its own routes at
`Spree::Core::Engine.routes`. So we can't skip defining `routes { }` for
each of its controllers unless we merge this engine into our app, but
that's going to require more effort. What could that entail in
https://github.com/openfoodfoundation/openfoodnetwork/compare/master...coopdevs:move-users-to-app-routes .
To make it even worse, note that we override spree's core routes from
our own, resulting in a controller whose actions are being served from
routes defined in either `config/routes.rb` or `config/spree/routes.rb`
🙈 .
2021-01-22 11:42:17 +01:00
Maikel Linke
46d23f1f8a
Fit bulk buy modal on small mobile screens
...
On some Iphones the modal wouldn't fit and there were line breaks
between the input fields. The inputs are now stacked vertically on small
screens so that there is still plenty of space for large numbers in the
quantity fields.
2021-01-22 16:44:52 +11:00
Maikel Linke
4ab48c4b85
Initialise valid quantities when choosing OCs
...
Line items were initialised with undefined quantities which makes it
impossible to distinguish between the initial unset quantity and a user
entering an invalid quantity. When a user changed order cycles, all
quantities are reset and the UI displayed the quantity modifier buttons
instead of the Add button.
Initialising with the valid quantity 0 helps us to display the Add
button in that situation.
2021-01-22 16:42:21 +11:00
Maikel Linke
bd731267ec
Allow user to get maximum available quantity
...
When the user entered a number beyond the stock level, the browser was
correcting that to the max number which is very helpful. But Angular was
setting the model to undefined which removes the item from the cart.
Deactivating Angular's max behaviour let's us set the value ourselves
which is then used in the cart.
2021-01-22 16:42:21 +11:00
Maikel Linke
35b4e8c4d1
Allow editing of invalid quantities
...
If the user entered an invalid quantity, Angular set the model to
undefined and we removed the input field to show the add button. That
makes it impossible for a user to see what the maximum quantity to enter
would be. For example:
- The variant has a stock level of 5.
- The user enters 7.
- Angular sets it to undefined.
- The input field disappears.
- The user is startled and doesn't know how to proceed.
But now we hide the input only if it's deliberately set to zero.
2021-01-22 16:42:21 +11:00
Maikel Linke
0166400b03
Guard against invalid quantity input
...
The user can now type anything into the quantity field and some of it
may not be valid. These safe guards ensure that the buttons still work
even if the quantity is undefined or out of range.
Angular guards against the value being out of range but that has other
side-effects. We want to be able to de-activate some of Angular's
behaviour.
2021-01-22 16:42:20 +11:00
Maikel Linke
cf2a105b2a
Prevent line breaks within plus/minus buttons
2021-01-22 16:42:20 +11:00
Maikel Linke
688be46b10
Avoid horizontal scroll bar on small screens
2021-01-22 16:42:20 +11:00
Maikel Linke
3558d01fce
Give the new input fields more space
...
The additional input needs more space and we are adjusting columns here.
2021-01-22 16:42:20 +11:00
Maikel Linke
66423a1ec3
Add quantity input to shop front product list
...
Adding bigger quantities can now be done via an input field instead of
clicking a thousand times.
The add-button has been widened to match the new space requirements.
2021-01-22 16:42:20 +11:00
Maikel Linke
e5506df5ea
Replace bulk quantity label with input field
...
Enable the user to enter a number directly.
2021-01-22 16:42:20 +11:00
Maikel Linke
af918e63ee
Change bulk quantities on any quantity change
...
This prepares for changing the quantity with an input field. It also
applies if the quantity is changed after an ajax request.
2021-01-22 16:42:20 +11:00
Maikel Linke
7add9247d5
Update translations from Transifex
2021-01-22 11:58:27 +11:00
Maikel
d5376ce29d
Merge pull request #6702 from openfoodfoundation/transifex
...
Transifex
2021-01-22 11:54:57 +11:00
Andy Brett
84689c43be
Merge pull request #6534 from andrewpbrett/sca-emails
...
Send email when SCA authorization is required for admin payment
2021-01-21 13:53:35 -08:00
Andy Brett
91d5b55376
Merge pull request #6673 from openfoodfoundation/dependabot/bundler/paypal-sdk-merchant-1.117.2
...
Bump paypal-sdk-merchant from 1.106.1 to 1.117.2
2021-01-21 11:21:27 -08:00
Andy Brett
0f92b3c4de
Merge pull request #6685 from Matt-Yorkley/angular-csrf
...
[Rails 5] Update Angular CSRF handling
2021-01-21 11:01:06 -08:00
Andy Brett
0e7f4b2f14
Merge pull request #6537 from mkllnk/simplify-mail-config
...
Simplify mail config
2021-01-21 10:59:43 -08:00
Andy Brett
d2b2e46124
Merge pull request #6701 from Matt-Yorkley/admin-order-performance
...
Fix performance issue in loading payment methods
2021-01-21 10:58:35 -08:00
Andy Brett
3ef4a74b84
Merge pull request #6655 from Matt-Yorkley/summing-amounts
...
Improve performance on summing adjustments and payment
2021-01-21 10:58:10 -08:00
Matt-Yorkley
d8b795ebee
Merge pull request #6679 from Matt-Yorkley/soft-delete-enterprise-fees
...
Soft-delete Enterprise Fees
2021-01-21 19:57:29 +01:00
Andy Brett
70f30f5224
Merge pull request #6658 from andrewpbrett/item-counter-fix
...
Further fix #5989 (Item counter accepts values higher than the available stock)
2021-01-21 10:56:18 -08:00
Andy Brett
bba9e55006
don't try to process a payment if it's pending auth
2021-01-21 09:18:29 -08:00
Andy Brett
ce4621858d
base authorization on the payment's order
2021-01-21 09:18:29 -08:00
Andy Brett
8bcaeff6c8
resolve merge conflict; add ssl helper to base controller
2021-01-21 09:18:29 -08:00
Andy Brett
1635b83c15
add missing translation key for payment actions
2021-01-21 09:18:29 -08:00
Andy Brett
903b2e7ff4
whitelist allowed events to be sent to a Payment
2021-01-21 09:18:29 -08:00
Andy Brett
ab5ffead1d
require that the redirect url be to stripe.com and over https
2021-01-21 09:18:29 -08:00
Andy Brett
affc82b2b5
update payment jobs delivery methods
2021-01-21 09:18:29 -08:00
Andy Brett
d76db9ee51
update payment controller spec to move payment to pending
2021-01-21 09:18:29 -08:00
Andy Brett
d9b27bc556
move controller and mailer outside of spree namespace; use haml in template
2021-01-21 09:18:29 -08:00
Andy Brett
5f1669280c
update to rspec 3 expect syntax
2021-01-21 09:17:07 -08:00
Andy Brett
b669ccdc74
refactor admin payments controller
2021-01-21 09:17:07 -08:00
Andy Brett
84b5fcf2ce
add resend-authorization-email button to admin screen
2021-01-21 09:17:07 -08:00
Andy Brett
5c0408c68c
pass paymentIntent ID to capture
2021-01-21 08:48:38 -08:00
Andy Brett
8507dacc10
pass return_url option to gateway authorize
2021-01-21 08:48:33 -08:00
Andy Brett
802e49bed3
add PaymentMailer and send email if payment auth is required
2021-01-21 08:24:01 -08:00
Cillian O'Ruanaidh
40f9b063fe
Remove ability to create new product from products page, use /admin/products/new instead.
...
It's simpler if there is just one place to add a new product. Closes #6650
This removes the 'creating directly from the new product path' test scenario because we have another 'assigning important attributes' scenario above which provides enough coverage.
2021-01-21 08:24:01 -08:00
Pau Pérez Fabregat
1833ab5ffa
Merge pull request #6710 from openfoodfoundation/dependabot/bundler/webdrivers-4.5.0
...
Bump webdrivers from 4.4.2 to 4.5.0
2021-01-21 12:27:02 +01:00
Pau Pérez Fabregat
3370271ad8
Merge pull request #6705 from coopdevs/fix-request-queuing-tracking
...
Pass request_queuing setting to Rack middleware
2021-01-21 12:04:22 +01:00
dependabot[bot]
b6e7307cb9
Bump webdrivers from 4.4.2 to 4.5.0
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 4.4.2 to 4.5.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.4.2...v4.5.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-21 05:16:36 +00:00
Andy Brett
77419a1e4b
Merge pull request #6675 from cillian/single-new-product-view
...
Remove ability to create new product from products page, use /admin/products/new instead.
2021-01-20 19:23:33 -08:00
Andy Brett
e31d566f7f
Merge pull request #6283 from luisramos0/sets
...
Move sets out of app/models to app/services/sets
2021-01-20 19:22:15 -08:00
Andy Brett
ca37976661
Merge pull request #6640 from jibees/2772-loading-spinner-reusable-component
...
Create a reusable "loading spinner" component
2021-01-20 19:21:31 -08:00
Andy Brett
1d4fa2983c
Merge pull request #6466 from Matt-Yorkley/package-optimisation
...
Optimise Shipment#to_package
2021-01-20 19:20:56 -08:00
Andy Brett
4a19a368dd
Merge pull request #6706 from Matt-Yorkley/adjustments-migration
...
Fix issue with orphaned adjustments in migration
2021-01-20 13:23:36 -08:00
Andy Brett
dd38c8b3e2
add down method for migration
2021-01-20 12:56:03 -08:00
Pau Perez
cc9e3fe69b
Replace double negation with proper list of states
...
We rely now on the exhaustive list of states an order can be in after
checkout. What made this all a bit more messy is that I made up the
"checkout" order state, likely mixing it from the payment model states.
This simplifies things quite a bit and gives meaningful names to things.
2021-01-20 18:34:31 +01:00
Pau Perez
d9c065a311
Remove outdated comment
...
This comment was related to the feature we removed in
https://github.com/openfoodfoundation/openfoodnetwork/pull/3609 .
2021-01-20 18:23:22 +01:00
Pau Perez
996761da67
Fix long line
2021-01-20 18:23:22 +01:00
Pau Perez
9bb49bb590
Ensure the query the class depends on is called
2021-01-20 18:23:22 +01:00
Pau Perez
db23428832
Test OutstandingBalance
...
This duplicates the scenarios tested for CustomersWithBalance.
2021-01-20 18:23:22 +01:00
Pau Perez
783863056d
Extract query object out of UsersController
...
It improves the overall readability of the code and as a result, things
became easier to manage already.
2021-01-20 18:23:22 +01:00
Pau Perez
d18e79ab19
Move query object to app/queries/ and doc it
2021-01-20 18:23:22 +01:00
Pau Perez
e8ef4acb2b
Hide new data fetching implementation under toggle
2021-01-20 18:23:22 +01:00
Pau Perez
37b7340eb1
Refactor specs to speed them up
...
We don't care about the conversion from hash to JSON (that's an
ActiveModel::Serializer responsibility that is thoroughly tested) but
our logic so we can skip that step which only slows down tests.
It consistently reduced ~1.5s on my machine but it's still too slow to wait
~8.5s to get feedback from them.
2021-01-20 18:23:22 +01:00
Pau Perez
a124f93b20
Remove old commented out code
2021-01-20 18:23:22 +01:00
Pau Perez
20abaaa950
Reuse outstanding balance statement across queries
...
Instead of relying on Spree::Order#outstanding_balance we make us of the
result set `balance_value` computed column. So, we ask PostgreSQL to
compute it instead of Ruby and then serialize it from that computed
column. That's a bit faster to compute that way and let's reuse logic.
We hide this new implementation under this features' toggle so it's only
used when enabled. We want hit the old behaviour by default.
2021-01-20 18:23:22 +01:00
Pau Perez
681a009eb6
Extract outstanding balance SQL CASE/WHEN
2021-01-20 18:23:22 +01:00
Pau Perez
caf1c9ecd9
Move data fetching from injection helper to action
...
Data fetching is a controller action responsibility. We shouldn't couple
the controller with it too much but it should trigger it, not the
view-layer.
2021-01-20 18:23:22 +01:00
Matt-Yorkley
e1c13bc194
Fix issue with orphaned adjustments in migration
2021-01-20 13:42:14 +00:00
Pau Perez
ba018df9c5
Pass request_queuing setting to Rack middleware
...
It turns out that this setting belongs to the Rack middleware Datadog
comes with to track requests (See
e4c430a174/docs/GettingStarted.md (rack) ).
The way to pass this option to it is through `configuration[:rack]`
where the `TraceMiddleware` will read it from. See
f57aefe60a/lib/ddtrace/contrib/rack/middlewares.rb (L215-L217)
and
f57aefe60a/lib/ddtrace/contrib/rack/middlewares.rb (L30-L43) .
2021-01-20 10:58:07 +01:00
Andy Brett
a53cc6bc92
Update all locales with the latest Transifex translations
2021-01-19 19:07:37 -08:00
Andy Brett
89ce850da6
Merge pull request #6703 from openfoodfoundation/fix-datadog-init
...
Revert "Enable request queuing tracking in Datadog"
2021-01-19 18:39:21 -08:00
Transifex-Openfoodnetwork
b9cf5b7a9b
Updating translations for config/locales/de_DE.yml
2021-01-20 12:46:16 +11:00
Andy Brett
012289e95f
Merge pull request #6687 from openfoodfoundation/dependabot/bundler/monetize-1.10.0
...
Bump monetize from 1.9.4 to 1.10.0
2021-01-19 17:23:33 -08:00
Matt-Yorkley
6a9505cf67
Ensure adjustments can access soft-deleted originators
...
Note: originator is generally an EnterpriseFee or a TaxRate
2021-01-19 16:46:14 +00:00
Matt-Yorkley
c4a8a38c8d
Soft-delete enterprise fees
...
These objects can hold critical information related to adjustments and tax categories. If they are hard-deleted we lose vital data that's needed by associated records.
2021-01-19 16:46:14 +00:00
Matt-Yorkley
a184075c5c
Fix performance issue in loading payment methods
...
This was loading and initializing every payment method in the database, and every calculator for each of those payment methods.
🔥
2021-01-19 15:33:44 +00:00
Pau Pérez Fabregat
b84fb5814e
Merge pull request #6696 from Matt-Yorkley/migration-issues
...
Update adjustment migration
2021-01-19 16:02:04 +01:00
Pau Pérez Fabregat
8b01c9c8ba
Merge pull request #6279 from luisramos0/base_controller
...
Merge Spree::BaseController with ApplicationController and merge StoreController with ::BaseController
2021-01-19 15:52:47 +01:00
Matt-Yorkley
79b86f535d
Move class definitions in adjustment migration
2021-01-19 13:33:37 +00:00
Luis Ramos
8007554176
Remove test_after_commit gem, it's baked into rails 5 now
2021-01-19 01:15:43 +00:00
Luis Ramos
fc40775ca8
Make paypal controller inherit from base controller and not from old store controller
2021-01-18 23:33:05 +00:00
Maikel
334e270a11
Merge pull request #6552 from Matt-Yorkley/adjustments-order-association
...
[Adjustments] Associate all adjustments with an order
2021-01-19 08:43:13 +11:00
Andy Brett
473ac820aa
Merge pull request #6676 from openfoodfoundation/transifex
...
Transifex
2021-01-18 13:34:44 -08:00
Pau Pérez Fabregat
c9d2149ef9
Merge pull request #6688 from coopdevs/remove-unneeded-deprecation-warning
...
Remove old deprecation warning
2021-01-18 21:06:56 +01:00
Pau Pérez Fabregat
cd7ba2c62b
Merge pull request #6690 from coopdevs/update-static-files-config
...
Update old setting to serve static assets
2021-01-18 18:05:44 +01:00
dependabot[bot]
d1eea4654a
Bump monetize from 1.9.4 to 1.10.0
...
Bumps [monetize](https://github.com/RubyMoney/monetize ) from 1.9.4 to 1.10.0.
- [Release notes](https://github.com/RubyMoney/monetize/releases )
- [Changelog](https://github.com/RubyMoney/monetize/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RubyMoney/monetize/commits )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-18 16:10:24 +00:00
Pau Perez
fd80d4a67f
Remove old deprecation warning
...
We're in Rails 4.2 so we can remove it. This gets rid of the following
message when running tests:
```
DEPRECATION WARNING: Suppressing Selenium deprecation warnings is not needed any more. (called from block in <top (required)> at /usr/src/app/spec/spec_helper.rb:214)
```
2021-01-18 17:01:43 +01:00
Pau Perez
006abee23d
Update old setting to serve static assets
...
Fixes the following deprecation warning:
```
DEPRECATION WARNING: The configuration option `config.serve_static_assets` has been renamed to `config.serve_static_files` to clarify its role (it merely enables serving everything in the `public` folder and is unrelated to the asset pipeline). The `serve_
static_assets` alias will be removed in Rails 5.0. Please migrate your configuration files accordingly. (called from block in <top (required)> at /usr/src/app/config/environments/test.rb:13)
```
2021-01-18 17:01:33 +01:00
Pau Pérez Fabregat
158aa78f89
Merge pull request #6692 from Matt-Yorkley/deliver-specs
...
Update mail delivery mocks in subscription specs
2021-01-18 16:41:02 +01:00
Matt-Yorkley
bc9020a555
Update mail delivery mocks in subscription specs
2021-01-18 12:27:07 +00:00
Andy Brett
1287cb1e56
Merge pull request #6686 from Matt-Yorkley/devise-spec-helper
...
Update deprecated devise spec helper
2021-01-17 19:57:49 -08:00
Luis Ramos
d8436c2dab
Downgrade libv8 so that mini racer keeps working
2021-01-16 22:41:50 +00:00
Andy Brett
ca022e505a
Merge pull request #6684 from Matt-Yorkley/subs-delivery
...
Use deliver_now in Jobs
2021-01-16 09:11:25 -08:00
Matt-Yorkley
a7ad62a735
Update deprecated devise spec helper
...
Devise has been complaining about this for a while in the test suite:
```
[Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
For controller tests, please include `Devise::Test::ControllerHelpers` instead.
```
2021-01-16 13:54:09 +00:00
Matt-Yorkley
ea9ebc8a33
Update Angular CSRF handling
2021-01-16 13:41:24 +00:00
Matt-Yorkley
b713219690
Use deliver_now in Jobs
2021-01-16 13:19:00 +00:00
Andy Brett
2c405a5705
Merge pull request #6672 from Matt-Yorkley/update-hooks
...
Delete dead code #update_hooks
2021-01-15 19:03:14 -08:00
Luis Ramos
7c9024101b
Some css fixes to make it all work in rails 5
2021-01-15 23:26:37 +00:00
Luis Ramos
4060e7debf
Replace usages of Spree::BaseController with ApplicationController
2021-01-15 21:59:16 +00:00
Luis Ramos
7a22367b4a
Make controllers use ::Basecontroller instead of StoreController
2021-01-15 21:59:16 +00:00
Luis Ramos
23e6048bde
Merge StoreController with BaseController
2021-01-15 21:59:16 +00:00
Luis Ramos
ff8a81cee7
Remove includes already present in parent ApplicationController
2021-01-15 21:59:16 +00:00
Luis Ramos
0eab1b2339
Merge Spree::BaseController with ApplicationController
2021-01-15 21:59:16 +00:00
Matt-Yorkley
c0c7c6ec78
Update checkout helper summing and add test coverage
2021-01-15 17:29:21 +00:00
Matt-Yorkley
5593da2928
Delete dead code #update_hooks
...
These hooks allow Spree core to be modified by other gems and apps without changing Spree code. We don't use it. #YAGNI
2021-01-15 16:49:45 +00:00
Andy Brett
f179214920
Merge pull request #6677 from Matt-Yorkley/remove-debugging
...
Remove debugging code from spec
2021-01-15 08:30:00 -08:00
Matt-Yorkley
1eb08ba31c
Define basic models in migration
2021-01-15 16:17:18 +00:00
Transifex-Openfoodnetwork
8f8f430e87
Updating translations for config/locales/en_CA.yml
2021-01-16 02:04:42 +11:00
Transifex-Openfoodnetwork
6be14dfb29
Updating translations for config/locales/fr_CA.yml
2021-01-16 01:58:02 +11:00
Matt-Yorkley
c870af8981
Remove debugging output.
2021-01-15 13:21:03 +00:00
Transifex-Openfoodnetwork
c132a5351f
Updating translations for config/locales/it.yml
2021-01-15 23:46:42 +11:00
Transifex-Openfoodnetwork
dc76f161a3
Updating translations for config/locales/es.yml
2021-01-15 23:42:27 +11:00
Transifex-Openfoodnetwork
26e817818f
Updating translations for config/locales/ca.yml
2021-01-15 23:34:40 +11:00
Pau Pérez Fabregat
5129611cff
Merge pull request #6668 from luisramos0/disable_cache_instrumentation
...
[Rails 5] Make app startup in rails 5 and update Gemfile_next.lock
2021-01-15 13:15:07 +01:00
Pau Pérez Fabregat
f240402c43
Merge pull request #6654 from Matt-Yorkley/update-without-callbacks
...
Remove #update_attributes_without_callbacks
2021-01-15 12:24:42 +01:00
Cillian O'Ruanaidh
79668e06a7
Remove ability to create new product from products page, use /admin/products/new instead.
...
It's simpler if there is just one place to add a new product. Closes #6650
This removes the 'creating directly from the new product path' test scenario because we have another 'assigning important attributes' scenario above which provides enough coverage.
2021-01-15 10:24:50 +00:00
dependabot[bot]
8e4e276995
Bump paypal-sdk-merchant from 1.106.1 to 1.117.2
...
Bumps [paypal-sdk-merchant](https://github.com/paypal/merchant-sdk-ruby ) from 1.106.1 to 1.117.2.
- [Release notes](https://github.com/paypal/merchant-sdk-ruby/releases )
- [Changelog](https://github.com/paypal/merchant-sdk-ruby/blob/master/ChangeLog.txt )
- [Commits](https://github.com/paypal/merchant-sdk-ruby/compare/v1.106.1...v1.117.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-15 05:49:20 +00:00
Andy Brett
9639c2af57
Update all locales with the latest Transifex translations
2021-01-14 17:24:42 -08:00
Andy Brett
cd383189c9
Merge pull request #6667 from openfoodfoundation/transifex
...
Transifex
2021-01-14 17:11:20 -08:00
Luis Ramos
209e2f20c5
Add rails 5 version for js template helpers
2021-01-15 00:23:37 +00:00
Luis Ramos
bc2d966e5f
Remove commented code
2021-01-15 00:22:20 +00:00
Luis Ramos
874da929d3
Disable db2fog in rails 5, it doesnt work, we need to find an alternative for rails 5
2021-01-15 00:21:28 +00:00
Luis Ramos
02a1116fff
Remove cache intrumentation
...
It doesnt work in rails 5 and apparently it was introduced to debug already deleted products cache in staging
See this commit that introduced it 10a79d5a65
2021-01-14 23:45:05 +00:00
Luis Ramos
d06c1fa665
Update Gemfile_next.lock
2021-01-14 23:44:09 +00:00
Maikel
d16bfbad93
Merge pull request #6662 from luisramos0/action_dispatch
...
First rails 5 upgrade PR with dual boot: remove action_dispatch/request if on rails 5 so we can boot the app in rails 5
2021-01-15 10:17:05 +11:00
Maikel
52b417877a
Merge pull request #6660 from openfoodfoundation/dependabot/bundler/webmock-3.11.1
...
Bump webmock from 3.11.0 to 3.11.1
2021-01-15 09:52:10 +11:00
Andy Brett
7ca81f45d0
Merge pull request #6641 from Matt-Yorkley/shipping-method-soft-deletion
...
Ensure ShippingMethod is correctly using soft-deletion
2021-01-14 11:53:19 -08:00
Transifex-Openfoodnetwork
3610827869
Updating translations for config/locales/en_GB.yml
2021-01-15 06:42:28 +11:00
Transifex-Openfoodnetwork
a0ee8cb1b3
Updating translations for config/locales/en_FR.yml
2021-01-15 06:01:40 +11:00
Andy Brett
18dcbbd892
Merge pull request #6613 from Matt-Yorkley/variant-override-serialization
...
Don't serialize all variant override objects where they are not needed
2021-01-14 10:59:11 -08:00
Transifex-Openfoodnetwork
577be5f70b
Updating translations for config/locales/fr.yml
2021-01-15 05:57:20 +11:00
Andy Brett
81ea71af94
Merge pull request #6652 from jibees/6651-remove-trailing-asterisk-on-non-mandatory-field
...
remove asterisk on 'display as' field unit value for a product
2021-01-14 10:09:15 -08:00
Pau Pérez Fabregat
929ae82e00
Merge pull request #6574 from Matt-Yorkley/bye-bye-spree-paypal
...
Bye Bye Spree Paypal
2021-01-14 18:16:44 +01:00
Pau Pérez Fabregat
9689fe2edf
Merge pull request #6384 from andrewpbrett/fix-product-descriptions
...
correctly display '&' and ' ' in product descriptions
2021-01-14 17:00:16 +01:00
Luis Ramos
82b2777cb3
Remove action_dispatch/request if on rails 5 so we can boot the app in rails 5
2021-01-14 09:48:59 +00:00
Luis Ramos
fd0bba19a7
Adapt enterprises code and specs to new namespace Sets::EnterpriseSet
2021-01-14 09:41:07 +00:00
Luis Ramos
ed0441dc41
Fix a few more rubocop issues
2021-01-14 09:41:07 +00:00
Luis Ramos
19b12092a0
Fix rubocop issues and adapt exceptions file
2021-01-14 09:41:07 +00:00
Luis Ramos
5d6d7f7ad0
Adapt enterprise fees code and specs to new namespace of Sets::EnterpriseFeeSet
2021-01-14 09:41:07 +00:00
Luis Ramos
96a351ad0e
Adapt usage of Sets to their new location
2021-01-14 09:41:07 +00:00
Luis Ramos
187b4a1fc2
Add Sets namespace to each set file
2021-01-14 09:41:07 +00:00
Luis Ramos
8e65d29b02
Move sets to specific services namespace
2021-01-14 09:41:07 +00:00
Pau Pérez Fabregat
9db4f9be15
Merge pull request #6634 from Matt-Yorkley/jobs-cleanup
...
Jobs cleanup
2021-01-14 10:08:15 +01:00
Pau Pérez Fabregat
85e932274d
Merge pull request #6442 from luisramos0/rails5-dualboot
...
Rails 5 upgrade with dualboot
2021-01-14 10:00:54 +01:00
Maikel
168958311a
Merge pull request #6656 from Matt-Yorkley/payment-identifier
...
Fix payment identifier generation
2021-01-14 17:34:38 +11:00
Maikel
fbda1fffd7
Merge pull request #6653 from Matt-Yorkley/dead-code-available-payment
...
Dead code: #has_available_payment
2021-01-14 17:33:07 +11:00
Maikel
50472d18e0
Merge pull request #6642 from coopdevs/doc-customer-serializer
...
Doc customer serializer
2021-01-14 17:28:34 +11:00
Maikel
14842f52fc
Merge pull request #6633 from Matt-Yorkley/inverse-of
...
Adding inverse_of
2021-01-14 17:25:51 +11:00
dependabot[bot]
3cee999032
Bump webmock from 3.11.0 to 3.11.1
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.0...v3.11.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-14 05:42:02 +00:00
Andy Brett
08d9ef5832
rename spec file; add test for nil content
2021-01-13 21:01:12 -08:00
Andy Brett
bbd7fd0350
handle nil product descriptions
2021-01-13 20:57:27 -08:00
Maikel Linke
c922a8fd4c
Fix: Remove unused conditional
...
I forgot to remove this unused conditional in a previous commit. Spree
defaulted to overriding the email config and we never changed that.
2021-01-14 12:05:42 +11:00
Maikel Linke
f1618ec35f
Remove old spec context
...
The specs all stay the same, just changing the indent.
2021-01-14 12:05:41 +11:00
Maikel Linke
be229c9002
Simplify email config by removing unused option
...
Spree used to give you more options to configure ActionMailer but our
setup is much simpler. We can remove unused code.
The removed option was never used by OFN and defaulted to true. We don't
need a database migration because the value isn't set in the database.
2021-01-14 12:05:41 +11:00
Andy Brett
8c4d12a501
limit item counter to max quantity available even if amount is manually filled in
2021-01-13 16:23:41 -08:00
Matt-Yorkley
5f2dc38241
Merge pull request #6098 from brymut/item-counter-fix
...
Fix #5989 Item counter accepts higher amount than available stock
2021-01-13 22:33:08 +01:00
Andy Brett
c29d57b54e
Merge pull request #6369 from Matt-Yorkley/broken-variants
...
Fix variant data inconsistencies
2021-01-13 11:10:44 -08:00
Pau Pérez Fabregat
6e48607760
Merge pull request #6629 from jibees/6199-alignment-readyfor-ipad
...
6199 adjust alignment on the Order Cycle component on ipad
2021-01-13 19:20:14 +01:00
Matt-Yorkley
9633ddf7ce
Add test for variant override symbol and tooltip
2021-01-13 18:19:16 +00:00
Matt-Yorkley
18c9e16303
Fix payment identifier generation
...
Upstream fix from Spree 2.2.
See: 4e747187d7
2021-01-13 17:37:22 +00:00
Matt-Yorkley
aacd942697
Update specs that stub associations inaccurately
...
These specs fail if the code is using #sum on stubbed objects that don't respond to it nicely.
2021-01-13 17:32:20 +00:00
Matt-Yorkley
305ae103ce
Use :create instead of :build in order updater specs
...
The order updater requires a persisted order
2021-01-13 17:09:02 +00:00
Matt-Yorkley
7d0ec48bcf
Improve performance on summing adjustments and payment
...
:amount is a database field in these cases, as opposed to a method that returns a computed result. Calling `.sum(:amount)` is much more efficient here as it computes the sum at database level, as opposed to `.map(&:amount).sum`, which would fetch and instanciate all the objects first, and then sum the amounts after.
2021-01-13 16:16:49 +00:00
Matt-Yorkley
561cf23dc1
Remove #update_attributes_without_callbacks
...
This is a hacky Spree method that's removed in Spree 2.2
See: 7deba6a152
2021-01-13 16:02:21 +00:00
Matt-Yorkley
8d338a06f3
Delete dead code #has_available_payment
...
This is removed in Spree 2.2, as it serves no purpose.
See: 0617bdce30
2021-01-13 15:48:02 +00:00
Pau Perez
acd4dddf1b
Doc how balance_value works
...
[skip ci]
2021-01-13 12:50:41 +01:00
Jean-Baptiste Bellet
dcbf02bc47
remove asterisk on 'display as' field unit value for a product
...
as it's not a mandatory field
2021-01-13 11:30:08 +01:00
Pau Pérez Fabregat
0b686bbd32
Merge pull request #6366 from coopdevs/fix-customer-balance-n+1
...
Fix customer balance n+1
2021-01-13 10:25:47 +01:00
Andy Brett
f633f1809f
Merge pull request #6646 from openfoodfoundation/dependabot/bundler/shoulda-matchers-4.5.0
...
Bump shoulda-matchers from 4.4.1 to 4.5.0
2021-01-12 09:07:39 -08:00
Andy Brett
667bc08f05
Merge pull request #6647 from openfoodfoundation/dependabot/bundler/rubocop-1.8.1
...
Bump rubocop from 1.8.0 to 1.8.1
2021-01-12 09:05:26 -08:00
Pau Perez
e83a3ff76d
Revert "Enable request queuing tracking in Datadog"
...
This reverts commit 91e5276140 .
2021-01-12 10:56:11 +01:00
dependabot[bot]
735c3ce022
Bump rubocop from 1.8.0 to 1.8.1
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.8.0...v1.8.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-12 05:47:39 +00:00
dependabot[bot]
c635c0f541
Bump shoulda-matchers from 4.4.1 to 4.5.0
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.4.1...v4.5.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-12 05:46:41 +00:00
Andy Brett
67e5825739
add specs for content sanitizer
2021-01-11 21:34:59 -08:00
Andy Brett
5723a79409
check for content.present?
2021-01-11 21:21:24 -08:00
Matt-Yorkley
ca4de40fa2
Associate all adjustments with an order
...
This change is introduced in the adjustments updates from Spree 2.2 and used heavily in new scopes and methods (not included here).
2021-01-11 17:35:35 +00:00
Jean-Baptiste Bellet
8399b82bfd
rename component to spinner
...
A name for a "thing" rather a state
2021-01-11 16:49:56 +01:00
Matt-Yorkley
46ff247bc9
Ensure ShippingMethod#destroy is using soft-deletion
...
25f5c2daf8
We've already applied some of the changes in this commit during previous Spree upgrade work, but there were a couple of bits missing.
2021-01-11 15:46:38 +00:00
Jean-Baptiste Bellet
26edd83a54
do not include inside a javascript asset
...
I made a mistake by using it inside a javascript asset
revert part of commit e34050f7c
2021-01-11 16:33:44 +01:00
Jean-Baptiste Bellet
71dc5a8ff0
remove trailing space
2021-01-11 16:29:13 +01:00
Jean-Baptiste Bellet
e34050f7cb
add wrapper to show/hide loading spinner
2021-01-11 16:23:22 +01:00
Jean-Baptiste Bellet
544a7407e3
specify max-width to not overflow parent element
2021-01-11 16:22:47 +01:00
Jean-Baptiste Bellet
1b4254a5cf
Revert "replace code by reusable component"
...
This reverts commit 4d953abbe9 .
2021-01-11 16:12:17 +01:00
Pau Perez
33c72ecab0
Defend from nil BETA_TESTERS var
2021-01-11 15:55:34 +01:00
Pau Perez
dfed20d634
Consider awaiting_return, returned in balance
...
These states are reached when the order is complete and shipped. An
admin can create a new return authorization, which will set the order in
`awaiting_return` state. It's only after, when we call
`return_authorization#receive` that the return authorization moves to
`received` state and the order to `returned`.
You can do so from the UI by editing the return authorization and
clicking on Receive. However, we didn't find any order in such state in
UK, FR and AU. The UX is quite obfuscated. That must be why no users
clicked on it.
The `returned` state cannot count for the balance as is, since some of
the products are returned to the shop. That's enough for now.
2021-01-11 15:50:19 +01:00
Pau Perez
aa3fc71626
Consider resumed & payment orders in balance
...
These order states are already taken care of because they fall in the
`WHEN state IS NOT NULL` case.
2021-01-11 15:50:19 +01:00
Pau Perez
5018e88a34
Consider all states prior to checkout in balance
2021-01-11 15:50:19 +01:00
Pau Perez
398467e7ed
Hide new balance impl. under feature toggle
...
This makes it possible to deploy it without releasing it to users since
the toggle is not enabled for anyone.
It aims to make the balance calculation consistent across pages.
2021-01-11 15:50:19 +01:00
Pau Perez
2e9bae0ea5
Move relation includes out of query object
...
This query object is meant to be reusable but those includes are
context-specific and will likely not be needed when reusing the query
elsewhere. If we keep them there, chances are next dev might not notice
it and will introduce a performance regression.
2021-01-11 15:50:19 +01:00
Pau Perez
46d997406a
Filter out cart orders when fetching customers
...
We only care about non-cart orders and skipping carts, saves PostgreSQL
query planner to go through thousands of records in production use cases
(my food hub).
We go from
```sql
-> Index Scan using index_spree_orders_on_customer_id on spree_orders (cost=0.42..12049.45 rows=152002 width=15) (actual time=0.015..11.703 rows=13867 loops=1)
```
to
```sql
-> Index Scan using index_spree_orders_on_customer_id on spree_orders (cost=0.42..12429.46 rows=10802 width=15) (actual time=0.025..17.705 rows=9954 loops=1)
```
2021-01-11 15:50:19 +01:00
Pau Perez
539c5d067a
Update order payment_total when voiding a payment
...
As is, `payment_total` is only increased after successfully processing
a payment and never updated. This inconsistency breaks
`CustomerWithBalance` which relies on it.
Needless to say that if we keep this denormalized column, we better make
it consistent. I investigated current Spree's master branch (709e686cc0)
and they also realized it was broken. Now `Payment` runs the following
from the `after_save` `update_order` callback.
```rb
order.updater.update_payment_total if completed? || void?
```
I also took the chance to rearrange tests a bit.
2021-01-11 15:50:19 +01:00
Pau Perez
04930877dd
Test that payment_total is stored after payment
...
CustomerWithBalance totally relies on `spree_orders.payment_total` so we
better cover it with tests.
2021-01-11 15:50:19 +01:00
Pau Perez
93cdca85c6
Return 0 balance when the customer has no orders
2021-01-11 15:50:19 +01:00
Pau Perez
96a91969c9
Extract balance-specific serializer
...
So we only show the customer balance where really needed. Aggregating
the balance can be costly. Also, we avoid defensive coding.
2021-01-11 15:50:19 +01:00
Pau Perez
9d0dd968b1
Test customer balance query with guest orders
...
Guest orders also have an associated customer record that is created
by Spree::Order#ensure_customer at checkout. Subsequent orders will use
that one due to Spree::Order#associate_customer.
2021-01-11 15:50:19 +01:00
Pau Perez
d8872bc785
Explain why Arel can't be used in statement
2021-01-11 15:50:19 +01:00
Pau Perez
1e9a1f340e
Don't consider order total when it is canceled
2021-01-11 15:50:19 +01:00
Pau Perez
e404225de0
Extract query object
2021-01-11 15:50:19 +01:00
Pau Perez
d62ab06504
Refactor DB query to aggregate customer balance
...
It's simpler and many orders of magnitude more efficient to ask the DB
to aggregate the customer balance based on their orders. It removes
a nasty N+1.
The resulting SQL query is:
```sql
SELECT customers.*, SUM(spree_orders.total - spree_orders.payment_total) AS balance
FROM "customers"
INNER JOIN "spree_orders"
ON "spree_orders"."customer_id" = "customers"."id"
WHERE "customers"."enterprise_id" = 1
AND (completed_at IS NOT NULL)
AND (state != 'canceled')
GROUP BY customers.id
ORDER BY email;
```
2021-01-11 15:50:19 +01:00
Pau Pérez Fabregat
ad6165c446
Merge pull request #6480 from openfoodfoundation/dependabot/bundler/paper_trail-10.3.1
...
Bump paper_trail from 7.1.3 to 10.3.1
2021-01-11 12:02:34 +01:00
Jean-Baptiste Bellet
6f24ecd973
replace code by reusable component
...
There is no need to add .text-center as it's already on the parent component
2021-01-11 11:20:00 +01:00
Jean-Baptiste Bellet
4d953abbe9
replace code by reusable component
...
in a js file
2021-01-11 11:18:54 +01:00
Jean-Baptiste Bellet
b02b36b8e8
replace code by reusable component
2021-01-11 11:18:34 +01:00
Jean-Baptiste Bellet
776a61d1d9
create loading spinner reusable component
2021-01-11 11:17:33 +01:00
Andy Brett
ffeea631b3
add spec for exceeding available quantity
2021-01-09 18:49:53 -08:00
Andy Brett
c8c576ce38
keep size attribute
2021-01-09 17:49:47 -08:00
Bryan Mutai
eef6396de3
Add max attribute to item counter input
2021-01-09 17:36:35 -08:00
dependabot[bot]
b6a115e271
Bump paper_trail from 7.1.3 to 10.3.1
...
Bumps [paper_trail](https://github.com/airblade/paper_trail ) from 7.1.3 to 10.3.1.
- [Release notes](https://github.com/airblade/paper_trail/releases )
- [Changelog](https://github.com/paper-trail-gem/paper_trail/blob/master/CHANGELOG.md )
- [Commits](https://github.com/airblade/paper_trail/compare/v7.1.3...v10.3.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-09 22:50:08 +00:00
Andy Brett
c12abf8057
Merge pull request #6617 from Matt-Yorkley/stock-items-variant-deletion
...
Stock items and variant deletion
2021-01-09 12:12:24 -08:00
Andy Brett
9cc0f74314
Merge pull request #6620 from mkllnk/6616-emphasize-qty-button-disabled
...
Emphasize disabled Add button when out of stock
2021-01-09 11:34:57 -08:00
Matt-Yorkley
e5be249f2c
Update comment on #expire_current_order
2021-01-09 13:26:30 +00:00
Matt-Yorkley
f9f830e0e1
Bring in Paypal certificates hack via new initializer
2021-01-09 13:26:30 +00:00
Matt-Yorkley
c07a4fcb5e
Remove data-hooks from views
2021-01-09 13:26:30 +00:00
Matt-Yorkley
8439b68b36
Update code comment and link
2021-01-09 13:26:30 +00:00
Matt-Yorkley
09b7512cd8
Remove dead code around unused payment_method_field data-hook
2021-01-09 13:26:30 +00:00
Matt-Yorkley
2e5810d64d
Fix more Rubocop offences
2021-01-09 13:26:30 +00:00
Matt-Yorkley
bf47db1792
Fix missing route in Spree::OrdersController
...
I'm not sure why this spec started failing. Fixes:
```
Spree::OrdersController viewing cart when an item is in the cart the page provides the right registration path
Failure/Error: expect(subject.registration_path).to eq registration_path
ActionController::UrlGenerationError:
No route matches {:action=>"index", :controller=>"registration"}
# ./spec/controllers/spree/orders_controller_spec.rb:140:in `block (5 levels) in <top (required)>'
```
2021-01-09 13:26:30 +00:00
Matt-Yorkley
83f58368c7
Fix class-loading issue in test suite
...
Fixes:
```
Failure/Error: include Spree::Core::ControllerHelpers::Auth
NameError:
uninitialized constant Spree::Core::ControllerHelpers::Auth
# ./lib/spree/api/controller_setup.rb:19:in `block in included'
# ./lib/spree/api/controller_setup.rb:5:in `class_eval'
# ./lib/spree/api/controller_setup.rb:5:in `included'
# ./app/controllers/api/base_controller.rb:9:in `include'
# ./app/controllers/api/base_controller.rb:9:in `<class:BaseController>'
# ./app/controllers/api/base_controller.rb:6:in `<module:Api>'
# ./app/controllers/api/base_controller.rb:5:in `<top (required)>'
# ./app/controllers/api/products_controller.rb:5:in `<module:Api>'
# ./app/controllers/api/products_controller.rb:4:in `<top (required)>'
# ./spec/controllers/api/products_controller_spec.rb:6:in `<top (required)>'
```
2021-01-09 13:26:30 +00:00
Matt-Yorkley
c34ae0af4b
Bring in paypal-sdk-merchant gem dependency
2021-01-09 13:26:30 +00:00
Matt-Yorkley
3487898f68
Remove better_spree_paypal_express gem
2021-01-09 13:24:51 +00:00
Matt-Yorkley
618738db69
Fix more Rubocop offences
2021-01-09 13:22:25 +00:00
Matt-Yorkley
2864f62a08
Fix missing semicolons in spree_paypal_express.js
2021-01-09 13:22:25 +00:00
Matt-Yorkley
ab43c04ca8
Bring in translations
2021-01-09 13:22:25 +00:00
Matt-Yorkley
5c7dc6621b
Bring in views (and convert from ERB to HAML)
2021-01-09 13:22:25 +00:00
Matt-Yorkley
7f8fe631dd
Bring in Spree::PaypalExpressCheckout
2021-01-09 13:22:25 +00:00
Matt-Yorkley
2a27da1cc5
Bring in Spree::Gateway::PayPalExpress
2021-01-09 13:22:25 +00:00
Matt-Yorkley
2dce66f079
Fix some simple Rubocop offences
2021-01-09 13:22:25 +00:00
Matt-Yorkley
4ca3e29458
Apply changes from and remove Spree::PaypalController decorator
2021-01-09 13:22:25 +00:00
Matt-Yorkley
94549e98ba
Bring in Spree::PaypalController
2021-01-09 13:22:09 +00:00
Matt-Yorkley
597eed5285
Bring in Spree::Admin::PaypalPaymentsController
2021-01-09 13:22:09 +00:00
Matt-Yorkley
42468e2ef3
Apply Spree::Admin::PaymentsController decorator
2021-01-09 13:22:09 +00:00
Matt-Yorkley
2fb7dfa430
Bring in Paypal Express javascript
2021-01-09 13:22:09 +00:00
Matt-Yorkley
478f761188
Add Spree::Gateway::PayPalExpress to spree payment_methods list
2021-01-09 13:22:09 +00:00
Matt-Yorkley
dd5a197fb3
Remove ManagerInvitationJob
2021-01-09 11:56:27 +00:00
Matt-Yorkley
ca42b1fff7
Remove ConfirmSignupJob
2021-01-09 11:38:29 +00:00
Matt-Yorkley
6a7f795f64
Remove WelcomeEnterpriseJob
2021-01-09 11:33:10 +00:00
Andy Brett
3877721209
Merge pull request #6631 from Matt-Yorkley/actionmailer-deliver
...
[Deprecation] Replace ActionMailer#deliver with ActionMailer#deliver_now
2021-01-08 17:42:31 -08:00
Andy Brett
d6656804eb
Merge pull request #6557 from luisramos0/rubocop
...
Rubocop exceptions update
2021-01-08 17:36:23 -08:00
Andy Brett
08dcb13fca
Merge pull request #6578 from Matt-Yorkley/products-endpoint-content-type
...
Products endpoint content type
2021-01-08 17:34:26 -08:00
Andy Brett
ebecabdda5
Merge pull request #22 from Matt-Yorkley/sanitizer-service
...
Content Sanitizer
2021-01-08 17:31:59 -08:00
Matt-Yorkley
b7ecf4791a
Extract more sanitizing logic from Api::ProductSerializer and make service more generic/re-usable.
2021-01-09 01:07:11 +00:00
Matt-Yorkley
69640dc785
Tidy up producer mailer spec
...
This is covered in two other spec files relating to order cycles, the producer mailer spec doesn't need to know what calls the producer mailer.
2021-01-09 00:07:50 +00:00
Matt-Yorkley
a9706fa5f1
Update syntax in rake task
2021-01-08 23:18:55 +00:00
Matt-Yorkley
9d5eaa1790
Delete dead code in delayed job spec helper
2021-01-08 23:18:55 +00:00
Matt-Yorkley
496f2dab69
Ensure Jobs are instantiated correctly
...
We should not be using `Delayed::Job.enqueue` anywhere...
2021-01-08 23:18:55 +00:00
Matt-Yorkley
2dc918ff59
Ensure all Job classes correctly inherit from ActiveJob
2021-01-08 23:18:55 +00:00
Matt-Yorkley
ff962c1c9b
Change various Mailer invocations from #deliver_now to #deliver_later
2021-01-08 23:18:55 +00:00
Luis Ramos
2e4a206825
Add new offenses to exceptions file
2021-01-08 22:43:15 +00:00
Luis Ramos
0b45533237
Update rubocop todo list
2021-01-08 22:43:15 +00:00
Luis Ramos
42fff560fb
Attempt at rails 5 upgrade
2021-01-08 22:40:47 +00:00
Andy Brett
53b119ddb7
Merge pull request #6630 from coopdevs/update-haml-lint-config
...
Update haml lint config
2021-01-08 13:46:57 -08:00
Andy Brett
05f6337e7d
Merge pull request #6622 from openfoodfoundation/dependabot/bundler/ddtrace-0.44.0
...
Bump ddtrace from 0.43.0 to 0.44.0
2021-01-08 13:39:07 -08:00
Andy Brett
59527ab38a
refactor filter to a service
2021-01-08 13:37:18 -08:00
Luis Ramos
c2c491ced2
Setup dualboot for rails 5 upgrade
2021-01-08 21:34:13 +00:00
Matt-Yorkley
3e6445c51c
Replace deprecated ActionMailer#deliver with ActionMailer#deliver_now
...
DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job.
2021-01-08 20:35:47 +00:00
Matt-Yorkley
87b14f0237
Avoid using #allow_any_instance_of
2021-01-08 17:47:09 +00:00
Matt-Yorkley
3b1ad29d20
Fix view rendering in Api::BaseController
2021-01-08 17:47:09 +00:00
Matt-Yorkley
eec9f27353
Move controller concern to correct directory
...
This is a controller concern, it should live in app/controllers/concerns/
2021-01-08 17:47:09 +00:00
Matt-Yorkley
d90ed56603
Add missing test for Api::OrderCyclesController responses
2021-01-08 17:47:09 +00:00
Matt-Yorkley
0dd57fc3de
Render an empty JSON object instead of a blank string
2021-01-08 17:47:09 +00:00
Matt-Yorkley
04e4893723
Update route declarations in caching spec
2021-01-08 17:47:09 +00:00
Matt-Yorkley
4ba3c81f90
Update route declaration in karma test
2021-01-08 17:47:09 +00:00
Matt-Yorkley
261ed751cb
Remove explicit content_type declarations in Api::OrderCyclesController
...
This should be handled in `Api::BaseController`
2021-01-08 17:47:09 +00:00
Matt-Yorkley
d0800b5e32
Specify json format for API routes that return json in OrderCycleResource
2021-01-08 17:47:09 +00:00
Pau Pérez Fabregat
95ab6c7d83
Merge pull request #6627 from Matt-Yorkley/dead-code-product-available
...
Delete dead code Spree::Product#available?
2021-01-08 17:35:21 +01:00
Pau Perez
b08a918ba5
Do not check for spaces inside the braces of hash
...
This shuts the annoying lint error
```
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace
```
and it aligns with our existing style. See
https://github.com/openfoodfoundation/openfoodnetwork/pull/6629 as an
example.
2021-01-08 17:22:37 +01:00
Pau Perez
03bb9899fa
Copy Hound's default Haml lint config
2021-01-08 17:22:36 +01:00
dependabot[bot]
96cf1c0514
Bump ddtrace from 0.43.0 to 0.44.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.43.0 to 0.44.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.43.0...v0.44.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-08 16:20:47 +00:00
Pau Pérez Fabregat
8ca51c8b72
Merge pull request #6626 from Matt-Yorkley/flaky-oc-simple-spec
...
[Flaky Spec] Improve simple OC spec
2021-01-08 17:18:43 +01:00
Matt-Yorkley
0949e72c88
Merge pull request #6597 from Matt-Yorkley/cancancan
...
Switch from cancan to cancancan
2021-01-08 17:15:08 +01:00
Matt-Yorkley
139773bc22
Add inverse_of to associations between shipping methods and rates
...
See 20d913c21c
2021-01-08 15:42:58 +00:00
Matt-Yorkley
f07c2dcd84
Add inverse_of for associations involved in cart processing
...
7bac3e7b2c
and
61bd5446e1
2021-01-08 15:42:58 +00:00
Pau Perez
6e689c4607
Update all locales with the latest Transifex translations
2021-01-08 16:18:31 +01:00
Pau Pérez Fabregat
9cf71c703d
Merge pull request #6615 from Matt-Yorkley/money
...
Money!
2021-01-08 13:24:14 +01:00
Matt-Yorkley
c281c67d0e
Switch from cancan to cancancan
...
Development of cancan stopped in 2013. cancancan is the active fork of the defunct original, and has been updated many times to keep up with changes in newer Rails and Ruby versions.
2021-01-08 12:02:18 +00:00
Pau Pérez Fabregat
b51d8c573a
Merge pull request #6614 from Matt-Yorkley/api-errors
...
API Bugnag errors
2021-01-08 12:59:11 +01:00
Pau Pérez Fabregat
47774b3b2e
Merge pull request #6628 from openfoodfoundation/dependabot/bundler/rubocop-1.8.0
...
Bump rubocop from 1.7.0 to 1.8.0
2021-01-08 12:57:14 +01:00
Pau Pérez Fabregat
3927f56ed4
Merge pull request #6444 from openfoodfoundation/dependabot/bundler/kaminari-1.2.1
...
[Security] Bump kaminari from 0.17.0 to 1.2.1
2021-01-08 12:47:59 +01:00
Pau Pérez Fabregat
bd83443595
Merge pull request #6611 from jibees/6196-fix-text-wrapping-on-oc
...
6196 fix text wrapping on oc
2021-01-08 11:48:41 +01:00
Pau Pérez Fabregat
27e83392bf
Merge pull request #6536 from coopdevs/enable-new-customer-balance-to-core-team
...
Enable new customer balance for the beta testers
2021-01-08 11:24:23 +01:00
Jean-Baptiste Bellet
fc71808517
use flex property to manage responsive
...
and remove unsued properties
2021-01-08 11:24:16 +01:00
Jean-Baptiste Bellet
5869eb1841
add new div container
...
to use flexbox properties for its two child divs
named: select-and-closing-container
2021-01-08 11:23:23 +01:00
dependabot[bot]
11ce9b943f
Bump rubocop from 1.7.0 to 1.8.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.7.0...v1.8.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-08 05:39:09 +00:00
Andy Brett
72a65426a0
allow '&' and spaces
2021-01-07 20:50:43 -08:00
Andy Brett
d78e8acee7
Merge pull request #6619 from luisramos0/remove_oj
...
Remove unused dependency
2021-01-07 12:43:09 -08:00
Andy Brett
3073a9b588
Merge pull request #6618 from luisramos0/byebug
...
Upgrade pry
2021-01-07 12:41:43 -08:00
Andy Brett
0bb92e04b5
Merge pull request #6621 from openfoodfoundation/dependabot/bundler/bugsnag-6.19.0
...
Bump bugsnag from 6.18.0 to 6.19.0
2021-01-07 12:35:51 -08:00
Matt-Yorkley
52b43d8c23
Delete dead code
...
This method isn't called from anywhere
2021-01-07 16:03:04 +00:00
Pau Pérez Fabregat
ca84e3eafb
Merge pull request #6610 from openfoodfoundation/dependabot/bundler/stripe-5.29.0
...
Bump stripe from 5.28.0 to 5.29.0
2021-01-07 16:58:02 +01:00
Matt-Yorkley
d27900d5fb
Merge pull request #6525 from openfoodfoundation/transifex
...
Transifex
2021-01-07 16:54:22 +01:00
Pau Pérez Fabregat
7f3c4f2433
Merge pull request #6551 from coopdevs/track-request-queuing
...
Track request queuing in Datadog
2021-01-07 16:34:42 +01:00
Matt-Yorkley
0c9df590d3
Add some improvements to help ensure UI elements are actually loaded by Angular before they are clicked on by Capybara
2021-01-07 14:50:09 +00:00
dependabot[bot]
0fdf398dd0
Bump bugsnag from 6.18.0 to 6.19.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.18.0 to 6.19.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v6.18.0...v6.19.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-07 05:42:58 +00:00
Maikel Linke
18b1504935
Emphasize disabled Add button when out of stock
...
Using the same grey as was used in the bulk modal already. This makes it
more consistent and hopefully more clear.
2021-01-07 10:32:10 +11:00
Luis Ramos
ea29c62c5e
Remove unused dependency
2021-01-06 22:50:55 +00:00
Luis Ramos
18b84fc850
Upgrade pry
2021-01-06 22:41:20 +00:00
Matt-Yorkley
a8d07a7e80
Merge pull request #6602 from openfoodfoundation/dependabot/bundler/awesome_nested_set-3.3.1
...
Bump awesome_nested_set from 3.2.1 to 3.3.1
2021-01-06 21:43:12 +01:00
Matt-Yorkley
cca16c6e1f
Fix stock issue and update specs (now passing)
...
See: dcd5944a29
2021-01-06 20:13:38 +00:00
Matt-Yorkley
c0c7c4f440
Import failing specs for stock items
...
See: dcd5944a29
2021-01-06 20:12:52 +00:00
Matt-Yorkley
cc88611b15
Update Spree::Money to use Monetize#parse instead of Money#parse
...
This method was removed from the money gem without replacement. It's now provided by the monetize gem.
2021-01-06 19:20:19 +00:00
Matt-Yorkley
3387bf5821
Switch from direct dependency on money gem to monetize gem
...
This change is actually made around Spree 2.0, but we missed it. The `monetize` gem also installs the `money` gem.
2021-01-06 19:17:00 +00:00
Matt-Yorkley
45e4d86631
Merge money_decorator.rb with money.rb
...
The #rounded method was left out, as it appears to be dead code.
2021-01-06 19:17:00 +00:00
dependabot-preview[bot]
47f59a5d0a
[Security] Bump kaminari from 0.17.0 to 1.2.1
...
Bumps [kaminari](https://github.com/kaminari/kaminari ) from 0.17.0 to 1.2.1. **This update includes security fixes.**
- [Release notes](https://github.com/kaminari/kaminari/releases )
- [Changelog](https://github.com/kaminari/kaminari/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kaminari/kaminari/compare/v0.17.0...v1.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2021-01-06 19:09:53 +00:00
Matt-Yorkley
0fbf3d6cd9
Merge pull request #6555 from filipefurtad0/tax_rates_spec
...
Extends spec coverage of Tax Rates settings - CRUD operations
2021-01-06 19:16:14 +01:00
Matt-Yorkley
019f4dfa24
Merge pull request #6605 from PauloVilarinho/refactor-pagination-data
...
Refactor pagination data
2021-01-06 19:06:23 +01:00
Matt-Yorkley
7beba3debf
Merge pull request #6609 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.9.1
...
Bump rubocop-rails from 2.5.2 to 2.9.1
2021-01-06 17:46:50 +01:00
filipefurtad0
3c123bb947
Simplified the delete test-case
...
Using :xpath may compromise the stability of the test, and make it break upon slight changes to the page.
2021-01-06 16:23:46 +00:00
filipefurtad0
fc062a04a4
Updated the assertion/error to consider PR #6545
2021-01-06 16:23:46 +00:00
filipefurtad0
7f658d4c46
Removed the "_id" ending from objects
...
Renamed objects ":zone_id" and ":tax_category_id" into ":zone" and ":tax_category," as these are full objects and not just ids.
2021-01-06 16:23:46 +00:00
filipefurtad0
8a453abd26
Adding "frozen_string_literal" back to the file
...
Mistakenly removed the line "# frozen_string_literal: true". This commit adds it back in.
2021-01-06 16:23:46 +00:00
filipefurtad0
3edf5fd6d9
Extends spec coverage of Tax Rates settings - CRUD operations
2021-01-06 16:23:46 +00:00
Matt-Yorkley
bd4560cff6
Don't serialize all variant override objects where they are not needed
...
This is only needed in one place, and only as a count, and can cause huge amounts of superfluous data to be fetched and serialized, for example in the admin products index page (where variant override data is not used at all).
2021-01-06 16:04:47 +00:00
Andy Brett
381d5a5e37
Merge pull request #6599 from openfoodfoundation/dependabot/bundler/capybara-3.32.2
...
Bump capybara from 3.15.1 to 3.32.2
2021-01-06 07:40:39 -08:00
Matt-Yorkley
c482173394
Delete dead code
...
This AMS injection method is no longer referenced anywhere in the codebase
2021-01-06 13:20:31 +00:00
Matt-Yorkley
b842bfbc3d
Explicitly notify Bugsnag on errors during API response processing
...
These errors are currently not being sent :/
2021-01-06 12:59:19 +00:00
Jean-Baptiste Bellet
39fc80172e
move css property
2021-01-06 09:49:12 +01:00
Jean-Baptiste Bellet
1b4906d55a
adjust margin according to old design
2021-01-06 09:17:11 +01:00
Jean-Baptiste Bellet
6e6be09740
use display flex to align
2021-01-06 09:16:38 +01:00
Jean-Baptiste Bellet
3a8b63b371
remove height constraint
2021-01-06 09:16:19 +01:00
dependabot[bot]
491dc387d7
Bump stripe from 5.28.0 to 5.29.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.28.0 to 5.29.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.28.0...v5.29.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-06 05:31:08 +00:00
dependabot[bot]
02c63519c7
Bump rubocop-rails from 2.5.2 to 2.9.1
...
Bumps [rubocop-rails](https://github.com/rubocop-hq/rubocop-rails ) from 2.5.2 to 2.9.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rails/compare/v2.5.2...v2.9.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-06 05:28:02 +00:00
Andy Brett
e58cd8a043
overwrite existing field value
2021-01-05 16:01:04 -08:00
Andy Brett
67bf6bb5fc
Merge pull request #6604 from openfoodfoundation/dependabot/bundler/webdrivers-4.4.2
...
Bump webdrivers from 4.2.0 to 4.4.2
2021-01-05 14:55:03 -08:00
Matt-Yorkley
540aa913a3
Tidy up Api::OrderController#index
2021-01-05 21:08:02 +00:00
Matt-Yorkley
fe0a0395d8
Remove DEFAULT_PAGE constants
2021-01-05 19:07:46 +00:00
Matt-Yorkley
4bb2653306
Tidy up pagination in Api::ProductsController#overridable and Angular PagedFetcher service
...
Refactors away some unnecessary mess and unblocks the last remaining issue in upgrading the Kaminari gem (deprecated calls to #num_pages method)
2021-01-05 18:57:08 +00:00
Matt-Yorkley
47f9a3f08a
Add guard clause and remove conditionals
...
Sometimes the objects are not paginated. In this case we need to avoid trying to render pagination data, as it will throw an error. This guard clause also means we can remove messy conditionals from several controllers.
2021-01-05 18:51:24 +00:00
Paulo Vilarinho
f53089c16c
fix products controller spec erros
2021-01-05 15:11:26 -03:00
dependabot[bot]
811480c8e0
Bump awesome_nested_set from 3.2.1 to 3.3.1
...
Bumps [awesome_nested_set](https://github.com/collectiveidea/awesome_nested_set ) from 3.2.1 to 3.3.1.
- [Release notes](https://github.com/collectiveidea/awesome_nested_set/releases )
- [Changelog](https://github.com/collectiveidea/awesome_nested_set/blob/master/CHANGELOG )
- [Commits](https://github.com/collectiveidea/awesome_nested_set/compare/v3.2.1...v3.3.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-05 16:56:21 +00:00
Pau Pérez Fabregat
dae065324d
Merge pull request #6600 from openfoodfoundation/dependabot/bundler/shoulda-matchers-4.4.1
...
Bump shoulda-matchers from 4.0.1 to 4.4.1
2021-01-05 17:54:47 +01:00
Pau Pérez Fabregat
a14750933c
Merge pull request #6592 from openfoodfoundation/dependabot/bundler/rubocop-1.7.0
...
Bump rubocop from 0.81.0 to 1.7.0
2021-01-05 17:54:22 +01:00
Pau Pérez Fabregat
20fd85786c
Merge pull request #6603 from openfoodfoundation/dependabot/bundler/rack-mini-profiler-2.3.0
...
Bump rack-mini-profiler from 2.0.2 to 2.3.0
2021-01-05 16:48:56 +01:00
Paulo Vilarinho
c99b250a5f
refactor pagination data removing default_per_page parameter
2021-01-05 12:18:47 -03:00
Paulo Vilarinho
4d217c9e9d
refactor render paginated products
2021-01-05 12:04:59 -03:00
Paulo Vilarinho
9a62ba8ed5
remove hound errors
2021-01-05 11:59:49 -03:00
Paulo Vilarinho
81c3c1cf32
remove default page
2021-01-05 11:57:54 -03:00
Paulo Vilarinho
330d42ea98
change inclue position to start of class
2021-01-05 11:48:02 -03:00
dependabot[bot]
381880d281
Bump webdrivers from 4.2.0 to 4.4.2
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 4.2.0 to 4.4.2.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.2.0...v4.4.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-05 12:07:15 +00:00
dependabot[bot]
87c9ec32e6
Bump shoulda-matchers from 4.0.1 to 4.4.1
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.0.1 to 4.4.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.0.1...v4.4.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-05 12:04:57 +00:00
dependabot[bot]
ba867e53d0
Bump rack-mini-profiler from 2.0.2 to 2.3.0
...
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler ) from 2.0.2 to 2.3.0.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases )
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.0.2...v2.3.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-05 12:01:20 +00:00
Paulo Vilarinho
efd4b97f5c
fix depracation warnings from kaminary
2021-01-05 00:33:29 -03:00
Paulo Vilarinho
ccac16c5b2
fix orders controllers specs errors
2021-01-05 00:07:38 -03:00
Paulo Vilarinho
ab586f58b1
apply pagination data concern to bulk line items controller
2021-01-04 20:22:58 -03:00
Paulo Vilarinho
3f324537a5
apply pagination data concern to exchange products controller
2021-01-04 20:22:43 -03:00
Paulo Vilarinho
1c5f6e7222
apply pagination data concern to orders controller
2021-01-04 20:22:14 -03:00
Paulo Vilarinho
9bb7096be1
apply pagination data concern to products_controller
2021-01-04 20:21:39 -03:00
Paulo Vilarinho
0f00107de1
add pagination data concern
2021-01-04 20:21:24 -03:00
Andy Brett
2085e183d4
Merge pull request #6601 from openfoodfoundation/dependabot/bundler/spring-2.1.1
...
Bump spring from 2.0.2 to 2.1.1
2021-01-04 12:37:59 -08:00
dependabot[bot]
5460fc9152
Bump rubocop from 0.81.0 to 1.7.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.81.0 to 1.7.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.81.0...v1.7.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-04 20:14:06 +00:00
dependabot[bot]
7ee8385902
Bump capybara from 3.15.1 to 3.32.2
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.15.1 to 3.32.2.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.15.1...3.32.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-04 20:14:05 +00:00
Andy Brett
a749bb602a
Merge pull request #6589 from openfoodfoundation/dependabot/bundler/ffaker-2.16.0
...
Bump ffaker from 2.11.0 to 2.16.0
2021-01-04 12:13:06 -08:00
Andy Brett
749c7f4193
Merge pull request #6585 from openfoodfoundation/dependabot/bundler/fuubar-2.5.1
...
Bump fuubar from 2.5.0 to 2.5.1
2021-01-04 12:11:52 -08:00
dependabot[bot]
343d8d2686
Bump spring from 2.0.2 to 2.1.1
...
Bumps [spring](https://github.com/rails/spring ) from 2.0.2 to 2.1.1.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v2.0.2...v2.1.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-04 18:58:40 +00:00
Andy Brett
59c981e14d
Merge pull request #6591 from openfoodfoundation/dependabot/bundler/test-prof-0.11.3
...
Bump test-prof from 0.7.5 to 0.11.3
2021-01-04 10:55:47 -08:00
dependabot[bot]
b8f7ef27a6
Bump fuubar from 2.5.0 to 2.5.1
...
Bumps [fuubar](https://github.com/thekompanee/fuubar ) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/thekompanee/fuubar/releases )
- [Changelog](https://github.com/thekompanee/fuubar/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thekompanee/fuubar/compare/releases/v2.5.0...releases/2.5.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-04 18:34:00 +00:00
dependabot[bot]
22d2b078e8
Bump ffaker from 2.11.0 to 2.16.0
...
Bumps [ffaker](https://github.com/ffaker/ffaker ) from 2.11.0 to 2.16.0.
- [Release notes](https://github.com/ffaker/ffaker/releases )
- [Changelog](https://github.com/ffaker/ffaker/blob/master/Changelog.md )
- [Commits](https://github.com/ffaker/ffaker/commits/v2.16.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-04 17:53:45 +00:00
Pau Pérez Fabregat
bfbad0ae81
Merge pull request #6560 from openfoodfoundation/dependabot/bundler/unicorn-5.8.0
...
Bump unicorn from 5.7.0 to 5.8.0
2021-01-04 18:07:54 +01:00
dependabot[bot]
b49a773bca
Bump test-prof from 0.7.5 to 0.11.3
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 0.7.5 to 0.11.3.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v0.7.5...v0.11.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-04 17:07:30 +00:00
Pau Pérez Fabregat
ca7548e8f4
Merge pull request #6573 from openfoodfoundation/dependabot/bundler/test-unit-3.3.9
...
Bump test-unit from 3.3.7 to 3.3.9
2021-01-04 18:06:07 +01:00
Pau Pérez Fabregat
258b25b453
Merge pull request #6596 from openfoodfoundation/dependabot/bundler/simplecov-0.18.5
...
Bump simplecov from 0.17.1 to 0.18.5
2021-01-04 18:05:03 +01:00
Pau Pérez Fabregat
1d28e7add3
Merge pull request #6588 from openfoodfoundation/dependabot/bundler/pry-byebug-3.8.0
...
Bump pry-byebug from 3.7.0 to 3.8.0
2021-01-04 18:02:17 +01:00
dependabot[bot]
b84820ad93
Bump simplecov from 0.17.1 to 0.18.5
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.17.1 to 0.18.5.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.17.1...v0.18.5 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-03 10:38:35 +00:00
Andy Brett
8452f174a1
Merge pull request #6575 from PauloVilarinho/remove-choose-currency-from-admin-general-settings
...
remove choose currency from admin general settings
2021-01-02 21:25:47 -08:00
dependabot[bot]
cf485266fe
Bump pry-byebug from 3.7.0 to 3.8.0
...
Bumps [pry-byebug](https://github.com/deivid-rodriguez/pry-byebug ) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/deivid-rodriguez/pry-byebug/releases )
- [Changelog](https://github.com/deivid-rodriguez/pry-byebug/blob/master/CHANGELOG.md )
- [Commits](https://github.com/deivid-rodriguez/pry-byebug/compare/v3.7.0...v3.8.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-02 23:12:57 +00:00
Andy Brett
180a49b501
Merge pull request #6590 from openfoodfoundation/dependabot/bundler/byebug-11.1.3
...
Bump byebug from 11.0.1 to 11.1.3
2021-01-02 15:11:38 -08:00
Andy Brett
115d3d0bfe
Merge pull request #6587 from andrewpbrett/comment-out-oc-spec
...
Comment out flaky spec for complex order cycle updating
2021-01-02 15:03:20 -08:00
Paulo Vilarinho
4839b7bd63
remove choose currency from admin general settings
2021-01-02 15:00:15 -08:00
Andy Brett
3d8c7cc9f0
Merge pull request #6522 from arku/feat/stripe-credit-card-removal
...
Extract Stripe credit card deletion logic to a service object
2021-01-02 14:56:00 -08:00
Andy Brett
1e9b2b34f7
Merge pull request #6545 from PauloVilarinho/add-internationalization-to-included_price_validation
...
adds translation key to the included in price validation
2021-01-02 14:55:16 -08:00
Andy Brett
042b4faf1e
comment out flaky spec
2021-01-02 14:53:55 -08:00
Andy Brett
97f1c586e1
Merge pull request #6595 from arku/chore/jsonp-format-handler-removal
...
Remove jsonp request handling logic
2021-01-02 14:51:30 -08:00
Arun Kumar Mohan
322e1496a9
Remove jsonp request handling logic
2021-01-02 02:17:30 -05:00
Andy Brett
51ee21e294
Merge pull request #6556 from Matt-Yorkley/adjustments-eligible
...
[Adjustments] Delete dead code #eligible_for_originator?
2021-01-01 20:48:27 -08:00
Andy Brett
9ddf3c4e5d
Merge pull request #6562 from romale/patch-11
...
Added translation key "en.spree.actions.cancel"
2021-01-01 20:48:04 -08:00
Andy Brett
fabde59671
Merge pull request #6564 from romale/patch-12
...
Added translation keys "en.description" "en.display" "en.tags"
2021-01-01 20:47:14 -08:00
Andy Brett
d0888415e2
Merge pull request #6594 from Matt-Yorkley/credit-card-spec-expired
...
Ensure credit card is not out of date in credit card spec
2021-01-01 17:29:31 -08:00
Matt-Yorkley
f6d0d43622
Ensure credit card is not out of date in credit card spec
...
This just blew up on New Years Eve 🙈
2021-01-01 11:54:14 +00:00
dependabot[bot]
c9f2c63e1e
Bump byebug from 11.0.1 to 11.1.3
...
Bumps [byebug](https://github.com/deivid-rodriguez/byebug ) from 11.0.1 to 11.1.3.
- [Release notes](https://github.com/deivid-rodriguez/byebug/releases )
- [Changelog](https://github.com/deivid-rodriguez/byebug/blob/master/CHANGELOG.md )
- [Commits](https://github.com/deivid-rodriguez/byebug/compare/v11.0.1...v11.1.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-01 06:08:33 +00:00
Andy Brett
e71908fbdd
Merge pull request #6566 from openfoodfoundation/dependabot/bundler/rspec-rails-4.0.2
...
Bump rspec-rails from 4.0.1 to 4.0.2
2020-12-31 13:10:21 -08:00
Andy Brett
17782a5577
Merge pull request #6570 from romale/patch-13
...
Added translation key "en.description"
2020-12-31 13:08:42 -08:00
Andy Brett
549bba0c4f
Merge pull request #6583 from PauloVilarinho/remove-xml-format
...
remove xml format
2020-12-31 13:08:05 -08:00
Matt-Yorkley
74228242c0
Merge pull request #6576 from andrewpbrett/flaky-tag-spec
...
Comment out flaky tag rules spec
2020-12-31 16:59:46 +01:00
Matt-Yorkley
e88972b989
Merge pull request #6441 from luisramos0/ruby24
...
Bump to ruby 2.4.4
2020-12-31 15:31:45 +01:00
Paulo Vilarinho
106c42fe84
remove xml format
2020-12-30 16:06:50 -03:00
Andy Brett
fc4634cd67
comment out flaky spec
2020-12-29 19:22:09 -08:00
dependabot[bot]
3199842ecc
Bump test-unit from 3.3.7 to 3.3.9
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.3.7 to 3.3.9.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.3.7...3.3.9 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-29 05:52:23 +00:00
romale
aa44615dd0
Missing translation key "en.description"
2020-12-28 19:04:03 +03:00
dependabot[bot]
cb8d2e95d8
Bump rspec-rails from 4.0.1 to 4.0.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v4.0.1...v4.0.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-28 06:41:44 +00:00
romale
00e61f0a99
Missing translation keys "en.description" "en.display" "en.tags"
2020-12-26 23:22:19 +03:00
Transifex-Openfoodnetwork
b9c41b4379
Updating translations for config/locales/ru.yml
2020-12-26 01:31:07 +11:00
romale
28f03947df
Added translation key "en.spree.actions.cancel"
2020-12-25 14:39:11 +03:00
dependabot[bot]
4e3f4cb52e
Bump unicorn from 5.7.0 to 5.8.0
...
Bumps [unicorn](https://yhbt.net/unicorn/ ) from 5.7.0 to 5.8.0.
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-25 05:43:50 +00:00
Matt-Yorkley
70f7d76723
Delete dead code #eligible_for_originator?
...
This check is used only by Spree::Promotion objects, which are not used in OFN. There are no objects which can be originators of an adjustment that respond to #eligible? in this way, so the method always returns true.
2020-12-23 08:29:12 +00:00
Andy Brett
ec4d171993
Merge pull request #6542 from openfoodfoundation/dependabot/bundler/paranoia-2.4.3
...
Bump paranoia from 2.4.2 to 2.4.3
2020-12-22 20:27:10 -08:00
Andy Brett
49a2dd6211
Update product set spec to allow changing the unit_value
...
These specs were introduced in cbac916e66 so we'll want to verify that we want to change them
2020-12-22 19:46:47 -08:00
Andy Brett
fade1696e2
update variant spec based on new validation behavior
2020-12-22 19:46:47 -08:00
Andy Brett
79aaa38173
update outdated spec
...
This spec was added as part of cbac916e66 - now that we're updating the unit_value to be 1, we expect this not to fail
2020-12-22 19:46:40 -08:00
Andy Brett
17faa7334e
Merge pull request #6538 from openfoodfoundation/dependabot/bundler/redcarpet-3.5.1
...
Bump redcarpet from 3.5.0 to 3.5.1
2020-12-22 19:32:59 -08:00
Andy Brett
fdf997847d
Merge pull request #6553 from openfoodfoundation/dependabot/bundler/webmock-3.11.0
...
Bump webmock from 3.10.0 to 3.11.0
2020-12-22 19:27:29 -08:00
Andy Brett
b4e47217ef
Merge pull request #6523 from arku/fix/credit-card-clone-destroyer
...
Handle nil stripe customer in credit card clone removal logic
2020-12-21 14:27:16 -08:00
Transifex-Openfoodnetwork
d2ba4c8111
Updating translations for config/locales/pt_BR.yml
2020-12-22 01:31:45 +11:00
Transifex-Openfoodnetwork
100d7275a6
Updating translations for config/locales/pt_BR.yml
2020-12-22 01:28:39 +11:00
Transifex-Openfoodnetwork
5a16fd7075
Updating translations for config/locales/tr.yml
2020-12-21 23:34:02 +11:00
Transifex-Openfoodnetwork
c3661cece9
Updating translations for config/locales/tr.yml
2020-12-21 23:33:59 +11:00
dependabot[bot]
554a55ecc9
Bump webmock from 3.10.0 to 3.11.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.10.0 to 3.11.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.10.0...v3.11.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-21 06:27:09 +00:00
Transifex-Openfoodnetwork
89f1d11e62
Updating translations for config/locales/en_US.yml
2020-12-19 05:14:00 +11:00
Pau Pérez Fabregat
9a199ae02c
Merge pull request #6540 from PauloVilarinho/add-internationalization-to-payment-method-clean-name
...
Add internationalization to payment method clean name
2020-12-18 18:06:19 +01:00
Pau Perez
91e5276140
Enable request queuing tracking in Datadog
...
Request queuing is critical to understand whether our app servers are
able to cope with all the traffic or requests pile up in Nginx queues.
I find the article
https://www.speedshop.co/2015/07/29/scaling-ruby-apps-to-1000-rpm.html
incredibly enlightening on this topic. Thanks @nateberkopec ❤️ .
This requires
https://github.com/openfoodfoundation/ofn-install/pull/689 .
2020-12-18 17:33:11 +01:00
Transifex-Openfoodnetwork
1d08e30b45
Updating translations for config/locales/ru.yml
2020-12-18 20:16:57 +11:00
Andy Brett
ebe71429db
Merge pull request #6541 from mkllnk/fix-subscription-script
...
Fix typo in subs test script
2020-12-17 17:10:05 -08:00
Andy Brett
2d636c8272
Merge pull request #6546 from andrewpbrett/sca-backend
...
Fix #6543
2020-12-17 14:00:36 -08:00
Andy Brett
13d6d2c978
separate conditionals 🤦
2020-12-17 13:23:14 -08:00
Paulo Vilarinho
747b747e2d
adds translation key to the included in price validation
2020-12-17 18:04:55 -03:00
Matt-Yorkley
1269e5f2e9
Merge pull request #6533 from andrewpbrett/sca-backend
...
Patch #6469 : use `purchase` to charge offline for Stripe Connect
2020-12-17 17:17:14 +01:00
Paulo Vilarinho
85663d15d1
Fix dynamic constant assignment issues
2020-12-17 10:14:54 -03:00
Paulo Vilarinho
92649ca97c
Refactor payment method clean name method
2020-12-17 10:06:41 -03:00
Transifex-Openfoodnetwork
128a2ada5c
Updating translations for config/locales/nb.yml
2020-12-17 20:47:05 +11:00
Transifex-Openfoodnetwork
0615c6ff3d
Updating translations for config/locales/nb.yml
2020-12-17 20:43:59 +11:00
Transifex-Openfoodnetwork
10eea3b9e0
Updating translations for config/locales/en_NZ.yml
2020-12-17 20:39:39 +11:00
dependabot[bot]
3d7a069b6b
Bump paranoia from 2.4.2 to 2.4.3
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.4.2 to 2.4.3.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.4.2...2.4.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-17 05:42:57 +00:00
Maikel Linke
f0db7a22cc
Fix typo in subs test script
2020-12-17 16:08:59 +11:00
Paulo Vilarinho
6225c83abb
Add internationalization of payment method clean name
...
The clean name payment method now uses the internationalization string
2020-12-17 00:35:57 -03:00
Paulo Vilarinho
50955d735c
Add tests for internationalization of payment method clean name
...
The clean name payment method tests now uses the internationalization string
2020-12-17 00:34:21 -03:00
Andy Brett
7fc9cc9f31
test that purchase is called by SCA and Connect providers
2020-12-16 11:09:15 -08:00
Pau Perez
6f8967f002
Enable new customer balance for the core team
...
This enables the use of the new customer balance implementation to
whatever users we specify in the BETA_TESTERS env var through
ofn-install.
This var is meant to contain the user emails that will log in such as
personal accounts (I have an account with admin access to my hub) or
superadmin accounts used by the core team. This way can gather early
feedback ourselves while not releasing the new logic to users.
2020-12-16 11:09:54 +01:00
dependabot[bot]
e2df5ebe5b
Bump redcarpet from 3.5.0 to 3.5.1
...
Bumps [redcarpet](https://github.com/vmg/redcarpet ) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/vmg/redcarpet/releases )
- [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vmg/redcarpet/compare/v3.5.0...v3.5.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-16 05:47:50 +00:00
Andy Brett
934f4f278e
add spec to subscription confirm job
2020-12-15 12:24:38 -08:00
Andy Brett
484576d1ac
add unit test for stripe connect
2020-12-15 10:30:05 -08:00
Andy Brett
cb29d05069
use purchase to charge offline for Stripe Connect
2020-12-14 11:54:03 -08:00
Pau Pérez Fabregat
c79baead84
Merge pull request #6524 from ankis17/DatePickerTranslation
...
Fixed Translation for DatePicker
2020-12-14 16:41:51 +01:00
Pau Pérez Fabregat
f26507b897
Merge pull request #6454 from arku/fix/signup-route
...
Remove /signup routes
2020-12-14 16:38:23 +01:00
Pau Pérez Fabregat
d4fc3f2118
Merge pull request #6516 from coopdevs/per-user-feature-toggles
...
Refactor FeatureToggle to toggle depending on user
2020-12-14 16:03:05 +01:00
Pau Pérez Fabregat
fa812364ff
Merge pull request #6453 from andrewpbrett/fix-void-payment-error
...
fix #5829 (Voiding an initial payment (i.e. a full refund) after partially refunding the order is not possible with Stripe-SCA)
2020-12-14 09:48:41 +01:00
Pau Pérez Fabregat
9f517e1931
Merge pull request #6455 from arku/fix/tabs
...
Fix tab toggle
2020-12-14 09:34:05 +01:00
Luis Ramos
997b9b9a2e
Merge pull request #6526 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.21
...
Bump combine_pdf from 1.0.16 to 1.0.21
2020-12-13 22:40:55 +00:00
Transifex-Openfoodnetwork
21efb4f3c6
Updating translations for config/locales/en_GB.yml
2020-12-14 07:19:09 +11:00
Arun Kumar Mohan
020df3619f
Add tests for Stripe::CreditCardRemover
2020-12-12 21:39:21 -05:00
Arun Kumar Mohan
f02f2c540c
Handle nil stripe customer in credit card clone removal logic
2020-12-12 21:31:06 -05:00
dependabot[bot]
6f763e1216
Bump combine_pdf from 1.0.16 to 1.0.21
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.16 to 1.0.21.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.16...v1.0.21 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-12 21:17:26 +00:00
Andy Brett
92aeab2ec3
Merge pull request #6490 from openfoodfoundation/dependabot/bundler/capybara-3.15.1
...
Bump capybara from 2.18.0 to 3.15.1
2020-12-12 13:16:04 -08:00
Luis Ramos
b76261c61c
Adapt preferable to work with new BigDecimal version
...
BigDecimal raises exception if called with nil or empty values
2020-12-12 18:50:57 +00:00
Andy Brett
94d10a45a7
Merge pull request #6486 from openfoodfoundation/dependabot/bundler/factory_bot_rails-5.2.0
...
Bump factory_bot_rails from 4.10.0 to 5.2.0
2020-12-12 08:58:53 -08:00
Transifex-Openfoodnetwork
18f642546d
Updating translations for config/locales/it.yml
2020-12-12 20:58:50 +11:00
Transifex-Openfoodnetwork
2afcdf9261
Updating translations for config/locales/it.yml
2020-12-12 20:55:35 +11:00
Ankita Satyavarapu
377febd8d7
Fixed Translation for DatePicker
2020-12-11 22:52:22 -05:00
Arun Kumar Mohan
1edebade78
Extract Stripe credit card deletion logic to a service object
2020-12-11 19:52:59 -05:00
Luis Ramos
1ea775cffb
Keep factory bot v4 behaviour
...
In v5 the default value is true, that means that all parent objects (for example the order od a line item) will be built using the same strategy as the object (build or create), in v4 and now with this config, the parent is always created
We can revert this and use the default value but that will require some adaptions, quite a lot of specs are broken with that behaviour activated
2020-12-12 00:23:24 +00:00
Luis Ramos
367622cea8
Capybara v3 is not cleaning up the html into text so the permissions that are inside html li elements are not matched with the matcher have_table_row when there are multiple permissions. So, in this case, we need to do the work ourselves: looking up the correct row and then asserting the permissions are the ones required
2020-12-12 00:07:33 +00:00
Luis Ramos
ada25fa2b2
Improve stripe spec
...
I am not sure why this was passing without these stubbed requests for
the second order, but now they were correctly failing. This commit fixes
the spec.
2020-12-11 23:15:08 +00:00
Luis Ramos
480dfdf961
Handle redirect case
...
For some reason the process is now working correctly, the authorization step succeeds and a redirect link is stored in the payment with state pending. The payment state is correctly left at pending. Here we add a check for the redirect path sent by stripe and fail the authorization if there is one (it means the payment would need an extra auth step only available in the frontoffice now and probably through email to customer at some point in the future). For some reason the flash with the authorization failure message is not showing up for the user
2020-12-11 23:14:23 +00:00
Andy Brett
a745fceb53
Merge pull request #6469 from andrewpbrett/sca-backend
...
Allow SCA cards to be setup and charged offline for subscriptions
2020-12-11 14:23:12 -08:00
Pau Perez
182f0f66b6
Refactor FeatureToggle to toggle depending on user
...
This enables showing features to individual users only, which enables us
to deploy features that are not yet released to gather feedback from
product and testing, while no users have access to it.
2020-12-11 09:13:07 +01:00
Luis Ramos
62715a8060
Adapt matcher to capybara v3
2020-12-11 00:21:46 +00:00
Luis Ramos
26165cc08d
Adapt matcher to capybara v3
2020-12-11 00:20:58 +00:00
Luis Ramos
f19946af8d
Remove unnecessary test step that is breaking in capybara v3
2020-12-11 00:16:31 +00:00
Luis Ramos
c92e8de51f
Adapt matchers to capybara v3
2020-12-11 00:13:46 +00:00
Luis Ramos
ed4a7bd361
Adapt matchers to capybara v3
2020-12-11 00:09:34 +00:00
Luis Ramos
6d37a15488
Adapt matchers to capybara v3
2020-12-11 00:02:22 +00:00
Luis Ramos
79c538fad9
Fix syntax for nil property
2020-12-10 23:44:24 +00:00
Luis Ramos
b287d67f6b
Adapt matchers to capybara v3
2020-12-10 23:36:40 +00:00
Luis Ramos
5ae955c27f
Adapt matchers to capybara v3
2020-12-10 23:35:34 +00:00
Luis Ramos
fd5adab0d5
Adapt matchers to capybara v3
2020-12-10 23:27:56 +00:00
Luis Ramos
773f733c8e
Adapt matchers to capybara v3
2020-12-10 23:05:15 +00:00
Luis Ramos
80e59a920e
Adpat matcher to capybara v3
2020-12-10 23:01:01 +00:00
Luis Ramos
b58fddf098
Adapt matcher to capybara v3
2020-12-10 22:59:37 +00:00
Luis Ramos
bcf7cc1013
Replace ignore with transient according to changes in factory bot v5
2020-12-10 22:16:17 +00:00
Andy Brett
3b7313f7e3
add spec for deleting the default card
2020-12-10 12:31:58 -08:00
Andy Brett
3daccb6420
update specs with new method signature
2020-12-10 12:17:55 -08:00
Andy Brett
655512adab
add missing require statements
2020-12-10 12:17:42 -08:00
Andy Brett
f50577b489
refactor cloner to use ivars
2020-12-10 11:42:28 -08:00
Andy Brett
a1f6fe5522
remove unused method now that we use autopaging
2020-12-10 11:22:14 -08:00
Andy Brett
8c747e4812
refactor destroy_clones to separate class
2020-12-10 11:22:02 -08:00
Andy Brett
4c25edd91c
refactor find_cloned_card to separate class
2020-12-10 11:04:27 -08:00
Andy Brett
0ac248f03a
refactor offline payment methods
2020-12-10 10:26:38 -08:00
Andy Brett
13b95f41bb
use built-in auto_paging_each with stripe
2020-12-10 08:19:41 -08:00
Andy Brett
50e87a023b
rename method to validate! since it can raise an error
2020-12-10 07:45:07 -08:00
Pau Pérez Fabregat
b4b4d38d3b
Merge pull request #6509 from mkllnk/image-tweaks
...
Image code tweaks
2020-12-10 12:50:18 +01:00
Pau Pérez Fabregat
3bf58b5b7c
Merge pull request #6503 from openfoodfoundation/dependabot/bundler/delayed_job_active_record-4.1.5
...
Bump delayed_job_active_record from 4.1.4 to 4.1.5
2020-12-10 12:33:41 +01:00
Maikel Linke
3f6288d5c7
Load rake task under test for all its specs
...
If you ran only the second spec without the first, the rake file wasn't
loaded and the test failed.
2020-12-10 15:35:05 +11:00
Maikel Linke
6bf041aa74
Reduce complexity
2020-12-10 15:33:34 +11:00
Maikel Linke
e6c411684f
Don't fail on missing images when resizing
...
The changed code obtains the image dimensions when you first upload an
image. Unfortunately it's also triggered when thumbnails are refreshed.
That doesn't change the size of the original image though.
2020-12-10 15:32:43 +11:00
Luis Ramos
465d2d2f1c
Remove unused dependency
2020-12-09 18:35:44 -08:00
Maikel Linke
edf9dd7921
Update translations from Transifex
2020-12-10 13:34:05 +11:00
Maikel
5ca10d5cd1
Merge pull request #6465 from openfoodfoundation/transifex
...
Transifex
2020-12-10 13:29:12 +11:00
Maikel
33d220e777
Merge pull request #6291 from luisramos0/subs_tasks
...
Add tasks to help manually test subscriptions
2020-12-10 12:55:59 +11:00
Luis Ramos
9728b088f9
Fix syntax for nil properties
2020-12-09 23:38:16 +00:00
dependabot[bot]
c033fe70e7
Bump delayed_job_active_record from 4.1.4 to 4.1.5
...
Bumps [delayed_job_active_record](https://github.com/collectiveidea/delayed_job_active_record ) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/collectiveidea/delayed_job_active_record/releases )
- [Commits](https://github.com/collectiveidea/delayed_job_active_record/compare/v4.1.4...v4.1.5 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-09 23:28:46 +00:00
Luis Ramos
c17998774e
Adapt factories to factory_bot_rails v5 syntax
2020-12-09 23:09:33 +00:00
Andy Brett
de786982dd
bump karma coffee preprocessor
2020-12-09 12:31:36 -08:00
dependabot[bot]
9b6702946c
Bump moment from 2.28.0 to 2.29.1
...
Bumps [moment](https://github.com/moment/moment ) from 2.28.0 to 2.29.1.
- [Release notes](https://github.com/moment/moment/releases )
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/moment/moment/compare/2.28.0...2.29.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-09 11:40:06 -08:00
Transifex-Openfoodnetwork
7c6621a49b
Updating translations for config/locales/en_FR.yml
2020-12-10 00:36:39 +11:00
Transifex-Openfoodnetwork
134c63f353
Updating translations for config/locales/en_FR.yml
2020-12-10 00:33:37 +11:00
Transifex-Openfoodnetwork
1d64230d4b
Updating translations for config/locales/fr.yml
2020-12-10 00:31:44 +11:00
Transifex-Openfoodnetwork
8f796de35b
Updating translations for config/locales/ar.yml
2020-12-10 00:03:43 +11:00
Transifex-Openfoodnetwork
b4a43e0554
Updating translations for config/locales/ar.yml
2020-12-10 00:00:34 +11:00
dependabot[bot]
f2c37ef64d
Bump karma-chrome-launcher from 2.2.0 to 3.1.0
...
Bumps [karma-chrome-launcher](https://github.com/karma-runner/karma-chrome-launcher ) from 2.2.0 to 3.1.0.
- [Release notes](https://github.com/karma-runner/karma-chrome-launcher/releases )
- [Changelog](https://github.com/karma-runner/karma-chrome-launcher/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma-chrome-launcher/compare/v2.2.0...v3.1.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-08 17:58:00 -08:00
dependabot[bot]
f45d348dd7
Bump ddtrace from 0.42.0 to 0.43.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.42.0 to 0.43.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.42.0...v0.43.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-08 17:56:37 -08:00
dependabot-preview[bot]
351d694c13
Bump haml from 5.2.0 to 5.2.1
...
Bumps [haml](https://github.com/haml/haml ) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/haml/haml/releases )
- [Changelog](https://github.com/haml/haml/blob/main/CHANGELOG.md )
- [Commits](https://github.com/haml/haml/compare/v5.2.0...5.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-08 17:53:03 -08:00
Andy Brett
22ef9a0fef
fix long line
2020-12-08 14:37:16 -08:00
Andy Brett
7a03882314
re-refactor cart_service
2020-12-08 14:37:16 -08:00
Andy Brett
b713bd7aa7
spec updates
2020-12-08 14:37:16 -08:00
Andy Brett
c70ea44091
show specific error message when add-to-cart fails
2020-12-08 14:37:16 -08:00
Luis Ramos
7a27741cf5
Remove unnecessary capybara version control in Gemfile
2020-12-08 22:15:54 +00:00
dependabot[bot]
2a3176f7f5
Bump capybara from 2.18.0 to 3.15.1
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 2.18.0 to 3.15.1.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/2.18.0...3.15.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-08 21:24:15 +00:00
dependabot[bot]
5c65f9bf55
Bump factory_bot_rails from 4.10.0 to 5.2.0
...
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails ) from 4.10.0 to 5.2.0.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases )
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md )
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v4.10.0...v5.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2020-12-08 20:24:41 +00:00
Luis Ramos
0824f12472
Merge pull request #6472 from luisramos0/depen
...
Fix dependabot config
2020-12-08 20:02:26 +00:00
Luis Ramos
ab6f6c463a
Fix problem in dependabot config, yarn is not a valid package-ecosystem, we can try npm
2020-12-08 20:00:19 +00:00
Luis Ramos
e2181960bc
Merge pull request #6450 from openfoodfoundation/dependabot/bundler/knapsack-1.20.0
...
Bump knapsack from 1.19.0 to 1.20.0
2020-12-08 19:39:13 +00:00
Luis Ramos
e8ba16cb3e
Merge pull request #6457 from openfoodfoundation/dependabot/bundler/spring-2.0.2
...
Bump spring from 1.7.2 to 2.0.2
2020-12-08 19:38:55 +00:00
Luis Ramos
c233052ec6
Merge pull request #6438 from luisramos0/devise4
...
Upgrade to devise 4.7
2020-12-08 17:19:13 +00:00
Andy Brett
d55343da1a
only return gateway payment info if set on customer
2020-12-08 07:52:42 -08:00
Andy Brett
eddf8da107
update subscription spec with new method name
2020-12-08 07:52:42 -08:00
Andy Brett
3a8203094a
refactor to remove boolean flag param
2020-12-08 07:52:42 -08:00
Andy Brett
f1d439870e
use a named argument for offline param
2020-12-08 07:52:42 -08:00
Andy Brett
103366ea97
add request limits to credit card cloner
2020-12-08 07:52:42 -08:00
Andy Brett
9c544ef2f4
remove cloned cards after removing the platform card
2020-12-08 07:52:42 -08:00
Andy Brett
bc3fd8c50c
remove unused method
2020-12-08 07:52:42 -08:00
Andy Brett
277d7f44b7
refactor api customers controller; resolve merge conflict
2020-12-08 07:52:42 -08:00
Andy Brett
a466886a32
fix rubocop warnings
2020-12-08 07:52:42 -08:00
Andy Brett
3d47ad7e33
add stubs for stripe requests
2020-12-08 07:52:42 -08:00
Andy Brett
fea7576ac1
update CreditCardCloner to find existing clone
2020-12-08 07:52:42 -08:00
Andy Brett
13ab25ac45
separate method for charging offline
2020-12-08 07:52:41 -08:00
Andy Brett
cad8a018f9
put SetupIntent on the connected Stripe account
2020-12-08 07:52:41 -08:00
Andy Brett
215d1bbe20
create js setup intent when authing shop
2020-12-08 07:52:41 -08:00
Andy Brett
b517d2f0c7
guard against a stripe customer already being deleted
2020-12-08 07:52:41 -08:00
Andy Brett
cc00f24569
add spec for clearing authorizations to credit_card_controller_spec
2020-12-08 07:46:10 -08:00
Andy Brett
d0098e190f
close #4175
2020-12-08 07:46:10 -08:00
Andy Brett
1f8b4e05bb
allow charges in subscriptions spec
2020-12-08 07:46:10 -08:00
Andy Brett
f875e406a8
update karma specs for setting default card
2020-12-08 07:46:10 -08:00
Andy Brett
3b44c8e7e2
update UI after changing default card
2020-12-08 07:46:10 -08:00
Andy Brett
6fdcd6218d
add remove_shop_authorizations method to controller
2020-12-08 07:46:10 -08:00
Andy Brett
c60dcc75cd
confirm changes to default card
2020-12-08 07:46:10 -08:00
Andy Brett
4cdc1993b8
add more specific copy on cc authorization
2020-12-08 07:46:10 -08:00
Andy Brett
747345ece9
only show authorized shops if there is a default card
2020-12-08 07:46:10 -08:00
Matt-Yorkley
5b9db50250
Optimise Shipment#to_package
...
This is done in a later Spree commit to reduce the amount of processing done in larger orders.
See: ab01b1ec1e
2020-12-08 11:21:05 +00:00
Maikel Linke
84730577da
Fail with better message when giving wrong OC id
...
The script was failing with:
NoMethodError: undefined method `update!' for nil:NilClass
Now it's failing with:
ActiveRecord::RecordNotFound: Couldn't find OrderCycle with id=1
2020-12-08 11:48:34 +11:00
Maikel Linke
906dbffb29
Fail loudly when task doesn't work
2020-12-08 11:43:21 +11:00
Maikel Linke
aa8df639c4
Style to avoid indent changes with context changes
...
When the indent of arguments is aligned with the method brackets, it
needs to be changed when the method changes. Putting all arguments on
their own line makes diffs of method changes or argument changes
clearer. See the next commit.
2020-12-08 11:38:50 +11:00
Maikel Linke
70d1888cc2
Ease reading of times
2020-12-08 11:36:15 +11:00
Maikel Linke
feb0ad452d
Safeguard production env from test script
2020-12-08 11:33:37 +11:00
Andy Brett
e866e983f6
add spec for partially refunded SCA orders
2020-12-07 14:51:47 -08:00
Transifex-Openfoodnetwork
33916cfff3
Updating translations for config/locales/nb.yml
2020-12-08 08:21:50 +11:00
Transifex-Openfoodnetwork
9333a6385e
Updating translations for config/locales/nb.yml
2020-12-08 08:00:43 +11:00
Transifex-Openfoodnetwork
c37bd8e911
Updating translations for config/locales/nb.yml
2020-12-08 07:40:37 +11:00
Andy Brett
96462325d2
fix #5829
2020-12-04 18:13:43 -08:00
dependabot-preview[bot]
567e489716
Bump spring from 1.7.2 to 2.0.2
...
Bumps [spring](https://github.com/rails/spring ) from 1.7.2 to 2.0.2.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v1.7.2...v2.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-04 19:14:16 +00:00
Arun Kumar Mohan
868a19df6e
Fix tab toggle
2020-12-03 21:03:44 -05:00
Arun Kumar Mohan
81b03906f9
Remove /signup routes
2020-12-03 20:43:28 -05:00
Luis Ramos
acddb496b7
Remove spree_i18n dependency
2020-12-03 15:34:46 -08:00
dependabot-preview[bot]
d29773d297
[Security] Bump jquery-rails from 3.1.5 to 4.4.0
...
Bumps [jquery-rails](https://github.com/rails/jquery-rails ) from 3.1.5 to 4.4.0. **This update includes a security fix.**
- [Release notes](https://github.com/rails/jquery-rails/releases )
- [Changelog](https://github.com/rails/jquery-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/jquery-rails/compare/v3.1.5...v4.4.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-03 15:33:41 -08:00
Luis Ramos
0f27f57cbb
Use new Admin::ResourceController
2020-12-03 15:32:20 -08:00
Luis Ramos
1d327a61a6
Fix rubocop issue and adapt rubocop exceptions
2020-12-03 15:32:20 -08:00
Luis Ramos
0fb9f44dda
Make all controllers use new Admin::ResourceController
2020-12-03 15:32:20 -08:00
Luis Ramos
c63d99dd20
Remove Spree namespace from controller
2020-12-03 15:32:20 -08:00
Luis Ramos
99fd99cd33
Move spree admin resource controller to admin resource controller
2020-12-03 15:32:20 -08:00
Luis Ramos
1d075bbc90
Remove empty resource controller
2020-12-03 15:32:20 -08:00
Luis Ramos
6e08fccbbe
Merge resource_controller url helpers with parent version
2020-12-03 15:32:20 -08:00
Luis Ramos
fc4cf6a9a7
Merge resource_controller model_class method with parent version
2020-12-03 15:32:20 -08:00
dependabot-preview[bot]
abc58f5bb4
Bump acts_as_list from 0.3.0 to 0.9.19
...
Bumps [acts_as_list](https://github.com/brendon/acts_as_list ) from 0.3.0 to 0.9.19.
- [Release notes](https://github.com/brendon/acts_as_list/releases )
- [Changelog](https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md )
- [Commits](https://github.com/brendon/acts_as_list/compare/0.3.0...v0.9.19 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-03 15:30:24 -08:00
Matt-Yorkley
0ceba7c0a8
Update orders closing message
2020-12-03 15:29:14 -08:00
Luis Ramos
f71de8123a
Dont show 'closing in' message when oc closes in more than 3 months
2020-12-03 15:29:14 -08:00
Luis Ramos
a51d01efac
Merge pull request #6452 from luisramos0/dep
...
Move dependabot file to correct location
2020-12-03 21:35:49 +00:00
Luis Ramos
7a35fabb22
Move dependendabot config file to .github
2020-12-03 21:32:57 +00:00
dependabot-preview[bot]
67ee8c3500
Bump knapsack from 1.19.0 to 1.20.0
...
Bumps [knapsack](https://github.com/ArturT/knapsack ) from 1.19.0 to 1.20.0.
- [Release notes](https://github.com/ArturT/knapsack/releases )
- [Changelog](https://github.com/ArturT/knapsack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ArturT/knapsack/compare/v1.19.0...v1.20.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-03 19:14:05 +00:00
Luis Ramos
5b00868c6f
Allow mutable strings in some specs
2020-12-03 06:38:24 -08:00
Luis Ramos
bfd4adbcee
Adapt code to work with frozen strings
2020-12-03 06:38:24 -08:00
Luis Ramos
611de912a8
Switch frozen_string_literal to false so that price code keeps working
2020-12-03 06:38:24 -08:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
Luis Ramos
de19efca64
Fix rubocop issue and add missing exceptions to manual_todo to get a green rubocop run
2020-12-03 06:38:24 -08:00
Luis Ramos
6c9e12b4ea
Update rubocop exceptions file after bye bye spree
2020-12-03 06:38:24 -08:00
Andy Brett
dfabc5fa06
Update all locales with the latest Transifex translations
2020-12-02 21:41:18 -08:00
Luis Ramos
7a5a4f956a
Replace use of Faker with FFaker
2020-12-02 11:40:50 -08:00
Luis Ramos
720edb4b05
Relax ffaker version requirement so that upgrades come as possible
2020-12-02 11:40:50 -08:00
dependabot-preview[bot]
3ec1af104f
Bump ffaker from 1.32.1 to 2.11.0
...
Bumps [ffaker](https://github.com/ffaker/ffaker ) from 1.32.1 to 2.11.0.
- [Release notes](https://github.com/ffaker/ffaker/releases )
- [Changelog](https://github.com/ffaker/ffaker/blob/master/Changelog.md )
- [Commits](https://github.com/ffaker/ffaker/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-02 11:40:50 -08:00
dependabot-preview[bot]
80d034706c
Bump test-unit from 3.3.6 to 3.3.7
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.3.6 to 3.3.7.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.3.6...3.3.7 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-02 11:40:04 -08:00
Andy Brett
902f8caea9
direct specifically to shop tab
2020-12-02 11:39:02 -08:00
Andy Brett
14091cd106
fix #6415
2020-12-02 11:39:02 -08:00
Andy Brett
936f5c1a0c
remove extraneous page call
2020-12-02 11:38:10 -08:00
Andy Brett
8963a787d6
only validate unit_value presence if "items" is not chosen
2020-12-02 11:38:10 -08:00
Andy Brett
59cab902f0
add numericality validation
2020-12-02 11:38:10 -08:00
Andy Brett
4d2c93930b
resolve merge conflict
2020-12-02 11:38:10 -08:00
Tsara Sudrajat
fb769d37f9
Fix error when setting stock for new product
2020-12-02 11:38:10 -08:00
Andy Brett
65f6f1febf
rearrange css
2020-12-02 11:37:25 -08:00
Andy Brett
99b5d9e0c5
use white-space: nowrap on variant prices
2020-12-02 11:37:25 -08:00
Andy Brett
c4cd574242
fix currency spec
2020-12-02 11:37:25 -08:00
Andy Brett
a3a6205343
fix #6252
2020-12-02 11:37:25 -08:00
Maikel
25c363feba
Merge pull request #6356 from openfoodfoundation/dependabot/bundler/stringex-2.8.5
...
Bump stringex from 1.5.1 to 2.8.5
2020-12-02 16:39:00 +11:00
Luis Ramos
839278fc75
Add dependendabot config to increase limit to 10 PRs
2020-12-01 12:40:24 -08:00
Luis Ramos
3162cf9abf
Add gem to make tests work with devise callbacks
...
This is noted in the devise 4.1 release notes: https://github.com/heartcombo/devise/blob/master/CHANGELOG.md#410
2020-12-01 17:19:07 +00:00
Luis Ramos
9abdcd88e5
Move confirmable config together with other devise configs in user model
2020-12-01 17:06:39 +00:00
Luis Ramos
ca1a4db299
Bump to ruby 2.4.4
2020-12-01 15:16:39 +00:00
Luis Ramos
bd6b1dbfed
Upgrade to devise 4.7
2020-12-01 11:59:41 +00:00
Matt-Yorkley
1cab9e473b
Merge pull request #6378 from openfoodfoundation/dependabot/bundler/webmock-3.10.0
...
Bump webmock from 3.9.5 to 3.10.0
2020-12-01 11:58:01 +01:00
dependabot-preview[bot]
93a73b4823
Bump stringex from 1.5.1 to 2.8.5
...
Bumps [stringex](https://github.com/rsl/stringex ) from 1.5.1 to 2.8.5.
- [Release notes](https://github.com/rsl/stringex/releases )
- [Commits](https://github.com/rsl/stringex/compare/v1.5.1...v2.8.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-12-01 09:58:08 +00:00
Matt-Yorkley
7408c45980
Merge pull request #6297 from openfoodfoundation/rails-4-1
...
[Rails 4.1] Merge Rails 4.1 branch into master
2020-12-01 10:56:08 +01:00
Matt-Yorkley
fe4b20dd7b
Merge pull request #6354 from openfoodfoundation/rails-4-2-rebased
...
Rails 4.2 upgrade
2020-12-01 10:55:25 +01:00
Pau Pérez Fabregat
3c71b7f6be
Merge pull request #6428 from coopdevs/upgrade-brakeman-dependencies
...
Upgrade Ruby and Ubuntu to latest in GH action
2020-11-30 21:13:25 +01:00
Transifex-Openfoodnetwork
ea148d7f51
Updating translations for config/locales/en_US.yml
2020-12-01 00:15:59 +11:00
Transifex-Openfoodnetwork
a5761707d5
Updating translations for config/locales/en_US.yml
2020-12-01 00:12:50 +11:00
Pau Perez
259e139c47
Update all locales with the latest Transifex translations
2020-11-30 09:21:13 +01:00
Pau Perez
8c1e222788
Upgrade Ruby and Ubuntu to latest in GH action
...
It was asked for in
https://github.com/openfoodfoundation/openfoodnetwork/pull/6163/ to use
the latest stable Ruby version. It's also better to use Ubuntu's latest
as well.
2020-11-30 09:11:41 +01:00
Pau Pérez Fabregat
4ca930bdad
Merge pull request #6163 from openfoodfoundation/luisramos0-patch-2
...
Add brakeman config
2020-11-30 09:08:32 +01:00
Pau Pérez Fabregat
f0a052b65b
Merge pull request #6357 from Matt-Yorkley/secret-key-base
...
Update secret key base
2020-11-27 17:32:14 +01:00
Pau Pérez Fabregat
07a72eccd4
Merge pull request #6391 from Matt-Yorkley/paypal-stock-clashes
...
Paypal stock clashes
2020-11-27 17:08:15 +01:00
Matt-Yorkley
b04a76e8bf
Update payments_report totals
2020-11-27 14:00:29 +00:00
Matt-Yorkley
1ceb6ac916
Update orders_and_fulfilment report totals
2020-11-27 14:00:29 +00:00
Andy Brett
049f66c2aa
address #6411
2020-11-27 14:00:29 +00:00
Matt-Yorkley
9c41c296e4
Remove default comments from ApplicationResponder
2020-11-27 14:00:29 +00:00
Matt-Yorkley
d299c8cf01
Update test setup in Packer spec.
...
This is the correct way to set a variant's weight.
2020-11-27 14:00:29 +00:00
Matt-Yorkley
2b2f1ac0cd
Improve specificity of expectation in reset password email test
2020-11-27 14:00:29 +00:00
Matt-Yorkley
d2998f1190
Remove spaces in payments report
2020-11-27 14:00:29 +00:00
Matt-Yorkley
c6c20dc0f6
Add ActionController::ConditionalGet to Api::BaseController
...
This was added in Spree around the time of Rails 4.2 and seems to fix some of the response errors around the `responders` gem.
2020-11-27 14:00:29 +00:00
Matt-Yorkley
60aaf8100a
Fix some Rubocop offences
2020-11-27 14:00:29 +00:00
Matt-Yorkley
98f42a1f81
Fix output of Package#inspect
2020-11-27 14:00:29 +00:00
Matt-Yorkley
f589d278cf
Add failing spec for Package#inspect
2020-11-27 14:00:29 +00:00
Matt-Yorkley
2b884be8dd
Update specs to work with ActionMailer::DeliveryJob
2020-11-27 14:00:29 +00:00
Matt-Yorkley
64153c5072
Remove #handle_asyncronously and update to recommended asyncronous devise mail method
2020-11-27 14:00:29 +00:00
Matt-Yorkley
9de3370a8a
Fix precision in adjustment form display
...
The tests here were looking for values with a format like "10.00" but the output had changed to "10.0"
2020-11-27 14:00:29 +00:00
Matt-Yorkley
63fb46f440
Delete some dead code
...
There are some really weird issues in the spec here, and this module is not in use anywhere.
2020-11-27 14:00:29 +00:00
Matt-Yorkley
aa718824d8
Fix touch spec
...
The behavior in #change blocks ironically seems to have changed
2020-11-27 14:00:29 +00:00
Matt-Yorkley
4394d2fe43
Fix tag_rules ForbiddenAttributes errors
...
Example error:
Tag Rules creating allows creation of rules of each type
Failure/Error: expect(tag_rule.preferred_shipping_method_tags).to eq "volunteers-only"
expected: "volunteers-only"
got: ""
(compared using ==)
# ./spec/features/admin/tag_rules_spec.rb:81:in `block (3 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
ea5c7c5990
Fix broken redirect after bulk product update
...
Error:
As an Administrator
I want to be able to manage products in bulk
updating when a filter has been applied
Failure/Error: expect(page.find("#status-message")).to have_content "Changes saved."
expected to find text "Changes saved." in "Saving.."
# ./spec/features/admin/bulk_product_update_spec.rb:451:in `block (2 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
2905267142
Fix broken variant weight assignment in spec
...
OrderManagement::Stock::Packer builds a package with all the items
Failure/Error: expect(package.weight).to be_positive
expected `0.0 (#<BigDecimal:7f156c99fda8,'0.0',9(18)>).positive?` to be truthy, got false
# ./engines/order_management/spec/services/order_management/stock/packer_spec.rb:19:in `block (2 levels) in <module:Stock>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
71c6cee94c
Fix "modifying frozen string" error in Package#inspect
2020-11-27 14:00:29 +00:00
Matt-Yorkley
7ef0056225
Fix invoice rendering issue
...
Setting `locals: { :@order => order }` no longer works; `@order` is not set as expected in the partial. Fixes various errors eg:
Failure/Error: = "#{@order.number}"
ActionView::Template::Error:
undefined method `number' for nil:NilClass
# ./app/views/spree/admin/orders/invoice.html.haml:14:in `_app_views_spree_admin_orders_invoice_html_haml__1740595365701113578_70025078036080'
# ./app/services/invoice_renderer.rb:3:in `render_to_string'
# ./app/controllers/spree/admin/orders_controller.rb:89:in `invoice'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
b512d3ce21
Fix column preferences spec
...
Failure/Error: expect(preferences.map(&:column_name)).to eq [:col1, :col2, :col3]
expected: [:col1, :col2, :col3]
got: ["col1", "col2", "col3"]
(compared using ==)
Diff:
@@ -1 +1 @@
-[:col1, :col2, :col3]
+["col1", "col2", "col3"]
# ./spec/models/column_preference_spec.rb:56:in `block (4 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
98c99de835
Use ActiveJob::Testhelper where needed
2020-11-27 14:00:29 +00:00
Matt-Yorkley
1aa2b7274b
Fix test mailer delivery
2020-11-27 14:00:29 +00:00
Matt-Yorkley
ae33df946e
Fix StateMachine specs
2020-11-27 14:00:29 +00:00
Matt-Yorkley
54ad90e071
Replace deprecated ActiveRecord::ConnectionAdapters::Column#value_to_boolean
...
This method has been removed in Rails 4.2
2020-11-27 14:00:29 +00:00
Matt-Yorkley
e1c1574931
Refactor BulkInvoiceService to use ActiveJob
...
Removes use of #handle_asynchronously, which we need to do elsewhere. Fixes:
BulkInvoiceService#start_pdf_job starts a background process to create a pdf with multiple invoices
Failure/Error:
expect do
service.start_pdf_job [1, 2]
end.to enqueue_job Delayed::PerformableMethod
expected to enqueue exactly 1 jobs, but enqueued 0
# ./spec/services/bulk_invoice_service_spec.rb:8:in `block (3 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
8f8973b6f9
Call #deliver in user_mailer_spec so mail is sent
2020-11-27 14:00:29 +00:00
Matt-Yorkley
3c74541145
Fix misbehaving params in Api::ProductsController
...
In some cases the given params were being deleted here.
2020-11-27 14:00:29 +00:00
Matt-Yorkley
1ab62fddcb
Patch Paranoia#delete to resolve ActiveRecord::ConnectionAdapters::NullTransaction errors
...
Patches Paranoia gem to fix a conflict with transactions in Rspec: https://github.com/rubysherpas/paranoia/issues/274
Example error:
```
Failure/Error: order.line_items.first.variant.tap(&:delete)
NoMethodError:
undefined method `state' for #<ActiveRecord::ConnectionAdapters::NullTransaction:0x0000564117dddd18>
```
2020-11-27 14:00:29 +00:00
Matt-Yorkley
1e8d400534
Add Paranoia#delete (original)
2020-11-27 14:00:29 +00:00
Matt-Yorkley
1a4e292178
Fix json "empty body" expectations
2020-11-27 14:00:29 +00:00
Matt-Yorkley
49081e171e
Fix PG::UndefinedTable errors
...
The logic of #includes has changed slightly in Rails 4.2 and now usually needs the #references method as well.
PG::UndefinedTable:
# ERROR: missing FROM-clause entry for table "enterprises"
# LINE 1: SELECT "spree_users".* FROM "spree_users" WHERE (enterprises...
# ^
# ./spec/models/spree/user_spec.rb:125:in `block (4 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
a5472d6b64
Convert ConfirmSignupJob to ActiveJob
2020-11-27 14:00:29 +00:00
Matt-Yorkley
62b80043ba
Fix mailer specs
...
These methods are not actually called now until the email is being delivered.
2020-11-27 14:00:29 +00:00
Matt-Yorkley
eb040de422
Fix expectation in base_helper_spec
...
The attribute on this element are now rendered in alphabetical order
2020-11-27 14:00:29 +00:00
Matt-Yorkley
b36b0eddee
Fix Rubocop issues
2020-11-27 14:00:29 +00:00
Matt-Yorkley
aaf7a90f8b
Convert OrderCycleNotificationJob to ActiveJob
2020-11-27 14:00:29 +00:00
Matt-Yorkley
9e334a4c1e
Convert ConfirmOrderJob to ActiveJob
2020-11-27 14:00:29 +00:00
Matt-Yorkley
56f2d38714
Use "raise_in_transactional_callbacks"
...
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#error-handling-in-transaction-callbacks
2020-11-27 14:00:29 +00:00
Matt-Yorkley
6b3da4ac89
Fix "PG::ProtocolViolation: ERROR: bind message supplies 0 parameters" errors
2020-11-27 14:00:28 +00:00
Matt-Yorkley
31415d00e6
TEMP - Fix deprecated cache store naming
2020-11-27 14:00:28 +00:00
Matt-Yorkley
e155b00ab9
Fix undefined constant Spree::Responder
2020-11-27 14:00:28 +00:00
Matt-Yorkley
3c0172c507
Fix Spree::Preferences cache issue
...
In some cases this method was trying to delete a Rails.cache entry with `nil` as the key, leading to lots of errors.
2020-11-27 14:00:28 +00:00
Matt-Yorkley
3cba9a16aa
Use ActionController::Base for Api::BaseController
...
It looks like ActionController::Metal does not play nicely with the big changes to controller responders: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#responders
2020-11-27 14:00:28 +00:00
Matt-Yorkley
58350ed338
Set ActiveJob configs and convert WelcomeEnterpriseJob to new format
...
This needs to be done for all jobs.
Docs: https://guides.rubyonrails.org/v4.2/active_job_basics.html
2020-11-27 14:00:28 +00:00
Matt-Yorkley
54a4952dc5
Fix ForbiddenAttributesError on tag rules
2020-11-27 14:00:28 +00:00
Matt-Yorkley
34bfd877cc
Fix #bulk_update in EnterprisesController
2020-11-27 14:00:28 +00:00
Matt-Yorkley
16cc0afe8f
Replace removed method #retrieve_collector_from_mimes
...
https://apidock.com/rails/v4.1.8/ActionController/MimeResponds/retrieve_collector_from_mimes
2020-11-27 14:00:28 +00:00
Matt-Yorkley
ccaff08928
Re-add ForbiddenAttributesError debugging helper
2020-11-27 14:00:28 +00:00
Matt-Yorkley
91908a0e4c
Switch from state_machine to state_machines gem
...
The old version is completely unmaintained and does not work with Rails 4.2
2020-11-27 14:00:28 +00:00
Matt-Yorkley
6b45208cf1
Define Capybara server
...
The server type now has to be set explicitly for Capybara
2020-11-27 14:00:28 +00:00
Matt-Yorkley
fb333c37e7
Fix Api controller setup for responders gem
2020-11-27 14:00:28 +00:00
Matt-Yorkley
3090cfa909
Add setup for responders gem
2020-11-27 14:00:28 +00:00
Matt-Yorkley
9205c85d4d
Run rake db:migrate
2020-11-27 14:00:28 +00:00
Matt-Yorkley
ff9f6c3317
Remove foreigner gem
...
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#foreign-key-support
2020-11-27 14:00:28 +00:00
Matt-Yorkley
25dd47e511
Add responders gem
...
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#responders
2020-11-27 14:00:28 +00:00
Matt-Yorkley
ece3e7aa69
Update gems to Rails 4.2
2020-11-27 14:00:28 +00:00
Luis Ramos
ff8d935699
Fix problem in enterprises controller
2020-11-27 13:59:46 +00:00
Luis Ramos
1d32ecab98
Fix spec by adding necessary references statement
2020-11-27 13:59:46 +00:00
Luis Ramos
ff17ced101
Fix enterprises spec by adding needed references statement
2020-11-27 13:59:46 +00:00
Luis Ramos
fa6cf0f281
Fix prod importer spec in rails 4.1
2020-11-27 13:59:46 +00:00
Luis Ramos
7e39d78733
Fix Long Method rubocop issue
2020-11-27 13:59:46 +00:00
Luis Ramos
0152b4da55
Fix rubocop issues
2020-11-27 13:59:46 +00:00
Luis Ramos
2a03e42f2a
Update deep_munge patch to rails 4.1 where the code is now in ActionDispatch::Request::Utils
2020-11-27 13:59:46 +00:00
Matt-Yorkley
01a726d9bd
Fix stubbing of stock totals
...
Recent changes to the way count_on_hand is summed in Spree::Stock::Quantifier mean the old method here will not work. Error:
```
2) Spree::Variant#in_stock? when stock_items are not backorderable when stock_items out of stock return false if stock_items out of stock
Failure/Error: expect(variant.in_stock?).to be_falsy
expected: falsey value
got: true
# ./spec/models/spree/variant_spec.rb:241:in `block (5 levels) in <module:Spree>'
```
2020-11-27 13:59:46 +00:00
Matt-Yorkley
93fe8dbc5f
Replace #scoped, which is now deprecated and removed in Rails 4.1
2020-11-27 13:59:46 +00:00
Matt-Yorkley
5c5a6361bf
Fix nasty json encoding issue
...
The enterprise id returned by these json endpoints was being returned in *unicode* format, so where Angular was expecting a simple integer it was instead getting strings like: "\u0017"
2020-11-27 13:59:46 +00:00
Matt-Yorkley
0f2cbe8a52
Fix API exception response handling
...
For some reason when using `render text:` instead of `render json:` for this response, the status code being returned was 200 instead of the clearly explicitly defined 422 (:unprocessable_entity). I absolutely have no idea why!
2020-11-27 13:59:46 +00:00
Matt-Yorkley
f1002b953d
Disable Javascript CSRF protection on EnterprisesController#check_permalink route
...
This route checks if an enterprise permalink is taken or not. Allowing the route to be accessed via Javascript without strict CSRF protection is reasonable. Fixes the following errors:
ActionController::InvalidCrossOriginRequest: Security warning: an embedded <script> tag on another site requested protected JavaScript. If you know what you're doing, go ahead and disable forgery protection on this action to permit cross-origin JavaScript embedding.
2020-11-27 13:59:46 +00:00
Luis Ramos
3ebc8145df
Avoid calling update with nil values
2020-11-27 13:59:46 +00:00
Luis Ramos
edc1773676
Fix some calls to sum in reports code
2020-11-27 13:59:46 +00:00
Luis Ramos
6814eb663f
Fix respond_with error
2020-11-27 13:59:46 +00:00
Luis Ramos
78cfcd905f
Adapt more & and no & when using sum
2020-11-27 13:59:46 +00:00
Luis Ramos
9bbef16804
Converting all calls to ActiveRelation#sum to use a symbol with &
...
This is only applicable to database columns, if we are summing using a method in the model than the & is required!
2020-11-27 13:59:46 +00:00
Luis Ramos
974240fd4b
Fix two sum calls in checkout helper
2020-11-27 13:59:46 +00:00
Luis Ramos
7472b7cc27
Fix sum call in quantifier
2020-11-27 13:59:46 +00:00
Eduardo
a8a933d73a
change from render json to render plain due to template missing issue
2020-11-27 13:59:46 +00:00
Luis Ramos
bcd07e1791
Upgrade to rails 4.1
2020-11-27 13:59:46 +00:00
Luis Ramos
ecb29ec830
Add state machine patch to fix error with state machine
...
See here for details: https://github.com/pluginaweek/state_machine/issues/251#issuecomment-32133267
2020-11-27 13:59:46 +00:00
Luis Ramos
202aa3e5b7
Use reflections instead of, now gone, reflections
2020-11-27 13:59:46 +00:00
Luis Ramos
a05f43000a
ActionView was extracted from ActionPack in rails 4.1 so we need to use ActionView
2020-11-27 13:59:46 +00:00
Luis Ramos
61708e5deb
AbstractController::ViewPaths was moved to ActionView::ViewPaths in rails 4.1
2020-11-27 13:59:46 +00:00
Matt-Yorkley
27586d072d
Merge pull request #6423 from openfoodfoundation/revert-6277-controllers
...
Revert "Move Spree::Admin::BaseController to Admin::BaseController"
2020-11-27 14:29:15 +01:00
Matt-Yorkley
3bfa903912
Revert "Move Spree::Admin::BaseController to Admin::BaseController"
2020-11-27 14:11:57 +01:00
Matt-Yorkley
0ba670b180
Ensure order is cleanly reset to cart state when redirecting to cart
2020-11-27 11:42:46 +00:00
Matt-Yorkley
c4cfc1dc05
Improve order test in paypal controller spec
2020-11-27 11:42:06 +00:00
Pau Pérez Fabregat
17957ed6c0
Merge pull request #6408 from openfoodfoundation/transifex
...
Transifex
2020-11-27 10:31:56 +01:00
Pau Pérez Fabregat
8b6a08457a
Merge pull request #6293 from luisramos0/subs_debug
...
Add task to print Subscriptions debug info
2020-11-27 10:17:57 +01:00
Maikel
9e2a3d6973
Merge pull request #6277 from luisramos0/controllers
...
Move Spree::Admin::BaseController to Admin::BaseController
2020-11-27 16:13:55 +11:00
Icker
55b21310e4
Added introductory information for testing.
2020-11-25 09:44:02 -08:00
Transifex-Openfoodnetwork
1266a37ac5
Updating translations for config/locales/en_NZ.yml
2020-11-25 05:39:17 +11:00
Transifex-Openfoodnetwork
54feb2f57d
Updating translations for config/locales/en_AU.yml
2020-11-24 07:31:32 +11:00
Transifex-Openfoodnetwork
e9eb90507e
Updating translations for config/locales/ca.yml
2020-11-24 07:22:28 +11:00
Transifex-Openfoodnetwork
ee44159c83
Updating translations for config/locales/es.yml
2020-11-24 07:19:47 +11:00
Transifex-Openfoodnetwork
8861f5c6aa
Updating translations for config/locales/ca.yml
2020-11-24 07:19:18 +11:00
Matt-Yorkley
b089404891
Merge pull request #6362 from coopdevs/remove-unused-truncate-html-gem
...
Remove unused truncate_html gem
2020-11-23 00:49:34 +01:00
Matt-Yorkley
2fa2a30c67
Add spec coverage, refactor, avoid double-render errors
...
👍
2020-11-22 18:37:31 +00:00
Matt-Yorkley
cabec7e73f
Fix Rubocop warnings and tidy up
2020-11-22 18:02:54 +00:00
Matt-Yorkley
87df44764f
Extract stock-check logic to controller concern and inject prior to final Paypal payment confirmation.
2020-11-22 18:02:52 +00:00
Andy Brett
8f25568530
Merge pull request #6390 from jhsu802701/qtest
...
SIMPLE: added scripts for running test suite in quiet mode
2020-11-20 12:15:04 -08:00
Andy Brett
b1b422b90e
fix/silence rubocop styles
2020-11-20 10:41:31 -08:00
Andy Brett
cd94b23277
fix rubocop styles
2020-11-20 10:35:02 -08:00
Andy Brett
4e155641fc
fix nil error if no proxy orders found
2020-11-20 10:32:48 -08:00
Andy Brett
85d99f3bf2
Merge branch 'master' into controllers
2020-11-20 08:12:03 -08:00
Andy Brett
c6b3a615f1
Merge pull request #6385 from jhsu802701/update_db_schema
...
SIMPLE: updated db/schema.rb with 'bundle exec rake db:migrate'
2020-11-20 08:03:27 -08:00
Matt-Yorkley
242c1a2715
Add new Paypal feature spec
2020-11-19 01:44:53 +00:00
Matt-Yorkley
21d67a0723
Extract some more paypal-specific test code to new helper
2020-11-19 01:44:38 +00:00
Jason Hsu
59b3bfa161
Added scripts for running test suite in quiet mode and updated docker/README.md
2020-11-18 16:25:03 -06:00
Matt-Yorkley
41a5787830
Extract paypal response stubbing to helper
2020-11-18 15:39:01 +00:00
Matt-Yorkley
010c1c799d
Add some notes on paypal checkout flow
2020-11-18 14:55:29 +00:00
Matt-Yorkley
2faea65f82
Bring in Spree::PaypalController#confirm method
...
Original method from the gem. This handles the post-payment response from paypal.
2020-11-18 14:51:23 +00:00
Matt-Yorkley
dd8f139c1b
Memoize Spree::PaypalController#payment_method
...
This gets called 4 or 5 times in a single request just to read basic attributes from the object. The query doesn't need to be repeated each time
2020-11-18 13:45:14 +00:00
Matt-Yorkley
6d0d4b5096
Bring in Spree::PaypalController#payment_method
...
Original method from the gem. Modified in preceding commit.
2020-11-18 13:45:13 +00:00
Jason Hsu
b85f8d4b45
Updated db/schema.rb with 'bundle exec rake db:migrate'
2020-11-16 18:23:00 -06:00
dependabot-preview[bot]
66799bad46
Bump webmock from 3.9.5 to 3.10.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.9.5 to 3.10.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.9.5...v3.10.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-11-13 19:16:37 +00:00
Matt-Yorkley
3d4f0ebb7b
Ensure variants don't end up with invalid data when a product's variant_unit is changed
...
Fixes an issue where a product's variant_unit value is changed from "weight" to "items" and some of the product's variants can be left in an invalid state, which in turn breaks cloning of order cycles (with fatal errors).
2020-11-11 20:24:21 +00:00
Pau Perez
f9869d4360
Remove unused truncate_html gem
...
It seems that we don't use this gem in OFN. It was used in Spree in
https://github.com/openfoodfoundation/spree/blob/2-1-0-stable/core/app/helpers/spree/orders_helper.rb
to truncate the product description. We don't because we show it in
the product modal, and there's no trace of that helper method in our
codebase nor I see the gem used at all.
2020-11-11 13:18:23 +01:00
Matt-Yorkley
1cad631bdb
Replace secret_token and update comments
...
`secret_token` is apparently still called directly in other places...
2020-11-11 01:30:52 +00:00
Luis Ramos
5d93180081
Move subs tasks into subs:test namespace
2020-11-10 22:03:36 +00:00
Luis Ramos
fdfc0b330f
Remove some duplicated code
2020-11-10 22:03:36 +00:00
Luis Ramos
63d62d7ce4
Improve subs task by making it handle open and close times of the Order Cycle being tested
2020-11-10 22:03:36 +00:00
Luis Ramos
51451292bd
Add task to closse OC and confirm orders
2020-11-10 22:03:36 +00:00
Luis Ramos
2bb22fb7f4
Add task to reset Orders inside a specific Order Cycle by repeating the
...
placement job
2020-11-10 22:03:36 +00:00
Luis Ramos
5289a5b381
Add namespace to all sample data factories
...
These factories are not used in testing and this way we avoid collisions on the root namespace as it was happening already with OrderFactory
2020-11-10 22:03:36 +00:00
Matt-Yorkley
03d49c7987
Update secret key base
...
`secret_token` is no longer used in Rails 4+
2020-11-10 20:46:15 +00:00
Luis Ramos
c07215552e
Add log entries to log
2020-11-02 20:59:57 +00:00
Luis Ramos
2b01c80c54
Add subs debug task that prints out basic info about a specific Order Cycle
2020-11-02 20:59:57 +00:00
Luis Ramos
fa77204e14
Adapt spec to the move of the controller, in prod the call to request.env['PATH_INFO'] will work correctly
2020-10-31 10:44:19 +00:00
Luis Ramos
af713385d8
Add frozen string literal
2020-10-31 10:16:37 +00:00
Luis Ramos
c9972189d0
Change usage of Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:56:59 +00:00
Luis Ramos
eb07a91acb
Adapt code from Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:52:34 +00:00
Luis Ramos
66ba9ff73d
Move Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:51:37 +00:00
Luis Ramos
dbd41e9d31
Use ruby 2.4 as github actions do not support ruby 2.3.
2020-10-13 10:31:26 +01:00
Luis Ramos
87327dcf57
Add brakeman config
2020-10-13 10:31:13 +01:00