Delete dead code #has_available_payment

This is removed in Spree 2.2, as it serves no purpose.

See: 0617bdce30
This commit is contained in:
Matt-Yorkley
2021-01-13 15:48:02 +00:00
parent 3877721209
commit 8d338a06f3
4 changed files with 0 additions and 10 deletions

View File

@@ -87,7 +87,6 @@ module Spree
after_create :create_tax_charge!
validate :has_available_shipment
validate :has_available_payment
validates :email, presence: true,
format: /\A([\w\.%\+\-']+)@([\w\-]+\.)+([\w]{2,})\z/i,
if: :require_email
@@ -816,11 +815,6 @@ module Spree
errors.add(:base, Spree.t(:items_cannot_be_shipped)) && (return false)
end
def has_available_payment
return unless delivery?
# errors.add(:base, :no_payment_methods_available) if available_payment_methods.empty?
end
def after_cancel
shipments.each(&:cancel!)

View File

@@ -68,7 +68,6 @@ describe Spree::Order::Checkout do
context "from address" do
before do
order.state = 'address'
allow(order).to receive(:has_available_payment)
order.shipments << create(:shipment)
order.email = "user@example.com"
order.save!

View File

@@ -51,7 +51,6 @@ describe Spree::Order do
context "when current state is address" do
before do
allow(order).to receive(:has_available_payment)
allow(order).to receive(:ensure_available_shipping_rates)
order.state = "address"
end

View File

@@ -399,8 +399,6 @@ describe Spree::Order do
end
before do
# Don't care about available payment methods in this test
allow(persisted_order).to receive_messages(has_available_payment: false)
persisted_order.line_items << line_item
persisted_order.adjustments.create(amount: -line_item.amount, label: "Promotion")
persisted_order.state = 'delivery'