Jean-Baptiste Bellet
dab595f17f
Update all locales with the latest Transifex translations
2023-07-07 17:11:40 +02:00
Filipe
f0bcb79c09
Merge pull request #11169 from openfoodfoundation/11164-admin-orders-actions-dropdown-is-not-well-placed
...
Fix container issues introduced by #11123
2023-07-07 11:15:14 +01:00
jibees
967c5a99c3
Merge pull request #11167 from openfoodfoundation/dependabot/bundler/faraday-2.7.10
...
chore(deps): bump faraday from 2.7.9 to 2.7.10
2023-07-07 11:50:01 +02:00
jibees
72fa132c17
Merge pull request #11172 from openfoodfoundation/dependabot/bundler/sanitize-6.0.2
...
chore(deps): bump sanitize from 6.0.1 to 6.0.2
2023-07-07 11:44:16 +02:00
dependabot[bot]
9f539df5e0
chore(deps): bump sanitize from 6.0.1 to 6.0.2
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/main/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: sanitize
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:06:31 +00:00
dependabot[bot]
74ef681607
chore(deps): bump faraday from 2.7.9 to 2.7.10
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.9 to 2.7.10.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.9...v2.7.10 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-07 09:06:22 +00:00
Gaetan Craig-Riou
fb3c99e52c
Merge pull request #11121 from filipefurtad0/cart_state_orders_not_appearing_orders_page
...
Cart state orders not appearing orders page
2023-07-07 09:27:36 +10:00
Matt-Yorkley
eb71c65fc0
Merge pull request #11138 from Matt-Yorkley/variant-timestamps
...
Add timestamps to variants table
2023-07-06 18:22:19 +01:00
Matt-Yorkley
bbf53133cb
Add timestamps to variants table
2023-07-06 16:16:03 +01:00
jibees
2e9442a7ab
Merge pull request #11127 from openfoodfoundation/dependabot/bundler/vcr-6.2.0
...
chore(deps-dev): bump vcr from 6.1.0 to 6.2.0
2023-07-06 16:43:49 +02:00
dependabot[bot]
de384ac261
chore(deps-dev): bump vcr from 6.1.0 to 6.2.0
...
Bumps [vcr](https://github.com/vcr/vcr ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/vcr/vcr/releases )
- [Changelog](https://github.com/vcr/vcr/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vcr/vcr/compare/v6.1.0...v6.2.0 )
---
updated-dependencies:
- dependency-name: vcr
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-06 14:22:55 +00:00
Filipe
ba1ba6dbec
Merge pull request #11092 from mkllnk/bye-datadog
...
Remove datadog gem, too expensive
2023-07-06 15:20:20 +01:00
Filipe
99ed019413
Merge pull request #11136 from Matt-Yorkley/remove-available-on
...
Remove :available_on attribute from Product
2023-07-06 15:20:08 +01:00
jibees
3f070d7152
Merge pull request #11166 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.4
...
chore(deps): bump @floating-ui/dom from 1.4.3 to 1.4.4
2023-07-06 16:13:35 +02:00
jibees
5f54c7fe56
Merge pull request #11146 from openfoodfoundation/dependabot/bundler/rails-7.0.6
...
chore(deps): bump rails from 7.0.5 to 7.0.6
2023-07-06 16:04:16 +02:00
jibees
9c035c6114
Merge pull request #11128 from openfoodfoundation/dependabot/bundler/view_component-3.3.0
...
chore(deps): bump view_component from 3.2.0 to 3.3.0
2023-07-06 16:00:51 +02:00
Matt-Yorkley
42a3087cdb
Remove :available_on attribute from Product class
2023-07-06 14:36:35 +01:00
Jean-Baptiste Bellet
6ee388fe51
Fix container issues
2023-07-06 11:41:54 +02:00
dependabot[bot]
5c56c9b60b
chore(deps): bump @floating-ui/dom from 1.4.3 to 1.4.4
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.4/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-06 09:10:25 +00:00
David Cook
05a22b80bc
Merge pull request #11123 from dacook/buu-products-table
...
[admin_style_v3] Products table with variants
2023-07-06 09:37:31 +10:00
Filipe
39b597096c
Merge pull request #11137 from Matt-Yorkley/remove-product-permalink
...
Remove :permalink attribute from Product
2023-07-05 18:35:48 +01:00
jibees
de34b9b109
Merge pull request #11142 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.3
...
chore(deps): bump @floating-ui/dom from 1.4.2 to 1.4.3
2023-07-05 14:53:53 +02:00
dependabot[bot]
2a059fd879
chore(deps): bump rails from 7.0.5 to 7.0.6
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.5...v7.0.6 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 12:52:51 +00:00
jibees
9205aafbd9
Merge pull request #11147 from openfoodfoundation/dependabot/bundler/faraday-2.7.9
...
chore(deps): bump faraday from 2.7.6 to 2.7.9
2023-07-05 14:52:00 +02:00
jibees
409cf54a45
Merge pull request #11152 from openfoodfoundation/dependabot/bundler/state_machines-activerecord-0.9.0
...
chore(deps): bump state_machines-activerecord from 0.8.0 to 0.9.0
2023-07-05 14:49:08 +02:00
jibees
24f9770acc
Merge pull request #11154 from openfoodfoundation/dependabot/bundler/rubocop-1.54.1
...
chore(deps-dev): bump rubocop from 1.52.1 to 1.54.1
2023-07-05 14:48:15 +02:00
jibees
722f7b981b
Merge pull request #11158 from openfoodfoundation/dependabot/bundler/geocoder-1.8.2
...
chore(deps): bump geocoder from 1.8.1 to 1.8.2
2023-07-05 14:47:12 +02:00
dependabot[bot]
20bc6c8028
chore(deps): bump geocoder from 1.8.1 to 1.8.2
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.8.1 to 1.8.2.
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.8.1...v1.8.2 )
---
updated-dependencies:
- dependency-name: geocoder
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 09:23:48 +00:00
dependabot[bot]
eba8d8db83
chore(deps-dev): bump rubocop from 1.52.1 to 1.54.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.52.1 to 1.54.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.52.1...v1.54.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-04 09:26:38 +00:00
filipefurtad0
e547e735c0
Adds test on API call for orders page
...
Removes unecessary assertion on http status
2023-07-03 11:51:46 +01:00
filipefurtad0
3f7958afe3
Adds regression test to issue #11120
2023-07-03 11:51:46 +01:00
dependabot[bot]
a9cb35dcc0
chore(deps): bump state_machines-activerecord from 0.8.0 to 0.9.0
...
Bumps [state_machines-activerecord](https://github.com/state-machines/state_machines-activerecord ) from 0.8.0 to 0.9.0.
- [Commits](https://github.com/state-machines/state_machines-activerecord/compare/v0.8.0...v0.9.0 )
---
updated-dependencies:
- dependency-name: state_machines-activerecord
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-03 09:58:39 +00:00
Maikel
400d087789
Merge pull request #11133 from mkllnk/dfc-api-specs
...
OFN DFC API documenation in OpenAPI format generated with Rswag
2023-07-03 10:53:40 +10:00
Maikel
ffda344838
Merge pull request #11144 from mkllnk/remove-test-unit
...
Remove unused gem test-unit
2023-07-03 10:34:24 +10:00
Matt-Yorkley
fefa9288a4
Remove :permalink attribute from Product
2023-06-30 11:37:57 +01:00
Filipe
b175793b91
Merge pull request #10704 from abdellani/hide-customers-with-no-completed-orders
...
Hide users with no completed orders from a hub's customers list
2023-06-30 10:56:56 +01:00
dependabot[bot]
7c9cabbab7
chore(deps): bump faraday from 2.7.6 to 2.7.9
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.6 to 2.7.9.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.6...v2.7.9 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-30 09:34:58 +00:00
Maikel Linke
9c2d092f4d
Remove unused gem test-unit
2023-06-30 11:37:57 +10:00
filipefurtad0
efb5132ac2
Update all locales with the latest Transifex translations
2023-06-29 23:28:28 +01:00
Filipe
54a85a504d
Merge pull request #11101 from mkllnk/dfc-api-key
...
Allow access to DFC API with OFN API token
2023-06-29 17:20:21 +01:00
Filipe
d27a632a38
Merge pull request #11079 from abdellani/fix-distributors-listing-on-checkout-options
...
filter distributors before listing on checkout options
2023-06-29 17:02:34 +01:00
Filipe
36f4b2e7f9
Merge pull request #11107 from jibees/11085-edit-variant-cant-update-values-on-the-variant-edit-page
...
Admin, Edit variant: remove unwanted extra space on price (added in certain specific conditions)
2023-06-29 16:46:42 +01:00
Filipe
97f131e556
Merge pull request #11089 from jibees/11049-invoices-actions-dropdown-menu-disappears-after-creating-the-first-invoice
...
[Invoices] Actions dropdown menu disappears after creating the first invoice
2023-06-29 16:23:35 +01:00
Filipe
da226ea021
Merge pull request #11109 from mkllnk/image-urls
...
Gracefully deal with missing S3 config
2023-06-29 12:50:36 +01:00
Filipe
d92c7f89bd
Merge pull request #11022 from Matt-Yorkley/matomo
...
Call matomo manually on asynchronous page visits
2023-06-29 12:02:48 +01:00
dependabot[bot]
af4ae4aaae
chore(deps): bump @floating-ui/dom from 1.4.2 to 1.4.3
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.3/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-29 09:59:20 +00:00
Jean-Baptiste Bellet
045435e9cc
use the variant price itself
2023-06-29 11:02:56 +02:00
Jean-Baptiste Bellet
3286094804
number_to_currency can be nil: use a safe operator
2023-06-29 10:47:00 +02:00
Maikel Linke
8b3f45263c
Remove unnecessary spec clean-up
...
And clarify locale setup.
2023-06-29 10:40:01 +02:00
Jean-Baptiste Bellet
2fcf706aa3
Remove unwanted space at the end of the price
...
This `number_to_currency` method seems to display an extra space, not necessary when unit is `''`
Strip it.
Update specs as well. Thanks @filipefurtad0 for specs!!!
2023-06-29 10:40:01 +02:00
filipefurtad0
6b84fbf2b8
Adds after block, to remove configurations
...
Sets pending shared examples
2023-06-29 10:40:01 +02:00
filipefurtad0
504ee50dd4
Sets up a spec for #11085
2023-06-29 10:40:00 +02:00
David Cook
0ba342bf11
Merge pull request #10965 from macanudo527/fix_linelength_bundle2
...
Fix Layout/LineLength - Bundle 2
2023-06-29 15:27:08 +10:00
Maikel
dd1e1328cc
Merge pull request #11080 from rioug/fix-bulk-order-cancelation-spec
...
Fix bulk order cancellation test
2023-06-29 14:44:04 +10:00
Maikel
46ddab3781
Merge pull request #11088 from Matt-Yorkley/deployments-check
...
Update workflow permissions check to latest version
2023-06-29 14:34:46 +10:00
Maikel
6392c2c115
Merge pull request #11075 from mkllnk/test-cache
...
Use Redis for caching in test environment
2023-06-29 14:33:09 +10:00
Maikel Linke
029364d4a3
Express spec intent with DSL instead of comment
2023-06-29 14:25:50 +10:00
David Cook
714642f331
Use different Redis database for test environment
2023-06-29 14:15:18 +10:00
Filipe
ba99f85f5c
Merge pull request #10914 from abdellani/fix-stripe-sca-failure
...
redirect user to payment when the card doesn't have enough credit
2023-06-28 19:58:18 +01:00
Matt-Yorkley
ace2c5778f
Call matomo manually on Turbo page visits
2023-06-28 12:52:54 +01:00
Matt-Yorkley
a0a1f8f910
Merge pull request #11002 from openfoodfoundation/voucher-prep
...
Vouchers part 1
2023-06-28 11:30:12 +01:00
Maikel Linke
78d6d129e8
Simplify with extracted helper method
2023-06-28 14:11:50 +10:00
Maikel Linke
d21e6f99bb
Swaggerise CatalogItems spec
2023-06-28 14:11:50 +10:00
Maikel Linke
883e637545
Create deterministic test data for stable API docs
...
Otherwise the auto-generated Swagger file changes all the time without
code changes.
2023-06-28 13:50:54 +10:00
Maikel Linke
df29eaab98
Document DFC example body to create a product
2023-06-28 13:50:54 +10:00
Maikel Linke
db77d1591c
Add test examples to DFC API documentation
...
In other API specs, you provide example values in the schema. So the
specs contain examples which can be used for the documentation. But
instead of defining example data separately, we can use the generated
data by the specs. This way we document real output and don't have to
double up on documentation.
Note that we don't have schema definitions for the DFC API yet. And it
wouldn't make sense to replicate the DFC Ontology manually in JSON
Schema for this purpose. The DFC Connector ensures already that we
comply with the ontology. But I hope that we can use a tool at some
point to generate JSON Schema from the DFC Ontology which would add more
detail to the Swagger docs, I think.
2023-06-28 13:50:54 +10:00
Maikel Linke
b14c9bdf4c
Swaggerize SuppliedProduct spec
2023-06-28 13:50:54 +10:00
Maikel Linke
f0a5475563
Swaggerize Enterprise spec
2023-06-28 13:50:54 +10:00
Maikel Linke
7c0a4108d8
Show api-docs in production as well
...
We were hiding that before because the API is not officially released
yet but that's actually quite annoying. It's very conenient to have the
UI on production and be able to try out endpoints.
2023-06-28 13:50:54 +10:00
Maikel Linke
494c5e78de
Swaggerize Person spec
...
I chose the simplest spec first to demonstrate how it works. The UI at
/api-docs now shows this endpoint with two possible responses.
The docs are missing an example response which I hope to add later.
2023-06-28 13:50:54 +10:00
Maikel Linke
8368a6ccc9
Announce the new DFC endpoint
...
We need to declare in each spec file for which endpoint the spec is
because it was just choosing the first declared one by default. The
first one was v1 and now it's dfc-v1.7.
2023-06-28 13:50:54 +10:00
Maikel Linke
de51a7833d
Add script to swaggerize DFC API in its engine
...
Rswag doesn't look for specs in engines by default. We haven't added any
Rswag specs in the dfc_provider engine yet but that will come.
The generated API schema has some superfluous whitespace removed due to
a fix in the rswag gems.
2023-06-28 13:50:54 +10:00
David Cook
f280881126
Style tables with relaxed and condensed rows
...
* attempt with shadows, but they are between every row: http://jsfiddle.net/d872e3nb/
* another attempt at applying styles to tbody groups http://jsfiddle.net/sb38cLdu/
2023-06-28 09:59:57 +10:00
David Cook
2c14fe0434
Add variant rows and price column
2023-06-28 09:59:57 +10:00
David Cook
9c573f823a
Move .content under main content div
...
The .content div provides overall page margins and a max width, and is already nested inside the nav menus (this allows the nav background to fill the full width of the page.
The main content area should be structured the same way, so we can have flexibility needed to allow some screens to use the full page.
This doesn't seem to change the layout of any screens in the admin interface.
Now the table content can stretch full width
2023-06-28 09:59:57 +10:00
David Cook
6a2025b271
Add products table
...
With ellipsis clipping for long lines.
2023-06-28 09:59:57 +10:00
David Cook
809c15b197
Load products page with reflex
...
We will add the products in the next commit.
2023-06-28 09:59:57 +10:00
David Cook
841192fb96
Add new products page
...
Hidden behind admin_style_v3 feature toggle.
2023-06-28 09:59:57 +10:00
David Cook
efcaab5deb
Rename colour variables
2023-06-28 09:59:57 +10:00
dependabot[bot]
d65239fe47
chore(deps): bump view_component from 3.2.0 to 3.3.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.2.0...v3.3.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-27 10:03:13 +00:00
Filipe
748cdaaa52
Merge pull request #10963 from jibees/10956-orders-page-uncaught-error-missing-target-element-tooltip-for-tooltip-controller
...
Admin, Orders list: add tooltip on Edit action icon + capitalize tooltip (instead of uppercasing)
2023-06-27 09:58:34 +01:00
Mohamed ABDELLANI
e678c6149f
extract payment_faild from processing_failed
2023-06-27 09:26:26 +01:00
Mohamed ABDELLANI
4cca823a66
redirect user to payment when the card doesn't have enough credit
2023-06-27 09:14:48 +01:00
Neal Chambers
a4220891c5
Update .rubocop_todo.yml
2023-06-26 13:06:57 +09:00
Neal Chambers
5b6f45931c
Fix Layout/LineLength
2023-06-26 13:06:56 +09:00
Maikel Linke
c3d49bf31a
Speed up, simplify helper with ActiveRecord scopes
2023-06-26 12:56:00 +10:00
Maikel Linke
61c4fb936a
Test OrderCycleHelper with real data, not mocks
...
It's more realistic and doesn't break with the next change.
2023-06-26 12:55:57 +10:00
Maikel Linke
7f94fbc085
Add common whitespace to spec
2023-06-26 12:48:54 +10:00
Maikel
014fb69d4b
Merge pull request #10964 from macanudo527/fix_linelength_bundle1
...
Fix Layout/LineLength - Bundle 1
2023-06-26 12:10:39 +10:00
Maikel
bb5c5ffc7b
Merge pull request #11078 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.126.0
...
chore(deps): bump aws-sdk-s3 from 1.124.0 to 1.126.0
2023-06-26 11:11:39 +10:00
Maikel
a7915b8089
Merge pull request #10849 from mkllnk/report-cable
...
Show "loading" screen for background reports and display when ready
2023-06-26 10:25:48 +10:00
Konrad
49db2f30bc
Merge pull request #11014 from mkllnk/specs
...
Restore line item ordering
2023-06-25 21:45:26 +02:00
Konrad
8a8d78c081
Merge pull request #11041 from cillian/export-ofn-uid-column
...
Add an OFN UID column to the Users & Enterprises report
2023-06-25 20:46:18 +02:00
Maikel Linke
ff588cec40
Restore line item ordering
...
The line item sorting by id has been replaced by sorting by completed_at
time: ccb183d60b
While that's a good idea, the query param to order was only defined in
the client Javascript and there was no default ordering. Line items also
get their completed_at date from the order. So it's the same for all
items of the same order and the ordering with that group of line items
was random.
Now we are adding an order in addition. Items are first sorted by date
and then by id if there's any ambiguity.
2023-06-25 19:24:58 +02:00
Cillian O'Ruanaidh
8ab077bed8
Create enterprise inside :it block because it's only needed there so far
2023-06-25 19:01:42 +02:00
Cillian O'Ruanaidh
1984a1feeb
Use more readable click_button helper instead of find and click in users_and_enterprises_spec.rb
2023-06-25 19:01:42 +02:00
Cillian O'Ruanaidh
40b0bfb433
Add an OFN UID column to the Users & Enterprises report
2023-06-25 19:01:42 +02:00
dependabot[bot]
5010d3bbf3
chore(deps): bump aws-sdk-s3 from 1.124.0 to 1.126.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.124.0 to 1.126.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-25 18:26:42 +02:00
David Cook
6240baec0d
Update app/controllers/admin/enterprises_controller.rb
...
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2023-06-23 16:18:45 +09:00
Maikel
e065910d2d
Merge pull request #10939 from Matt-Yorkley/master-variants
...
Remove master variants
2023-06-23 13:42:58 +10:00
Maikel Linke
33d212d274
Gracefully deal with missing S3 config
...
I could have split this into several commits:
* DRY direct linking to images.
* Check S3 config before direct linking.
* Just check if service is public instead of relying on name.
Developers may copy a staging or production database or experiment with
S3 storage. But when the S3 config is missing then calling `service`
raises an ArgumentError due to a missing name.
Now we only try to call `service` if the S3 config is present.
2023-06-23 12:41:36 +10:00
David Cook
4bf65e330b
Enable master variants with associated order cycles
...
There's only 5 in UK prod. keeping them is easier than figuring out if it's safe to delete.
2023-06-23 11:50:26 +10:00
David Cook
2025a98f58
Delete stock_items for master variants
...
All variants have stock_items records, but master variants never use them, so these were always redundant.
2023-06-23 11:49:29 +10:00
David Cook
3bff7a9f13
Fix query
...
With deep nesting syntax.
I chose the longer alias 'left_outer_joins' because it's more explicit, and matches the use up on line 121.
2023-06-23 09:11:03 +09:00
Neal Chambers
172b1eea94
Update .rubocop_todo.yml
2023-06-23 09:11:02 +09:00
Neal Chambers
1e4034534c
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
Filipe
bca7813320
Merge pull request #10323 from abdellani/enterprise-fee-w-tax-by-order
...
Enterprise fee w tax by order
2023-06-22 23:25:11 +01:00
Filipe
9293dd379b
Merge pull request #11087 from Matt-Yorkley/image-error-notifications
...
Add image error Bugsnag notifications
2023-06-22 16:30:57 +01:00
Filipe
b4c4381473
Merge pull request #10987 from jibees/10979-white-label-trix-link-unlink-buttons-are-white-text-on-white-background
...
[White Label] Fix colors of custom content editor to have beautiful toolbar
2023-06-22 16:12:25 +01:00
Jean-Baptiste Bellet
7ce3c3f447
Overide a text-transform: uppercase to capitalize
...
Inherit comes from `app/webpacker/css/admin/components/buttons.scss`
2023-06-22 14:15:43 +02:00
Jean-Baptiste Bellet
91d24ba8ab
Add Edit tooptip for action icon in orders table
2023-06-22 14:15:43 +02:00
Matt-Yorkley
c88799618f
Set master variants which are associated to line items to non-master
...
Line items which reference a master variant is a scenario that in theory shouldn't have been valid or even possible for at least 5-6 years, and these old bits of data in theory should have been cleaned up at the time those changes were made. But a couple of servers have some really old data that's not in a nice state.
Here we can just flip the is_master flag to false for those specific (legacy data) cases before deleting any other master variants, to keep the legacy line item data intact.
2023-06-22 13:10:47 +01:00
jibees
22a3b31172
Merge pull request #11100 from mkllnk/remove-json-patch
...
Revert "Fix json v1.8.6 common.rb warning"
2023-06-22 11:11:21 +02:00
jibees
8eee90118e
Merge pull request #11093 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.4.2
...
chore(deps): bump @floating-ui/dom from 1.3.0 to 1.4.2
2023-06-22 10:25:13 +02:00
jibees
5ba9c815cf
Merge pull request #11082 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.20.2
...
chore(deps-dev): bump rubocop-rails from 2.19.1 to 2.20.2
2023-06-22 10:18:26 +02:00
jibees
300c4ceed2
Merge pull request #11083 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.1.2
...
chore(deps-dev): bump knapsack_pro from 5.1.0 to 5.1.2
2023-06-22 10:17:44 +02:00
Mohamed ABDELLANI
b072da142e
filter distributors before listing on checkout options
2023-06-22 09:00:39 +01:00
Maikel Linke
08a06d21fa
Allow access to DFC API with OFN API token
2023-06-22 16:58:12 +10:00
Maikel Linke
82fc6a2a9d
Prepare spec to authenticate with other means
...
I want to add OFN API key support.
2023-06-22 16:27:04 +10:00
Maikel Linke
e7fe04f526
Revert "Fix json v1.8.6 common.rb warning"
...
This reverts commit 21b80db0ee .
This fix was needed for an old version of the JSON module with a newer
version of Ruby. But we updated the json gem since and don't need this
any more.
2023-06-22 12:47:28 +10:00
Matt-Yorkley
f9185ea56e
Remove line items related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 18:08:21 +01:00
Matt-Yorkley
6f5d3ceacc
Remove inventory units related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 17:20:28 +01:00
Jean-Baptiste Bellet
d2534d6645
Be more specific via !important than the default button rule
...
This one should override the default one
2023-06-21 15:01:14 +02:00
Jean-Baptiste Bellet
7d9018c590
Instead of overriding css rules, prefer to not select rules for trix buttons
2023-06-21 15:01:14 +02:00
dependabot[bot]
c532e822e5
chore(deps): bump @floating-ui/dom from 1.3.0 to 1.4.2
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.3.0 to 1.4.2.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.4.2/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-21 09:57:46 +00:00
Jean-Baptiste Bellet
5d1c32e8cd
Remove linksDropdown which is now unused
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
4ec41572b1
Add spec on Canceling an order
...
Strange that it doesn't exist, but anyway, let's create it!
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
ce28c14544
Replace AngularJS directive to a StimulusJS one
...
Delete _order_links.html.haml_spec.rb
2023-06-21 10:29:48 +02:00
Jean-Baptiste Bellet
7421691506
Creates a dropdown controller with its specs
2023-06-21 10:29:47 +02:00
David Cook
5ec872c6fd
Merge pull request #11008 from mkllnk/dfc-connector-import
...
Prototype: Import products via DFC Connector
2023-06-21 12:23:58 +10:00
Maikel Linke
14b2e0f962
Remove datadog gem, too expensive
2023-06-21 11:44:21 +10:00
Matt-Yorkley
98a56bfcf8
Update workflow permissions check to latest version
2023-06-20 14:41:17 +01:00
Matt-Yorkley
776eac9f52
Add image error Bugsnag notifications
2023-06-20 14:14:19 +01:00
Matt-Yorkley
24aa55e053
Remove array syntax on new product form for product image
2023-06-20 13:14:52 +01:00
dependabot[bot]
e8e3aa5f5d
chore(deps-dev): bump knapsack_pro from 5.1.0 to 5.1.2
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 5.1.0 to 5.1.2.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.0...v5.1.2 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-20 09:31:26 +00:00
dependabot[bot]
584a25052f
chore(deps-dev): bump rubocop-rails from 2.19.1 to 2.20.2
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.19.1 to 2.20.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.19.1...v2.20.2 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-20 09:14:06 +00:00
Gaetan Craig-Riou
ea73781668
Fix bulk order cancellation
...
Add unticking of "send cancellation email to customer" to match
the current test expectation
2023-06-20 10:03:55 +10:00
Maikel Linke
a9f8c7c4ab
Update DFC API docs, describe all endpoints
2023-06-19 16:20:35 +10:00
Maikel Linke
ec8c710e3a
Import simple DFC SuppliedProduct
...
OFN products and variants need more data like a price but the DFC
stores that in a different object. We may get a larger graph containing
that information but we don't have any test data yet.
2023-06-19 16:19:48 +10:00
Maikel Linke
df9e1ac2b4
Encapsulate SuppliedProductBuilder
...
And improve EnterpriseBuilder. It was builder products twice.
2023-06-19 16:19:48 +10:00
Maikel Linke
1adfb5463a
Import DFC measures
2023-06-19 16:19:40 +10:00
Maikel Linke
949019a277
Map has* predicates to Connector attributes
2023-06-19 16:19:40 +10:00
Maikel Linke
bfd084d9b6
Import graphs including anonymous objects
2023-06-19 16:18:58 +10:00
Maikel Linke
3c6f90dbb3
Import from IO objects for convenience, efficiency
...
The Connector exports to a String but Rails' `request.body` is an IO
object. Since the used JSON-LD parser needs an IO object anyway and it
can lower the memory usage we take IO objects as well and handle
in-memory Strings only when given.
2023-06-19 16:18:58 +10:00
Maikel Linke
f5f8c349e1
Resolve DFC Connector objects when importing graph
2023-06-19 16:18:51 +10:00
Maikel Linke
12d56d725b
Import properties which contains lists
...
Not just single values.
2023-06-19 16:18:51 +10:00
Maikel Linke
2abad60511
Import DFC graphs with multiple objects
2023-06-19 16:18:42 +10:00
Maikel Linke
15dd38d6c6
Import simple data from DFC
2023-06-19 16:16:18 +10:00
Maikel Linke
cceca5f936
Use Redis for caching in test environment
...
All other environments use it.
2023-06-19 15:35:17 +10:00
Maikel Linke
f6db69104f
Update Gemfile.lock with new Ruby version
2023-06-19 15:03:44 +10:00
Maikel
7e20415490
Merge pull request #10888 from mkllnk/ruby3.1
...
Bump Ruby from 3.0.3 to 3.1.4
2023-06-19 10:08:20 +10:00
Maikel
101e72726c
Merge pull request #11032 from dacook/show-current-version2
...
Show current version2
2023-06-19 10:07:49 +10:00
Konrad
dab5436444
Merge pull request #10532 from abdellani/invoices
...
Invoices
2023-06-18 21:44:29 +02:00
Mohamed ABDELLANI
d059680f4b
remove white label from feature toggle
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
27c1fd0d30
test invoice model
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
639567e903
replace attr with attr_reader
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
fff0b1e577
Update lib/open_food_network/feature_toggle.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
7a0686786d
Update db/migrate/20230308075421_create_invoices.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
73cdcca022
fix linter issues
2023-06-18 21:03:13 +02:00
Matt-Yorkley
4eb05a1d73
Reduce public interface of OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Matt-Yorkley
3946e7a6f5
Memoize presenters in OrderInvoiceComparator
...
This is now twice as fast and triggers half the number of database queries if both comparison methods get called
2023-06-18 21:03:13 +02:00
Matt-Yorkley
c6ec13443e
Drop next_invoice_number method from Spree::Order
2023-06-18 21:03:13 +02:00
Matt-Yorkley
d3a31bd0bd
Rename @invoice_presenter instance variable to @order in invoice templates
2023-06-18 21:03:13 +02:00
Matt-Yorkley
352ad20681
Fix display_checkout_taxes_hash in invoice_table4 template
2023-06-18 21:03:13 +02:00
Matt-Yorkley
68ab539ed3
Include completed_at attribute
2023-06-18 21:03:13 +02:00
Matt-Yorkley
113e1344f2
Include tax adjustments in serializer and presenter
2023-06-18 21:03:13 +02:00
Matt-Yorkley
5bbc63f716
Fix options_text displaying when there is no options_text
2023-06-18 21:03:13 +02:00
Matt-Yorkley
72e537b598
Update *_amount_with_adjustments methods on LineItem presenter
...
These methods are slightly different and they're both needed in the template for invoice4
2023-06-18 21:03:13 +02:00
Matt-Yorkley
208840b99d
Use @invoice_presenter.checkout_adjustments
2023-06-18 21:03:13 +02:00
Matt-Yorkley
a44f24ad43
Remove prefixes from invoice data representation so it conforms to the same interface as order
2023-06-18 21:03:13 +02:00
Matt-Yorkley
8dba1618b1
Don't call information from @order in new invoice templates
...
Previously this template was calling various bits of data from the @order object and not the @invoice_presenter object
2023-06-18 21:03:13 +02:00
Matt-Yorkley
c3d6b2280f
Update reference to removed method
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0ed7599267
extract methods related to invoices from the order model to the OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
61d58df56f
fix linter issues
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d86173c509
add feature toggle
...
seperate the invoice templates that rely on presenters from the old ones.
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
fa14dc370b
implement the invoice data generator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d9efd10ac0
update attributes relevant for the comparaison
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0fbf88190e
Generate invoice model
...
There are three main components:
1. The invoice model
2. order serializers: serialize the order for the invoice
3. data presenters: the object that will be use to access the order's serialize data
2023-06-18 21:03:13 +02:00
Matt-Yorkley
ae24b2d688
Update ScopeVariantsForSearch logic to match both product and variant SKUs
2023-06-16 21:26:28 +01:00
Matt-Yorkley
0f253bb2a0
Blank out product SKU when cloning a product
...
This was effectively being done before for the product's sku (stored on the master variant) via the #duplicate_variant method, but now it needs to be done explicitly on the product in #duplicate_product
2023-06-16 21:26:28 +01:00
Matt-Yorkley
15000c7ed1
Remove unnecessary iterator
2023-06-16 21:26:28 +01:00
Matt-Yorkley
733dd3c428
Disable variant is_master column
2023-06-16 21:23:44 +01:00
Matt-Yorkley
be72bbebb9
Remove master images data migration tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
fbd09869bb
Remove is_master from variant serializer
2023-06-16 21:23:44 +01:00
Matt-Yorkley
ced60d4382
Remove superfluous method from products controller
2023-06-16 21:23:44 +01:00
Matt-Yorkley
b59bdc75e9
Delete master variants
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1daab8994d
Remove is_master and not_master scopes
2023-06-16 21:23:44 +01:00
Matt-Yorkley
0703bb4583
Remove unused is_master references in tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
85059bfb26
Remove master variant validation conditionals
2023-06-16 21:23:44 +01:00
Matt-Yorkley
8247dce2dc
Improve validation feedback on new variant page and add test coverage
2023-06-16 21:23:44 +01:00
Matt-Yorkley
618900767f
Fix flaky spec: use milliseconds in cache service and remove sleep
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1e36043a2e
Set unit_value to true when cloning a product
...
This value doesn't get persisted, but it's presence is validated. The product's duplicated variants store the actual :unit_value attribute
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1922598d2d
Reorganise associations, validations, scopes and callbacks for clarity
2023-06-16 21:23:44 +01:00
Matt-Yorkley
3ef7d2c9ff
Remove master variant from product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
21cba0aa13
Migrate first master variant image to product image
2023-06-16 21:23:44 +01:00
Matt-Yorkley
7dc1091bc2
Migrate product image from master variant to product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
d8649fc9fb
Migrate master variant :sku to product
2023-06-16 21:21:40 +01:00
Matt-Yorkley
6b9b5ea347
Stop storing unit_value and unit_description on master variant
2023-06-16 21:21:40 +01:00
Matt-Yorkley
8c0b8dad85
Stop using master variant for storing :display_as value
2023-06-16 21:21:40 +01:00
Matt-Yorkley
1b06c20197
Stop using master variant as a potential store for prices
2023-06-16 21:21:40 +01:00
Matt-Yorkley
80a0138b48
Update old specs that rely on master variant instead of real variants
2023-06-16 21:21:40 +01:00
Matt-Yorkley
d4188da7c1
Simplify product images delegation mess
2023-06-16 21:21:40 +01:00
Matt-Yorkley
42a5a48816
Remove dead code
2023-06-16 21:21:40 +01:00
Matt-Yorkley
dd224b953d
Update stage.yml
2023-06-16 14:24:23 +01:00
Matt-Yorkley
cfe5d9a740
Update stage.yml
2023-06-16 14:00:30 +01:00
Matt-Yorkley
09bfe14ae9
Update stage.yml
2023-06-16 13:39:12 +01:00
Mohamed ABDELLANI
68503e4e8b
remove useless variable
2023-06-16 06:54:11 +01:00
Mohamed ABDELLANI
65bc8e23c1
move update instructions to let blocks
2023-06-16 06:50:45 +01:00
Mohamed ABDELLANI
2b79258fdc
renamed: spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order.rb -> spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order_spec.rb
2023-06-16 06:39:38 +01:00
Mohamed ABDELLANI
c21a35a9fc
fix typo on lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_order.rb
2023-06-16 06:38:15 +01:00
Mohamed ABDELLANI
c8c3e65498
Update lib/reporting/reports/list.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
2cfa435b54
Update spec/system/admin/reports/enterprise_summary_fees/enterprise_summary_fee_with_tax_report_by_order.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
3e61830b40
optimize total_excl_tax & enterprise_fee_adjustemnt_ids
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
10fc816bba
update rubocop_todo list
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
542811b9ad
implement filtering by entreprise fee owner
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
9d53d775a6
add filtering by fee name
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
f66d9b9626
remove producers filter
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
83b951662a
add filters
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
e9671e4e1f
test enterprise fees with tax report by order
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
e9367b1f86
add enterprise fees with tax report by order
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
535f651c7e
implement enterprise fee report filters
2023-06-16 06:35:01 +01:00
Mohamed ABDELLANI
a120329aa6
rename EnterpriseFeeSummary::Base to EnterpriseFeeSummary::FeeSummary
2023-06-16 06:35:01 +01:00
Maikel
4e1f735630
Include feature toggle heading in release notes
2023-06-16 14:13:41 +10:00
Maikel Linke
2453084a6b
Update translations
2023-06-16 14:02:47 +10:00
Maikel
39183547aa
Merge pull request #11033 from openfoodfoundation/revert-10455-dependabot/bundler/redis-5.0.6
...
Revert "Fix `redis` and `hiredis-client` version requirements "
2023-06-16 13:42:55 +10:00
Maikel
24000b2ce3
Revert "Fix redis and hiredis-client version requirements "
2023-06-16 13:09:25 +10:00
Maikel
8e86f76278
Merge pull request #11018 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.2
...
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
2023-06-16 12:08:25 +10:00
Maikel
4a91c180a3
Merge pull request #11017 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.1
...
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
2023-06-16 11:14:10 +10:00
Maikel
d192024786
Merge pull request #11019 from filipefurtad0/flaky_cache_spec
...
Clears cache around examples
2023-06-16 11:12:24 +10:00
Maikel
ec7de516aa
Merge pull request #11011 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.124.0
...
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
2023-06-16 10:59:56 +10:00
David Cook
56e4b3b843
Load git version once at initialisation
...
Co-authored-by: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2023-06-16 09:36:16 +10:00
David Cook
47745b5e49
Merge pull request #11004 from dacook/show-current-version
...
Show current version at bottom of admin dashboard
2023-06-16 09:26:00 +10:00
Matt-Yorkley
3301c7cabc
Update stage.yml
2023-06-16 00:18:36 +01:00
David Cook
35d9837f24
Show current version at bottom of admin dashboard
...
With generic link to the releases page. We could provide a link to latest tag with `git describe --tags --abbrev=0`. But I thought it better to keep things simple.
2023-06-16 09:11:59 +10:00
Matt-Yorkley
436deb9797
Update stage.yml
2023-06-16 00:03:16 +01:00
Matt-Yorkley
57451f2639
Update stage.yml
2023-06-15 23:26:27 +01:00
Matt-Yorkley
d56ad66ab8
Update stage.yml
2023-06-15 20:57:40 +01:00
Matt-Yorkley
fc5a53ebd9
Update stage.yml
2023-06-15 20:53:20 +01:00
Matt-Yorkley
f27472106e
Update stage.yml
2023-06-15 20:52:07 +01:00
Matt-Yorkley
5729e33f69
Merge pull request #11031 from Matt-Yorkley/deployment-workflow
...
Add workflow for deploying to staging
2023-06-15 20:40:10 +01:00
Matt-Yorkley
584f6297f5
Allow manual workflow triggers
2023-06-15 20:18:44 +01:00
Matt-Yorkley
12bf17e21e
Add workflow for deploying to staging
2023-06-15 19:37:18 +01:00
Matt-Yorkley
7068df5d4b
Merge pull request #10804 from Matt-Yorkley/public-images
...
Update ActiveStorage image processing
2023-06-15 15:49:11 +01:00
Konrad
7a10edff82
Merge pull request #10988 from jibees/10980-white-label-trix-bullets-and-numbers-are-displayed-outside-the-text-field
...
[White Label] Custom tab content editor: order and unordered list should have a margin-left set
2023-06-15 16:13:19 +02:00
Konrad
5c0db892e5
Merge pull request #10983 from jibees/10982-admin_style_v3-use-oidc-settings-instead-of-oidc-settings-in-navigation
...
[OIDC] Translate 'Enterprises' > 'OIDC Settings' tab title
2023-06-15 16:07:07 +02:00
filipefurtad0
598f69f42f
Clears cache around examples
...
for specs testing cache
2023-06-15 11:28:01 +01:00
dependabot[bot]
ca5de6b0b2
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.1 to 7.1.2.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.1...v7.1.2 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-15 10:05:58 +00:00
dependabot[bot]
b0c9c6e6e1
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.12.0...v1.12.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-15 09:58:24 +00:00
David Cook
d195882645
Use builtin Rails method
2023-06-15 15:26:22 +10:00
Maikel Linke
a46917a7b7
Remove NULL possibility from customer flag
...
It should only be true or false. This was flagged by Rubocop. I also
added another Rubocop suggestion and combined two migrations because
they are related.
2023-06-15 12:02:45 +10:00
Maikel Linke
75cce8bc19
Simplify customer code
...
The API endpoint merges the created_manually flag in the params already.
No need to write it separately.
2023-06-15 12:02:45 +10:00
Maikel Linke
a655d3d787
Remove unnecessary writes on customer creation
...
The form only submits enterprise id and email address. We don't need to
assign any other attributes.
2023-06-15 12:02:45 +10:00
Maikel Linke
9bd6615dad
Change spec to "unhide" customers on create
2023-06-15 12:02:45 +10:00
Maikel Linke
ebebcf7a13
Remove useless code
2023-06-15 12:02:45 +10:00
Maikel Linke
22a6861f6f
Place class methods above instance methods
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
298ae8ffc3
set create_manualll flag if the customer already exists
2023-06-15 12:02:45 +10:00
Maikel Linke
107b17addb
Add index of much used created_manually column
2023-06-15 12:02:45 +10:00
Maikel Linke
9910d10eb8
Simplify and speed-up customers migration
...
This reduces the migration run time from 9.6 seconds to 0.16 seconds on
a production database.
* Simplify model naming.
* Remove unnecessary model code.
* Use Rails `missing` scope for efficient simplicity.
* Add `down` method for rollback instead of running `change` again.
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
608ff054b0
set the created_manually flag to true for all customers that don't have any orders
2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI
ebc3073604
use Customer#visible on the customers listing endpoints
...
Update app/models/customer.rb
Co-authored-by: Maikel <maikel@email.org.au >
Update spec/models/customer_spec.rb
Co-authored-by: Maikel <maikel@email.org.au >
Update spec/models/customer_spec.rb
Co-authored-by: Maikel <maikel@email.org.au >
authorize created_manually field to be set on APIv1
2023-06-15 12:02:45 +10:00
Maikel
701fef84f3
Merge pull request #10850 from mkllnk/require-belongs-to--part1
...
Require belongs_to associations - part 1
2023-06-15 09:20:42 +10:00
Konrad
cf3692e688
Merge pull request #10992 from openfoodfoundation/dependabot/bundler/active_storage_validations-1.0.4
...
chore(deps): bump active_storage_validations from 1.0.3 to 1.0.4
2023-06-14 22:25:16 +02:00
Konrad
863fed56ce
Merge pull request #10455 from openfoodfoundation/dependabot/bundler/redis-5.0.6
...
Fix `redis` and `hiredis-client` version requirements
2023-06-14 22:09:13 +02:00
Filipe
e6d42a0c4f
Merge pull request #10999 from Matt-Yorkley/bom-issues
...
Fix BOM order loading issue
2023-06-14 19:01:54 +01:00
Matt-Yorkley
64508d3c3d
Add unit test for direct image URLs
2023-06-14 12:53:20 +01:00
Matt-Yorkley
395cf7fb8d
Use direct image URLs for enterprise logos
2023-06-14 12:53:20 +01:00
Matt-Yorkley
5ad37ce6a5
Return default image url on ActiveStorage errors in image loading
2023-06-14 12:53:20 +01:00
dependabot[bot]
6e9721b64c
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.123.1 to 1.124.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-14 09:58:54 +00:00
Matt-Yorkley
4c7e947738
Migrate data
...
So it turns out all images uploaded before the ActiveStorage migration are internally set to "public-read", and all images uploaded after the migration are internally set to "private". This migration switches all images in S3 buckets back to "public-read".
2023-06-14 10:56:10 +01:00
Matt-Yorkley
b510668ecf
Render direct URLs for s3 images
2023-06-14 10:56:10 +01:00
Matt-Yorkley
6f12d012ed
Use #url helper
2023-06-14 10:56:10 +01:00
Matt-Yorkley
551d0d3a93
Simplify calling #url_for in models
2023-06-14 10:56:10 +01:00
Matt-Yorkley
a898915724
Use named image variants
2023-06-14 10:56:10 +01:00
Matt-Yorkley
e54cff2274
Set images to public-read
...
Defining an alternate s3 configuration set to `public: true` means we can use it selectively. It sets the objects to `acl: "public-read"` by default (read-only) and means any image tags for those assets can use direct public links in the src attribute (without hitting the ActiveStorage::Representation endpoint). The default non-public service will still be used by default for any other files on instances using s3.
2023-06-14 10:56:10 +01:00
Matt-Yorkley
202b0041d1
Remove voucher processing from checkout edit action
2023-06-14 10:19:30 +01:00
Matt-Yorkley
1a744de37a
Improve voucher #calculate tests
2023-06-14 10:19:30 +01:00
Matt-Yorkley
93df70c0a7
Use order total excluding discounts in voucher calculations
2023-06-14 10:19:30 +01:00
Matt-Yorkley
52806a35ee
Fix Rubocop complaint
2023-06-14 10:19:30 +01:00
Matt-Yorkley
11382a518e
Fix test setup in BOM spec
2023-06-14 10:19:30 +01:00
Matt-Yorkley
ef09492883
Update adjustment spec to use orders past delivery state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
6fa381197a
Don't tax fees before payment state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
837e581c29
Reload order after cancelling it in tests that check shipment states
2023-06-14 10:19:30 +01:00
Matt-Yorkley
06c9697d0d
Don't try to cancel shipments that might already be cancelled
2023-06-14 10:19:30 +01:00
Matt-Yorkley
c5dfecbb69
Reapply taxes at model level if order address changes
...
This should be done at the model level
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0f23fc510
Extract before_payment_state? method
2023-06-14 10:19:30 +01:00
Matt-Yorkley
13a22c56f4
Move taxing of admin adjustments out of customer details controller
2023-06-14 10:19:30 +01:00
Matt-Yorkley
65b6a75c9b
Reorder callback definitions
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0d0f8fd2f
Tidy up checkout tax spec
2023-06-14 10:19:30 +01:00
Maikel Linke
c2605b2606
Display loading spinner before quick reports
...
We had a race condition that could first display the report and then
replace it again with the "loading" spinner. That doesn't seem to happen
now that we changed the order of cable events.
2023-06-14 15:40:52 +10:00
Maikel Linke
91d0dabc1d
Require associations on DistributorShippingMethod
2023-06-14 15:09:12 +10:00
Maikel Linke
bd11475fe1
Require associations on DistributorPaymentMethod
2023-06-14 15:08:22 +10:00
Maikel Linke
ed231ec512
Update belongs_to default in Customer model
2023-06-14 15:08:05 +10:00
Maikel Linke
fc00a48d67
Require associations of CoordinatorFee
2023-06-14 15:08:05 +10:00
Maikel Linke
c02c90317f
Require user of column preference record
...
It doesn't make sense to have a preference without a user. And it was
already enforced in the database.
2023-06-14 15:07:43 +10:00
Maikel Linke
2d4cfd7548
Validate and enforce AdjustmentMetadata associations
2023-06-14 15:07:43 +10:00
Maikel Linke
d88781a083
Start to adopt new default to require belongs_to
...
Newer version of Rails have this option as default. We can slowly
transition to opt in gradually, model by model. Once all models are
covered, we can change the default and remove the setting from the
models again.
The style violation was added to the todo file because it's temporary.
We have 60 models using `belongs_to`. And changing them all at once
breaks some specs. So let's do it gradually.
2023-06-14 15:06:59 +10:00
Maikel
989a88e252
Merge pull request #10848 from mkllnk/totals-report
...
Fix error on summarising total_units in Order Cycle Supplier Totals report
2023-06-14 13:59:48 +10:00
Matt-Yorkley
074eb4b592
Move tax charge logic out of checkout controller and update payment transition
2023-06-13 17:53:46 +01:00
Matt-Yorkley
bf912ae4d3
Remove angular loading element in darkwarm layout
2023-06-13 17:35:13 +01:00
Filipe
9c42781ff1
Merge pull request #10913 from abdellani/remove-split-checkout-toggle-and-legacy-checkout
...
Remove split checkout toggle and legacy checkout
2023-06-13 17:00:07 +01:00
Matt-Yorkley
73b2d37224
Don't try to load orders if the number of line_items with the current filters applied is zero
...
This ends up sending a request to the orders endpoint with no filters and no search params, which then tries to load every order in the entire database if the user is superadmin, which blows up.
2023-06-13 15:47:19 +01:00
Mohamed ABDELLANI
2654d3b866
update the rubocop_todo list
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5fa81d1333
Fix invalid test setup in old tax tests
2023-06-13 14:58:16 +01:00
Matt-Yorkley
4e7fab6914
Delete dead code Checkout#find_transition
...
This method is only called from tests and nowhere else in the codebase. We may as well remove it.
2023-06-13 14:58:16 +01:00
Matt-Yorkley
8d633234f4
Set voucher specs to pending temporarily
2023-06-13 14:58:16 +01:00
Matt-Yorkley
d5a625bdeb
Fix Paypal spec
2023-06-13 14:58:16 +01:00
Matt-Yorkley
0e289a23c1
Set some legacy checkout specs that we might want to rewrite later to pending
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5487aa19fc
Fix missing checkout_state_path
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
345f540723
fix spec/models/spree/tax_rate_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
78617905c6
remove spec/requests/checkout/concurrency_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
56204b2315
fix ./spec/routing/stripe_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
905187f3ce
fix ./spec/services/order_tax_adjustments_fetcher_spec.rb:100
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
7e84579aa3
spec/system/consumer/shopping/checkout_stripe_spec
...
these tests are using the legacy checkout
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
bd0e7cdfc8
remove legacy checkout tests
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
907c65d98c
run create_tax_charge! after transition to payment state
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
c2aaf88e98
remove checkout controller
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
fc0cca2210
remove legacy checkout view
2023-06-13 14:58:16 +01:00
jibees
c379dcacc5
Merge pull request #10993 from openfoodfoundation/dependabot/bundler/jwt-2.7.1
...
chore(deps): bump jwt from 2.7.0 to 2.7.1
2023-06-13 15:05:30 +02:00
jibees
64e6d639c1
Merge pull request #10995 from openfoodfoundation/dependabot/bundler/rubocop-1.52.1
...
chore(deps-dev): bump rubocop from 1.52.0 to 1.52.1
2023-06-13 15:03:45 +02:00
jibees
374904f473
Merge pull request #10996 from openfoodfoundation/dependabot/bundler/test-unit-3.6.0
...
chore(deps): bump test-unit from 3.5.9 to 3.6.0
2023-06-13 15:03:03 +02:00
jibees
fb7ae9fd58
Merge pull request #10991 from openfoodfoundation/dependabot/bundler/view_component-3.2.0
...
chore(deps): bump view_component from 3.1.0 to 3.2.0
2023-06-13 15:02:26 +02:00
dependabot[bot]
19bd05ce5a
chore(deps): bump test-unit from 3.5.9 to 3.6.0
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.9 to 3.6.0.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.9...3.6.0 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:11:47 +00:00
dependabot[bot]
f9abec4346
chore(deps-dev): bump rubocop from 1.52.0 to 1.52.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.52.0 to 1.52.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.52.0...v1.52.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:10:38 +00:00
dependabot[bot]
3e7ad17f69
chore(deps): bump jwt from 2.7.0 to 2.7.1
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.7.0...v2.7.1 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:08:44 +00:00
dependabot[bot]
b813879330
chore(deps): bump active_storage_validations from 1.0.3 to 1.0.4
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.3...1.0.4 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 10:02:26 +00:00
Filipe
12bb8db7b3
Merge pull request #10933 from Matt-Yorkley/fix-payment-intents
...
Fix ProcessPaymentIntent service
2023-06-13 11:00:27 +01:00
dependabot[bot]
c3846ad269
chore(deps): bump view_component from 3.1.0 to 3.2.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-13 09:58:11 +00:00
Matt-Yorkley
93c3241bb5
Add more test coverage in stripe controller spec
2023-06-13 10:14:09 +01:00
Matt-Yorkley
abd55b2104
Move order to completed whether it's current state is payment or confirmation
2023-06-13 10:14:09 +01:00
Matt-Yorkley
47df9493ae
Fix ProcessPaymentIntent service
2023-06-13 10:14:09 +01:00
Gaetan Craig-Riou
694e46d1fb
Fix Bundler/OrderedGems
2023-06-13 15:35:40 +10:00
Gaetan Craig-Riou
4564021f79
Remove redis version limitation
2023-06-13 15:06:52 +10:00
David Cook
b85cf26907
Add comment
2023-06-13 15:00:09 +10:00
Jean-Baptiste Bellet
02432ee2ec
Do not upgrade to redis >= 5
...
since Redis >= 3, < 5 is actually a requirement of Action Cable Redis subscription adapter until Rails 7.0.4.
https://github.com/rails/rails/blob/v6.1.7/actioncable/lib/action_cable/subscription_adapter/redis.rb
2023-06-13 15:00:09 +10:00
Jean-Baptiste Bellet
520ced350e
Do not specify redis version
2023-06-13 14:59:19 +10:00
Jean-Baptiste Bellet
e41d1f2205
Following the doc, remove hiredis and use hiredis-client
...
Reference:
- https://github.com/redis/redis-rb/issues/1178
- https://github.com/redis/redis-rb#hiredis-binding
2023-06-13 14:59:19 +10:00
David Cook
c5ce49e08c
Merge pull request #10948 from dacook/buu-table-styles
...
[admin_v3] Update all table styles
2023-06-13 13:08:55 +10:00
David Cook
e4c65ea87d
Prettify palette file
2023-06-13 11:46:28 +10:00
David Cook
f007cf3dad
Fix up table borders
2023-06-13 11:45:39 +10:00
David Cook
edcdcd3f74
Use header colour for table headers
2023-06-13 11:45:39 +10:00
David Cook
16534319b6
Replace dark blue with "Sherpa blue"
...
It looks like it’s used in headers, some buttons and a loading message
2023-06-13 11:45:39 +10:00
David Cook
d85ea628e2
Change default font colour to near-black
...
It looks like this is the main font colour in the new designs.
2023-06-13 11:45:39 +10:00
David Cook
821446e150
Style pagination links
...
And provide a basic hover state for most other buttons.
The pagination button hover and active states will need updating.
The darker background colour sometimes wraps a whole table (eg products table).
2023-06-13 11:45:39 +10:00
David Cook
744f95809a
Remove uppercase styling of form elements
2023-06-13 11:45:39 +10:00
David Cook
fb17a679c0
First pass at new table colours
...
There is more to do, for example the dropshadows.
I've continued with the unopinionated colour naming (eg color-7), but would like to consider giving them more meaningfule names..
2023-06-13 11:45:39 +10:00
David Cook
2ae91bdbe2
Use variable for font size reset
...
The current value is 13px already, but I'd like to experiment changing this.
I'm not sure if we even need the reset, but am not delving into that right now.
2023-06-13 11:44:48 +10:00
David Cook
3967f54533
Use different variables and table styles for admin_v3
2023-06-13 11:44:48 +10:00
Konrad
6bd66585a9
Merge pull request #10935 from openfoodfoundation/dependabot/bundler/i18n-1.14.1
...
chore(deps): bump i18n from 1.13.0 to 1.14.1
2023-06-12 17:39:42 +02:00
Konrad
11f84b5276
Merge pull request #10934 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.123.1
...
chore(deps): bump aws-sdk-s3 from 1.122.0 to 1.123.1
2023-06-12 17:24:20 +02:00
Filipe
23239bad8b
Merge pull request #10970 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.1.0
...
chore(deps-dev): bump knapsack_pro from 4.1.0 to 5.1.0
2023-06-12 16:19:32 +01:00
Konrad
a207a445b1
Merge pull request #10907 from jibees/3041-missing-translation-in-product-variant-selection-upon-order-creation
...
Admin, Create an order, Select a product: translate some messages in the product selection search box
2023-06-12 17:08:52 +02:00
Jean-Baptiste Bellet
16256ee114
Order and Unordered list should have a margin-left set
...
Has been reset to 0 via `typography.scss`
2023-06-12 16:58:00 +02:00
dependabot[bot]
15e9c4eb37
chore(deps): bump i18n from 1.13.0 to 1.14.1
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.13.0 to 1.14.1.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.13.0...v1.14.1 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 14:44:01 +00:00
Konrad
3e3ae5d8ae
Merge pull request #10929 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.0
...
chore(deps): bump ddtrace from 1.11.1 to 1.12.0
2023-06-12 16:43:01 +02:00
Konrad
48c107bde1
Merge pull request #10974 from cillian/ignore-whitespace-in-product-import
...
Ignore leading and trailing whitespace when importing products via a spreadsheet
2023-06-12 16:32:15 +02:00
Konrad
80dd8755b0
Merge pull request #10915 from mkllnk/mini-racer
...
Remove unused mini_racer gem
2023-06-12 16:05:52 +02:00
Konrad
791518988d
Merge pull request #10918 from openfoodfoundation/dependabot/bundler/view_component-3.1.0
...
chore(deps): bump view_component from 3.0.0 to 3.1.0
2023-06-12 15:36:21 +02:00
Jean-Baptiste Bellet
149ec5511c
Translate select2 messages
2023-06-12 15:11:23 +02:00
dependabot[bot]
351343fb6c
chore(deps): bump aws-sdk-s3 from 1.122.0 to 1.123.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.122.0 to 1.123.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:06:04 +02:00
dependabot[bot]
6145413b1a
chore(deps): bump ddtrace from 1.11.1 to 1.12.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.1 to 1.12.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.1...v1.12.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:05:11 +02:00
dependabot[bot]
d87e40bb69
chore(deps): bump view_component from 3.0.0 to 3.1.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 15:04:17 +02:00
Maikel Linke
d6859e0bf7
Remove unused mini_racer gem
...
All asset compilation is done with webpacker at the moment.
2023-06-12 15:01:11 +02:00
Konrad
1f2f5e2eec
Merge pull request #10892 from openfoodfoundation/dependabot/bundler/rails-7.0.5
...
chore(deps): bump rails from 7.0.4.3 to 7.0.5
2023-06-12 14:58:07 +02:00
jibees
b53aba3844
Merge pull request #10986 from openfoodfoundation/dependabot/bundler/capybara-3.39.2
...
chore(deps-dev): bump capybara from 3.39.1 to 3.39.2
2023-06-12 14:42:48 +02:00
jibees
45dcdf1611
Merge pull request #10985 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.1
...
chore(deps-dev): bump jasmine-core from 5.0.0 to 5.0.1
2023-06-12 14:31:03 +02:00
jibees
8c971f2efa
Merge pull request #10984 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.3.0
...
chore(deps): bump @floating-ui/dom from 1.2.9 to 1.3.0
2023-06-12 14:29:56 +02:00
dependabot[bot]
8a8200a039
chore(deps-dev): bump capybara from 3.39.1 to 3.39.2
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.1 to 3.39.2.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.1...3.39.2 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:58:05 +00:00
dependabot[bot]
8a376e782a
chore(deps-dev): bump jasmine-core from 5.0.0 to 5.0.1
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:57:39 +00:00
dependabot[bot]
6ab1bfb2ab
chore(deps): bump @floating-ui/dom from 1.2.9 to 1.3.0
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.9 to 1.3.0.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.3.0/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-12 09:57:18 +00:00
Sigmund Petersen
c2305615a6
Merge pull request #10971 from filipefurtad0/mouse_hover_spec
...
Adds spec for tooltips on orders page
2023-06-12 09:53:16 +02:00
Jean-Baptiste Bellet
ff0f81167a
Translate 'Enterprises' > 'OIDC Settings' tab title
2023-06-12 09:19:16 +02:00
Gaetan Craig-Riou
41b3ddae08
Merge pull request #10714 from macanudo527/fix_linelength
...
Fix Style/LineLength
2023-06-12 09:53:23 +10:00
Konrad
fc09f95fa1
Merge pull request #10961 from jibees/10946-white-label-trix-editor-changes-on-the-custom-tab-content-do-not-trigger-the-update-button
...
[WhiteLabel] Make update button active when changing custom tab content
2023-06-09 21:46:02 +02:00
Konrad
13037d2d9d
Merge pull request #10949 from jibees/10630-buu-as-an-enterprise-user-i-can-see-the-back-office-with-new-brand-colours
...
[`admin_style_v3`] As an enterprise user i can see the back office with new brand colours
2023-06-09 21:24:01 +02:00
Konrad
9125c730ed
Merge pull request #10960 from jibees/customize-trix-editor-to-have-the-right-colors
...
[White Label] Customize colors of custom content editor to have beautiful toolbar
2023-06-09 20:35:36 +02:00
Matt-Yorkley
70170078d1
Merge pull request #10976 from Matt-Yorkley/payment-localized-number
...
Require localized_number in Payment class
2023-06-09 18:45:13 +01:00
Konrad
bd505bbee7
Merge pull request #10959 from jibees/10945-white-label-narrow-screen-width-no-marging-on-custom-tab-content
...
[WhiteLabel] Add some margin to custom tab content for a shop
2023-06-09 19:45:04 +02:00
Matt-Yorkley
24200de8dd
Require localized_number in Payment class
...
There seems to be some contexts (jobs for subscriptions) where the Payment class loads but LocalizedNumber is an undefined constant. It lives in the /lib directory so it's not auto-loaded.
2023-06-09 18:16:37 +01:00
Konrad
d0f4c44add
Merge pull request #10938 from jibees/10931-white-label-custom-tab-without-a-title-impossible-to-disable-the-custom-tab
...
[White Label] Validate the presence of a custom tab title before creating it (+ max 20 characters length)
2023-06-09 19:01:13 +02:00
Cillian O'Ruanaidh
5cde4de512
Ignore leading and trailing whitespace in spreadsheet when importing products
2023-06-09 16:23:18 +01:00
Konrad
502b5e8664
Merge pull request #10937 from jibees/10900-white-label-remove-ofn-navigation-for-small-width-screens
...
[White Label] Remove ofn navigation for small width screens as well when option is activated
2023-06-09 16:28:22 +02:00
Konrad
35fef9e7ac
Merge pull request #10876 from dacook/prettier-css-admin
...
Prettier css admin
2023-06-09 16:02:11 +02:00
filipefurtad0
24913476ac
Adds spec for tooltips on orders page
2023-06-09 11:23:42 +01:00
dependabot[bot]
515a9a9b1c
chore(deps-dev): bump knapsack_pro from 4.1.0 to 5.1.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 4.1.0 to 5.1.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v4.1.0...v5.1.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-09 10:02:21 +00:00
Neal Chambers
a65b43d32f
Update .rubocop_todo.yml
2023-06-09 16:39:29 +09:00
Neal Chambers
9a8551e3ea
Shorten Where Statement
2023-06-09 16:39:29 +09:00
Neal Chambers
a35a07b441
Rewrite sum to be more Readable
2023-06-09 16:39:29 +09:00
Neal Chambers
449430cabc
Indent code to be more Readable
2023-06-09 16:39:29 +09:00
Neal Chambers
252697b782
Rewrite If and Unless Statements to be more Readable
2023-06-09 16:39:26 +09:00
Maikel Linke
ec865627d2
Wait for page setup to avoid flaky spec
...
I'm hiding a real bug here. There's a race condition when the cable event of
the finished report is sent before the loading spinner rendered. The
spinner then overwrites the report again. I added a spec for that but
don't have a solution yet.
I also noticed that the loading spinner is not displayed in testing but
we can assert on the CSS class of the container.
2023-06-09 16:22:01 +10:00
Jean-Baptiste Bellet
74fd1814e4
Create a trixeditor controller and broadcast a change event on form
...
Therefore, AngularJS can set form as dirty
+ add associated spec
2023-06-09 08:03:17 +02:00
Maikel Linke
d312a5912a
Style Layout/MultilineMethodCallIndentation
2023-06-09 14:45:06 +10:00
Maikel Linke
828b2f6f44
Replace too long list of arguments with keywords
...
Rubocop was complaining about too many arguments. But
`ApplicationJob#perform` needs all arguments handled in one call. While
we could allow the `perform` method generally to have more arguments,
there could be other methods called `perform` which should still be
scrutinised. Instead, it seems acceptable to me to have more arguments
as long as they are clearly named as keyword arguments. Rails uses this
a lot to document all options including their default values, for
example in Active Storage. It's better then bundling several arguments
in an undocumented hash just to reduce the number of given arguments.
And once we upgraded to Ruby 3.1, we can clean the method calls up as
well. `call(user: user)` becomes `call(user:)` without repetition.
2023-06-09 14:44:54 +10:00
Maikel Linke
e56c06571c
Remove outdated report timeout handling
...
Since we don't wait for the report any more, a timeout is very unlikely
and we don't need special handling for it.
2023-06-09 14:44:54 +10:00
Matt-Yorkley
7caf4b03d4
Improve flakyness on report specs
2023-06-09 14:44:53 +10:00
Matt-Yorkley
b230b37284
Update report email spec
2023-06-09 14:44:53 +10:00
Matt-Yorkley
524d1f0264
Switch to tighter Channel scoping...
...
This is not a normal pattern for setting up ActionCable channels, so it might need some notes. It ensures the broadcasts from the ReportJob are unique not just to the user session but also to the specific tab in the user's browser. Otherwise if the user has two different report pages open in separate tabs with the same session, the broadcast would overwrite the #report-table element in both of them.
2023-06-09 14:44:53 +10:00
Matt-Yorkley
a3ef604797
Run reports in background
2023-06-09 14:44:53 +10:00
Matt-Yorkley
ced959ad6a
Load reports show page without all the legacy javascript
2023-06-09 14:44:53 +10:00
Matt-Yorkley
242c74ceaf
DRY admin javascript imports
2023-06-09 14:44:53 +10:00
Maikel Linke
6803e0a8f9
Fix error on summarising total_units
2023-06-09 09:55:33 +10:00
Maikel Linke
71e4d2c6ed
Spec total_units report column
...
Current reports don't deal with invalid legacy data.
2023-06-09 09:55:33 +10:00
Maikel Linke
00e171a8f1
Reduce indentation in report spec
...
Specs should also test from the outside instead of declaring modules and
test from within those modules.
2023-06-09 09:55:33 +10:00
Jean-Baptiste Bellet
5d43285834
Update all locales with the latest Transifex translations
2023-06-08 17:36:04 +02:00
Filipe
ca03e1596b
Merge pull request #10952 from Matt-Yorkley/full-name
...
Improve nil-safety in variant naming methods
2023-06-08 16:26:28 +01:00
Filipe
c12415a340
Merge pull request #10955 from Matt-Yorkley/bulk-invoice-bug
...
Ensure directory exists before saving invoices pdf
2023-06-08 15:22:27 +01:00
Matt-Yorkley
f4261b85b8
Merge pull request #10940 from Matt-Yorkley/order-tidyup
...
Order class tidyup
2023-06-08 15:06:59 +01:00
Filipe
7974e1eaa6
Merge pull request #10936 from abdellani/fix-order-progressing-automatically-on-BOO
...
fix Viewing an order in state "confirmation" changes the state to "complete"
2023-06-08 14:50:04 +01:00
Jean-Baptiste Bellet
457d5a6c83
Override some css classes, to have a beautiful trix editor toolbar buttons
...
- buttons background are transparent (instead of blue)
- buttons background on hovering are transparent (instead of green)
- disabled buttons cursor is default (instead of pointer)
2023-06-08 11:43:59 +02:00
Jean-Baptiste Bellet
05104841cd
Add some margin to custom tab content via columns css class
2023-06-08 11:36:06 +02:00
Jean-Baptiste Bellet
d1d050e6a4
Limit size to 20 char for the custom tab title
2023-06-08 11:27:07 +02:00
David Cook
e2ba18f828
Set sentence case tab names in Ruby instead of CSS
...
I chose .capitalize instead of .humanize, because the latter has extra features which may not be desired.
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d6cb483f0d
Adjust color to the title of the page
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d7f7ff7436
Remove background, border and adjust margin top
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
905220a055
Add new color: $color-8 #191c1d Near-black
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
b865d8c1c0
Copy/Paste file admin/shared/layout under admin_v3 folder
...
+ prettier
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
51f47fc351
Add border bottom when hovering or selected
...
+ add some padding to separate those borders then
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
1b4236640d
Add border with box-shadow to menu and sub-menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
2057449dac
Add new color: $color-7 #EFF1F2 Light grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
ba98039e95
Adjust color to orange when selected or hover
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
d51786ac9e
Adjust font size for labels in menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
ccd7466ede
No more white on labels but dark grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
b163d4a584
Remove background-color on menu
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
a4d3011e27
Add new color: $color-9 #2E3132 Dark Grey
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
dd48092728
Prettier file
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
5ee3550ebd
Change case to Sentence case
...
CSS property `capitalize` uppercase all first letter of each words.
I need to use a small trick with `::first-letter` selector
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
eab46b67e3
Copy/Paste file admin/components/navigation under admin_v3 folder
...
+ prettier
2023-06-08 11:24:44 +02:00
Jean-Baptiste Bellet
e34f4a9971
AdminV3: Remove icon from icon from primary navigation menu
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-06-08 11:24:43 +02:00
Neal Chambers
dde775d2b7
Remove Old Code and Comments
2023-06-08 15:20:04 +10:00
Neal Chambers
3432e30465
Fix Style/UnlessGuard
2023-06-08 15:20:04 +10:00
Neal Chambers
12aa4f9970
Fix Layout/IndentationStyle
2023-06-08 15:20:04 +10:00
Neal Chambers
b04879604a
Rewrite Ternary Expression to Prevent Layout/LineLength
2023-06-08 15:20:04 +10:00
Maikel Linke
4ecbbae55e
Adapt large browser window as default
...
We were really close to that anyway. It simplifies the code a bit.
2023-06-08 13:51:29 +10:00
Maikel Linke
7cf68cd33b
Ensure that specs restore default window size
2023-06-08 13:51:25 +10:00
Maikel Linke
241b307762
Fix typos
2023-06-08 11:34:05 +10:00
David Cook
7d26158e06
Code cleanup
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-08 11:31:37 +10:00
Maikel Linke
99fbf80b4c
Style Layout/MultilineMethodCallIndentation
2023-06-08 11:15:42 +10:00
Matt-Yorkley
98f78927b7
Update app/jobs/bulk_invoice_job.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-08 00:56:24 +01:00
Matt-Yorkley
bf051fc35b
Pull checkout-workflow-related callback methods out into the Checkout module which defines checkout state changes
2023-06-07 18:54:20 +01:00
Matt-Yorkley
760bf269ca
Pull validations-related methods out into a separate module
2023-06-07 18:54:20 +01:00
Matt-Yorkley
bed2fe69f6
Update regression tests
2023-06-07 16:39:37 +01:00
jibees
c6b5eda85c
Merge pull request #10951 from openfoodfoundation/dependabot/bundler/faraday-2.7.6
...
chore(deps): bump faraday from 2.7.5 to 2.7.6
2023-06-07 17:34:10 +02:00
Matt-Yorkley
b091a0ed1a
Ensure directory exists before saving pdf
...
These directories can get wiped during deployments
2023-06-07 16:25:53 +01:00
Mohamed ABDELLANI
fbf55cf7bd
Merge pull request #2 from Matt-Yorkley/fix-order-progressing-automatically-on-BOO
...
Fix pre-existing issues with admin order controller
2023-06-07 13:49:06 +01:00
David Cook
3ce48848f0
Prettify the rest
2023-06-07 14:23:57 +02:00
David Cook
548a6f8d2e
Prettify app/webpacker/css/admin/plugins/
2023-06-07 14:23:57 +02:00
David Cook
10c52959ad
Prettify app/webpacker/css/admin/hacks/
2023-06-07 14:23:57 +02:00
David Cook
08dc3e3cbe
Prettify more admin css
...
yarn prettier --write
2023-06-07 14:23:02 +02:00
David Cook
fbf5862c66
Ignore some css subfolders
...
Prettier changes these files dramatically and they're arguably not easier to read.
2023-06-07 14:21:34 +02:00
dependabot[bot]
01dcf068f9
chore(deps): bump rails from 7.0.4.3 to 7.0.5
...
Bumps [rails](https://github.com/rails/rails ) from 7.0.4.3 to 7.0.5.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.0.4.3...v7.0.5 )
---
updated-dependencies:
- dependency-name: rails
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-07 14:12:34 +02:00
Matt-Yorkley
b58b555e38
Improve flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
983353e078
Remove dead code
...
I'm pretty sure this was here because advancing the order was adding order errors in some cases
2023-06-07 13:01:37 +01:00
Matt-Yorkley
968bf882c4
Fix flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
daf243996b
Improve flaky spec
2023-06-07 13:01:37 +01:00
Matt-Yorkley
7a7ab17db4
Improve customer tests
2023-06-07 13:01:37 +01:00
Matt-Yorkley
6daf29400f
Improve distribution and line items tests
2023-06-07 13:01:37 +01:00
Matt-Yorkley
f3ee10dd5a
Simplify by moving conditional to guard clause
2023-06-07 13:01:37 +01:00
Matt-Yorkley
cf0f148dba
Advance order when creating a shipment
...
This action gets called from the order edit page when adding line items and it's one of the places that needs to advance the order *before* redirecting back to the order edit action
2023-06-07 13:01:37 +01:00
Matt-Yorkley
bb73d70e57
Improve nil-safety in variant naming methods
2023-06-07 12:17:50 +01:00
dependabot[bot]
24343c769e
chore(deps): bump faraday from 2.7.5 to 2.7.6
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.5...v2.7.6 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-07 09:57:34 +00:00
Filipe
2d28a57c6f
Merge pull request #10922 from jibees/10903-white-label-make-logo-url-link-more-tolerant-in-terms-of-format-and-add-example
...
[White Label] Make logo url link more tolerant in terms of format
2023-06-07 10:00:31 +01:00
Maikel
1c9a09d88d
Merge pull request #10943 from openfoodfoundation/dependabot/bundler/paranoia-2.6.2
...
chore(deps): bump paranoia from 2.6.1 to 2.6.2
2023-06-07 16:31:01 +10:00
Maikel Linke
1ebacf96ad
Ignore accidental spaces around whitelabel URL
2023-06-07 13:12:06 +10:00
Matt-Yorkley
acc34d1deb
Update advance to payment logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
e1b37090be
Use _path helper instead of _url
2023-06-07 00:58:43 +01:00
Matt-Yorkley
6e8ed1f612
Hide secondary form until the order has line items
2023-06-07 00:58:43 +01:00
Matt-Yorkley
c7bb24e2a0
Remove dead code and clarify update logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
e88843c733
Ensure order number is generated nicely on new records
2023-06-07 00:58:43 +01:00
Matt-Yorkley
67c3e09dba
Use RESTful routes for orders controller actions
2023-06-07 00:35:47 +01:00
Konrad
1b6147db30
Merge pull request #10896 from jibees/10571-bom-orders-not-sorted-by-most-recent-date
...
BOM: Sort by order completed at desc for line items by default
2023-06-06 17:37:54 +02:00
Matt-Yorkley
2bfb57a1a1
Clarify shipments partial inclusion
2023-06-06 14:59:53 +01:00
Matt-Yorkley
8813edaed8
Fix variables in form partial
2023-06-06 14:59:03 +01:00
Jean-Baptiste Bellet
7dc8c4b891
Hide OFN navigation also on small width screens
2023-06-06 14:55:41 +02:00
Jean-Baptiste Bellet
a8b85a65e9
Add context for visiting a path
2023-06-06 14:44:05 +02:00
Jean-Baptiste Bellet
5c3e07db52
Test that OFN navigation is on mobile views as well
2023-06-06 14:44:05 +02:00
dependabot[bot]
10ca09eaef
chore(deps): bump paranoia from 2.6.1 to 2.6.2
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.1...v2.6.2 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-06 10:00:41 +00:00
Jean-Baptiste Bellet
daaeca88e8
Add some helpers to test mobile views
2023-06-06 12:00:16 +02:00
Mohamed ABDELLANI
77554e21fc
move advance_to_payment on order's details page from edit to update
2023-06-06 10:23:01 +01:00
Matt-Yorkley
7c72969792
Move Order #state_changed method out into Checkout concern (alongside order states logic)
2023-06-05 23:54:04 +01:00
Matt-Yorkley
a62e51c0d0
Remove Order #refresh_shipment_rates method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
1a7d70772a
Make Order #products_available_from_new_distribution method private
2023-06-05 23:54:04 +01:00
Matt-Yorkley
3dd4e7ef03
Delegate order updater method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
8a27dd84fe
Make Order #disallow_guest_order method private
2023-06-05 21:30:49 +01:00
Matt-Yorkley
05a715a43a
Remove Order #distribution_set? method
2023-06-05 21:30:46 +01:00
Matt-Yorkley
17b10d10c0
Make Order #deliver_order_confirmation_email method private
2023-06-05 21:30:43 +01:00
Matt-Yorkley
10dbeb32b2
Remove Order #credit_cards method
2023-06-05 21:30:40 +01:00
Matt-Yorkley
b3bd112cdb
Remove Order #shipped_shipments method
2023-06-05 21:30:36 +01:00
Jean-Baptiste Bellet
93cf562d59
Update en.yml
2023-06-05 15:48:02 +02:00
Jean-Baptiste Bellet
5938577bd1
Update custom_tab_spec.rb
2023-06-05 15:43:11 +02:00
Jean-Baptiste Bellet
1594d1c718
Validate custom tab title
2023-06-05 15:41:33 +02:00
Jean-Baptiste Bellet
abe63e5b04
Add context for visiting a path
2023-06-05 12:08:43 +02:00
Jean-Baptiste Bellet
40111910b6
Validates white_label_logo_link on enterprise model
2023-06-05 11:24:07 +02:00
Jean-Baptiste Bellet
4edb159ef8
Avoid flaky spec by matching the array
...
Context: https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/5081492387/jobs/9129944001?pr=10896
2023-06-05 10:05:09 +02:00
Jean-Baptiste Bellet
ccb183d60b
Sort by order_date desc for line_items in BOM
...
+ update spec to have different order time
2023-06-05 10:05:09 +02:00
jibees
a785b4d5e0
Merge pull request #10928 from openfoodfoundation/dependabot/bundler/rubocop-1.52.0
...
chore(deps-dev): bump rubocop from 1.51.0 to 1.52.0
2023-06-05 09:28:04 +02:00
Maikel Linke
16fba20686
Update rubocop todo file
2023-06-05 12:13:35 +10:00
Maikel Linke
1cbb45a618
Style Lint/RedundantSafeNavigation
...
The cop suggested to change more but they were false positives:
* https://github.com/rubocop/rubocop/pull/11915
2023-06-05 12:09:32 +10:00
Maikel Linke
38bd31d0e3
Style Layout/TrailingWhitespace
2023-06-05 10:42:21 +10:00
Konrad
750b6b284d
Merge pull request #10910 from jibees/10902-white-label-for-uploading-custom-logo-use-same-design-as-for-enterprise-logobanner-and-provide-required-image-dimensions
...
[White Label] Backoffice: improve design for logo used in shopfront
2023-06-04 14:50:49 +02:00
dependabot[bot]
78338864d8
chore(deps-dev): bump rubocop from 1.51.0 to 1.52.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.51.0 to 1.52.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.51.0...v1.52.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-02 09:57:30 +00:00
filipefurtad0
840da55941
Update all locales with the latest Transifex translations
2023-06-02 09:17:23 +01:00
Jean-Baptiste Bellet
880ba85791
Add http to white label logo link if this do not start with http
2023-06-01 17:37:05 +02:00
Jean-Baptiste Bellet
ced8f8aa58
Use shared_examples as we will test many URLs later on
...
"It's a Surprise Tool That Will Help Us Later"
2023-06-01 17:37:05 +02:00
jibees
d63c47e0f1
Merge pull request #10920 from openfoodfoundation/dependabot/bundler/sidekiq-scheduler-5.0.3
...
chore(deps): bump sidekiq-scheduler from 5.0.2 to 5.0.3
2023-06-01 17:26:54 +02:00
jibees
fd7d68d0a8
Merge pull request #10919 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.3
...
chore(deps-dev): bump rspec-rails from 6.0.2 to 6.0.3
2023-06-01 17:25:58 +02:00
Jean-Baptiste Bellet
2e0191e603
Improve UX: same as enterprise logo and promo image
2023-06-01 17:16:22 +02:00
Filipe
12159edaca
Merge pull request #10833 from Matt-Yorkley/order-angular
...
Remove Angular from admin orders index page
2023-06-01 13:57:39 +01:00
Filipe
2ba0f635f2
Merge pull request #10860 from Matt-Yorkley/order-cycle-deleting
...
Delete exchange variants in bulk when deleting an order cycle
2023-06-01 13:49:32 +01:00
Filipe
d67227deb8
Merge pull request #10812 from Matt-Yorkley/options-values
...
Remove OptionValue and OptionType code
2023-06-01 13:49:16 +01:00
Matt-Yorkley
1128fd9c02
Visual tweak to ship/capture buttons and success feedback
2023-06-01 12:13:12 +01:00
dependabot[bot]
3e46115f79
chore(deps): bump sidekiq-scheduler from 5.0.2 to 5.0.3
...
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases )
- [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moove-it/sidekiq-scheduler/compare/v5.0.2...v5.0.3 )
---
updated-dependencies:
- dependency-name: sidekiq-scheduler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-01 10:00:31 +00:00
dependabot[bot]
e428944849
chore(deps-dev): bump rspec-rails from 6.0.2 to 6.0.3
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.2...v6.0.3 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-01 09:59:07 +00:00
Matt-Yorkley
e99c328643
Update app/services/variant_units/variant_and_line_item_naming.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
0ac10472cf
Update app/models/spree/line_item.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
7f5d1be792
Guard against unsaved variant's product in OptionValueNamer for product import
2023-06-01 10:12:19 +01:00
Matt-Yorkley
a20277c3a7
Completely remove option_values and option_types from the codebase
2023-06-01 10:12:19 +01:00
Matt-Yorkley
35b41fc7fe
Persist unit_value on variant and "option value text" on variant and line_item and improve related AR callbacks
2023-06-01 10:12:19 +01:00
Matt-Yorkley
bfcf1203ac
Delete dead code
2023-06-01 10:11:20 +01:00
Matt-Yorkley
896e4c45f2
Clarify confusing class
2023-06-01 10:11:20 +01:00
Matt-Yorkley
3e5ecba738
Remove unhelpful Helper
2023-06-01 10:11:20 +01:00
Matt-Yorkley
e5eb622ac7
Cut dead code
2023-06-01 10:11:20 +01:00
Filipe
6b98e2b3cb
Merge pull request #10911 from jibees/10901-white-label-customized-logo-on-small-screens-doesnt-use-the-customized-url
...
[White Label] Small width screens : use the white label link if exists for logo in nav bar
2023-06-01 08:16:53 +01:00
Filipe
61b70a25d9
Merge pull request #10897 from openfoodfoundation/dependabot/npm_and_yarn/mrujs-1.0.0
...
chore(deps): bump mrujs from 0.10.1 to 1.0.0
2023-06-01 08:03:32 +01:00
Filipe
e0d24ed5c0
Merge pull request #10912 from openfoodfoundation/dependabot/bundler/puma-6.3.0
...
chore(deps): bump puma from 6.2.2 to 6.3.0
2023-06-01 07:42:22 +01:00
Filipe
2d4d8e26f5
Merge pull request #10875 from jibees/10561-allow-user-to-create-custom-tab-in-shop-navigation
...
[White Label] Allow user to create custom tab in shop navigation
2023-06-01 07:21:25 +01:00
Maikel
add725b6c0
Merge pull request #10861 from mkllnk/dfc-import
...
Update products with DFC Prototype
2023-06-01 08:48:39 +10:00
Filipe
5f429c77f8
Merge pull request #10791 from dacook/10630-new-brand-colours
...
[admin_v3] New brand colours in admin interface
2023-05-31 16:03:18 +01:00
dependabot[bot]
1b6815515e
chore(deps): bump puma from 6.2.2 to 6.3.0
...
Bumps [puma](https://github.com/puma/puma ) from 6.2.2 to 6.3.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.2.2...v6.3.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-31 10:01:43 +00:00
Jean-Baptiste Bellet
ac30e8b9da
Use the white label link if exists, otherwise, use the main_app.root_path
2023-05-31 10:46:23 +02:00
Filipe
668a573f12
Merge pull request #10908 from filipefurtad0/flaky_simple_spec
...
Changes date through keystrokes; removes Retry option
2023-05-30 16:43:36 +01:00
filipefurtad0
c5358b1303
Changes date through keystrokes; removes Retry option
2023-05-30 10:02:44 +01:00
jibees
7b6077d01f
Merge pull request #10905 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.9
...
chore(deps): bump @floating-ui/dom from 1.2.8 to 1.2.9
2023-05-29 14:57:34 +02:00
dependabot[bot]
841a021bc4
chore(deps): bump @floating-ui/dom from 1.2.8 to 1.2.9
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.8 to 1.2.9.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.9/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-29 09:59:12 +00:00
jibees
7ea2aa699d
Merge pull request #10904 from mkllnk/update-job-spec
...
Simplify background report spec after rspec fix
2023-05-29 10:19:31 +02:00
Maikel Linke
3fa62ceccf
Simplify background report spec after rspec fix
...
The rspec-rails gem had an issue which was fixed in the last release.
Now we can remove my workaround and simplify the spec.
2023-05-29 13:25:44 +10:00
David Cook
24c407f920
Merge pull request #10898 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.1
...
chore(deps): bump sidekiq from 7.1.0 to 7.1.1
2023-05-29 13:09:15 +10:00
Maikel Linke
77f716306d
Remove redundant test
2023-05-29 10:07:34 +10:00
Konrad
fff02a7ddb
Merge pull request #10893 from jibees/10853-white-label-remove-ofn-logo-on-navigation-menu-for-small-width-screens
...
[White Label] Small width screens: Hide OFN logo and use the customized logo if activated
2023-05-28 12:00:49 +02:00
Maikel Linke
0dcd87dda9
Update stock and SKU from DFC
...
The input has been observed with the nginx access log including
$request_body when the DFC Protoype pushed an update.
2023-05-28 10:39:08 +02:00
Maikel Linke
375b3a3cb0
Update variant's quantity from DFC
2023-05-28 10:39:08 +02:00
Maikel Linke
48a52582e6
Update variant description with DFC description
...
We used the name before because the DFC Prototype only displays the
description.
2023-05-28 10:39:08 +02:00
Maikel Linke
63837381e0
Update DFC test data with observation
...
This request came from the current DFC prototype. The changes are
probably implementing DFC v1.7.
I observed by including `$request_body` in the nginx log on the staging
server.
2023-05-28 10:39:08 +02:00
Maikel Linke
50ef06c973
Name DFC test data to clarify content
...
The DFC has several products like PhysicalProduct and SuppliedProduct.
Here we have a supplied product.
2023-05-28 10:39:08 +02:00
Maikel Linke
7344eb678b
Remove now unused helper
...
It was only used in controller specs which were all converted to request
specs.
2023-05-28 10:39:08 +02:00
Maikel Linke
dde4ea9334
Convert CatalogItems controller spec to request spec
2023-05-28 10:39:08 +02:00
Maikel Linke
207a15e55c
Convert SuppliedProducts controller spec to request spec
2023-05-28 10:39:08 +02:00
Maikel Linke
742468efd2
Convert EnterpriseController spec to request spec
...
Also testing request of unrelated enterprise instead of non-existing
enterprise because authorisation is important to test.
2023-05-28 10:39:08 +02:00
Maikel Linke
d338c61d2c
Convert PersonsController spec request spec
...
It's much more realistic and also tests the routing and authentication.
Besides using real authentication I also improved the matchers.
2023-05-28 10:39:08 +02:00
Maikel Linke
67c29dd38f
Activate DFC provider engine, remove feature toggle
2023-05-28 10:39:08 +02:00
Jean-Baptiste Bellet
01b3b3b5bb
Add some specs around tab for a shop
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
6b29f7e3c5
Sanitize content with a new TrixScrubber
...
specifically made for trix editor with its allowed tags
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
f26ecdf4f9
Don't need to pass the order through the nested view
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
6775e0b8f1
Add custom_ prefix to avoid name collision
...
One can name the custom tab `shop` which can be confusing.
2023-05-26 15:19:27 +02:00
Jean-Baptiste Bellet
9e67bd5824
Use specified values to be sure they aren't empty
2023-05-26 15:19:27 +02:00
dependabot[bot]
2f1e3a5c96
chore(deps): bump sidekiq from 7.1.0 to 7.1.1
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.0 to 7.1.1.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.0...v7.1.1 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-26 10:01:59 +00:00
dependabot[bot]
856fcd9e18
chore(deps): bump mrujs from 0.10.1 to 1.0.0
...
Bumps [mrujs](https://github.com/KonnorRogers/mrujs ) from 0.10.1 to 1.0.0.
- [Changelog](https://github.com/KonnorRogers/mrujs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/KonnorRogers/mrujs/compare/v0.10.1...v1.0.0 )
---
updated-dependencies:
- dependency-name: mrujs
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-26 09:58:38 +00:00
Matt-Yorkley
e34c2acba8
Move CablecarResponses include to ApplicationController
2023-05-26 10:35:41 +01:00
Matt-Yorkley
2373d044f7
Update app/services/orders_bulk_cancel_service.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-26 10:33:23 +01:00
Jean-Baptiste Bellet
a24604f146
Remove unused enterprise declaration
2023-05-26 10:24:11 +02:00
David Cook
14345ef1fa
Change warning orange to Mojo
...
> That way we only have one orangy/red colour and we start simplifying things.
2023-05-26 15:11:23 +10:00
David Cook
0df7c45a61
Change warning red to Mojo
...
Some templates still had this colour hardcoded. They are using angular so I didn't spend time updating them.
2023-05-26 15:11:23 +10:00
David Cook
dcf857cafb
Move warning colour definition to CSS
...
This also changes the orange to red, but that's part of the plan.
2023-05-26 15:11:23 +10:00
David Cook
e674c53535
Change error red color to Mojo
...
color-5 is used for error messages.
2023-05-26 15:11:23 +10:00
David Cook
719a704985
Change blue colour as per design
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/10630#issue-1644928392
2023-05-26 15:11:23 +10:00
David Cook
60ec24b92b
Use variables for spree-blue
...
Aka 'Havelock Blue', which is going to be changing.
2023-05-26 15:11:23 +10:00
David Cook
e928e74ae6
Use different palette for admin styles v3
...
Note that mail.css is still referring to the old palette.
2023-05-26 15:10:49 +10:00
David Cook
31fa9c2c04
Add admin_style_v3 feature toggle
2023-05-26 15:10:27 +10:00
David Cook
01b3901b08
Add admin_style_v3
...
Individual files may be copied in order to replace the old files.
NOTE: these may need manually re-syncing. If any of the copied files have changed on master in the meantime, we'll need to manaully review to consider bringing those changes to the new design.
2023-05-26 15:10:27 +10:00
David Cook
9051318147
Move colour palette to new file
...
This seemed like a good separation which will probably help with the upcoming changes.
Co-authored-by: jibees <jb.bellet@gmail.com >
2023-05-26 15:09:59 +10:00
Maikel
b013d3f2d4
Merge pull request #10895 from jibees/10894-flaky-speccontrollersapiv0order_cycles_controller_specrb89
...
Fix flaky spec: Prefer using `match_array` over `eq` to compare array
2023-05-26 14:06:14 +10:00
Maikel Linke
2e52a633ae
Acknowledge new style violations
2023-05-26 13:34:48 +10:00
Maikel Linke
15ef826ac1
Style Style/ClassAndModuleChildren
2023-05-26 13:27:34 +10:00
Maikel Linke
f674d5cd37
Style Layout/TrailingEmptyLines
2023-05-26 13:26:30 +10:00
David Cook
875f68b0e2
Update one more translation
2023-05-26 11:46:22 +10:00
Jean-Baptiste Bellet
cf9342f2c4
Prefer using match_array over eq to compare array
...
As we don't need order: https://rubydoc.info/github/rspec/rspec-expectations/RSpec%2FMatchers:match_array
2023-05-25 15:24:25 +02:00
Jean-Baptiste Bellet
eea1db4c4a
Hide OFN logo and use the customized logo if activated
2023-05-25 15:17:04 +02:00
jibees
8dde81c498
Merge pull request #10891 from openfoodfoundation/dependabot/bundler/test-unit-3.5.9
...
chore(deps): bump test-unit from 3.5.8 to 3.5.9
2023-05-25 13:34:38 +02:00
dependabot[bot]
2084d84c7a
chore(deps): bump test-unit from 3.5.8 to 3.5.9
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.8 to 3.5.9.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.8...3.5.9 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-25 09:58:28 +00:00
Filipe
8b7ca292af
Merge pull request #10884 from openfoodfoundation/10882-cookie-banner-is-displayed-on-every-page-even-after-accepting
...
Do not show cookies banner once user accept it
2023-05-25 10:36:27 +01:00
Jean-Baptiste Bellet
f961548da2
Deactivate file upload for trix editor
...
Source: https://benborgers.com/posts/trix-disable-files
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
e434eb17f0
Use full width since we use a WYSIWYG editor with toolbar
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
bb211bfc84
Allow HTML via trix editor for custom tab content
...
+ update spec as well
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
4dede3b361
Add trix editor
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
6e677f15ec
Can delete custom tab if uncheck the checkbox
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
f0665b0862
Add custom tab on shop
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
916b2313ab
Some links does not include _panel suffix. Add if needed.
...
Yep. Sounds like a hack.
+ Use the right URL anchor with `_panel` in href for each tab
+ update specs
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
fc21fdb485
Customize default tab: could be either shop or home
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
6b1d1ddbce
On order cycle change, go to shop panel
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
a28a792642
Allow communication between controllers via event
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
bb6b1e59f9
Use tabs_and_panels_controller.js instead of PageSelectionCtrl
...
Prefer StimulusJS over Angular
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
925b0e0308
Add a form in admin to create/update a custom tab for an enterprise
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
839419791f
Create CustomTab model, that belongs to an enterprise
2023-05-25 09:19:51 +02:00
David Cook
f890d9ceb4
Update all locales with the latest Transifex translations
2023-05-25 17:12:10 +10:00
jibees
abc0a29ddb
Merge pull request #10889 from mkllnk/dead-code
...
Remove dead reference to removed model
2023-05-25 09:10:14 +02:00
Maikel Linke
86c35fe2dc
Remove dead reference to removed model
2023-05-25 16:13:33 +10:00
Filipe
6d032002f1
Merge pull request #10750 from jibees/10560-allow-hide-of-groups-tab-in-shop-navigation
...
White Label: allow hide of groups tab in shop navigation
2023-05-24 21:11:04 +01:00
filipefurtad0
ca107c036c
Enables caching for cookies_spec.rb
2023-05-24 19:46:28 +02:00
jibees
e60376e6bd
Merge pull request #10885 from openfoodfoundation/dependabot/bundler/faraday-2.7.5
...
chore(deps): bump faraday from 2.7.4 to 2.7.5
2023-05-24 15:18:10 +02:00
jibees
d704157fef
Merge pull request #10886 from openfoodfoundation/dependabot/bundler/knapsack_pro-4.1.0
...
chore(deps-dev): bump knapsack_pro from 4.0.0 to 4.1.0
2023-05-24 15:17:16 +02:00
dependabot[bot]
b985ab8d99
chore(deps-dev): bump knapsack_pro from 4.0.0 to 4.1.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 4.0.0 to 4.1.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-24 10:10:08 +00:00
dependabot[bot]
d60ba96fe9
chore(deps): bump faraday from 2.7.4 to 2.7.5
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.4 to 2.7.5.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.4...v2.7.5 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-24 10:08:17 +00:00
Jean-Baptiste Bellet
3cd53cbd41
Adds some keys to this cached element, due to cookie banner
...
Once the user accept the cookie, we should not show the cookie banner element. This is handled via `app/helpers/footer_links_helper.rb#cookies_policy_link` and boolean:
```
!Web::CookiesConsent.new(cookies, request.host).exists? && Spree::Config.cookies_consent_banner_toggle
```
2023-05-24 10:45:06 +02:00
Maikel Linke
b4deb21872
Bump Ruby from 3.0.3 to 3.1.4
...
Major 3.1 highlights:
* https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/
2023-05-24 16:52:34 +10:00
Maikel
32d425dd58
Merge pull request #10880 from openfoodfoundation/dependabot/bundler/knapsack_pro-4.0.0
...
Bump knapsack_pro from 3.11.0 to 4.0.0
2023-05-24 14:05:09 +10:00
Maikel
ce1317933b
Merge pull request #10815 from Pauloparakleto/issue-7483
...
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
2023-05-24 11:57:44 +10:00
Maikel
340f10b323
Merge pull request #10539 from filipefurtad0/spec_for_enterprise_fee_selection_tax_inherit
...
Adds a spec to check enterprise fees creation
2023-05-24 11:29:27 +10:00
Maikel
8c11bf3033
Merge pull request #10839 from mkllnk/valid-email
...
Validate user's email address
2023-05-24 10:37:00 +10:00
Konrad
0854287b92
Merge pull request #10744 from jibees/10556-remove-ofn-header-banner-in-order-confirmation-emails
...
White Label: remove OFN banner from order confirmation emails when `hide_ofn_navigation` is activated for the shop
2023-05-24 01:14:16 +02:00
dependabot[bot]
6dc1cb6baa
Bump knapsack_pro from 3.11.0 to 4.0.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.11.0 to 4.0.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.11.0...v4.0.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-23 10:01:38 +00:00
Maikel Linke
ef3422bf58
Update syntax and clarify use of outdated gem
2023-05-23 08:23:58 +02:00
Maikel Linke
90cbac7176
Validate email domains
...
The gem checks the DNS system for a valid domain entry.
2023-05-23 08:23:58 +02:00
Maikel Linke
ffc45f77cf
Validate user email syntax on change
...
We probably have invalid entries in the database and we don't want these
records to suddenly become invalid. People would not be able to log in.
2023-05-23 08:23:58 +02:00
Maikel Linke
101b9025b4
Spec user email validation
...
The pending spec addresses:
* https://github.com/openfoodfoundation/openfoodnetwork/issues/10808
2023-05-23 08:23:58 +02:00
Konrad
b56b36f617
Merge pull request #10859 from filipefurtad0/change_voucher_default_message_en
...
[Vouchers] Updates warning_forfeit_remaining_amount default message
2023-05-23 08:20:41 +02:00
filipefurtad0
5e248aa715
Improving shared_example naming
2023-05-22 12:27:04 +01:00
filipefurtad0
554d515875
Introduces prefix to simplify assertions
2023-05-22 12:27:04 +01:00
Matt-Yorkley
459ef5f0d1
Only delete related exchange variants if exchange is outgoing
2023-05-22 11:09:29 +01:00
Jean-Baptiste Bellet
0bec7562a0
When hide_groups_tab is set to false, do not display group in shopfront
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-05-22 10:29:57 +02:00
Jean-Baptiste Bellet
0d98ec8f4c
In admin, add form to set hide_groups_tab attribute
...
+ add specs
2023-05-22 10:29:56 +02:00
Jean-Baptiste Bellet
38cc8a89d1
Add hide_groups_tab to Enterprise model
2023-05-22 10:29:56 +02:00
Matt-Yorkley
7c5067ff42
Update "special instructions" note tooltip and add missing test coverage
2023-05-21 14:06:14 +01:00
Matt-Yorkley
005d95e882
Fix "Resend Confirmation" link and add missing test coverage
2023-05-21 13:33:29 +01:00
Matt-Yorkley
dcdcdb4fc0
Align filter buttons centrally
2023-05-21 00:15:32 +01:00
Matt-Yorkley
abf00353ea
Permit explicit params
2023-05-21 00:15:32 +01:00
Matt-Yorkley
be1ed2bbcf
Update tomselect multiselect styling
2023-05-21 00:15:32 +01:00
Matt-Yorkley
52450028a1
Fix checkbox alignment
2023-05-21 00:15:32 +01:00
Matt-Yorkley
d50ac4bf45
Reinstate dropdown-with-prepend
2023-05-21 00:15:32 +01:00
Matt-Yorkley
4ddde65a04
Reimplement saving and restoring submitted search filters between page loads
2023-05-21 00:15:32 +01:00
Matt-Yorkley
7d33e0f74d
Allow programmatically refreshing flatpickr element via "flatpickr:change" event after changing the select's value externally
2023-05-21 00:15:32 +01:00
Matt-Yorkley
2ba2a826db
Clean up event handlers on disconnect in Flatpickr controller
2023-05-21 00:15:32 +01:00
Matt-Yorkley
d64a9afece
Replace angular ofn-with-tip directive on capture/ship buttons
2023-05-21 00:15:32 +01:00
Matt-Yorkley
770880c062
Update specs
2023-05-21 00:15:32 +01:00
Matt-Yorkley
310577c49d
Close dropdown after selection with multiselect
...
This conforms with the previous select2 multiselect behaviour
2023-05-21 00:15:32 +01:00
Matt-Yorkley
c3cf79f5ef
Delete angular ordersCtrl
2023-05-21 00:15:32 +01:00
Matt-Yorkley
71c4f2a5be
Update styling on multiselect tabs for tom-select
2023-05-21 00:15:32 +01:00
Matt-Yorkley
95f1643cec
Combine related reflex actions
2023-05-21 00:15:32 +01:00
Matt-Yorkley
bee46720f4
Combine bulk action controllers and pass reflex as an argument
2023-05-21 00:15:32 +01:00
Matt-Yorkley
5930d0c1f5
Make bulk actions more generic
2023-05-21 00:15:32 +01:00
Matt-Yorkley
55d9deb5bd
Update order cancelling bulk action
2023-05-21 00:15:32 +01:00
Matt-Yorkley
134f1ab151
Replace angular bulkInvoiceCtrl
2023-05-21 00:15:32 +01:00
Matt-Yorkley
27290e5b57
Make modal controller creatable and destroyable
2023-05-21 00:15:32 +01:00
Matt-Yorkley
25aecfa5b9
Add reflex for shipping orders
2023-05-21 00:15:32 +01:00
Matt-Yorkley
e58a37f65b
Add reflex for capturing orders
2023-05-21 00:15:32 +01:00
Matt-Yorkley
61849d84e7
Extract order capturing to OrderCaptureService
2023-05-21 00:15:32 +01:00
Matt-Yorkley
73b41154cc
Update admin flashes
2023-05-21 00:15:32 +01:00
Matt-Yorkley
048df6230b
Remove angular from admin orders index page
2023-05-21 00:15:32 +01:00
Matt-Yorkley
5ad68f25e3
Handle old jquery_ujs buttons
2023-05-21 00:15:30 +01:00
Matt-Yorkley
3df166fb2f
Drop jquery_ujs
2023-05-20 19:47:41 +01:00
Matt-Yorkley
59fd4ad251
Tidy up JS imports
2023-05-20 19:47:41 +01:00
Matt-Yorkley
48a8f57262
Prep admin JS
2023-05-20 19:47:41 +01:00
Matt-Yorkley
f181b35a90
Add minimal admin js setup
2023-05-20 19:47:41 +01:00
Matt-Yorkley
c4bc0a7bbd
Rename select-all-controller
2023-05-20 19:47:41 +01:00
paulo-felipe
3a35f12801
chore(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Group together sample tests to avoid rebuilding browser state.
2023-05-19 19:55:27 -03:00
paulo-felipe
c9ab092f7c
chore(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add back comment explaining bill address has been pre-loaded.
2023-05-19 19:55:27 -03:00
paulo-felipe
1e1d4b07d1
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Remove the old chained smoke test.
2023-05-19 19:55:27 -03:00
paulo-felipe
bd05f40b17
lint(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Solve line too long offense and separate variables from expectations.
2023-05-19 19:55:27 -03:00
paulo-felipe
105d695f18
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
add unit test to check creation of standing line items when click create subscription without changing shipping address.
2023-05-19 19:55:27 -03:00
paulo-felipe
4df550fcf1
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
add unit test to check basic Subscription properties when click create subscription without changing shipping address.
2023-05-19 19:55:27 -03:00
paulo-felipe
49ceec8b8e
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
share common before action Create subscription between samples.
2023-05-19 19:55:27 -03:00
paulo-felipe
03aade4072
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when click Create Subscription button on third page after click next button previously on second page.
It has selector for price, input for quantity and selector for total price.
2023-05-19 19:55:27 -03:00
paulo-felipe
f0da85d723
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when click Create Subscription button on third page after click next button previously on second page.
2023-05-19 19:55:27 -03:00
paulo-felipe
8c709e13e0
lint(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Solve line too lng offense.
2023-05-19 19:55:27 -03:00
paulo-felipe
c63a8d12f7
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product AND adding a new product and click next button.
2023-05-19 19:55:26 -03:00
paulo-felipe
5a5aa4c067
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product AND adding a new product.
2023-05-19 19:55:26 -03:00
paulo-felipe
5776bdb31c
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product AND deleting the existing product.
2023-05-19 19:55:26 -03:00
paulo-felipe
b0623ab4de
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and adding a product.
2023-05-19 19:55:26 -03:00
paulo-felipe
f05e2618be
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page and click next button without adding at least one product.
2023-05-19 19:55:26 -03:00
paulo-felipe
35ce463811
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on third page.
2023-05-19 19:55:26 -03:00
paulo-felipe
7efc68281e
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when using copy button to fill in ship address.
2023-05-19 19:55:26 -03:00
paulo-felipe
aa16110e9a
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when resetting the billing address after clearing the bill address. MOve scenario to its before do block.
2023-05-19 19:55:26 -03:00
paulo-felipe
39a76861f3
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when resetting the billing address after clearing the bill address.
2023-05-19 19:55:26 -03:00
paulo-felipe
79ff13e8ba
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Move on second page to a before action and clearing some elements of bill address to a before action. Let the unit test with the action isolated.
2023-05-19 19:55:26 -03:00
paulo-felipe
573ab1beb0
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context on second page when clearing some elements of the bill address.
2023-05-19 19:55:26 -03:00
paulo-felipe
384ad1ba12
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Group context for first page scenarios. Extract common customer actions to its before do block.
2023-05-19 19:55:26 -03:00
paulo-felipe
77857a0168
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Add context when date field is filled. It goes to the next page with preloaded data.
2023-05-19 19:55:26 -03:00
paulo-felipe
47b0d626e2
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Isolate when no field is filled on first screen describe it better as per reviewer suggestion.
2023-05-19 19:55:26 -03:00
paulo-felipe
0bf7e53ce4
refactor(spec/system/admin/subscriptions_spec.rb): issue #7483
...
Isolate when no field is filled on first screen.
2023-05-19 19:55:26 -03:00
Konrad
fed7c3da51
Merge pull request #10761 from rioug/vouchers-any-amount
...
[Vouchers] Flat rate of any amount
2023-05-19 17:39:33 +02:00
Matt-Yorkley
a8559e621f
Simplify exchange variant callback and prefer delete over destroy
...
Delete is faster than destroy but should only be used if the object has no callbacks or touches.
2023-05-19 11:26:33 +01:00
Matt-Yorkley
434c9ae110
Delete exchange variants in bulk when deleting an order cycle
2023-05-19 10:46:55 +01:00
David Cook
9d7316c553
Use a fixed value for voucher factory
2023-05-19 17:19:54 +10:00
Maikel Linke
37441be371
Update translations
2023-05-19 14:33:23 +10:00
Maikel
0d403f4087
Merge pull request #10814 from Matt-Yorkley/serializer-eager-loading
...
Improve eager-loading on admin products page
2023-05-19 14:31:25 +10:00
Maikel
f943b411c5
Merge pull request #10823 from abdellani/fix-file-name-used-as-parameter
...
[Security] Validate product import file path
2023-05-19 14:28:09 +10:00
Maikel
7af14e37fa
Merge pull request #10488 from mkllnk/dfc-connector
...
Serialize DFC catalog items with DFC Connector
2023-05-19 11:31:23 +10:00
filipefurtad0
8d2885e147
Updates spec after merging #10512
2023-05-18 16:04:30 +01:00
filipefurtad0
51b144f174
Covers editing into invalid combinations
2023-05-18 15:59:48 +01:00
filipefurtad0
4e2095f0fb
Tests enterprise fee creation
...
...when inheriting tax category from product
as shared examples
2023-05-18 15:59:48 +01:00
Filipe
3d1b0816ed
Merge pull request #10512 from abdellani/fix-tax-not-charged-when-tax-category-set-to-inherit-from-product
...
Prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-18 13:43:14 +01:00
Konrad
39bb1f6f41
Merge pull request #10832 from Matt-Yorkley/cloning
...
Clone all ExchangeVariant objects in bulk
2023-05-18 14:32:30 +02:00
filipefurtad0
c99829e457
Updates spec to reflect change on en.yml
2023-05-18 12:11:37 +01:00
filipefurtad0
7ea3834900
Updates warning_forfeit_remaining_amount default message
2023-05-18 11:57:15 +01:00
David Cook
360a241402
Style fix
2023-05-18 10:07:52 +10:00
Filipe
0d23b63bbd
Merge pull request #10779 from dacook/10634-remove-admin_style_v2
...
10634 Remove admin_style_v2 feature
2023-05-17 15:37:05 +01:00
Konrad
19caadb1a0
Merge pull request #10800 from dacook/remove-localisation
...
Also remove localized number logic from weight calculator
2023-05-17 14:57:26 +02:00
David Cook
c0c123a92a
Remove localized number logic from weight calculator
...
Follow-on from a46eef291c
2023-05-17 14:10:58 +02:00
Konrad
f26bef5f98
Merge pull request #10813 from saunmanoj888/fix-fullname-search-issue-on-bulk-orders
...
Fix searching issue with full name on bulk order management
2023-05-17 13:58:04 +02:00
saunmanoj888
aee7645e29
Fix searching issue with full name on bulk order management
2023-05-17 13:14:10 +02:00
Konrad
02873d7596
Merge pull request #10817 from Matt-Yorkley/permissions-scoping
...
Scope orders before bulk actions
2023-05-17 12:44:07 +02:00
Matt-Yorkley
e1b0a03819
Scope orders before bulk actions
2023-05-17 12:03:40 +02:00
Jean-Baptiste Bellet
2336981ca0
Do not display OFN banner on order confirmation email if white label
2023-05-17 11:35:18 +02:00
Jean-Baptiste Bellet
dfafbfe996
Create an order confirmation email preview of the last completed order
...
Available on `/rails/mailers/order_mailer/confirm_email_for_customer`
2023-05-17 11:35:06 +02:00
Jean-Baptiste Bellet
f7d06fe0e8
Do not display OFN banner on subscription confirmation email if white label
...
+ add specs that test for the presence of the footer logo which is in the header (I know it's a bit contradictory)
2023-05-17 11:34:35 +02:00
Jean-Baptiste Bellet
3ed89fc2db
Create a subscription confirmation email preview of the last completed order
...
Available on: `/rails/mailers/subscription_mailer/confirmation_email`
2023-05-17 11:34:16 +02:00
Maikel Linke
eaf3bd0bae
Update spec after new import file validation
2023-05-17 15:18:29 +10:00
Mohamed ABDELLANI
fcb8550cb1
extract file path sanitizer to an independent class
2023-05-17 15:09:48 +10:00
Mohamed ABDELLANI
4d5ba6a7e6
add file path validation
2023-05-17 15:09:48 +10:00
Maikel Linke
a0d05b26d1
Spec current product import vulnerabilities
...
I didn't use pending specs but deliberately passing specs on wrong
behaviour. This is not how it should be but how it is at the moment.
2023-05-17 15:09:01 +10:00
Konrad
4a66b62fa7
Merge pull request #10825 from jibees/10824-remove-feature-toggle-on-white-label-feature
...
Activate white label feature
2023-05-16 13:50:58 +02:00
Maikel
16329e953f
Merge pull request #10844 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.0
...
Bump jasmine-core from 4.6.0 to 5.0.0
2023-05-16 17:50:39 +10:00
Gaetan Craig-Riou
abf2105df7
Admin::VoucherController check enterprise permission
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
355af9e818
Per review comment, build enterprise instead of create
...
Speed up testing by removing unnecessarily created record
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
b585f77be4
Make enterprise mandatory for a voucher
...
It should have already been the case...
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
2d8fa24862
Add a voucher factory
...
As vouchers are getting more complicated, it makes sense to use a
factory to simplify writing test.
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
b427e420ce
Update admin pages to allow entering an amount
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
15eee8175e
Add amount to voucher
...
Change value to amount to be more consistent
2023-05-16 16:19:59 +10:00
Maikel
10c918be75
Merge pull request #10732 from mkllnk/report-email
...
[Hidden] Notify about completed report with download link via email
2023-05-16 10:25:23 +10:00
Maikel
a979f7c8df
Merge pull request #10587 from rioug/10432-vouchers-bare-minimum-checkout
...
10432 vouchers bare minimum checkout
2023-05-16 09:19:06 +10:00
Maikel Linke
08aff56e20
Expire report files after 1 week, maximum for S3
...
We didn't see this in tests which use disk storage. But AWS S3 has a
maximum of one week for URL expiry.
2023-05-15 19:41:45 +02:00
Maikel Linke
5ae04a5a3e
Hide report link which only works at unknown time
...
It was bad UX to show a link that doesn't work straight away. At the
time, it was the only way to download the report but now we send an
email which is a much better way to go.
I leave the rest of the code because we want to implement a reflex which
shows the download link once it's ready.
2023-05-15 19:41:45 +02:00
Maikel Linke
299bc253a4
Expire report download links in a month, not 5mins
2023-05-15 19:41:45 +02:00
Maikel Linke
8a8c53ceee
Add ReportMailer preview for devs
2023-05-15 19:41:45 +02:00
Maikel Linke
860fe85af9
Add report download link to email notification
...
I added a system spec to verify that the download link can be generated
within the mailer in a background job. ActiveStorage is a bit particular
when it comes to genererating URLs and depending on the situation it may
generate a redirect URL, a proxy URL or link directly to the storage.
But we want a redirect URL here.
2023-05-15 19:41:45 +02:00
Maikel Linke
cf5a8a26ce
Notify only about slow reports
...
It would be annoying to get an email for reports which display on the
screen immediately.
2023-05-15 19:41:45 +02:00
Maikel Linke
1f4af7f990
Send (dummy) email when background report is done
...
I'll fill it out in future commits.
2023-05-15 19:41:45 +02:00
Jean-Baptiste Bellet
aaa9bac4dd
Remove white_label feature toggle
...
White label is now activated for everyone.
+ add mock for `spec/controllers/spree/orders_controller_spec.rb`
2023-05-15 17:10:50 +02:00
jibees
d43678c68b
Merge pull request #10827 from filipefurtad0/logging_out_spec
...
Adds test case for logging out
2023-05-15 15:33:56 +02:00
Jean-Baptiste Bellet
ec0cbc5bf9
Avoid warning by being more precise about *.erb files
2023-05-15 15:29:28 +02:00
jibees
a1e4c45daa
Merge pull request #10843 from openfoodfoundation/dependabot/bundler/rubocop-1.51.0
...
Bump rubocop from 1.50.2 to 1.51.0
2023-05-15 15:03:24 +02:00
jibees
edeedc0704
Merge pull request #10841 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.8
...
Bump @floating-ui/dom from 1.2.7 to 1.2.8
2023-05-15 15:02:22 +02:00
jibees
d2539b34e0
Merge pull request #10840 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.7
...
Bump rails-i18n from 7.0.6 to 7.0.7
2023-05-15 15:01:12 +02:00
jibees
fea3957481
Merge pull request #10845 from openfoodfoundation/dependabot/bundler/test-unit-3.5.8
...
Bump test-unit from 3.5.7 to 3.5.8
2023-05-15 15:00:03 +02:00
jibees
b183832fbb
Merge pull request #10842 from openfoodfoundation/dependabot/bundler/capybara-3.39.1
...
Bump capybara from 3.39.0 to 3.39.1
2023-05-15 12:22:59 +02:00
dependabot[bot]
8a352132a0
Bump test-unit from 3.5.7 to 3.5.8
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.7 to 3.5.8.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.7...3.5.8 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:55 +00:00
dependabot[bot]
0e59a5db91
Bump jasmine-core from 4.6.0 to 5.0.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 4.6.0 to 5.0.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v4.6.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:22 +00:00
dependabot[bot]
340fe91e07
Bump rubocop from 1.50.2 to 1.51.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.2 to 1.51.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.2...v1.51.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:15 +00:00
dependabot[bot]
6c126cfc33
Bump capybara from 3.39.0 to 3.39.1
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.0 to 3.39.1.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.0...3.39.1 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:59:19 +00:00
dependabot[bot]
82c6eaab4e
Bump @floating-ui/dom from 1.2.7 to 1.2.8
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.7 to 1.2.8.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.8/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:51 +00:00
dependabot[bot]
d4918893a7
Bump rails-i18n from 7.0.6 to 7.0.7
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.6 to 7.0.7.
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:24 +00:00
jibees
1e05bc5b5c
Merge pull request #10789 from jibees/10770-bom-cancelling-an-order-always-restocks-the-line-item
...
BOM: when deleting the last item of order that leads to order cancellation, take into account the restock items checkbox
2023-05-15 09:50:13 +02:00
Mohamed ABDELLANI
7f52684488
add check_calculators_compatibility_with_taxes before running enterprise bulk update
2023-05-15 07:35:52 +01:00
Gaetan Craig-Riou
5eb6097101
Fix error handling when creating a voucher adjustment
...
I wrongly assumed that `voucher.create_adjustment` would return nil
if failing to create an adjustment. I will in fact return an
adjustment object with errors.
2023-05-15 13:42:40 +10:00
David Cook
ccff3379ea
Update schema.rb
...
On a freshly mirrored prod db, I found these changes.
I don't know why.. but hopefully this is correct.
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
d29119f5c5
Remove non need belongs_to associations from Adjustments
...
It turns out the "tax_rate" association isn't used and wasn't working.
Same for the "voucher" one, which I added to be consistent with existing
code.
Both of these weren't caught by the specs because you can't test associations
with a custome relation with 'shouda-matchers' see: https://github.com/thoughtbot/shoulda-matchers/issues/981
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b67f5ae154
Fixing Rubocop issue
...
My editor automatically remove blank character on empty line, that's
why rubocop got grumpy here.
2023-05-15 13:42:40 +10:00
Matt-Yorkley
9b1725d39f
Fix model name in adjustment association
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b80274f49d
Per review comment, Use named value on voucher submit button to distinguish between submission types
...
The voucher apply button is inside form that has another a submit button,
it leads to a weird situation where either one will submit the whole
payments page form. Adding a named parameter on the voucher apply button
means we can distinguish between the two by checking for the presence
of params[:apply_voucher].
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
92bcd937dc
Per review comment, remove form object from the partial
...
This partial is rendered inside another <form> element, nested form
don't work.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
0a249d7722
Fix ButtonEnableToggleController to remove hacky button disable
...
As per review comment, use data-disable-with="false" do prevent Rails
from automatically enabling the "Apply" button. We can then remove
the timeout hack.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
236f6926d9
Cleaning up left over TODOs
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
aa526a639c
Checkout payment page, enable voucher "apply" button when code entered
...
The "apply" button is disabled by default. If left enabled, a customer
could try to apply an empty voucher, which results in system trying
to move to the order summary step, an unexpected behaviour!
We only enable the button when something is entered in the input.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
e5f14177d3
Fix rubocop warning
...
I guess the new cops are effective :)
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
815dcbcefe
Fix translations
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
a2e1e6ca33
Review comment, use dig to access voucher_code param
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
2f1fe6d096
Fix rubocop warning
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
17e32a89f8
Add VoucherAdjustmentsService to handle calculation
...
Refactor Voucher to move voucher adjustments calculation
to VoucherAdjustmentsService
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
56e981d300
Refactor Voucher to get rid of CalculatedAdjustments
...
Voucher adjustment have complicated calculation that prevent us from
using Spree::Calculator, and we need to override CalculatedAdjustments
method, so no point using it.
We still keep the same methods to stay as consitent as possible in
regards to adjustments
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
3f37554ff9
Add VoucherAdjustmentsController and specs
...
Refactor split checkout to use the new controller. But unfortunately
we can't have nested form, so adding a voucher is still handled by
SplitCheckoutController.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
43ab881181
Rename order association to voucher_adjustments
...
The name vouchers is a bit confusing as the order is linked to a
voucher adjutment and not the actual voucher
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
fe9b94a80e
Fix cart disappearing bug after adding a voucher
...
The split checkout page uses `mrujs` and `CableCar` to set the form as
a remote one and perform `CableCar` operation if any : https://mrujs.com/how-tos/integrate-cablecar
The previous solution broke the cart handled by angularJS, it looks like
`morpdom` (https://mrujs.com/references/remote-forms-and-links Navigation Adapter section )
was doing something that angularJS didn't like when redirecting to
the current page.
With the power of `CableCar`, we now replace the #voucher-section on the
split checkout page instead of doing a redirect.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
94294fa161
Voucher adjustment, add ordering by created_at
...
It gives us a consistent result when calling #vouchers
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
a1ad25f217
Fix failing specs
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
bb9d835bd8
Fix rubocop warning
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
87cc525d27
Refactor #vouchers
...
Use "has_many" instead of a method
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
4b5d6d7eac
Fix voucher adjustments association
...
Add missing, "inverse_of" and "dependent" options. Use :nullify as
for "dependent" because we would want to keep the adjustments on order
even if the voucher is deleted.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
58469adfeb
Adjustments spec, add association test
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
5064bf5383
Allow voucher adjustment to be created with an amount of 0
...
Although unlikely, we should still be able to create a voucher amount
with. This can happen if the order.total is for instance.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
9789911523
Rework how voucher are applied to an order and handle tax calculation
...
At the time when we can apply a voucher to an order (payment step) we
don't have any data on possible taxes and payment fees. These are
calculated when we move to the summary step. So voucher are applied in
two step:
- create an "open" voucher adjustment on the order when a customer enters
a voucher code.
- when we move to the summary step, recalulate the amount and
possible tax for the voucher adjustment, once taxes and payment fees
have been included in the order. And then close the original and update
order to reflect the changes
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
d157d91054
When voucher cover more than order total, use only amount needed
...
The checkout payment step will also show a warning.
The amount used is stored in the adjustment created, so we will be able
to track how much has been used down the line.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
3f609d3842
Add error message if adding a voucher fails
...
It's not really useful to the user but better than failing silently
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
596c775af6
Add controller spec to cover voucher in split checkout
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74e0b0f6b5
Add voucher adjustment loading to CheckoutCallbacks
...
This is needed so the voucher is loaded properly when the "checkout"
partials are render via cable_car.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74a8730f04
Highlight voucher on order summary step
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
856386fcb0
SplitCheckoutController refactor add_voucher
...
Now all redirection/render_error happen in #update, it makes it
easier to understand.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
e487ed0532
Add link to remove voucher when a voucher has been applied
...
Improve styling to match the design
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
b6213b25e9
add acts_as_paranoid to voucher
...
This is so the relation
`belongs_to :originator, -> { with_deleted }, polymorphic: true`
setup in Spree::Adjustement works as expected.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
a9d9b33f7d
First take at adding a voucher to an order
...
Use voucher.create_adjustment to add an adjustment to the order
Currently doesn't take into account tax part
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
3ec58d8791
Add #vouchers, return an array of voucher adjustments
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
9b680e1a92
Add CalculatedAdjustments to Voucher
...
Vouchers are only flat rate of 10 for now, so we add a FlatRate
calculator in a before_validation callback
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
f7ee01b9f8
Add voucher input on checkout payment's step
...
Voucher input is displayed only if the distributor has any voucher
2023-05-15 13:42:37 +10:00
Maikel
4f7059d0c7
Merge pull request #10838 from filipefurtad0/fix_negative_adjustment_error
...
Adds minus sign to validation criteria
2023-05-15 11:07:45 +10:00
Gaetan Craig-Riou
d715b6b3bb
Spec fix LocalisedNumber validation to allow negative number
...
As part of this PR https://github.com/openfoodfoundation/openfoodnetwork/pull/10329
LocalisedNumber validation was tightened, but that means negative number
were not valid anymore.
This commit has been cherry-picked after this fix has already been
applied. Now we just change the order of characters in the regex because
humans are used to reading the minus at the beginning of the number. But
this change doesn't change the logic at all.
2023-05-15 10:55:59 +10:00
Maikel
5045e26792
Merge pull request #10834 from mkllnk/variant-spec
...
Improve readability and performance of variant spec
2023-05-15 09:48:06 +10:00
filipefurtad0
0442f2da7e
Fixes spec warning
...
An example was being ignored due to legacy syntax - WARNING: ignoring the provided expectation message argument since it is not a string or a proc.
2023-05-14 23:02:44 +01:00
filipefurtad0
e7ab839fb3
Adds minus sign as validation criteria
...
Removes pending from passing examples
2023-05-14 23:02:44 +01:00
filipefurtad0
596b318778
Adds spec on negative adjustment
...
with different localization settings
Using shared examples and setting failing
ones as pending
2023-05-14 23:02:00 +01:00
Filipe
3c7337b53a
Merge pull request #10836 from jibees/10835-on-small-width-screen-the-cart-element-is-missplaced
...
Fix bad indentation (and hierarchy) of DOM elements causing bad rendering on small width screens
2023-05-12 11:24:49 +01:00
Jean-Baptiste Bellet
60edb4363e
Fix bad indentation (and hierarchy)
...
`%section` must be siblings each others
introduced by https://github.com/openfoodfoundation/openfoodnetwork/pull/10772
2023-05-12 09:30:37 +02:00
Maikel Linke
6596225a99
Fix typo in VCR cassette name
2023-05-12 14:48:00 +10:00
Maikel Linke
87c4c5373b
Spec more variant naming with realistic data
2023-05-12 14:10:54 +10:00
Maikel Linke
f70607259a
Spec Variant#product_and_full_name with real data
...
Mocking skips a lot of code execution which we want to test as well.
2023-05-12 13:34:34 +10:00
Maikel Linke
ce180caad9
Test with in-memory data when possible
...
This should speed up specs but I observed only one second less run time.
2023-05-12 13:21:58 +10:00
Maikel Linke
01be934caf
Reduce spec run time by not creating unused subject
...
The `variant` instance isn't used in all specs and doesn't need to be
created every time. This reduced run time from 1min5sec to 43sec on my
machine.
2023-05-12 13:21:58 +10:00
Maikel Linke
54c6559b97
Move Spree::Variant spec out of Spree module
...
I also discovered that some specs were just in the Spee module and not
within the `describe Variant` block. I moved them inside the block.
2023-05-12 13:21:19 +10:00
Maikel
93c0a06403
Merge pull request #10829 from filipefurtad0/flaky_order_spec_error
...
Splits assertions to allow JS table populate
2023-05-12 11:49:06 +10:00
Maikel Linke
636b365304
Tell Rubocop and devs about bulk insert
2023-05-12 10:30:47 +10:00
Jean-Baptiste Bellet
51d6fb81dd
Fwd to request the restock_items input value when adjusting items qty
2023-05-11 22:58:44 +02:00
Jean-Baptiste Bellet
f679d8733e
Pass the restock_items params to each methods and request call
...
+ update spec to test whether the restock item checkbox is checked or not.
2023-05-11 22:58:44 +02:00
Matt-Yorkley
b139087c5f
Clone ExchangeVariant objects in bulk
...
An ExchangeVariant is a simple representation of a join table between Exchange and Variant. Previously this code was triggering an additional INSERT query for every variant added to the newly cloned exchange. Some exchanges have ~3000 variants! The code now creates them in bulk in a single INSERT statement. When cloning large order cycles this can improve performance by ~1000% or so.
2023-05-11 20:51:20 +01:00
Filipe
1bdb668cd3
Merge pull request #10769 from Matt-Yorkley/visible-line-items-query
...
Improve `Permissions::Order#visible_line_items` querying
2023-05-11 15:36:32 +01:00
filipefurtad0
d035d4bb87
Update all locales with the latest Transifex translations
2023-05-11 15:25:39 +01:00
Mohamed ABDELLANI
6771d2e7be
test enterprise fees creation with tax category inheritance flag
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
a22fe9f948
fix existing invalid enterprise fees
2023-05-11 12:46:17 +01:00
Maikel Linke
25b7f1749c
Simplify error when tax rate can't be inherited
...
I changed the text to focus on the resolution: the user needs to choose
a tax category or a different calculator.
I associated the error to the model to prevent the attribute name from
being included in the error message. Alternatively, we could have
changed the name of the attribute to match the UI. But this error
affects the combination of two attributes, none of them is invalid on
its own.
I'm using Rails' default lazy lookup for error messages which results in
shorter code and a standard structure.
I also added a simple spec.
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
89eb3a1967
fix existing tests
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
7eca32e84f
prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-11 12:46:17 +01:00
filipefurtad0
f5eb72c804
Adds sleep(1)
2023-05-11 11:29:24 +01:00
Konrad
2836751698
Merge pull request #10805 from jibees/10717-bo-orders-changing-customer-does-not-update-customer_id
...
Admin, Edit customer details for an order: when changing to another customer, update `customer_id` as well
2023-05-10 19:08:57 +02:00
Filipe
bf7a559a32
Merge pull request #10772 from Matt-Yorkley/view-caching
...
Locale-aware Fragment Caching
2023-05-10 11:18:08 +01:00
filipefurtad0
82f307ae61
Adds test case for logging out
2023-05-10 10:41:43 +01:00
Matt-Yorkley
d90653c682
Merge pull request #10793 from jibees/fix-webpack-configuration-use-the-default-one
...
Use the default webpack configuration for dev env
2023-05-10 10:09:28 +01:00
jibees
ca5300284c
Merge pull request #10820 from Matt-Yorkley/js-dependencies
...
Remove indirect JS dependencies
2023-05-10 09:57:05 +02:00
Matt-Yorkley
406cb572ea
Remove indirect JS dependencies
2023-05-10 09:27:00 +02:00
jibees
ca90b5cee2
Merge pull request #10810 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.122.0
...
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
2023-05-10 09:23:44 +02:00
jibees
760860a06d
Merge pull request #10811 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.11.0
...
Bump knapsack_pro from 3.10.0 to 3.11.0
2023-05-10 09:21:46 +02:00
jibees
189207f751
Merge pull request #10822 from openfoodfoundation/dependabot/bundler/debug-1.8.0
...
Bump debug from 1.7.2 to 1.8.0
2023-05-10 09:20:34 +02:00
Matt-Yorkley
1bd9182cea
Update menu cache blocks
2023-05-09 16:46:09 +01:00
David Cook
04a5c7452e
Remove admin_style_v2 description
...
Partially reverts 9a1b1498bf
2023-05-09 21:26:47 +10:00
David Cook
e29df5ea8f
Remove unused secondary class
...
This partially reverts 97c3aaebb2 because it referred to the new feature toggle which has been removed.
2023-05-09 21:26:47 +10:00
David Cook
3ec659d82b
Revert pull #10025
...
[WIP 🚧 ] Admin, behind feature toggle admin_style_v2: adjust some colors
This reverts commits 60f0a58508ce77666fa96c73d76dc0620f23daaf~1..09bcc772ff089f911a56bb
2023-05-09 21:26:47 +10:00
David Cook
be70cd7893
Revert pull #10054
...
[WIP 🚧 ] Admin/Orders, behind feature toggle admin_style_v2: adjust colors
This reverts commits 5cab0f7f3d495daaeb97fd786208a24355b630fe..4ef5609b0eb08fe7e48803de166ae3e979103c1b
2023-05-09 21:26:47 +10:00
David Cook
0ff540e1e3
Revert pull #10080
...
[WIP 🚧 ] Admin - Order edition, behind feature toggle admin_style_v2: adjust colors
This reverts commits faf106b2824f248812f523c10b688bd9b254dc14..74b618230ff736ac7929246e2c83ed95067a4dd0
2023-05-09 21:25:29 +10:00
David Cook
c21ff075de
Revert pull #10131
...
[WIP 🚧 ] /admin/order_cycles behind feature toggle admin_style_v2
This reverts commits ccfc632149f062fca546784c7c2f14708d91a08e~1..e403a2c174def34cfa115eab038c86923482bfbf
2023-05-09 21:24:25 +10:00
dependabot[bot]
969d0b6687
Bump debug from 1.7.2 to 1.8.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-09 10:03:20 +00:00
Maikel Linke
3c6f55732d
Add dummy product type to DFC export
2023-05-09 17:01:00 +10:00
Maikel Linke
b2e8af0cd1
Add stock to DFC Offer as well
2023-05-09 16:51:26 +10:00
Maikel Linke
c81230d334
Add old DFC API name for prototype compatibility
2023-05-09 16:51:26 +10:00
Maikel Linke
54137067dd
Export variant's display_name if present
...
The `#name` method is simply delegated to a variant's product.
2023-05-09 16:51:26 +10:00
Maikel Linke
0c5ab783ca
Update DFC API route to reflect Connector version
2023-05-09 16:51:26 +10:00
Maikel Linke
80edc44ef5
Replace SuppliedProductSerializer with DFC Connector
...
And remove the BaseSerializer because this was the last serializer.
2023-05-09 16:51:26 +10:00
Maikel Linke
0b808a4b1e
Add product quantity to DFC export
2023-05-09 16:51:26 +10:00
Maikel Linke
1e23cf1c92
Replace EnterpriseSerializer with DFC Connector
...
And move same test coverage to a new builder spec.
2023-05-09 16:51:26 +10:00
Maikel Linke
683ad0f5b9
Replace PersonSerializer with DFC Connector
...
And the address serializer was just an empty placeholder.
2023-05-09 16:51:26 +10:00
Maikel Linke
c60d622818
List catalog items with DFC Connector
2023-05-09 16:51:25 +10:00
Maikel Linke
7f8ce08d4e
Include DFC Offer in the export with valid id
2023-05-09 16:51:25 +10:00
Maikel Linke
78cf3b5a1d
Serialize DFC catalog item with DFC Connector
...
This is work in progress. The DFC Connector uses a more recent DFC
version and other endpoints still use the old serializers. We need to
update those endpoints as well and update the version number in the API
URL.
2023-05-09 16:51:25 +10:00
Maikel Linke
5187201796
Add DFC vocabularies
...
- Add a script for downloading updated files.
- Add a service for easier loading of vocab files.
2023-05-09 16:51:25 +10:00
Maikel Linke
352c350840
Add gem datafoodconsortium-connector
...
We hope that replacing our own JSON generation with this gem will reduce
maintenance. Same for parsing DFC input.
2023-05-09 16:51:25 +10:00
David Cook
8fe20ecfbe
Merge pull request #10794 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.8
...
Bump @babel/core from 7.21.5 to 7.21.8
2023-05-09 16:37:42 +10:00
Maikel
83141ec05c
Merge pull request #10818 from mkllnk/schema-order
...
Fixup order of statements in db schema
2023-05-09 14:21:03 +10:00
Matt-Yorkley
4b707b9310
Extract locale file digest logic to a separate class and add tests
2023-05-08 14:09:00 +01:00
Matt-Yorkley
1c277e5547
Cache some html fragments
2023-05-08 14:07:50 +01:00
Matt-Yorkley
be48a6c295
Implement cache_with_locale helper for fragment caching with locales
2023-05-08 14:07:50 +01:00
Matt-Yorkley
11f45dc2f8
Give ContentConfig an updated_at attribute and a usable cache_key
2023-05-08 14:07:50 +01:00
Konrad
4303cabe56
Merge pull request #10792 from mkllnk/feature-deletion
...
Remove unknown (deleted) feature toggles at boot
2023-05-08 14:49:42 +02:00
Maikel Linke
f1f3ecc4f7
Fixup order of statements in db schema
...
It looks like the resolution of a merge conflict introduced the wrong
ordering of schema statements. Rails wants to sort tables alphabetically
and running `./bin/rails db:migrate` on a fresh database altered the
schema.rb file. This should be fixed here.
Rails also omits the default setting of `precision: 6` since Rails 7.
The vouchers feature was developed during the upgrade to Rails 7.
2023-05-08 14:37:33 +10:00
Maikel
ad033e8d44
Merge pull request #10767 from Matt-Yorkley/remove-session-cookie-upgrader
...
Remove SessionCookieUpgrader from middleware
2023-05-08 12:50:42 +10:00
Gaetan Craig-Riou
f25a3650bd
Merge pull request #10802 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.1
...
Bump ddtrace from 1.11.0 to 1.11.1
2023-05-08 11:45:07 +10:00
Konrad
e4d8dd9f87
Merge pull request #10780 from dacook/enable-prettier-css
...
Enable prettier for Admin SCSS
2023-05-06 18:24:58 +02:00
Matt-Yorkley
1995a44848
Improve eager-loading on admin products page adn resolve issue with serializer
...
For some reason eager-loaded data isn't passed to nested serializers when using associations. Defining the association as a method and passing in some optional paramaters resolves the issue.
This reduces queries run by the controller action by around 75%, as well as the response times.
2023-05-06 17:15:27 +01:00
dependabot[bot]
b29d38f3fb
Bump knapsack_pro from 3.10.0 to 3.11.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.10.0 to 3.11.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.10.0...v3.11.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 10:01:08 +00:00
dependabot[bot]
1c52fe1648
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.121.0 to 1.122.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 09:59:02 +00:00
David Cook
a170b93cc1
Simplify further
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-05 15:34:23 +10:00
Maikel Linke
2a943ecafb
Spec setting up all feature toggle names
2023-05-05 11:09:10 +10:00
Jean-Baptiste Bellet
3a1579104f
Submit customer_id as params when updating customer details on order
2023-05-04 16:40:58 +02:00
jibees
ec4c7b79bf
Merge pull request #10803 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.2
...
Bump rspec-rails from 6.0.1 to 6.0.2
2023-05-04 13:55:37 +02:00
dependabot[bot]
9f12295a89
Bump rspec-rails from 6.0.1 to 6.0.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:54 +00:00
dependabot[bot]
46fd6b1a3a
Bump ddtrace from 1.11.0 to 1.11.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:25 +00:00
Jean-Baptiste Bellet
8a5608435c
Update all locales with the latest Transifex translations
2023-05-03 17:30:48 +02:00
Konrad
d02d0b8847
Merge pull request #10763 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.0
...
Bump ddtrace from 1.10.1 to 1.11.0
2023-05-03 17:27:13 +02:00
Konrad
4b6ef7796e
Merge pull request #10762 from mkllnk/report-encoding
...
Preserve encoding of stored reports
2023-05-03 17:08:44 +02:00
Konrad
b60a6fbd05
Merge pull request #10329 from thejwuscript/9861-improve-input-validation
...
Improve input validation on new and edit Payment Method pages
2023-05-03 16:11:21 +02:00
jibees
2e267091f6
Merge pull request #10795 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.10.0
...
Bump knapsack_pro from 3.9.0 to 3.10.0
2023-05-03 14:31:11 +02:00
dependabot[bot]
eb3fe1b7a5
Bump knapsack_pro from 3.9.0 to 3.10.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.9.0...v3.10.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 10:06:11 +00:00
dependabot[bot]
61f34a23a7
Bump @babel/core from 7.21.5 to 7.21.8
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.5 to 7.21.8.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.8/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 09:57:57 +00:00
Jean-Baptiste Bellet
2d7356f2bb
Use the default webpack configuration for dev env
...
We used to override the output filename but this was a misunderstanding of an error (due to webpacke(r) incompatibles versions)
https://medium.com/@web_developer/hash-vs-chunkhash-vs-contenthash-e94d38a32208
https://github.com/webpack/webpack.js.org/issues/2096
Context: https://github.com/openfoodfoundation/openfoodnetwork/pull/10631#pullrequestreview-1410083331
2023-05-03 10:10:17 +02:00
jibees
62c2d9a290
Merge pull request #10782 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.0
...
Bump sidekiq from 7.0.9 to 7.1.0
2023-05-03 09:56:07 +02:00
jibees
a329aab007
Merge pull request #10774 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.5
...
Bump @babel/core and @babel/preset-env from 7.21.4 to 7.21.5
2023-05-03 09:26:10 +02:00
Maikel Linke
e24198fe85
Bump @babel/preset-env from 7.21.4 to 7.21.5
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-preset-env )
I did this manually:
```
$ yarn upgrade "@babel/preset-env"
yarn upgrade v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > stimulus_reflex@3.5.0-rc2" has unmet peer dependency "@hotwired/stimulus@>= 3.0".
[4/4] Rebuilding all packages...
success Saved lockfile.
success Saved 35 new dependencies.
info Direct dependencies
└─ @babel/preset-env@7.21 .5
info All dependencies
├─ @babel/code-frame@7.21 .4
├─ @babel/helper-builder-binary-assignment-operator-visitor@7.21 .5
├─ @babel/helper-function-name@7.21 .0
├─ @babel/helper-module-imports@7.21 .4
├─ @babel/helper-replace-supers@7.21 .5
├─ @babel/helper-string-parser@7.21 .5
├─ @babel/helper-wrap-function@7.20 .5
├─ @babel/highlight@7.18 .6
├─ @babel/parser@7.21 .5
├─ @babel/plugin-transform-arrow-functions@7.21 .5
├─ @babel/plugin-transform-computed-properties@7.21 .5
├─ @babel/plugin-transform-for-of@7.21 .5
├─ @babel/plugin-transform-modules-commonjs@7.21 .5
├─ @babel/plugin-transform-regenerator@7.21 .5
├─ @babel/plugin-transform-unicode-escapes@7.21 .5
├─ @babel/preset-env@7.21 .5
├─ @babel/regjsgen@0.8.0
├─ @babel/template@7.20 .7
├─ @babel/traverse@7.21 .5
├─ @jridgewell/resolve-uri@3.1.0
├─ color-convert@1.9.3
├─ escape-string-regexp@1.0.5
├─ is-core-module@2.12 .0
├─ js-tokens@4.0.0
├─ jsesc@2.5.2
├─ ms@2.1.2
├─ regenerate-unicode-properties@10.1.0
├─ regenerator-runtime@0.13.11
├─ regexpu-core@5.3.2
├─ regjsparser@0.9.1
├─ to-fast-properties@2.0.0
├─ unicode-canonical-property-names-ecmascript@2.0.0
├─ unicode-match-property-ecmascript@2.0.0
├─ unicode-match-property-value-ecmascript@2.1.0
└─ unicode-property-aliases-ecmascript@2.1.0
Done in 16.54s.
```
2023-05-03 15:33:57 +10:00
Maikel Linke
b30e962cdd
Remove unknown (deleted) feature toggles at boot
2023-05-03 15:20:26 +10:00
Maikel Linke
5f1f717974
Spec FeatureToggle.setup!
2023-05-03 15:02:08 +10:00
Maikel Linke
b6f2fe0e92
Avoid defining modules in specs
...
We avoid some indent and show how code outside of the module works.
2023-05-03 14:58:59 +10:00
dependabot[bot]
a9bf7a2498
Bump @babel/core from 7.21.4 to 7.21.5
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 12:18:41 +10:00
David Cook
e11518938f
Prettify admin components scss
...
Largely whitespace, but some other updates too, including uppercase colour codes and standardising numbers.
Best viewed with whitespace ignored.
2023-05-03 12:10:58 +10:00
David Cook
c4dc5e0718
Prettier: use double quotes by default
...
Unfortunately Prettier won't let you do one rule at a time (https://stackoverflow.com/q/63813336/421243 ), so I'll break it into file chunks.
2023-05-03 12:10:58 +10:00
David Cook
c67d61a376
Don't ignore admin scss for prettying
...
...and watch the changes flow in!
2023-05-03 12:09:22 +10:00
David Cook
0b4556e72b
Allow line length up to 100char
...
Same as we have for Ruby code: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/.rubocop_styleguide.yml#L78-L80
This will avoid unnecessary reformatting.
2023-05-03 12:09:22 +10:00
David Cook
8c7f92d42e
Explicitly ignore each css folder
...
With the goal to progressively un-ignore them.
2023-05-03 12:09:22 +10:00
Konrad
21a0017352
Merge pull request #10756 from jibees/10743-admin-add-unregistered-users-modal-some-html-is-rendered-as-plain-text-instead-of-being
...
Admin, Add unregistered user: Fix a reflex-morph issue that lead to a HTML escaping error
2023-05-02 19:28:48 +02:00
Konrad
d115c4ce2c
Merge pull request #10733 from jibees/9782-shops-list-overlapping-and-overflowing-texts-on-mobile2
...
Shops list: fix some overlapping and overflowing texts on mobile
2023-05-02 12:15:19 +02:00
dependabot[bot]
b05d46c3e3
Bump sidekiq from 7.0.9 to 7.1.0
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.9 to 7.1.0.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.9...v7.1.0 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-02 09:57:28 +00:00
jibees
aae0fc59fb
Merge pull request #10768 from Matt-Yorkley/query-logs
...
Improve query logging in development
2023-05-02 11:44:19 +02:00
Gaetan Craig-Riou
d1f7cc1b2a
Merge pull request #10764 from Matt-Yorkley/remove-data-hooks
...
Remove `data-hook` attributes
2023-05-02 16:35:46 +10:00
Gaetan Craig-Riou
964481f188
Merge pull request #10765 from Matt-Yorkley/update-webpack-packages
...
Update webpack packages
2023-05-02 15:19:37 +10:00
Maikel
9bca22ae3b
Merge pull request #10775 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.2
...
Bump mini_portile2 from 2.8.1 to 2.8.2
2023-05-02 11:54:37 +10:00
dependabot[bot]
064c843c90
Bump mini_portile2 from 2.8.1 to 2.8.2
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.1...v2.8.2 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-01 10:02:13 +00:00
Maikel
482d438ec9
Merge pull request #10766 from filipefurtad0/remove_asertion_on_js_element_loading_orders
...
Removes assertions on transient JS element - "Loading orders"
2023-05-01 13:36:44 +10:00
Maikel Linke
9f0a66659a
Delete now unused SessionCookieUpgrader
2023-05-01 13:35:52 +10:00
Konrad
1176ea2a5f
Merge pull request #9941 from basilawwad/conditionally-send-cancellation-email
...
Conditionally send cancellation email when cancelling order.
2023-04-28 21:54:42 +02:00
Matt-Yorkley
dfc651ed2c
Convert Permissions::Order#visible_line_items to a relation with or query
...
This change looks innocuous but the result of converting this into a nice relation instead of two queries stuck together with the pipe operator (|) can make a huge difference when chaining this into subqueries. The result set is ultimately the same, but the queries can be built without first returning all the ids and then sticking those ids in an array.
2023-04-28 19:13:22 +01:00
Matt-Yorkley
f42a9e3a66
Add query_count gem in development
...
A very simple gem that counts the total number of queries triggered by each request and displays a little number in the log. Nice.
2023-04-28 15:02:02 +01:00
Matt-Yorkley
8d9a8d8db5
Enable verbose query logs in development
...
This is a new feature in Rails 7. Whenever a query is triggered it not only show you the query (as before), but also tells you (directly in the logs) exactly which line of code was responsible for triggering the query. It's unbelievably useful for debugging and performance work.
2023-04-28 14:35:16 +01:00
Matt-Yorkley
84df1bfeab
Remove SessionCookieUpgrader from middleware
...
This was a transitional bit of code to allow us to rename our session cookies without killing active sessions and logging users out. It's done it's job, the transition is finished, and it isn't doing anything useful now. It can be removed from the middleware stack.
2023-04-28 14:01:15 +01:00
Matt-Yorkley
b9431cd121
Remove data-hook attributes
2023-04-28 13:03:13 +01:00
filipefurtad0
74d18fb6ff
Removes assertions on transient JS element
2023-04-28 12:48:59 +01:00
Matt-Yorkley
5e26e49764
Update webpack packages
...
`webpack-cli` is a dependency of `@rails/webpacker` but needs to be at version 3.x, we can just cut it from the explicit dependecy list and the correct version will be installed.
`webpack-dev-server` version 3.x corresponds (unhelpfully) to `webpacker` 4.x, and needs to be left that way. Dependabot tries to change it occasionally, but it should not be updated to 4.x
2023-04-28 12:48:21 +01:00
dependabot[bot]
c9dada4215
Bump ddtrace from 1.10.1 to 1.11.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.10.1 to 1.11.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.10.1...v1.11.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-28 10:00:28 +00:00
Maikel Linke
630169f8bb
Preserve encoding of stored reports
...
Active Storage reads stored strings as ASCII and that can clash with
Rails' default UTF-8 encoding when special characters are present.
2023-04-28 16:38:06 +10:00
Gaetan Craig-Riou
152af5e105
Merge pull request #10751 from mkllnk/mail-config
...
Remove unused feature to intercept emails
2023-04-28 16:28:41 +10:00
David Cook
918425fd93
Remove customised error message
...
We're now handling these values on the frontend, so can keep this simple.
fixes up:
Add numericality validation for *
Add translation for Active Record error message
2023-04-28 14:02:12 +10:00
David Cook
a46eef291c
Remove localized number logic from calculators
...
The browser is now responsible for dealing with the decimal separator, for all numeric preferences (as input[type=number]; see Spree::Admin::BaseHelper::preference_field_tag). Calculators are the only place that numeric preferences are used.
It will enforce that only one comma or dot (depending on user's locale) is entered, thus avoiding any ambiguity, and mis-interpretation (eg 100,001 could be interpreted as more than 100 thousand or 100 with a decimal place).
2023-04-28 13:54:16 +10:00
David Cook
d2fbb0bde2
Update translations
...
js: admin: orders: order_state: confirmation
2023-04-27 14:49:28 +10:00
David Cook
c42dfdde10
Merge pull request #10748 from openfoodfoundation/dependabot/bundler/view_component-3.0.0
...
Bump view_component from 2.82.0 to 3.0.0
2023-04-27 14:46:09 +10:00
Jean-Baptiste Bellet
959dcb82e1
Morph the form itself instead of morphing a parent DOM element
...
This seems to avoid HTML parsing error
2023-04-26 17:41:28 +02:00
jibees
51d5817665
Merge pull request #10755 from openfoodfoundation/dependabot/bundler/i18n-1.13.0
...
Bump i18n from 1.12.0 to 1.13.0
2023-04-26 15:45:59 +02:00
jibees
a8384b3155
Merge pull request #10754 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.7
...
Bump @floating-ui/dom from 1.2.6 to 1.2.7
2023-04-26 15:44:04 +02:00
Konrad
394bfd00d8
Merge pull request #10586 from jibees/10563-allow-custom-url-on-logo-click
...
White Label: can link an URL to the white label logo
2023-04-26 13:52:10 +02:00
dependabot[bot]
bda1a527d3
Bump i18n from 1.12.0 to 1.13.0
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.12.0...v1.13.0 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:48 +00:00
dependabot[bot]
77bd832dd6
Bump @floating-ui/dom from 1.2.6 to 1.2.7
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.7/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:09 +00:00
Jean-Baptiste Bellet
b1de28eeea
When there is a white_label_logo_link pref. use it!
...
+ update spec as well
+ use an an helper to get the main logo link for a shopfront
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
679fcc0114
When removing the logo, also delete white_label_logo_link preference
...
since it has no sense without the logo
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
35778ecf1d
If enterprise has a white_label_logo attached, then can edit its link
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
70a6e9f44b
Add a white_label_logo_link attribute to enterprise model
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
30ba29382a
Avoid name collision by renaming some classes with a prefix flex-
...
This classes should only be used with `.flex`
2023-04-26 09:52:24 +02:00
Jean-Baptiste Bellet
9584205a8e
Use .flex class in utilities.scss file
...
No need to have multiple definition as already included
2023-04-26 09:51:28 +02:00
Jean-Baptiste Bellet
3644dbc0fd
Small fix of a prettier formatter error
2023-04-26 09:51:17 +02:00
Jean-Baptiste Bellet
05a7276c9c
Create an utilities.scss file that contains some utility classes
...
Finally Tailwind is coming? ;)
2023-04-26 09:47:23 +02:00
David Cook
1fc60d498a
Merge pull request #10746 from openfoodfoundation/dependabot/bundler/rswag-specs-2.9.0
...
Bump rswag-specs from 2.8.0 to 2.9.0
2023-04-26 14:08:30 +10:00
Maikel Linke
dae8703b02
Remove unused feature to intercept emails
...
This option came from Spree and we never used it. The config input field
is disabled in the admin interface and I checked our managed databases.
I don't think that we will want this feature in the future either.
Staging sends unmodified emails which is more realistic and we haven't
had a use case to intercept those emails. There's still the BCC option
if we need additional access.
2023-04-26 13:50:31 +10:00
Maikel
3078c599f9
Merge pull request #10747 from openfoodfoundation/dependabot/bundler/rswag-ui-2.9.0
...
Bump rswag-ui from 2.8.0 to 2.9.0
2023-04-26 12:04:09 +10:00
dependabot[bot]
5d91ac217d
Bump rswag-specs from 2.8.0 to 2.9.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 02:03:53 +00:00
Maikel
f2edb6d404
Merge pull request #10745 from openfoodfoundation/dependabot/bundler/rswag-api-2.9.0
...
Bump rswag-api from 2.8.0 to 2.9.0
2023-04-26 12:02:38 +10:00
David Cook
7cd1b5d5db
Update link
...
The old project was closed in favour of a new one.
2023-04-26 09:44:58 +10:00
dependabot[bot]
ad82f66173
Bump rswag-api from 2.8.0 to 2.9.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 10:10:17 +00:00
dependabot[bot]
62bfa9e04c
Bump view_component from 2.82.0 to 3.0.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.82.0 to 3.0.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.82.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:51 +00:00
dependabot[bot]
28c9d72342
Bump rswag-ui from 2.8.0 to 2.9.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:22 +00:00
jibees
7317d6ca34
Merge pull request #10742 from filipefurtad0/fix_broken_build
...
Considers recent changes on login test helpers
2023-04-25 11:36:56 +02:00
filipefurtad0
edb8da4b4d
Considers recent changes on login test helpers
...
PR #10696 introduced changes on the login helpers which were not considered, when merging a recent PR; This broke the build
2023-04-24 18:35:10 +01:00
Konrad
00d5bd9165
Merge pull request #10684 from MadisonBowron/master
...
Fix admin product variants form to close issues #10579 & Wishlist: 430
2023-04-24 18:18:01 +02:00
Jean-Baptiste Bellet
1730c9eb60
Fix one warning: Modal window with text has been opened, ...
...
```
Modal window with text `An invoice for this order will be sent to the customer. Are you sure you want to continue?` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
```
2023-04-24 15:18:35 +02:00
Jean-Baptiste Bellet
5b9815f4a3
Test that restock has been called or not, depending on checkbox checked
2023-04-24 15:03:14 +02:00
jibees
445eb45ad7
Merge pull request #10737 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.8
...
Bump prettier from 2.8.7 to 2.8.8
2023-04-24 14:43:20 +02:00
jibees
8770471ada
Merge pull request #10738 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.4.2
...
Bump karma from 6.4.1 to 6.4.2
2023-04-24 14:43:07 +02:00
dependabot[bot]
6d45940ca4
Bump karma from 6.4.1 to 6.4.2
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.4.1 to 6.4.2.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.4.1...v6.4.2 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:22 +00:00
dependabot[bot]
69383ac621
Bump prettier from 2.8.7 to 2.8.8
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.7 to 2.8.8.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.7...2.8.8 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:05 +00:00
Maikel
945cb84127
Merge pull request #10683 from filipefurtad0/update-the-build-env-to-ubuntu-2204
...
Updates build environment to Ubuntu 22.04
2023-04-24 15:27:05 +10:00
Maikel
343a2db1bf
Merge pull request #10722 from mkllnk/rubocop-autocorrect-script
...
Add script for bulk autocorrect with Rubocop
2023-04-24 10:58:43 +10:00
Maikel Linke
de8f5e13b3
Explain gotcha in case it breaks one day
2023-04-24 09:39:21 +10:00
Konrad
75b5d1fd6f
Merge pull request #10712 from jibees/6133-backoffice-orders-endless-spinner-and-error-500-after-skipping-oc-selector
...
Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step)
2023-04-22 16:04:15 +02:00
Konrad
0c1606e50c
Merge pull request #10728 from jibees/10718-missing-translation-confirmation-order-state
...
Admin, `/orders`: adds translation for order in `confirmation` state
2023-04-22 11:56:23 +02:00
jibees
fa05554f15
Merge pull request #10734 from openfoodfoundation/dependabot/npm_and_yarn/karma-chrome-launcher-3.2.0
...
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
2023-04-21 14:13:19 +02:00
Jean-Baptiste Bellet
2cc509de15
Do not check Metrics/BlockLength for shared_examples_for block
...
They can contains a lot of `it` tests
2023-04-21 11:59:24 +02:00
dependabot[bot]
41afad73e4
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
...
Bumps [karma-chrome-launcher](https://github.com/karma-runner/karma-chrome-launcher ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/karma-runner/karma-chrome-launcher/releases )
- [Changelog](https://github.com/karma-runner/karma-chrome-launcher/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma-chrome-launcher/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: karma-chrome-launcher
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-21 09:57:29 +00:00
Jean-Baptiste Bellet
b17b25516f
Use a UTF-8 character
2023-04-21 10:37:20 +02:00
Jean-Baptiste Bellet
8444fca19a
Fix syntax error
2023-04-21 10:36:47 +02:00
Jean-Baptiste Bellet
18d90114fe
Be more responsive: use flex, ellipsis, less columns
2023-04-21 10:36:21 +02:00
Gaetan Craig-Riou
2f17a02974
Merge pull request #10726 from mkllnk/spec-email-helper
...
Remove useless email test setup
2023-04-21 15:43:19 +10:00
Gaetan Craig-Riou
135bc7e2f8
Removing env variable $runs_on
...
Seting "env" under "jobs" doesn't work it gets picked up as a job. I moved
runs_on to the top level env. but I couldn't fine a way to get it to work.
I tried all syntax I could think of: $runs_on, ${{ runs_on }} env.runs_on,
${{ env.runs_on }} and their capitalized versions.
2023-04-21 15:14:20 +10:00
Gaetan Craig-Riou
3810d79cad
Merge pull request #10695 from macanudo527/rename_inversables
...
Rename Inversable Method Names
2023-04-21 11:38:58 +10:00
Maikel Linke
4960402643
Update translations
2023-04-21 09:45:45 +10:00
jibees
3557c10cd6
Merge pull request #10730 from openfoodfoundation/dependabot/bundler/stringex-2.8.6
...
Bump stringex from 2.8.5 to 2.8.6
2023-04-20 15:50:19 +02:00
jibees
45dd421f1f
Merge pull request #10729 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.121.0
...
Bump aws-sdk-s3 from 1.120.1 to 1.121.0
2023-04-20 15:48:46 +02:00
Jean-Baptiste Bellet
81606e841a
Canceling an order: clicking on cancel btn or cancel action in dropdown
2023-04-20 14:38:59 +02:00
basilawwad
e633670e01
Use a shared_examples for the order cancellation tests
2023-04-20 14:38:59 +02:00
Filipe
11653c9430
Merge pull request #10575 from jibees/10559-allow-upload-of-custom-header-logo
...
White Label: can upload a custom header logo
2023-04-20 13:27:52 +01:00
dependabot[bot]
d068094044
Bump stringex from 2.8.5 to 2.8.6
...
Bumps [stringex](https://github.com/rsl/stringex ) from 2.8.5 to 2.8.6.
- [Release notes](https://github.com/rsl/stringex/releases )
- [Commits](https://github.com/rsl/stringex/compare/v2.8.5...v2.8.6 )
---
updated-dependencies:
- dependency-name: stringex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-20 10:06:33 +00:00
dependabot[bot]
b892bf726e
Bump aws-sdk-s3 from 1.120.1 to 1.121.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.120.1 to 1.121.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-20 10:00:05 +00:00
Jean-Baptiste Bellet
76357789a3
Avoid line break between state wording and its little colored circle
2023-04-20 09:09:29 +02:00
Jean-Baptiste Bellet
5dd7246b85
Rename confirm to use confirmation
...
`confirmation` is the state used by order model
2023-04-20 09:07:01 +02:00
Jean-Baptiste Bellet
ba45dd84dd
Solves rubocop linter errors
2023-04-20 08:46:19 +02:00
Jean-Baptiste Bellet
92e2a83e0e
Use Rails7 command for image variant syntax
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
f42f513f8c
Display white_label_logo image when hide_ofn_navigation is set to true
...
for both desktop and mobile view
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
54342254b6
Do not show white label logo is hide_ofn_navigation is not checked
...
They are both strongly linked
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
470761da86
Add a simple CheckboxDisplay controller that show/hide content
...
depending on the checkbox state (checked or not)
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
6fdf9fa038
Add/Remove white label logo in enterprise preferences panel
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
bbec01a9cb
Create a concern for reflexes that handle Enterprise update
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
e3001cc8c4
Add white_label_logo to enterprise model as attachment
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
ad0d0e393e
ConfirmModalComponent is ready to receive data-reflex
...
And not only `data-action`
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
2690ff5eb5
Add comment, which links these two files together
2023-04-20 08:45:03 +02:00
jibees
2594382488
Merge pull request #10723 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.9
...
Bump sidekiq from 7.0.8 to 7.0.9
2023-04-20 08:31:46 +02:00
Maikel Linke
9b3cfe80ff
Remove useless clearing of test emails
...
They are cleared by the test environment anyway.
2023-04-20 13:35:40 +10:00
Maikel Linke
04d33adaf2
Remove duplicate declaration of test mail delivery
...
Our test environment sets the mail delivery method already. We don't
have to do it in individual spec files.
2023-04-20 13:28:59 +10:00
Maikel Linke
915bd19d7b
Remove useless email test setup
...
We always deliver emails these days.
2023-04-20 12:18:04 +10:00
Maikel Linke
9998025687
Remove useless test header setup for emails
...
Once upon a time we needed a helper to set the `from` header of emails.
This is now set in the ApplicationMailer and not necessary any more.
2023-04-20 12:15:34 +10:00
Maikel Linke
1955a6719c
Fix commit message formatting
...
Git needs a blank line between the summary and the longer description.
And `echo` doesn't interpret `\n` by default.
2023-04-20 11:19:32 +10:00
Maikel Linke
f71e5ee43c
Limit number of rubocop autocorrect runs
...
The typical use case is to create a small number of commits for a pull
request to ease the review. And you can still run it for all cops with
`-n 999` or `-n -0`.
2023-04-20 11:19:32 +10:00
Maikel Linke
0ac2358f2c
Regenerate Rubocop's TODO file without timestamp
2023-04-20 10:34:35 +10:00
dependabot[bot]
946b69242c
Bump sidekiq from 7.0.8 to 7.0.9
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.8 to 7.0.9.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.8...v7.0.9 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-19 09:58:13 +00:00
Jean-Baptiste Bellet
a27b64a66b
Add confirmation state translation
2023-04-19 11:32:51 +02:00
Jean-Baptiste Bellet
0f54d3950d
Save can have a context: simplify then
2023-04-19 10:15:35 +02:00
Jean-Baptiste Bellet
7e306693a8
Use Rails standard naming: same name for the route and the method
2023-04-19 10:15:35 +02:00
Maikel Linke
213fb42a05
Safely autocorrect Gemspec/RequireMFA
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/catalog/catalog.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:9:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |spec| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:21:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 8 offenses detected, 8 offenses corrected
2023-04-19 15:35:30 +10:00
Maikel Linke
bde46fa1e9
Safely autocorrect Gemspec/DeprecatedAttributeAssignment
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:17:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
spec.test_files = Dir['spec/**/*']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["spec/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 4 offenses detected, 4 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
dc560d3793
Safely autocorrect Bundler/OrderedGems
...
Inspecting 1404 files
.C..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
Gemfile:18:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem angular-rails-templates should appear before rexml.
gem 'angular-rails-templates', '>= 0.3.0'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:19:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem awesome_nested_set should appear before rexml.
gem 'awesome_nested_set'
^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:20:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem ransack should appear before rexml.
gem 'ransack', '~> 2.6.0'
^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:21:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem responders should appear before rexml.
gem 'responders'
^^^^^^^^^^^^^^^^
Gemfile:74:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem omniauth-rails_csrf_protection should appear before openid_connect.
gem 'omniauth-rails_csrf_protection'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:154:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before factory_bot_rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:155:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before fuubar.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:156:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before json_spec.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:157:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before knapsack_pro.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:158:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before letter_opener.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:159:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:160:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-retry.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:161:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rswag-specs.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:162:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before shoulda-matchers.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:163:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before timecop.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:179:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem foreman should appear before rails-erd.
gem 'foreman'
^^^^^^^^^^^^^
Gemfile:180:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem listen should appear before rails-erd.
gem 'listen'
^^^^^^^^^^^^
Gemfile:181:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem pry should appear before rails-erd.
gem 'pry', '~> 0.13.0'
^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 18 offenses detected, 18 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
52f134fc9e
Regenerate Rubocop's TODO file
2023-04-19 15:35:29 +10:00
Maikel Linke
c08e264afa
Add script for bulk autocorrect with Rubocop
...
We also had an old script which wasn't used and needed manual steps.
2023-04-19 15:35:29 +10:00
Neal Chambers
4e32bfd70b
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
Jean-Baptiste Bellet
722c660697
Do not show any links to other steps when no distribution set
...
distribution means tuple: distributor + order cycle
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ac666a6fce
Validate presence of distributor and order_cycle in set_distribution step
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ba1d985932
update the set_distribution form on the same path
...
and use the same method `OrdersController#set_distribution`
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
0f28d318ac
Fix rubocop error and prefer using a return clause
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
6172d1f2e5
Extract method on_update that will be used elsewhere
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
05a040b4c3
No need to ensure if the distribution is set on new action
...
This will be handled by validation on set_distribution action
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
73a81310f8
Create a new url /orders/ORDER_ID/distribution
...
That handles the step when distributor and order_cycle must be selected
2023-04-18 14:21:23 +02:00
David Cook
43e51cb592
Simplify login spec helpers, avoid long lines
...
Follow on from 5c6d9a092e
2023-04-18 10:01:23 +10:00
David Cook
6570891349
Fix linter issues
...
Although I don't think the size was an issue here, small hashes can easily fit on one line.
2023-04-18 09:50:08 +10:00
David Cook
0f3e2ae572
Use browser validation for calculator values
...
They're all numbers, so we can reliably validate in the browser, removing the need for additional validation logic.
They will still be validated server-side, and in the unlikely even that there is an error, the generic 'Calculator is invalid' message will appear, with the relevant fields highlighted red. I think that's fine.
2023-04-18 09:50:08 +10:00
David Cook
f0110d20a2
Move config to base helper
...
This config is relevant for all specs, including system specs.
2023-04-18 09:50:08 +10:00
David Cook
353acfd6ae
Validate associated calculator with built in error handling
...
Except that pesky generic message was appearing. I still don't know how to control that so just deleted it.
2023-04-18 09:39:39 +10:00
David Cook
e43a018dc7
[wip] Copy each calculator error
...
But we still have the duplicate problem.
Wait a minute, it copies them in the same format that I am copying them. So.. I don't need to copy them at all!
Now I see that we just needed the right format in the translation file.
2023-04-18 09:39:39 +10:00
David Cook
f6fac018ea
[wip] Use a custom message format for associated errors
...
This is much simpler. Multiple messages get combined onto one line though, which is not perfect.
And.. it still seems to duplicate the errors. Weird, it's fine on my frontend though.
2023-04-18 09:39:39 +10:00
David Cook
ce1bd12760
Consolidate specs
...
It takes time to set up this test case. Given that there's no interactions in the expectations, we should save time to generate it only once.
2023-04-18 09:39:39 +10:00
David Cook
364ccc2146
Add comment
2023-04-18 09:39:39 +10:00
James Wu
2a7cb50fa9
Keep and display submitted data on new payment method page
2023-04-18 09:39:39 +10:00
James Wu
29ddc68d20
Fix duplicate validation error message
2023-04-18 09:39:39 +10:00
James Wu
d40f3414ea
fixup! Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
f5e2edb028
fixup! Modify Calculator validation error messages [wip]
...
DC: the error message has now become "Amount Invalid input".
2023-04-18 09:39:39 +10:00
James Wu
7af26e6579
Add errors for invalid input with number localization enabled
2023-04-18 09:39:39 +10:00
James Wu
824d4adf21
Rename spec file
2023-04-18 09:39:39 +10:00
James Wu
00cc8da2fc
Fix rubocop class length error
2023-04-18 09:39:39 +10:00
James Wu
ae5f2cc19d
Fix error saving data on new Calculator
2023-04-18 09:39:39 +10:00
James Wu
41ce4fbc16
Fix cache issue with invalid form data
2023-04-18 09:39:39 +10:00
James Wu
48753df5f0
Improve input validation and error notification
2023-04-18 09:39:39 +10:00
James Wu
1f3e66316b
Modify Calculator validation error messages
2023-04-18 09:39:39 +10:00
James Wu
6b1426d0c6
Add numericality validation for PriceSack
2023-04-18 09:39:39 +10:00
James Wu
c68987c0f2
Add numericality validation for PerItem
2023-04-18 09:39:39 +10:00
James Wu
2cb25e6366
Add numericality validation for FlexiRate
2023-04-18 09:39:39 +10:00
James Wu
073f46e590
Add numericality validation for FlatRate
2023-04-18 09:39:39 +10:00
James Wu
23beea8a13
Add numericality validation for FlatPercentPerItem
2023-04-18 09:39:39 +10:00
James Wu
096e388fdf
Add numericality validation for FlatPercentItemTotal
2023-04-18 09:39:39 +10:00
James Wu
3dfaf882a3
Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
7b51f45b4d
Fix spelling in test description
2023-04-18 09:39:39 +10:00
James Wu
b9b2fa7c94
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
James Wu
ee30d3d139
Fix PaymentMethodFactory creating extra Calculator
2023-04-18 09:39:39 +10:00
MadisonBowron
697f2795d4
Remove arbitrary comments
2023-04-14 01:25:14 -04:00
filipefurtad0
7d51979c06
Updates build environment to Ubuntu 22.04
...
Creates environment variable to set OS version
2023-04-12 09:19:14 +02:00
MadisonBowron
8c6e0a841c
Fix rubocop extra blank line error
2023-04-11 15:35:37 -04:00
MadisonBowron
9d0a69cceb
Fix admin product variants form to close issues #10579 & #430
2023-04-10 18:53:01 -04:00