Maikel Linke
0bdee785bb
Update all locales with the latest Transifex translations
2025-11-28 12:37:53 +11:00
Maikel
1029b61bb0
Merge pull request #13742 from mkllnk/market-organic
...
Add Market Organic as available platform
2025-11-28 12:15:57 +11:00
Gaetan Craig-Riou
065e7a420b
Merge pull request #13770 from openfoodfoundation/dependabot/bundler/pagy-9.4.0
...
Bump pagy from 9.3.4 to 9.4.0
2025-11-28 10:32:22 +11:00
Gaetan Craig-Riou
fe4b6accb0
Merge pull request #13767 from openfoodfoundation/dependabot/bundler/turbo-rails-2.0.20
...
Bump turbo-rails from 2.0.5 to 2.0.20
2025-11-28 10:28:12 +11:00
Filipe
b3314d7441
Merge pull request #13689 from rahsheen/fix/13396-cloned-order-cycles-not-processed
...
Clear opened_at when cloning order cycle
2025-11-27 18:52:09 +00:00
dependabot[bot]
77121dfacf
Bump pagy from 9.3.4 to 9.4.0
...
Bumps [pagy](https://github.com/ddnexus/pagy ) from 9.3.4 to 9.4.0.
- [Release notes](https://github.com/ddnexus/pagy/releases )
- [Changelog](https://github.com/ddnexus/pagy/blob/9.4.0/CHANGELOG.md )
- [Commits](https://github.com/ddnexus/pagy/compare/9.3.4...9.4.0 )
---
updated-dependencies:
- dependency-name: pagy
dependency-version: 9.4.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-27 09:02:19 +00:00
David Cook
04323388ad
Merge pull request #13766 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.31
...
Bump combine_pdf from 1.0.26 to 1.0.31
2025-11-27 10:35:15 +11:00
dependabot[bot]
700be792e5
Bump turbo-rails from 2.0.5 to 2.0.20
...
Bumps [turbo-rails](https://github.com/hotwired/turbo-rails ) from 2.0.5 to 2.0.20.
- [Release notes](https://github.com/hotwired/turbo-rails/releases )
- [Commits](https://github.com/hotwired/turbo-rails/compare/v2.0.5...v2.0.20 )
---
updated-dependencies:
- dependency-name: turbo-rails
dependency-version: 2.0.20
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-26 09:04:01 +00:00
dependabot[bot]
9f2ece379a
Bump combine_pdf from 1.0.26 to 1.0.31
...
Bumps [combine_pdf](https://github.com/boazsegev/combine_pdf ) from 1.0.26 to 1.0.31.
- [Release notes](https://github.com/boazsegev/combine_pdf/releases )
- [Changelog](https://github.com/boazsegev/combine_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/boazsegev/combine_pdf/compare/v1.0.26...v1.0.31 )
---
updated-dependencies:
- dependency-name: combine_pdf
dependency-version: 1.0.31
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-26 09:02:07 +00:00
Maikel
2662371507
Merge pull request #13755 from deivid-rodriguez/no-default-stylesheet-media
...
Pass media attribute explicitly to stylesheet link tags
2025-11-26 15:45:46 +11:00
Maikel
24fc3e9e86
Merge pull request #13748 from mkllnk/connector
...
Bump DFC version from 1.14 to 1.16 with new country and phone format
2025-11-26 12:32:02 +11:00
Gaetan Craig-Riou
b064173b7a
Merge pull request #13758 from openfoodfoundation/dependabot/bundler/debug-1.11.0
...
Bump debug from 1.9.2 to 1.11.0
2025-11-26 10:58:07 +11:00
Gaetan Craig-Riou
f95581cd1f
Merge pull request #13756 from openfoodfoundation/dependabot/bundler/whenever-1.1.0
...
Bump whenever from 1.0.0 to 1.1.0
2025-11-26 10:57:13 +11:00
dependabot[bot]
93d73f4763
Bump debug from 1.9.2 to 1.11.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.9.2 to 1.11.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.9.2...v1.11.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-version: 1.11.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-25 09:06:09 +00:00
dependabot[bot]
154d17969c
Bump whenever from 1.0.0 to 1.1.0
...
Bumps [whenever](https://github.com/javan/whenever ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/javan/whenever/releases )
- [Changelog](https://github.com/javan/whenever/blob/main/CHANGELOG.md )
- [Commits](https://github.com/javan/whenever/compare/v1.0.0...v1.1.0 )
---
updated-dependencies:
- dependency-name: whenever
dependency-version: 1.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-25 09:01:45 +00:00
David Rodríguez
e32dcd53b5
Pass media attribute explicitly to stylesheet link tags
...
So that we can enable Rails default behavior for potential future such link
tags without changing current behavior.
2025-11-25 08:08:59 +01:00
David Cook
44c4a66970
Merge pull request #13741 from mkllnk/gem-coop
...
Replace rubygems.org with gem.coop
2025-11-25 13:01:03 +11:00
Gaetan Craig-Riou
d05834b896
Merge pull request #13751 from openfoodfoundation/dependabot/bundler/dotenv-3.1.8
...
Bump dotenv from 3.1.2 to 3.1.8
2025-11-25 11:39:29 +11:00
Gaetan Craig-Riou
854e136d09
Merge pull request #13750 from openfoodfoundation/dependabot/bundler/flipper-active_record-1.3.6
...
Bump flipper-active_record from 1.3.0 to 1.3.6
2025-11-25 11:37:19 +11:00
Gaetan Craig-Riou
7f3fc4ff91
Merge pull request #13749 from openfoodfoundation/dependabot/bundler/view_component-4.1.1
...
Bump view_component from 3.12.1 to 4.1.1
2025-11-25 11:32:31 +11:00
dependabot[bot]
62ae62db5a
Bump dotenv from 3.1.2 to 3.1.8
...
Bumps [dotenv](https://github.com/bkeepers/dotenv ) from 3.1.2 to 3.1.8.
- [Release notes](https://github.com/bkeepers/dotenv/releases )
- [Changelog](https://github.com/bkeepers/dotenv/blob/main/Changelog.md )
- [Commits](https://github.com/bkeepers/dotenv/compare/v3.1.2...v3.1.8 )
---
updated-dependencies:
- dependency-name: dotenv
dependency-version: 3.1.8
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-24 09:13:22 +00:00
dependabot[bot]
a6fc49abce
Bump flipper-active_record from 1.3.0 to 1.3.6
...
Bumps [flipper-active_record](https://github.com/flippercloud/flipper ) from 1.3.0 to 1.3.6.
- [Release notes](https://github.com/flippercloud/flipper/releases )
- [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/flippercloud/flipper/compare/v1.3.0...v1.3.6 )
---
updated-dependencies:
- dependency-name: flipper-active_record
dependency-version: 1.3.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-24 09:12:40 +00:00
dependabot[bot]
528c5a3593
Bump view_component from 3.12.1 to 4.1.1
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 3.12.1 to 4.1.1.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.12.1...v4.1.1 )
---
updated-dependencies:
- dependency-name: view_component
dependency-version: 4.1.1
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-24 09:12:02 +00:00
Maikel Linke
81165cd82b
Replace country names with standard ISO code concepts
...
The DFC version 1.16.0 introduced this new standardisation.
2025-11-24 16:59:41 +11:00
Maikel Linke
faf50a1922
Bump datafoodconsortium-connector from 1.1.0 to 1.2.0
2025-11-24 16:45:06 +11:00
Maikel Linke
5f237adda2
Publish phone numbers as objects
...
The standard introduced this a while ago but I didn't notice.
We have to update integrations like Disco Regen now.
2025-11-24 16:44:23 +11:00
Maikel Linke
2e09a96c4b
Document new managedBy attribute on DFC API
2025-11-24 15:19:34 +11:00
Gaetan Craig-Riou
82139a9ac0
Merge pull request #13747 from mkllnk/doc-reset
...
Show reset tasks in task list `./bin/rails -T`
2025-11-24 13:19:33 +11:00
Gaetan Craig-Riou
6d9946c3c6
Merge pull request #13738 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.205.0
...
Bump aws-sdk-s3 from 1.151.0 to 1.205.0
2025-11-24 13:17:41 +11:00
Maikel Linke
f58b6bcada
Show reset tasks in task list ./bin/rails -T
...
I wrote them a while ago but noticed only now that they don't show up in
the overview.
2025-11-24 12:59:41 +11:00
Maikel
dc13ef4162
Merge pull request #13743 from deivid-rodriguez/bump-prettier
...
Bump prettier and let Dependabot handle further updates
2025-11-24 12:06:19 +11:00
Maikel
dcb48272f5
Merge pull request #13746 from rioug/security-255-code-injection
...
[Security] Fix potential code injection
2025-11-24 12:01:44 +11:00
Gaetan Craig-Riou
08bc374576
Merge pull request #13740 from openfoodfoundation/dependabot/bundler/image_processing-1.14.0
...
Bump image_processing from 1.12.2 to 1.14.0
2025-11-24 09:48:37 +11:00
Gaetan Craig-Riou
afbf0a5d0e
Merge pull request #13739 from openfoodfoundation/dependabot/bundler/database_cleaner-2.1.0
...
Bump database_cleaner from 2.0.2 to 2.1.0
2025-11-24 09:32:45 +11:00
Gaetan Craig-Riou
7e034a3037
Merge pull request #13737 from openfoodfoundation/dependabot/npm_and_yarn/webpack-4.47.0
...
Bump webpack from 4.46.0 to 4.47.0
2025-11-24 09:21:11 +11:00
Ahmed Ejaz
2db2fb2f11
Update all locales with the latest Transifex translations
2025-11-24 03:07:32 +05:00
Gaetan Craig-Riou
74d2a94181
Add input validation to prevent code injection
...
Plus spec
2025-11-23 13:46:36 +11:00
rahsheen
7a5b273e71
update specs
2025-11-22 10:51:17 -05:00
rahsheen
0b6e7593db
Set oc.opened at nil when cloning service
2025-11-22 10:51:17 -05:00
David Rodríguez
6d0d91c56a
Let prettier updates be handled by Dependabot
2025-11-21 12:49:44 +01:00
David Rodríguez
a509d49ec6
Bump prettier to 3.6.2
...
And fix new style issues.
2025-11-21 12:49:06 +01:00
Filipe
dddc945c42
Merge pull request #13679 from deivid-rodriguez/customer-edition
...
Improve `/admin/customers` form handling
2025-11-21 10:51:55 +00:00
Filipe
12c0363b7e
Merge pull request #13716 from chahmedejaz/bugfix/13554-sorting-on-demand-products
...
"On hand" value influences sorting of "on demand" products/variants
2025-11-21 10:05:44 +00:00
Maikel Linke
fbce264dd7
Adjust webhook URL for Market Organic
2025-11-21 14:16:47 +11:00
Maikel Linke
3c1313bfa0
Add Market Organic as available platform
2025-11-21 14:16:47 +11:00
Maikel Linke
4ca420bd84
Correct needed scope of access token
2025-11-21 14:16:41 +11:00
Maikel Linke
134ea28249
Remove obsolete DPM option
2025-11-21 13:47:00 +11:00
Maikel Linke
78cfc0db65
Replace rubygems.org with gem.coop
...
Several maintainers of RubyGems created gem.coop as a community-governed
service after a takeover by RubyCentral, pushed by Shopify.
We are moving with the community that reflects our values best.
2025-11-21 12:59:30 +11:00
dependabot[bot]
816e06d37c
Bump image_processing from 1.12.2 to 1.14.0
...
Bumps [image_processing](https://github.com/janko/image_processing ) from 1.12.2 to 1.14.0.
- [Changelog](https://github.com/janko/image_processing/blob/master/CHANGELOG.md )
- [Commits](https://github.com/janko/image_processing/compare/v1.12.2...v1.14.0 )
---
updated-dependencies:
- dependency-name: image_processing
dependency-version: 1.14.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-21 01:21:08 +00:00
dependabot[bot]
2e80b7d92f
Bump database_cleaner from 2.0.2 to 2.1.0
...
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner ) from 2.0.2 to 2.1.0.
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/main/History.rdoc )
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v2.0.2...v2.1.0 )
---
updated-dependencies:
- dependency-name: database_cleaner
dependency-version: 2.1.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-21 01:20:30 +00:00
dependabot[bot]
753173e2be
Bump aws-sdk-s3 from 1.151.0 to 1.205.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.151.0 to 1.205.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-version: 1.205.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-21 01:19:54 +00:00
dependabot[bot]
c9954f0823
Bump webpack from 4.46.0 to 4.47.0
...
Bumps [webpack](https://github.com/webpack/webpack ) from 4.46.0 to 4.47.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v4.46.0...v4.47.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-version: 4.47.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-21 01:18:20 +00:00
Maikel
80f5fa30c4
Merge pull request #13736 from deivid-rodriguez/unify-dependabot-strategy
...
Unify dependabot strategy
2025-11-21 12:17:15 +11:00
Gaetan Craig-Riou
9194d0ba2b
Merge pull request #13733 from openfoodfoundation/dependabot/bundler/rubocop-1.81.7
...
Bump rubocop from 1.81.6 to 1.81.7
2025-11-21 10:16:12 +11:00
Gaetan Craig-Riou
e00c993a98
Merge pull request #13732 from openfoodfoundation/dependabot/bundler/undercover-0.8.2
...
Bump undercover from 0.8.1 to 0.8.2
2025-11-21 10:11:54 +11:00
Gaetan Craig-Riou
800333f65b
Merge pull request #13731 from openfoodfoundation/dependabot/bundler/arel-helpers-2.17.0
...
Bump arel-helpers from 2.14.0 to 2.17.0
2025-11-21 10:10:33 +11:00
Ahmed Ejaz
64df7cc9bc
Refactor backorderable_name tests for clarity and consistency in product sorting
2025-11-20 06:06:56 +05:00
Ahmed Ejaz
b23fec268e
fix lint issues
2025-11-20 05:08:07 +05:00
Ahmed Ejaz
7b7a7d3418
Add backorderable_name sorting and enhance combined sorting tests
2025-11-20 05:01:08 +05:00
David Rodríguez
6fa99b187d
Unify Dependabot strategy
...
Let's do the same we do for Ruby dependencies.
2025-11-19 14:47:44 +01:00
David Rodríguez
a009dacd41
Pin version of foundation
...
Reading through open issues, I think it's more likely that we end up
removing it rather than upgrading it.
So let's fix it like when we don't want certain dependencies to be
managed by Dependabot.
2025-11-19 14:45:52 +01:00
dependabot[bot]
472ba98ec2
Bump rubocop from 1.81.6 to 1.81.7
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.81.6 to 1.81.7.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.81.6...v1.81.7 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-version: 1.81.7
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-19 09:02:45 +00:00
dependabot[bot]
91cd3356b0
Bump undercover from 0.8.1 to 0.8.2
...
Bumps [undercover](https://github.com/grodowski/undercover ) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/grodowski/undercover/releases )
- [Changelog](https://github.com/grodowski/undercover/blob/master/CHANGELOG.md )
- [Commits](https://github.com/grodowski/undercover/compare/v0.8.1...v0.8.2 )
---
updated-dependencies:
- dependency-name: undercover
dependency-version: 0.8.2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-19 09:02:08 +00:00
dependabot[bot]
67ef142546
Bump arel-helpers from 2.14.0 to 2.17.0
...
Bumps [arel-helpers](https://github.com/camertron/arel-helpers ) from 2.14.0 to 2.17.0.
- [Changelog](https://github.com/camertron/arel-helpers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/camertron/arel-helpers/compare/v2.14.0...v2.17.0 )
---
updated-dependencies:
- dependency-name: arel-helpers
dependency-version: 2.17.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-19 09:01:31 +00:00
Maikel
0aa4993a4d
Merge pull request #13686 from mkllnk/litefarm-market-organic
...
Allow Litefarm and Market.Organic to access DFC API
2025-11-19 15:11:51 +11:00
Gaetan Craig-Riou
98176bd5de
Merge pull request #13730 from openfoodfoundation/dependabot/bundler/redcarpet-3.6.1
...
Bump redcarpet from 3.6.0 to 3.6.1
2025-11-19 10:10:20 +11:00
Gaetan Craig-Riou
dde0e23a79
Merge pull request #13729 from openfoodfoundation/dependabot/bundler/wicked_pdf-2.8.2
...
Bump wicked_pdf from 2.8.1 to 2.8.2
2025-11-19 10:08:42 +11:00
Gaetan Craig-Riou
d1021210e6
Merge pull request #13728 from openfoodfoundation/dependabot/bundler/rubocop-factory_bot-2.28.0
...
Bump rubocop-factory_bot from 2.27.1 to 2.28.0
2025-11-19 10:08:08 +11:00
dependabot[bot]
bfa472a293
Bump redcarpet from 3.6.0 to 3.6.1
...
Bumps [redcarpet](https://github.com/vmg/redcarpet ) from 3.6.0 to 3.6.1.
- [Release notes](https://github.com/vmg/redcarpet/releases )
- [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/vmg/redcarpet/compare/v3.6.0...v3.6.1 )
---
updated-dependencies:
- dependency-name: redcarpet
dependency-version: 3.6.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-18 09:02:38 +00:00
dependabot[bot]
9d14c1026c
Bump wicked_pdf from 2.8.1 to 2.8.2
...
Bumps [wicked_pdf](https://github.com/mileszs/wicked_pdf ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/mileszs/wicked_pdf/releases )
- [Changelog](https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mileszs/wicked_pdf/commits )
---
updated-dependencies:
- dependency-name: wicked_pdf
dependency-version: 2.8.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-18 09:02:04 +00:00
dependabot[bot]
c653743a56
Bump rubocop-factory_bot from 2.27.1 to 2.28.0
...
Bumps [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot ) from 2.27.1 to 2.28.0.
- [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases )
- [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-factory_bot/compare/v2.27.1...v2.28.0 )
---
updated-dependencies:
- dependency-name: rubocop-factory_bot
dependency-version: 2.28.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-18 09:01:30 +00:00
Filipe
a1ee1eac4c
Merge pull request #13680 from rioug/13674-enable-variant-tag-new-enterprise
...
[Variant tags] Enable variant tag for enterprise created after 11th of August and super admins
2025-11-17 23:05:11 +00:00
Gaetan Craig-Riou
84b351e076
Merge pull request #13723 from openfoodfoundation/dependabot/npm_and_yarn/js-yaml-3.14.2
...
Bump js-yaml from 3.14.1 to 3.14.2
2025-11-18 09:51:04 +11:00
Ahmed Ejaz
9f7faac842
Remove .tool-versions file
2025-11-18 03:49:06 +05:00
dependabot[bot]
02c1b309f3
Bump js-yaml from 3.14.1 to 3.14.2
...
Bumps [js-yaml](https://github.com/nodeca/js-yaml ) from 3.14.1 to 3.14.2.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nodeca/js-yaml/compare/3.14.1...3.14.2 )
---
updated-dependencies:
- dependency-name: js-yaml
dependency-version: 3.14.2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-17 22:36:10 +00:00
Gaetan Craig-Riou
58028df3b7
Merge pull request #13721 from openfoodfoundation/dependabot/bundler/newrelic_rpm-9.23.0
...
Bump newrelic_rpm from 9.22.0 to 9.23.0
2025-11-18 09:29:31 +11:00
Gaetan Craig-Riou
638c139bca
Merge pull request #13720 from openfoodfoundation/dependabot/bundler/bugsnag-6.28.0
...
Bump bugsnag from 6.26.4 to 6.28.0
2025-11-18 09:28:23 +11:00
Gaetan Craig-Riou
5adfdf11fb
Merge pull request #13719 from openfoodfoundation/dependabot/bundler/angular_rails_csrf-7.0.2
...
Bump angular_rails_csrf from 6.0.0 to 7.0.2
2025-11-18 09:26:57 +11:00
dependabot[bot]
152a7b7fe9
Bump newrelic_rpm from 9.22.0 to 9.23.0
...
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent ) from 9.22.0 to 9.23.0.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases )
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md )
- [Commits](https://github.com/newrelic/newrelic-ruby-agent/compare/9.22.0...9.23.0 )
---
updated-dependencies:
- dependency-name: newrelic_rpm
dependency-version: 9.23.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-17 09:05:19 +00:00
dependabot[bot]
5c998bfc77
Bump bugsnag from 6.26.4 to 6.28.0
...
Bumps [bugsnag](https://github.com/bugsnag/bugsnag-ruby ) from 6.26.4 to 6.28.0.
- [Release notes](https://github.com/bugsnag/bugsnag-ruby/releases )
- [Changelog](https://github.com/bugsnag/bugsnag-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bugsnag/bugsnag-ruby/compare/v6.26.4...v6.28.0 )
---
updated-dependencies:
- dependency-name: bugsnag
dependency-version: 6.28.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-17 09:04:19 +00:00
dependabot[bot]
97ca8702d4
Bump angular_rails_csrf from 6.0.0 to 7.0.2
...
Bumps [angular_rails_csrf](https://github.com/jsanders/angular_rails_csrf ) from 6.0.0 to 7.0.2.
- [Release notes](https://github.com/jsanders/angular_rails_csrf/releases )
- [Changelog](https://github.com/bodrovis/angular_rails_csrf/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jsanders/angular_rails_csrf/compare/v6.0.0...v7.0.2 )
---
updated-dependencies:
- dependency-name: angular_rails_csrf
dependency-version: 7.0.2
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-17 09:03:44 +00:00
Maikel
e194ebf0f3
Merge pull request #13552 from openfoodfoundation/dependabot/npm_and_yarn/jest-30.2.0
...
Bump jest from 27.5.1 to 30.2.0
2025-11-17 15:21:57 +11:00
Gaetan Craig-Riou
f6fc8a6993
Merge pull request #13715 from openfoodfoundation/dependabot/bundler/rexml-3.4.2
...
Bump rexml from 3.3.9 to 3.4.2
2025-11-17 15:07:10 +11:00
Gaetan Craig-Riou
cbf6b4462e
Merge pull request #13712 from openfoodfoundation/dependabot/bundler/shoulda-matchers-7.0.1
...
Bump shoulda-matchers from 6.2.0 to 7.0.1
2025-11-17 15:04:52 +11:00
Gaetan Craig-Riou
c03580180a
Merge pull request #13711 from openfoodfoundation/dependabot/bundler/geocoder-1.8.6
...
Bump geocoder from 1.8.3 to 1.8.6
2025-11-17 15:03:06 +11:00
Gaetan Craig-Riou
77b72134d8
Merge pull request #13710 from openfoodfoundation/dependabot/bundler/good_migrations-0.3.1
...
Bump good_migrations from 0.2.1 to 0.3.1
2025-11-17 15:02:16 +11:00
Ahmed Ejaz
c638e2e65e
Update specs to prioritize name order in case of on-demand products
2025-11-16 17:02:47 +05:00
dependabot[bot]
25ac714cc6
Bump rexml from 3.3.9 to 3.4.2
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.3.9 to 3.4.2.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.3.9...v3.4.2 )
---
updated-dependencies:
- dependency-name: rexml
dependency-version: 3.4.2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-14 23:10:57 +00:00
Filipe
475e6c33f1
Merge pull request #13498 from chahmedejaz/task/13497-upgrade-activemerchant-gem
...
Upgrade ActiveMerchant to v1.137.0 and rexml to 3.3.9
2025-11-14 23:09:47 +00:00
Ahmed Ejaz
ae70a1372b
Remove version constraints for activemerchant and angular-rails-templates in Gemfile
2025-11-15 01:46:30 +05:00
Ahmed Ejaz
6eb6bf634f
Update activemerchant version constraint to '>= 1.137.0' in Gemfile and Gemfile.lock
2025-11-15 01:46:30 +05:00
Ahmed Ejaz
a82209af85
Update activemerchant version constraint to '~> 1.137.0' in Gemfile and Gemfile.lock
2025-11-15 01:46:30 +05:00
Ahmed Ejaz
ecf0d53f0a
Revert "revert "Bump rexml from 3.2.9 to 3.3.9""
...
This reverts commit c821b0a285 .
2025-11-15 01:46:30 +05:00
Filipe
fc047e3f7c
Merge pull request #13668 from openfoodfoundation/dependabot/npm_and_yarn/leaflet-providers-3.0.0
...
Bump leaflet-providers from 2.0.0 to 3.0.0
2025-11-14 18:21:59 +00:00
Filipe
d9e3076a3b
Merge pull request #13654 from pacodelaluna/check-enterprise-image-logic
...
Improve enterprise images-related logic
2025-11-14 18:15:50 +00:00
Filipe
271e895486
Merge pull request #13676 from deivid-rodriguez/z-index
...
Fix tag rule visibility select box options hidden by save bar
2025-11-14 17:41:52 +00:00
Filipe
3e02a03312
Merge pull request #13650 from rioug/13539-update-variant-multi-producer
...
Fix update multi producer products
2025-11-14 16:56:16 +00:00
dependabot[bot]
ec31ff418d
Bump shoulda-matchers from 6.2.0 to 7.0.1
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 6.2.0 to 7.0.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/main/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v6.2.0...v7.0.1 )
---
updated-dependencies:
- dependency-name: shoulda-matchers
dependency-version: 7.0.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-14 01:38:47 +00:00
dependabot[bot]
22f3577b0d
Bump geocoder from 1.8.3 to 1.8.6
...
Bumps [geocoder](https://github.com/alexreisner/geocoder ) from 1.8.3 to 1.8.6.
- [Changelog](https://github.com/alexreisner/geocoder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/alexreisner/geocoder/compare/v1.8.3...v1.8.6 )
---
updated-dependencies:
- dependency-name: geocoder
dependency-version: 1.8.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-14 01:36:45 +00:00
dependabot[bot]
9c9773f493
Bump good_migrations from 0.2.1 to 0.3.1
...
Bumps [good_migrations](https://github.com/testdouble/good-migrations ) from 0.2.1 to 0.3.1.
- [Changelog](https://github.com/testdouble/good-migrations/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testdouble/good-migrations/compare/v0.2.1...v0.3.1 )
---
updated-dependencies:
- dependency-name: good_migrations
dependency-version: 0.3.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-14 01:35:47 +00:00
Gaetan Craig-Riou
33cea470ad
Merge pull request #13704 from deivid-rodriguez/more-dependabot
...
Update all webpack related dependencies together
2025-11-14 12:32:34 +11:00
Gaetan Craig-Riou
17ac3507a6
Merge pull request #13701 from openfoodfoundation/dependabot/bundler/angular-rails-templates-1.3.1
...
Bump angular-rails-templates from 1.2.1 to 1.3.1
2025-11-14 12:06:34 +11:00
Ahmed Ejaz
763655f0e5
Enhance product sorting for On-Demand items and add backorderable name support
2025-11-14 06:04:32 +05:00
Gaetan Craig-Riou
7cf0a95688
Merge pull request #13700 from openfoodfoundation/dependabot/bundler/rswag-ui-2.17.0
...
Bump rswag-ui from 2.16.0 to 2.17.0
2025-11-14 11:25:14 +11:00
Gaetan Craig-Riou
c641fae2b9
Merge pull request #13699 from openfoodfoundation/dependabot/bundler/rails-7.1.6
...
Bump rails from 7.1.5.2 to 7.1.6
2025-11-14 11:23:21 +11:00
Gaetan Craig-Riou
526df1cb9c
Merge pull request #13698 from openfoodfoundation/dependabot/bundler/acts-as-taggable-on-13.0.0
...
Bump acts-as-taggable-on from 10.0.0 to 13.0.0
2025-11-14 11:20:47 +11:00
Gaetan Craig-Riou
f4e9daec80
Merge pull request #13706 from deivid-rodriguez/tweak-reviewdog
...
Let reviewdog use github-pr-annotation formatter
2025-11-14 10:44:51 +11:00
Ahmed Ejaz
3e2cd839cc
add .tools-versions for asdf version manager
2025-11-14 04:38:52 +05:00
Gaetan Craig-Riou
b9a790ba20
Per review, comment out transform configuration
...
We are using the default one, no need to actually specify it, and also
updated the documentaion link to the latest documentation.
2025-11-14 10:32:14 +11:00
Maikel Linke
aaad1bc0b3
Accept short client ids in tokens
2025-11-14 10:00:16 +11:00
Maikel Linke
d7f4a5c874
Allow Market.Organic to access DFC API
2025-11-14 10:00:16 +11:00
Maikel Linke
f8ca8ae942
Trust FDC dev realm to sign tokens
2025-11-14 10:00:16 +11:00
Maikel Linke
2805ea4926
Allow LiteFarm to access DFC API
2025-11-14 10:00:16 +11:00
David Rodríguez
36ac5dc44e
Let reviewdog use github-pr-annotation formatter
...
This is already the default for forked PRs, and most (if not all) PRs to
this repository come from forks anyways.
2025-11-13 20:39:09 +01:00
David Rodríguez
49a976810b
Update all webpack related dependencies together
2025-11-13 08:45:18 +01:00
David Rodríguez
f6d605a3aa
Dismiss success message automatically after 5 seconds
...
We were already eventually removing the "success" border style on
inputs. I think it makes sense to do the same for the success message
itself. That's how our standard "flash messages" already work.
2025-11-13 08:37:52 +01:00
David Rodríguez
6901323827
Fix success message taking 5 seconds to show up
...
This is pretty black magic to me, but my understanding is that:
* When submitting customer forms, we use `$q.all()` on the result of
submitting each form asynchronously in order to decide whether to
display a success message (no errors) or a failure message.
* The value returned for each particular form submission was the return
value of either `change.scope.success()` or `change.scope.error()`.
These use the `switchClass` factory, which changes a particular DOM
element's class to the proper pending/success/error class, but in the
success case, it also sets a timeout to remove the class using
`$timeout()`, which is a promise, and that was its return value.
* Because of the above, `$q.all()` was actually waiting for the
`$timeout()` promise to be fulfilled before proceeding.
The fix is to not return a `$timeout()` promise from the `switchClass`
factory when a timeout is passed, but instead set a timeout on the
element, but return the element itself regardless.
2025-11-13 08:37:52 +01:00
David Rodríguez
186fe0503f
Show orange border when input has changes
...
Even if it's on focus.
2025-11-13 08:37:52 +01:00
David Rodríguez
e990e5ffd5
Don't show flash messages in customer edition form
...
They don't actually show up when the customer is saved, but the next
time the page is reloaded. We already have the save bar for the same
purpose so it's not necessary.
2025-11-13 08:37:52 +01:00
David Rodríguez
3d7207d8c5
Properly track changes in code attribute
...
If the code was initially nil, some value is added, and then removed, we
would not detect that the code has not actually changed.
2025-11-13 08:37:52 +01:00
David Rodríguez
4b31352e4f
Wait for page before checking DB
2025-11-13 08:37:51 +01:00
David Rodríguez
278a8b1ec2
Let save-bar properly track form state
...
* Keep save bar visible as long as there's a customer form displayed.
* Only display "You have unsaved changes" when there's any difference
from the original values. If form changes are reverted, hide that
note.
* Similarly, only let the button be enabled if there are any actual
changes to be saved.
2025-11-13 08:37:51 +01:00
Gaetan Craig-Riou
b96a0875f3
Turn on cleaning up of globals.
...
It will be come default in future jest release, currently jest isn't
emitting any warning so there is no reason to wait to turn it on.
2025-11-13 09:44:22 +11:00
Gaetan Craig-Riou
4e62e20fa8
Fix test to work with new jsdom restriction
...
since jsdom 21, it's no longer possible to mock window.location
See : https://github.com/jsdom/jsdom/issues/3492
2025-11-11 14:58:48 +11:00
Gaetan Craig-Riou
2729fb14d6
Fix jest configuration to work with version 28
...
Per migration guide : https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28/
2025-11-11 14:58:43 +11:00
dependabot[bot]
5dab6f67f2
Bump jest from 27.5.1 to 30.2.0
...
Bumps [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest ) from 27.5.1 to 30.2.0.
- [Release notes](https://github.com/jestjs/jest/releases )
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jestjs/jest/commits/v30.2.0/packages/jest )
---
updated-dependencies:
- dependency-name: jest
dependency-version: 30.2.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-11 14:56:15 +11:00
dependabot[bot]
3aa48fcd18
Bump angular-rails-templates from 1.2.1 to 1.3.1
...
Bumps [angular-rails-templates](https://github.com/pitr/angular-rails-templates ) from 1.2.1 to 1.3.1.
- [Release notes](https://github.com/pitr/angular-rails-templates/releases )
- [Changelog](https://github.com/pitr/angular-rails-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pitr/angular-rails-templates/commits )
---
updated-dependencies:
- dependency-name: angular-rails-templates
dependency-version: 1.3.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-11 02:50:19 +00:00
dependabot[bot]
e5fd5a0d4c
Bump rswag-ui from 2.16.0 to 2.17.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.16.0 to 2.17.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/2.17.0/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.16.0...2.17.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-version: 2.17.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-11 02:48:08 +00:00
David Cook
ad5a22a69b
Merge pull request #13691 from rioug/fix-order-cycle-flaky-spec
...
Fix flaky spec
2025-11-11 13:47:41 +11:00
dependabot[bot]
43b3114237
Bump rails from 7.1.5.2 to 7.1.6
...
Bumps [rails](https://github.com/rails/rails ) from 7.1.5.2 to 7.1.6.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v7.1.5.2...v7.1.6 )
---
updated-dependencies:
- dependency-name: rails
dependency-version: 7.1.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-11 02:47:34 +00:00
dependabot[bot]
a83109cb05
Bump acts-as-taggable-on from 10.0.0 to 13.0.0
...
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on ) from 10.0.0 to 13.0.0.
- [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases )
- [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mbleigh/acts-as-taggable-on/compare/v10.0.0...v13.0.0 )
---
updated-dependencies:
- dependency-name: acts-as-taggable-on
dependency-version: 13.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-11 02:46:59 +00:00
David Cook
72327a352e
Merge pull request #13685 from deivid-rodriguez/no-raw-credit-card-data
...
Change CreditCardRemover specs to not send raw credit card data
2025-11-11 13:46:45 +11:00
David Cook
35ef895cff
Merge pull request #13677 from deivid-rodriguez/tweak-dependabot
...
Update turbo_power npm and rubygem packages together
2025-11-11 13:44:21 +11:00
David Cook
52e4293e90
Merge pull request #13673 from deivid-rodriguez/bump-state-machines
...
Bump state_machines related gems again
2025-11-11 13:22:53 +11:00
Gaetan Craig-Riou
460d109bd2
Update product ability
...
A user has product permission if it is a supplier of at least one of the
product's variants
2025-11-11 11:35:19 +11:00
Gaetan Craig-Riou
7d0f17fe1a
Merge pull request #13693 from openfoodfoundation/dependabot/npm_and_yarn/testing-library/dom-10.4.1
...
Bump @testing-library/dom from 9.3.4 to 10.4.1
2025-11-11 09:55:17 +11:00
Gaetan Craig-Riou
cff6fcf52e
Merge pull request #13697 from openfoodfoundation/dependabot/bundler/roadie-rails-3.4.0
...
Bump roadie-rails from 3.2.0 to 3.4.0
2025-11-11 09:50:52 +11:00
Gaetan Craig-Riou
4083aa82b8
Merge pull request #13696 from openfoodfoundation/dependabot/bundler/digest-3.2.1
...
Bump digest from 3.2.0 to 3.2.1
2025-11-11 09:47:02 +11:00
Gaetan Craig-Riou
ac61ef1f81
Merge pull request #13695 from openfoodfoundation/dependabot/bundler/paper_trail-17.0.0
...
Bump paper_trail from 15.1.0 to 17.0.0
2025-11-11 09:45:13 +11:00
Gaetan Craig-Riou
924c421b75
Merge pull request #13694 from openfoodfoundation/dependabot/bundler/devise-i18n-1.15.0
...
Bump devise-i18n from 1.12.1 to 1.15.0
2025-11-11 09:41:43 +11:00
dependabot[bot]
71262d18a0
Bump @testing-library/dom from 9.3.4 to 10.4.1
...
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) from 9.3.4 to 10.4.1.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v9.3.4...v10.4.1 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-version: 10.4.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-10 22:41:11 +00:00
David Rodríguez
9645660d87
Fix tag rule visibility select box options hidden by save bar
2025-11-10 17:32:11 +01:00
filipefurtad0
f18487ea68
Update all locales with the latest Transifex translations
2025-11-10 11:22:54 +00:00
dependabot[bot]
13a955d45a
Bump roadie-rails from 3.2.0 to 3.4.0
...
Bumps [roadie-rails](https://github.com/Mange/roadie-rails ) from 3.2.0 to 3.4.0.
- [Changelog](https://github.com/Mange/roadie-rails/blob/master/Changelog.md )
- [Commits](https://github.com/Mange/roadie-rails/compare/v3.2.0...v3.4.0 )
---
updated-dependencies:
- dependency-name: roadie-rails
dependency-version: 3.4.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-10 09:41:12 +00:00
dependabot[bot]
7a06c72534
Bump digest from 3.2.0 to 3.2.1
...
Bumps [digest](https://github.com/ruby/digest ) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/ruby/digest/releases )
- [Commits](https://github.com/ruby/digest/compare/v3.2.0...v3.2.1 )
---
updated-dependencies:
- dependency-name: digest
dependency-version: 3.2.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-10 09:40:38 +00:00
dependabot[bot]
cdb572f347
Bump paper_trail from 15.1.0 to 17.0.0
...
Bumps [paper_trail](https://github.com/paper-trail-gem/paper_trail ) from 15.1.0 to 17.0.0.
- [Release notes](https://github.com/paper-trail-gem/paper_trail/releases )
- [Changelog](https://github.com/paper-trail-gem/paper_trail/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paper-trail-gem/paper_trail/compare/v15.1.0...v17.0.0 )
---
updated-dependencies:
- dependency-name: paper_trail
dependency-version: 17.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-10 09:39:38 +00:00
dependabot[bot]
8f44b06244
Bump devise-i18n from 1.12.1 to 1.15.0
...
Bumps [devise-i18n](https://github.com/devise-i18n/devise-i18n ) from 1.12.1 to 1.15.0.
- [Release notes](https://github.com/devise-i18n/devise-i18n/releases )
- [Changelog](https://github.com/devise-i18n/devise-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/devise-i18n/devise-i18n/compare/v1.12.1...v1.15.0 )
---
updated-dependencies:
- dependency-name: devise-i18n
dependency-version: 1.15.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-10 09:39:04 +00:00
Gaetan Craig-Riou
e8b81c1ff6
Fix variant filtering
...
We don't want to filter out variant missing producer, so that the user
can address the problem.
2025-11-10 16:29:27 +11:00
Gaetan Craig-Riou
ab443fa50f
Refactor the clone template to use local variable
...
and add define locals on the template
2025-11-10 16:29:27 +11:00
Gaetan Craig-Riou
25d55fec24
Filter out variant the user is not allowed to update
...
With a product with mutiple variant, we can end in a scenario where a
user sees variant associated to producer it doesn't have permission for.
This prevents the user from updating any variant. This fix filter out
variant a user shoudn't be seeing
2025-11-10 16:29:27 +11:00
Gaetan Craig-Riou
61f8b5c7f4
Add strict locals for some products V3 templates
...
Rails now allows you to define which local a template is expecting:
https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
2025-11-10 16:29:27 +11:00
Maikel
7c4714288d
Merge pull request #13675 from deivid-rodriguez/unify-linters
...
Unify linters and linter related tools
2025-11-10 16:24:36 +11:00
Maikel
b6e393eabb
Merge pull request #13662 from filipefurtad0/spec_deprecation_nil_in_sum
...
Catches exceptions on final_weight_volume inputs
2025-11-10 15:25:49 +11:00
Gaetan Craig-Riou
d18aeb9918
Merge pull request #13687 from openfoodfoundation/dependabot/bundler/openid_connect-2.3.1
...
Bump openid_connect from 2.3.0 to 2.3.1
2025-11-10 15:15:32 +11:00
Gaetan Craig-Riou
6596afc562
Fix flaky spec, contain_exactly doesn't care about the order
2025-11-10 13:29:30 +11:00
Maikel
587f76415b
Merge pull request #13656 from pacodelaluna/replace-alias-attribute-with-alias-method
...
Replace alias_attribute with alias_method
2025-11-10 11:50:33 +11:00
dependabot[bot]
665aee6eb0
Bump openid_connect from 2.3.0 to 2.3.1
...
Bumps [openid_connect](https://github.com/nov/openid_connect ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/nov/openid_connect/releases )
- [Changelog](https://github.com/nov/openid_connect/blob/main/CHANGELOG.md )
- [Commits](https://github.com/nov/openid_connect/compare/v2.3.0...v2.3.1 )
---
updated-dependencies:
- dependency-name: openid_connect
dependency-version: 2.3.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-10 00:48:19 +00:00
Gaetan Craig-Riou
5e505c1240
Merge pull request #13683 from openfoodfoundation/dependabot/bundler/omniauth_openid_connect-0.8.0
...
Bump omniauth_openid_connect from 0.7.1 to 0.8.0
2025-11-10 11:46:51 +11:00
Gaetan Craig-Riou
e948f89625
Merge pull request #13682 from openfoodfoundation/dependabot/bundler/activerecord-session_store-2.2.0
...
Bump activerecord-session_store from 2.1.0 to 2.2.0
2025-11-10 11:31:56 +11:00
Gaetan Craig-Riou
f42b91f414
Merge pull request #13681 from openfoodfoundation/dependabot/bundler/spring-4.4.0
...
Bump spring from 4.2.1 to 4.4.0
2025-11-10 11:25:57 +11:00
Gaetan Craig-Riou
3e8a34c5f3
Per dicussion, remove super admin from migration
2025-11-10 11:14:56 +11:00
Gaetan Craig-Riou
1101310845
Enable variant_tag for recent enterprise and admins
...
Recent entperise are enterprise created after 11th of August which
should not have access to inventory
2025-11-10 11:14:56 +11:00
Gaetan Craig-Riou
0745028c06
Fix checking if variant tag is enabled
...
variant_tag feature check should happen per enterprise basis, but we
still want super admin to so see variant tag. To do so we check if the
user is amdin or if any of the current user enterprise has variant tag
enable.
2025-11-10 11:14:56 +11:00
Rachel Arnould
94bda6d0f8
Merge pull request #13592 from rioug/13266-tag-variant-tag-rule
...
[Variant tags] Add tag rules for variant
2025-11-07 14:14:50 +01:00
David Rodríguez
915d03a66a
Change CreditCardRemover specs to not send raw credit card data
...
If I re-record cassettes for these specs using my test API key, I get
the following errors:
```
1) Stripe::CreditCardRemover#remove Stripe customer exists and is not deleted deletes the credit card clone and the customer
Failure/Error:
Stripe::PaymentMethod.create(
{
type: 'card',
card: {
number: '4242424242424242',
exp_month: 8,
exp_year: Time.zone.now.year.next,
cvc: '314',
},
},
Stripe::CardError:
Sending credit card numbers directly to the Stripe API is generally unsafe. We suggest you use test tokens that map to the test card you are using, see https://stripe.com/docs/testing . To enable testing raw card data APIs, see https://support.stripe.com/questions/enabling-access-to-raw-card-data-apis .
# ./spec/lib/stripe/credit_card_remover_spec.rb:16:in `block (3 levels) in <main>'
# ./spec/lib/stripe/credit_card_remover_spec.rb:44:in `block (4 levels) in <main>'
# ./spec/lib/stripe/credit_card_remover_spec.rb:56:in `block (4 levels) in <main>'
# ./spec/base_spec_helper.rb:208:in `block (2 levels) in <main>'
# ./spec/base_spec_helper.rb:155:in `block (3 levels) in <main>'
# ./spec/base_spec_helper.rb:155:in `block (2 levels) in <main>'
# -e:1:in `<main>'
```
Use test payment methods instead as suggested by the error.
2025-11-06 18:30:45 +01:00
Filipe
1422b440e4
Merge pull request #13493 from dacook/bump-stripe-v13
...
Bump stripe to v13
2025-11-06 13:48:52 +00:00
Filipe
95ad87d840
Merge pull request #13666 from chahmedejaz/bugfix/13519-order-disappear-from-orders-page
...
Order lines are deleted when one tries to capture a payment after order cycle is closed
2025-11-06 13:07:36 +00:00
Konrad
7357419f6f
Merge pull request #13652 from navaneethkp36/13651-fix-button-size-order-confirmation
...
Make the width of "Back to Store" and "Back to Website" buttons consistent with other buttons in order confirmation page
2025-11-05 19:29:42 +01:00
François Turbelin
e07ebc21b9
Use instance_double when possible in enterprise model spec
2025-11-05 16:31:20 +01:00
filipefurtad0
8e5404a268
Replaces negative assertion with a positive assertion
...
Adds test case on white spece
Refactors to have tests as shared_examples
2025-11-05 11:12:55 +00:00
filipefurtad0
04fc729a5a
Changes tests not to trigger error
...
after https://github.com/openfoodfoundation/openfoodnetwork/pull/13571 was merged
2025-11-05 10:34:52 +00:00
filipefurtad0
8818a98230
Catches exceptions on final_weight_volume inputs
2025-11-05 10:34:52 +00:00
David Rodríguez
d3efa3afa6
Remove pretty-quick
...
Because:
* We already have reviewdog running prettier in CI.
* We already removed the associated commit hooks.
* Running plain prettier is already very fast in our case.
2025-11-05 10:08:04 +01:00
David Rodríguez
4414879b3f
Completely remove codeclimate as well
...
Most of it is already disabled, and the stuff that's not actually
disabled don't seem worth enough for me to keep it.
2025-11-05 10:08:04 +01:00
David Rodríguez
3c7aac59e9
Remove ancient rubocop plugin from codeclimate config
...
We already get RuboCop offense information through reviewdog.
2025-11-05 10:08:04 +01:00
David Rodríguez
41cd40a55b
Completely get rid of hound
...
We already get RuboCop offense information through reviewdog.
2025-11-05 10:08:04 +01:00
David Rodríguez
a0e8111b3a
Remove spurious scss-lint configuration
...
It was broken due to several reasons:
* Bad globs from not catching up after file renames.
* Bad rule indentation.
Also, the scss-lint project itself recommends using other tools, because
it relies on the ruby SASS implementation while upstream has moved to a
dart-based implementation.
Even when you fix the config and try to run the tool, you feel the pain
of this deviation:
```
$ scss-lint
(...)
app/webpacker/css/admin/grid.scss:10:1 [E] Syntax: Syntax Error: Invalid CSS after "$col-width: math": expected selector or at-rule, was ".div($total-col..."
(...)
```
The grid.scss file use using `math.div` feature, which is only supported
by the `sass` version based on dart. `scss-lint` will never be able to
parse this file at all.
Also, we're already handling scss rule formatting through prettier.
Because of all these reasons, it's best to forget about scss-lint.
2025-11-05 10:08:03 +01:00
David Rodríguez
8f07ee5bf7
Move haml-lint from hound to reviewdog
...
We can somewhat easily get it passing and integrate nice with reviewdog
by adding a TODO file for the rules that we had enabled, so that we
don't need to correct anything now, but we still get alerted for new
offenses. So I say let's keep it and enforce it from now on.
2025-11-05 10:08:03 +01:00
David Rodríguez
43da235d15
Make sure all linters run even if some of them fails
2025-11-05 10:08:03 +01:00
dependabot[bot]
3252de19a3
Bump omniauth_openid_connect from 0.7.1 to 0.8.0
...
Bumps [omniauth_openid_connect](https://github.com/omniauth/omniauth_openid_connect ) from 0.7.1 to 0.8.0.
- [Changelog](https://github.com/omniauth/omniauth_openid_connect/blob/master/CHANGELOG.md )
- [Commits](https://github.com/omniauth/omniauth_openid_connect/compare/v0.7.1...v0.8.0 )
---
updated-dependencies:
- dependency-name: omniauth_openid_connect
dependency-version: 0.8.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-05 09:04:05 +00:00
dependabot[bot]
fd3bd062fe
Bump activerecord-session_store from 2.1.0 to 2.2.0
...
Bumps [activerecord-session_store](https://github.com/rails/activerecord-session_store ) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/rails/activerecord-session_store/releases )
- [Changelog](https://github.com/rails/activerecord-session_store/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/activerecord-session_store/compare/v2.1.0...v2.2.0 )
---
updated-dependencies:
- dependency-name: activerecord-session_store
dependency-version: 2.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-05 09:02:12 +00:00
dependabot[bot]
029d447d98
Bump spring from 4.2.1 to 4.4.0
...
Bumps [spring](https://github.com/rails/spring ) from 4.2.1 to 4.4.0.
- [Release notes](https://github.com/rails/spring/releases )
- [Changelog](https://github.com/rails/spring/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rails/spring/compare/v4.2.1...v4.4.0 )
---
updated-dependencies:
- dependency-name: spring
dependency-version: 4.4.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-05 09:01:40 +00:00
David Cook
8e5fac9fb3
Merge pull request #13632 from rioug/security-247-code-injection
...
[security] Fix potential code injection
2025-11-05 16:34:37 +11:00
Gaetan Craig-Riou
30c0bcc910
Merge pull request #13678 from deivid-rodriguez/remove-debugger-linecache
...
Remove debugger-linecache
2025-11-05 11:14:11 +11:00
Gaetan Craig-Riou
1a4ba9b689
Merge pull request #13672 from openfoodfoundation/dependabot/bundler/i18n-tasks-1.0.15
...
Bump i18n-tasks from 1.0.14 to 1.0.15
2025-11-05 10:21:46 +11:00
Gaetan Craig-Riou
4de8191e27
Merge pull request #13579 from openfoodfoundation/dependabot/bundler/flipper-ui-1.3.6
...
Bump flipper-ui from 1.3.0 to 1.3.6
2025-11-05 10:06:43 +11:00
Gaetan Craig-Riou
472ca5a16b
Merge pull request #13490 from openfoodfoundation/dependabot/bundler/turbo_power-0.7.0
...
Bump turbo_power from 0.6.2 to 0.7.0
2025-11-05 10:00:07 +11:00
Gaetan Craig-Riou
dab626031b
Merge pull request #13041 from openfoodfoundation/dependabot/npm_and_yarn/turbo_power-0.7.1
...
Bump turbo_power from 0.7.0 to 0.7.1
2025-11-05 09:57:40 +11:00
Ahmed Ejaz
913dded766
Refactor order cycle handling to simplify closed cycle checks and improve redirection messaging
2025-11-05 02:50:01 +05:00
filipefurtad0
a36b7ce01a
deletes all old VCR cassettes
2025-11-04 15:40:45 +00:00
David Cook
e4be336630
Bump Stripe to v13
2025-11-04 15:36:53 +00:00
David Cook
cae13df2c7
Bump Stripe to v12
...
re-recording cassettes with script/test-stripe-live
2025-11-04 15:32:05 +00:00
David Cook
81796db6e5
Fix date-dependent spec
2025-11-04 15:17:45 +00:00
David Cook
ba3553854e
Allow script to continue if you've already deleted the old files
2025-11-04 15:17:45 +00:00
David Rodríguez
c386d1af01
Remove debugger-linecache
...
This gem has not been updated since 2013 and serves no purpose these
days.
2025-11-04 10:22:37 +01:00
David Rodríguez
9566075dee
Tweak Dependabot config
2025-11-04 08:57:10 +01:00
dependabot[bot]
9916b361e4
Bump turbo_power from 0.6.2 to 0.7.0
...
Bumps [turbo_power](https://github.com/marcoroth/turbo_power-rails ) from 0.6.2 to 0.7.0.
- [Release notes](https://github.com/marcoroth/turbo_power-rails/releases )
- [Commits](https://github.com/marcoroth/turbo_power-rails/compare/v0.6.2...v0.7.0 )
---
updated-dependencies:
- dependency-name: turbo_power
dependency-version: 0.7.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-03 11:05:43 +00:00
François Turbelin
b2d7d797d9
Use wrap_parameters to handle address params on Customer v1 API
2025-11-03 11:35:39 +01:00
David Rodríguez
7076afecfb
Bump state_machines related gems again
...
This fixes warnings like
```
$ bundle exec rspec spec/system/admin/users_spec.rb:179
(...)
Instance method "invalid?" is already defined in Spree::Payment(id: integer, amount: decimal, order_id: integer, created_at: datetime, updated_at: datetime, source_id: integer, source_type: string, payment_method_id: integer, state: string, response_code: string, avs_response: string, identifier: string, cvv_response_code: string, cvv_response_message: text, captured_at: datetime, redirect_auth_url: string),
use generic helper instead or set StateMachines::Machine.ignore_method_conflicts = true.
(...)
```
2025-11-03 10:56:16 +01:00
François Turbelin
e385b9f708
Revert "Use customer-nested params for Customer v1 API writing operations"
...
This reverts commit cf4cd311b3 .
2025-11-03 10:32:26 +01:00
dependabot[bot]
2b9b02aeea
Bump i18n-tasks from 1.0.14 to 1.0.15
...
Bumps [i18n-tasks](https://github.com/glebm/i18n-tasks ) from 1.0.14 to 1.0.15.
- [Release notes](https://github.com/glebm/i18n-tasks/releases )
- [Changelog](https://github.com/glebm/i18n-tasks/blob/main/CHANGES.md )
- [Commits](https://github.com/glebm/i18n-tasks/compare/v1.0.14...v1.0.15 )
---
updated-dependencies:
- dependency-name: i18n-tasks
dependency-version: 1.0.15
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-03 09:06:01 +00:00
dependabot[bot]
009b5e5ff1
Bump flipper-ui from 1.3.0 to 1.3.6
...
Bumps [flipper-ui](https://github.com/flippercloud/flipper ) from 1.3.0 to 1.3.6.
- [Release notes](https://github.com/flippercloud/flipper/releases )
- [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md )
- [Commits](https://github.com/flippercloud/flipper/compare/v1.3.0...v1.3.6 )
---
updated-dependencies:
- dependency-name: flipper-ui
dependency-version: 1.3.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-03 17:31:57 +11:00
dependabot[bot]
7c310e7e46
Bump turbo_power from 0.7.0 to 0.7.1
...
Bumps [turbo_power](https://github.com/marcoroth/turbo_power ) from 0.7.0 to 0.7.1.
- [Release notes](https://github.com/marcoroth/turbo_power/releases )
- [Commits](https://github.com/marcoroth/turbo_power/compare/v0.7.0...v0.7.1 )
---
updated-dependencies:
- dependency-name: turbo_power
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-03 05:17:35 +00:00
Gaetan Craig-Riou
bd0db57768
Per review, more concise code
2025-11-03 15:58:27 +11:00
Gaetan Craig-Riou
bb8ecccc31
Fix variant tag rules endpoint
...
It now returns tag rules filtered on the preferred variant tags and not
the prefered customer tags
2025-11-03 15:50:12 +11:00
Gaetan Craig-Riou
ffd5817749
Add spec for variant_tag_rules
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
1a68236c3c
Add variant_tag_rule ability
...
It's needed to allow enterprise user to get a tag autocomplete. Classic
mistake of not testing with a non superadmin user.
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
c057bab493
Use route helpers for autocomplete url
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
59340c7cff
Per review, remove unnecessary new translation
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
aebb18da99
Per review, improve specs
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
ce60335a60
Per review, fix leftover comment
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
307acdd9d1
Per review, fixing specs descriptions
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
d51e257904
Fix order cycle tag rule specs
...
It works better when you actually save the changes to the tag_list...
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
07a3e83dc6
Fix enterprise specs
...
Plus small refactor
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
38f58b168a
Fix tag rules spec
...
Make sure the autocomplete dropdown list is hidden by default
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
34abca5ff1
Add missing js unit test got TagListInput component
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
145764a921
Add testing library
...
See :https://testing-library.com/docs/
It allows us to query DOM node in way that's similar to how a user would
interect with element on the page. It's particularly usefull for
elements that trigger AJAX request.
2025-11-03 14:25:40 +11:00
Gaetan Craig-Riou
9bbe573335
Fix test to match the improved controller
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
c5d5694f24
Tweaked jest configuration
...
- include app/components in the directories to search for modules, ie we
can require view component js controller like this :
`import tag_list_input_controller from "tag_list_input_component/tag_list_input_controller";`
- fixed the regexp to skip transformation so it skips any modules
starting by "stimulus"
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
ab194a0e80
Add styling for the dropdown
...
It's mostly the same styling as the AngularJs version but with updated
colors
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
749944fc25
Rework TagListInputComponent to integrate autocomplete
...
The component now will try to load a list of existing tag if you give an
`autocomplete_url`. I tried to keep the tag input and the autocomplete
functionality decoupled but is wasn't really possible. Instead I opted
to sub class the Autocomplete stimulus controller, but it only gets
initialised if we pass an `autocomplete_url`.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
3cffc5538a
Add tag filtering for tag autocomplete
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
6d7908e1f8
Style formatting
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
965b34318f
Add new component to provide tag autocomplete for variant tag
...
It uses composition and inject the TagListInputComponent as a depency,
which should be more flexible that creating a sub class. This new
component could potentially be made more generic if needed
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
3bb9eb9765
Add endpoint to provide autocomplete tag for variant
...
It return a list of available tags and number of related rules, based on
the given enterprise and a partial match on the given tag
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
bd39595917
Add ability to pass option to the tag input field
...
And also render any content given to the component via block
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
81e16a9cdf
Add stimulus-autocomplete package
...
https://github.com/afcapel/stimulus-autocomplete/tree/main
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
c38c8bcff2
Pass the variant_tag_enbabled options to relevant services
...
Plus add integration testing for variant tag rule filtering.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
7633af8ff2
Call VariantTagRulesFilterer when variant_tag feature is enabled
...
We only support either inventory or variant_tag feature, with the later
taking precedence if both are turned on.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
94c0ebd897
Fix error in the muliple tag rules spec
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
7b3db4bae4
Add VariantTagRuleFilterer to filter variants by tag rule
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
b1d95cac7f
Display filter by variant tag rule
...
We only support one of filter by inventory variants or filter by variants
at any given time, based on enabled feature. If both features inventory
and variant tag are enabled, variant tag takes precedence.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
3f297a8afa
Add tag rule to filter by variant
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
af111a9625
Clean up tag rules specs
...
Remove unnecessary use mocking and use of `__send__`
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
96f715b62b
Merge pull request #13661 from deivid-rodriguez/ruby-3.2
...
Bump Ruby from 3.1.7 to 3.2.9
2025-11-03 13:29:40 +11:00
Maikel
33b4e38fc5
Merge pull request #13664 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.12.1
...
Bump jasmine-core from 5.12.0 to 5.12.1
2025-11-03 13:11:49 +11:00
Maikel
27e4ae9892
Merge pull request #13639 from deivid-rodriguez/verify-latest-reviewdog
...
Upgrade to latest reviewdog
2025-11-03 12:28:01 +11:00
Gaetan Craig-Riou
f434d8b066
Merge pull request #13658 from openfoodfoundation/dependabot/bundler/paranoia-2.6.4
...
Bump paranoia from 2.6.3 to 2.6.4
2025-11-03 12:05:44 +11:00
Gaetan Craig-Riou
43d471f93d
Merge pull request #13657 from openfoodfoundation/dependabot/npm_and_yarn/hotwired/turbo-8.0.20
...
Bump @hotwired/turbo from 8.0.13 to 8.0.20
2025-11-03 12:03:58 +11:00
Ahmed Ejaz
3794f69cad
Add shared examples to handle closed order cycle in checkout process
2025-11-02 01:48:10 +05:00
François Turbelin
cf4cd311b3
Use customer-nested params for Customer v1 API writing operations
2025-10-31 14:39:55 +01:00
François Turbelin
275326eaa6
Replace alias_attribute with alias_method
2025-10-31 14:26:33 +01:00
dependabot[bot]
526f8be676
Bump leaflet-providers from 2.0.0 to 3.0.0
...
Bumps [leaflet-providers](https://github.com/leaflet-extras/leaflet-providers ) from 2.0.0 to 3.0.0.
- [Changelog](https://github.com/leaflet-extras/leaflet-providers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/leaflet-extras/leaflet-providers/commits/v3.0.0 )
---
updated-dependencies:
- dependency-name: leaflet-providers
dependency-version: 3.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-31 09:01:59 +00:00
David Rodríguez
0c392d5302
Drop version constraints for pg and pry entirely, so their versions can be fully managed by Dependabot
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-10-31 09:18:12 +01:00
David Rodríguez
e71a2603bd
Bump pry to a version that plays nice with Ruby 3.2
...
Otherwise you get the following error when starting RSpec:
```
(...)
An error occurred while loading base_spec_helper.
Failure/Error: require 'pry' unless ENV['CI']
NameError:
undefined method `=~' for class `Pry::Code'
# ./spec/base_spec_helper.rb:10:in `<top (required)>'
No examples found.
(...)
```
2025-10-31 09:18:11 +01:00
David Rodríguez
5aea527962
Use Bundler version that comes with Ruby 3.2.9 by default
2025-10-31 09:18:11 +01:00
David Rodríguez
05b3e97a0e
Bump Ruby from 3.1.7 to 3.2.9
...
Release announcements:
* https://www.ruby-lang.org/en/news/2025/07/24/ruby-3-2-9-released/
* https://www.ruby-lang.org/en/news/2025/03/26/ruby-3-2-8-released/
* https://www.ruby-lang.org/en/news/2025/02/04/ruby-3-2-7-released/
* https://www.ruby-lang.org/en/news/2024/10/30/ruby-3-2-6-released/
* https://www.ruby-lang.org/en/news/2024/07/26/ruby-3-2-5-released/
* https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-2-4-released/
* https://www.ruby-lang.org/en/news/2024/01/18/ruby-3-2-3-released/
* https://www.ruby-lang.org/en/news/2023/03/30/ruby-3-2-2-released/
* https://www.ruby-lang.org/en/news/2023/02/08/ruby-3-2-1-released/
* https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
Also autocorrect new offenses.
2025-10-31 09:18:11 +01:00
Maikel Linke
f9b76fadbd
Update all locales with the latest Transifex translations
2025-10-31 16:05:11 +11:00
Maikel
64f44b8a9b
Merge pull request #13571 from pacodelaluna/update_sum_calcultation
...
Update sum calculation in order_cycle_customer_totals spec
2025-10-31 16:03:11 +11:00
Maikel Linke
5dfb7645cb
Avoid enabling rubocop rule listed in todo file
2025-10-31 15:39:58 +11:00
Maikel Linke
74927dd03d
Regenerate Rubocop todo file
2025-10-31 15:30:17 +11:00
François Turbelin
71dd398131
Apply cosmetics and fix specs
2025-10-31 15:20:44 +11:00
François Turbelin
245f0caedb
Adjust sum for remaining reports
2025-10-31 15:20:44 +11:00
François Turbelin
18bc95c6a3
Update sum calculation in order_cycle_customer_totals spec
2025-10-31 15:20:44 +11:00
Ahmed Ejaz
243190491b
Fix specs
2025-10-31 04:40:44 +05:00
dependabot[bot]
7213dcf124
Bump jasmine-core from 5.12.0 to 5.12.1
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 5.12.0 to 5.12.1.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v5.12.0...v5.12.1 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-version: 5.12.1
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-30 09:02:08 +00:00
David Rodríguez
e90569bdcc
Adjust error format to latest prettier output
...
To avoid generating an unnecessary annotation.
2025-10-29 11:55:11 +01:00
David Rodríguez
404e27ab71
Run reviewdog directly
...
So that we can control the version we run without depending on external
actions, and so that we use a consistent version for all linters.
At the same time, unify to running the latest version of reviewdog,
0.21.0, which also involves changing the deprecated `fail_on_error` flag
previously used by prettier action to `fail_level`.
2025-10-29 11:55:10 +01:00
David Rodríguez
5af6d534df
Use "nofilter" for prettier
...
Now that we fixed all prettier issues.
2025-10-29 11:55:03 +01:00
David Rodríguez
65410aabad
Speed up rubocop reviewdog by skipping install
...
Since we already run `bundle install` at the beginning of the job.
2025-10-29 11:55:03 +01:00
David Rodríguez
2e78ea62b6
Change linters workflow label to reviewdog
2025-10-29 11:55:03 +01:00
David Rodríguez
201461918d
Fix prettier offense
...
I accidentally introduced this, not sure how, when correcting all
prettier issues.
2025-10-29 11:55:03 +01:00
dependabot[bot]
3efe0c7835
Bump paranoia from 2.6.3 to 2.6.4
...
Bumps [paranoia](https://github.com/rubysherpas/paranoia ) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/rubysherpas/paranoia/releases )
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md )
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.3...v2.6.4 )
---
updated-dependencies:
- dependency-name: paranoia
dependency-version: 2.6.4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-29 09:02:20 +00:00
dependabot[bot]
e3d453e397
Bump @hotwired/turbo from 8.0.13 to 8.0.20
...
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo ) from 8.0.13 to 8.0.20.
- [Release notes](https://github.com/hotwired/turbo/releases )
- [Commits](https://github.com/hotwired/turbo/compare/8.0.13...v8.0.20 )
---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
dependency-version: 8.0.20
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-29 09:01:59 +00:00
Maikel
0ecfc23c67
Merge pull request #13644 from deivid-rodriguez/more-rspec-fixes
...
Fix Rspec warnings and the broken Stripe intent API specs that fixing them revealed
2025-10-29 15:04:22 +11:00
Maikel
ff16b575c4
Merge pull request #13653 from deivid-rodriguez/bump-rubocop
...
Bump rubocop to 1.86.6
2025-10-29 12:00:31 +11:00
Maikel
faa826a76e
Merge pull request #13647 from deivid-rodriguez/remove-obsoleted-gem
...
Remove obsolete gem
2025-10-29 11:44:59 +11:00
Maikel
1e02084f95
Merge pull request #13646 from deivid-rodriguez/bump-ruby
...
Bump Ruby from 3.1.4 to 3.1.7
2025-10-29 11:43:04 +11:00
Maikel
44cca40db6
Merge pull request #13643 from deivid-rodriguez/fix-prettier-issues
...
Fix all existing prettier issues
2025-10-29 11:36:54 +11:00
David Cook
52174b1e06
Merge pull request #13645 from deivid-rodriguez/review-dog-write-checks
...
Fix reviewdog workflow failing to create checks
2025-10-29 09:17:26 +11:00
François Turbelin
c01818f57b
Improve entreprise spec on white label logo part
2025-10-28 18:29:25 +01:00
François Turbelin
f5e3d104e2
Add validation for enterprise white_label_logo
2025-10-28 18:19:12 +01:00
François Turbelin
ba9dca4b05
Avoid urls generation when the logo attachment is not saved yet
2025-10-28 18:19:12 +01:00
François Turbelin
efb7da316a
Use update! to save enterprise logo on API v0
2025-10-28 18:19:12 +01:00
Filipe
cdf0777d8e
Merge pull request #13641 from openfoodfoundation/dependabot/bundler/knapsack_pro-8.4.0
...
Bump knapsack_pro from 8.1.2 to 8.4.0
2025-10-28 12:31:44 +00:00
David Cook
9cb7c46b44
Merge pull request #13631 from rioug/13117-upgrade-node
...
Upgrade to node version 24
2025-10-28 10:52:34 +11:00
David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
David Rodríguez
27975252f5
Rename pm_card to payment_method_id
...
And also remove a couple of now unused `let`'s that were already using
this terminology.
Co-authored-by: David Cook <david@openfoodnetwork.org.au >
2025-10-27 10:52:36 +01:00
David Rodríguez
9fc82776ec
Move Stripe test payment method handling to a single place
...
And comment a bit on them.
Co-authored-by: David Cook <david@openfoodnetwork.org.au >
2025-10-27 10:45:45 +01:00
David Rodríguez
2c8bf82426
Migrate some spec to not send raw card numbers to Stripe API
...
If I regenerate the VCR cassetes for
spec/lib/stripe/payment_intent_validator_spec.rb, I get a lot of errors
like this:
```
Stripe::CardError:
Sending credit card numbers directly to the Stripe API is generally
unsafe. We suggest you use test tokens that map to the test card you are
using, see https://stripe.com/docs/testing . To enable testing raw card
data APIs, see
https://support.stripe.com/questions/enabling-access-to-raw-card-data-apis .
```
It seems the sandbox environment associated to my developer API keys is
not allowed to send raw credit card data.
Instead of requesting Stripe support to enable that, or regenerate
cassettes with the API keys in Bitwarden, I figured we could migrate the
tests to not use raw credit card data.
2025-10-27 09:08:30 +01:00
David Rodríguez
121019411c
Fix spec instantiating payment method with wrong source
...
Previous error is fixed, which allows the spec to proceed further, and
reveals that the current cassettes are missing some requests:
```
1) Stripe::PaymentIntentValidator#call as a guest when payment intent is valid valid non-3D credit cards are correctly handled behaves like payments intents from Visa returns payment intent id and does not raise
Failure/Error:
payment_intent_response = Stripe::PaymentIntent.retrieve(
payment_intent_id,
stripe_account: stripe_account_id
)
VCR::Errors::UnhandledHTTPRequestError:
================================================================================
An HTTP request has been made that VCR does not know how to handle:
GET https://api.stripe.com/v1/payment_intents/pi_3P8hNGKuuB1fWySn0dvhu9lG
VCR is currently using the following cassette:
(...)
```
2025-10-27 09:08:29 +01:00
David Rodríguez
1a5eb5b39a
Remove raise_error negative block to fix RSpec warnings
...
Currently RSpec warns these specs like this:
```
WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives, since literally any other error would cause the
expectation to pass, including those raised by Ruby (e.g. `NoMethodError`, `NameError` and `ArgumentError`), meaning the code you are intending
to test may not even get reached. Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`.
This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`.
Called from /path/to/spec/lib/stripe/payment_intent_validator_spec.rb:53:in `block (7 levels) in <main>'.
```
The warnings are super accurate in this particular case: the inner
assertion is not actually getting reached due to a previous unrelated
error.
Since there's an inner assertion already, I think it's best to
completely remove to `raise_error` negative block, since it just hides
errors and buys us nothing.
By removing it, the underlying error surfaces:
```
1) Stripe::PaymentIntentValidator#call as a guest when payment intent is valid valid non-3D credit cards are correctly handled behaves like payments intents from Visa returns payment intent id and does not raise
Failure/Error:
create(:payment, amount: payment_intent.amount, payment_method:,
response_code: payment_intent.id, source: pm_card)
NoMethodError:
undefined method `has_query_constraints?' for Stripe::PaymentMethod:Class
elsif (klass || self.klass).has_query_constraints? || options[:query_constraints]
^^^^^^^^^^^^^^^^^^^^^^^
Shared Example Group: "payments intents" called from ./spec/lib/stripe/payment_intent_validator_spec.rb:75
# ./spec/lib/stripe/payment_intent_validator_spec.rb:16:in `block (3 levels) in <main>'
# ./spec/lib/stripe/payment_intent_validator_spec.rb:19:in `block (3 levels) in <main>'
# ./spec/lib/stripe/payment_intent_validator_spec.rb:53:in `block (7 levels) in <main>'
# ./spec/base_spec_helper.rb:208:in `block (2 levels) in <main>'
# ./spec/base_spec_helper.rb:155:in `block (3 levels) in <main>'
# ./spec/base_spec_helper.rb:155:in `block (2 levels) in <main>'
# -e:1:in `<main>'
```
2025-10-27 09:08:29 +01:00
David Rodríguez
2bd536298b
Showcase the problem with some specs
...
They're always passing because an error (different from `StripeError`),
is actually making them pass.
2025-10-27 09:08:29 +01:00
Ahmed Ejaz
7415503b63
Update all locales with the latest Transifex translations
2025-10-27 05:55:44 +05:00
Ahmed Ejaz
895e142e2c
Enhance order cycle closure handling with improved messaging and redirection logic
2025-10-26 02:08:53 +05:00
Navaneeth
f1ffadd39c
Make the width of "Back to Store" and "Back to Website" buttons consistent with other buttons in order confirmation page
2025-10-25 22:15:14 +05:30
Filipe
cc35d118eb
Merge pull request #13627 from guidoDutra/10261/bad-table-format-in-edit-order-page
...
fix table format in edit order page
2025-10-24 13:16:49 +01:00
David Rodríguez
e09d78dfb2
Remove obsolete gem
...
Even without it, Rails seems to do this by default:
```console
$ RAILS_ENV=production SITE_URL=foo.bar SECRET_TOKEN=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx bin/rails db:drop
I, [2025-10-23T12:38:12.383244 #32647 ] INFO -- : [dotenv] Loaded .env
I, [2025-10-23T12:38:12.383292 #32647 ] INFO -- : [dotenv] Loaded .env
W, [2025-10-23T12:38:12.411675 #32647 ] WARN -- [Bugsnag]: No valid API key has been set, notifications will not be sent
bin/rails aborted!
ActiveRecord::ProtectedEnvironmentError: You are attempting to run a destructive action against your 'production' database.
If you are sure you want to continue, run the same command with the environment variable:
DISABLE_DATABASE_ENVIRONMENT_CHECK=1
Tasks: TOP => db:drop => db:check_protected_environments
(See full trace by running task with --trace)
```
And the gem hasn't been updated in 10 years, so probably best to get rid
of it.
2025-10-23 12:41:37 +02:00
David Rodríguez
dad7cfc180
Bump Ruby from 3.1.4 to 3.1.7
...
Release announcmenets:
* https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-1-5-released/
* https://www.ruby-lang.org/en/news/2024/05/29/ruby-3-1-6-released/
* https://www.ruby-lang.org/en/news/2025/03/26/ruby-3-1-7-released/
2025-10-23 10:34:21 +02:00
David Rodríguez
678497914f
Fix reviewdog workflow failing to create checks
2025-10-22 19:59:10 +02:00
David Rodríguez
852e7fa81e
Fix all existing prettier issues
2025-10-22 15:30:36 +02:00
dependabot[bot]
fb437fb34d
Bump knapsack_pro from 8.1.2 to 8.4.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 8.1.2 to 8.4.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/main/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v8.1.2...v8.4.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-version: 8.4.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-22 09:02:10 +00:00
Maikel
025f8b25b1
Merge pull request #13637 from deivid-rodriguez/fix-missing-stripe-js-error-in-edge-case
...
Fix JS error when Stripe connect is disabled but Stripe API keys are setup
2025-10-22 13:09:58 +11:00
Maikel
3017f61047
Merge pull request #13638 from deivid-rodriguez/refactor-specs
...
Remove only usage of `STRIPE_PUBLIC_TEST_API_KEY` env and refactor specs that were using it
2025-10-22 13:08:31 +11:00
Maikel
8cb3d06f7c
Merge pull request #13635 from deivid-rodriguez/testing-stripe-wiki
...
Link to Stripe testing wiki page from the cassette regeneration script
2025-10-22 13:02:21 +11:00
Maikel
8f442e82ed
Merge pull request #13634 from openfoodfoundation/dependabot/bundler/activerecord-import-2.2.0
...
Bump activerecord-import from 1.6.0 to 2.2.0
2025-10-22 13:00:43 +11:00
David Rodríguez
b28886dd38
Normalize casing
2025-10-21 17:34:40 +02:00
David Rodríguez
bd4f115185
Create account directly with the proper stripe_user_id
2025-10-21 17:34:40 +02:00
David Rodríguez
c43650034f
Remove unnecessary test specific environment variable
2025-10-21 17:34:40 +02:00
David Rodríguez
94bc787283
Remove unused let
2025-10-21 17:34:40 +02:00
David Rodríguez
58851a8e67
Move client_id let to the only spec using it
2025-10-21 17:34:39 +02:00
David Rodríguez
c3e2382600
Move let! to the only spec using it
2025-10-21 17:34:39 +02:00
David Rodríguez
802878b4eb
Fix JS error when Stripe connect is disabled but Stripe API keys are setup
2025-10-21 17:24:34 +02:00
Filipe
69d8fc3cad
Merge pull request #13624 from chahmedejaz/bugfix/13556-fix-500-error-on-stripe-checkout
...
Error 500 checking out with Stripe, after navigating back to the Summary page
2025-10-21 14:34:53 +01:00
David Rodríguez
6a226e476d
Link to Stripe testing wiki page from the cassette regeneration script
...
I think this is the more relevant wiki page for someone looking into
regenerating cassettes.
Also, no need to mention bitwarden explicitly, the wiki page already
explains everything.
2025-10-21 14:38:10 +02:00
dependabot[bot]
479d52a2bb
Bump activerecord-import from 1.6.0 to 2.2.0
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.6.0 to 2.2.0.
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.6.0...v2.2.0 )
---
updated-dependencies:
- dependency-name: activerecord-import
dependency-version: 2.2.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-21 09:02:00 +00:00
Gaetan Craig-Riou
8afd6eb0ab
Upgrade node to 24.10.0
...
This is the latest node 24 version which set to be the next lts.
2025-10-21 15:56:50 +11:00
Gaetan Craig-Riou
8d4a1ff320
Update spec to cover new code path
2025-10-21 15:48:27 +11:00
Gaetan Craig-Riou
1f0e541743
Update spec description wording
2025-10-21 15:48:27 +11:00
Gaetan Craig-Riou
adb7563ccb
Fix possible code injection
...
It will fix this security issue :
https://github.com/openfoodfoundation/openfoodnetwork/security/code-scanning/247
2025-10-21 15:48:27 +11:00
Gaetan Craig-Riou
73688b9544
Merge pull request #13630 from openfoodfoundation/dependabot/bundler/webmock-3.25.1
...
Bump webmock from 3.23.1 to 3.25.1
2025-10-21 10:02:14 +11:00
dependabot[bot]
02ea3cb61c
Bump webmock from 3.23.1 to 3.25.1
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.23.1 to 3.25.1.
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.23.1...v3.25.1 )
---
updated-dependencies:
- dependency-name: webmock
dependency-version: 3.25.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-20 09:26:20 +00:00
Maikel
c7d0594257
Merge pull request #13622 from deivid-rodriguez/no-reviewdog-master
...
Don't run reviewdog on pushes
2025-10-20 16:34:06 +11:00
Maikel
4eee7ad603
Merge pull request #13604 from deivid-rodriguez/silent-puma
...
Silence capybara starting puma during system specs
2025-10-20 16:26:18 +11:00
David Cook
23f7f2974a
Merge pull request #13618 from deivid-rodriguez/remove-unnecessary-sleeps
...
Remove unnecessary explicit sleeps
2025-10-20 16:06:44 +11:00
Maikel
8105b919e0
Merge pull request #13600 from deivid-rodriguez/profile-enables-dev-caching
...
The PROFILE env variable should actually enable, not disable, caching
2025-10-20 16:03:20 +11:00
David Cook
53ef5148e9
Merge pull request #13617 from deivid-rodriguez/upgrade-cache-format-version
...
Upgrade cache format version
2025-10-20 15:41:52 +11:00
David Cook
93e6f9034c
Merge pull request #13602 from deivid-rodriguez/bump-mini_magick
...
Update mini_magick to a version that plays nice with imagemagick v7
2025-10-20 15:26:20 +11:00
David Cook
125a92346c
Merge pull request #13599 from deivid-rodriguez/fix-duplicate-key-warning
...
Fix duplicate keys warnings in some views
2025-10-20 15:21:40 +11:00
Gaetan Craig-Riou
31b8fe16cb
Merge pull request #13623 from deivid-rodriguez/follow-up-to-old-rename
...
Follow up to old ofnEmptiesCart to ofnChangeHub rename
2025-10-20 10:53:47 +11:00
Gaetan Craig-Riou
cbffea8d30
Merge pull request #13616 from openfoodfoundation/dependabot/bundler/state_machines-activerecord-0.31.0
...
Bump state_machines-activerecord from 0.9.0 to 0.31.0
2025-10-20 09:50:30 +11:00
Ahmed Ejaz
10917161b0
Refactor order cycle expiry handling to allow skipping order emptying during checkout
2025-10-20 01:42:20 +05:00
Guido Oliveira
be9da62d98
fix table format in edit order page
2025-10-19 07:58:40 -03:00
Ahmed Ejaz
9f6c149735
Add check for payment authorization state in StripeScaPaymentAuthorize and corresponding spec
2025-10-17 05:25:45 +05:00
David Rodríguez
50578647ee
Follow up to old ofnEmptiesCart to ofnChangeHub rename
...
This happened back in 2015 through
9c9051498b , but two places were missed.
One was a code comment so did not affect anything (other than confused
code readers I guess?). The other one did create a regression but was
later fixed by 18d966f0de in 2021.
2025-10-16 12:56:17 +02:00
David Rodríguez
a28f05fddc
Don't run reviewdog on pushes
...
As configured, it's meant to annotate PRs with linter errors (so you
don't have to skim through logs). So it does not make sense for pushes.
In fact, on pushes rubocop action is doing nothing, and prettier action
is failing with:
> reviewdog: this is not PullRequest build.
> sed: couldn't write 80 items to stdout: Broken pipe
2025-10-16 12:34:37 +02:00
David Rodríguez
d6c044fd5b
Remove unnecessary explicit sleeps
...
Capybara helpers already wait for the content to show up (and we already
have a default of 10 seconds configured), so I don't think waiting more is
actually the problem in these specs.
But if we wanted to wait more, I think it's better to pass the `:wait`
option to capybara matchers, because that's a "maximum waiting value"
but we'll still proceed earlier if the content shows up.
Using the same idea, I changed the positive assertions to happen first,
because negative assertions do spend "max wait time" waiting, while
positive assertions only wait until the content shows up.
2025-10-15 13:09:52 +02:00
David Rodríguez
a75ea5b506
Upgrade cache format version
...
It's supposed to be faster and more compact, and the previous format
will become unsupported in Rails 7.2 as per Rails boot warnings:
> DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.
>
> Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format
> for more information on how to upgrade.
> (called from <main> at /path/to/config/environment.rb:5)
2025-10-15 12:17:03 +02:00
dependabot[bot]
7f937fd4b1
Bump state_machines-activerecord from 0.9.0 to 0.31.0
...
Bumps [state_machines-activerecord](https://github.com/state-machines/state_machines-activerecord ) from 0.9.0 to 0.31.0.
- [Release notes](https://github.com/state-machines/state_machines-activerecord/releases )
- [Changelog](https://github.com/state-machines/state_machines-activerecord/blob/master/CHANGELOG.md )
- [Commits](https://github.com/state-machines/state_machines-activerecord/compare/v0.9.0...state_machines-activerecord/v0.31.0 )
---
updated-dependencies:
- dependency-name: state_machines-activerecord
dependency-version: 0.31.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-15 09:02:41 +00:00
David Rodríguez
667ce5eda2
Silence capybara starting puma during system specs
...
##### Before
```
$ bin/rspec spec/system/admin/order_cycles/simple_spec.rb:460
Running via Spring preloader in process 79308
Run options: include {:locations=>{"./spec/system/admin/order_cycles/simple_spec.rb"=>[460]}}
As an administrator
I want to manage simple order cycles
as an enterprise user
that is a manager of the coordinator
when variants are hidden via inventory settings
Capybara starting Puma...
* Version 6.5.0, codename: Sky's Version
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:51103
shows a warning when going to 'outgoing products' tab
Finished in 3.95 seconds (files took 0.45949 seconds to load)
1 example, 0 failures
```
##### After
```
$ bin/rspec spec/system/admin/order_cycles/simple_spec.rb:460
Running via Spring preloader in process 79234
Run options: include {:locations=>{"./spec/system/admin/order_cycles/simple_spec.rb"=>[460]}}
As an administrator
I want to manage simple order cycles
as an enterprise user
that is a manager of the coordinator
when variants are hidden via inventory settings
shows a warning when going to 'outgoing products' tab
Finished in 4.03 seconds (files took 0.49981 seconds to load)
1 example, 0 failures
```
2025-10-14 20:34:05 +02:00
David Rodríguez
c72f9477cd
bundle update mini_magick
...
This is mainly to shush a lot of warnings when running the test suite,
like the following:
```
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
```
2025-10-14 08:17:12 +02:00
David Rodríguez
8787eed863
The PROFILE env variable should actually enable, not disable, caching
...
I think this may be a typo from 6d8ddd1edac17a431222c86482bceb83e8a7d32f?
2025-10-14 08:03:15 +02:00
David Rodríguez
e2b6199f26
Fix duplicate keys warnings in some views
...
We're passing the `id` key twice, and with different value, resulting in
warnings like:
> /path/to/app/views/producers/index.html.haml:27: warning: key :id is duplicated and overwritten on line 31
Use only the latest value passed to remove the warning.
##### Before
```
$ bundle exec rspec -e "displays in an iframe" -e "logging in with a redirect set"
(...)
Run options: include {:full_description=>/(?-mix:displays\ in\ an\ iframe)|(?-mix:logging\ in\ with\ a\ redirect\ set)/}
Capybara starting Puma...
* Version 6.5.0, codename: Sky's Version
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:50292
/path/to/app/views/producers/index.html.haml:27: warning: key :id is duplicated and overwritten on line 31
./path/to/app/views/groups/show.html.haml:68: warning: key :id is duplicated and overwritten on line 72
Modal window with text `Unable to load map. Please check your browser settings and allow 3rd party cookies for this website.` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
.
Finished in 4.54 seconds (files took 4.04 seconds to load)
2 examples, 0 failures
```
##### After
```
$ bundle exec rspec -e "displays in an iframe" -e "logging in with a redirect set"
(...)
Run options: include {:full_description=>/(?-mix:displays\ in\ an\ iframe)|(?-mix:logging\ in\ with\ a\ redirect\ set)/}
Capybara starting Puma...
* Version 6.5.0, codename: Sky's Version
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:50256
.Modal window with text `Unable to load map. Please check your browser settings and allow 3rd party cookies for this website.` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
.
Finished in 4.17 seconds (files took 4.1 seconds to load)
2 examples, 0 failures
```
2025-10-14 07:58:32 +02:00