raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Showcase the problem with some specs

Browse Source 
They're always passing because an error (different from `StripeError`),
is actually making them pass.
This commit is contained in:
David Rodríguez
2025-10-21 03:57:47 +02:00
parent 7415503b63
commit 2bd536298b
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/lib/stripe/payment_intent_validator_spec.rb
View File

@@ -52,7 +52,10 @@ RSpec.describe Stripe::PaymentIntentValidator do
it "returns payment intent id and does not raise" do
expect {
result = validator.call
expect(result).to eq payment_intent_response_body
expect(result).to eq(
"this doesn't affect the spec because it never runs, due to a previous error." \
"Yet, since this is wrapper in a negative raise_error block, it still passes"
)
}.not_to raise_error Stripe::StripeError
end
@@ -196,7 +199,10 @@ RSpec.describe Stripe::PaymentIntentValidator do
it "returns payment intent id and does not raise" do
expect {
result = validator.call
expect(result).to eq payment_intent_response_body
expect(result).to eq(
"this doesn't affect the spec because it never runs, due to a previous error." \
"Yet, since this is wrapper in a negative raise_error block, it still passes"
)
}.not_to raise_error Stripe::StripeError
end