Maikel Linke
37441be371
Update translations
2023-05-19 14:33:23 +10:00
Maikel
0d403f4087
Merge pull request #10814 from Matt-Yorkley/serializer-eager-loading
...
Improve eager-loading on admin products page
2023-05-19 14:31:25 +10:00
Maikel
f943b411c5
Merge pull request #10823 from abdellani/fix-file-name-used-as-parameter
...
[Security] Validate product import file path
2023-05-19 14:28:09 +10:00
Maikel
7af14e37fa
Merge pull request #10488 from mkllnk/dfc-connector
...
Serialize DFC catalog items with DFC Connector
2023-05-19 11:31:23 +10:00
Filipe
3d1b0816ed
Merge pull request #10512 from abdellani/fix-tax-not-charged-when-tax-category-set-to-inherit-from-product
...
Prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-18 13:43:14 +01:00
Konrad
39bb1f6f41
Merge pull request #10832 from Matt-Yorkley/cloning
...
Clone all ExchangeVariant objects in bulk
2023-05-18 14:32:30 +02:00
David Cook
360a241402
Style fix
2023-05-18 10:07:52 +10:00
Filipe
0d23b63bbd
Merge pull request #10779 from dacook/10634-remove-admin_style_v2
...
10634 Remove admin_style_v2 feature
2023-05-17 15:37:05 +01:00
Konrad
19caadb1a0
Merge pull request #10800 from dacook/remove-localisation
...
Also remove localized number logic from weight calculator
2023-05-17 14:57:26 +02:00
David Cook
c0c123a92a
Remove localized number logic from weight calculator
...
Follow-on from a46eef291c
2023-05-17 14:10:58 +02:00
Konrad
f26bef5f98
Merge pull request #10813 from saunmanoj888/fix-fullname-search-issue-on-bulk-orders
...
Fix searching issue with full name on bulk order management
2023-05-17 13:58:04 +02:00
saunmanoj888
aee7645e29
Fix searching issue with full name on bulk order management
2023-05-17 13:14:10 +02:00
Konrad
02873d7596
Merge pull request #10817 from Matt-Yorkley/permissions-scoping
...
Scope orders before bulk actions
2023-05-17 12:44:07 +02:00
Matt-Yorkley
e1b0a03819
Scope orders before bulk actions
2023-05-17 12:03:40 +02:00
Maikel Linke
eaf3bd0bae
Update spec after new import file validation
2023-05-17 15:18:29 +10:00
Mohamed ABDELLANI
fcb8550cb1
extract file path sanitizer to an independent class
2023-05-17 15:09:48 +10:00
Mohamed ABDELLANI
4d5ba6a7e6
add file path validation
2023-05-17 15:09:48 +10:00
Maikel Linke
a0d05b26d1
Spec current product import vulnerabilities
...
I didn't use pending specs but deliberately passing specs on wrong
behaviour. This is not how it should be but how it is at the moment.
2023-05-17 15:09:01 +10:00
Konrad
4a66b62fa7
Merge pull request #10825 from jibees/10824-remove-feature-toggle-on-white-label-feature
...
Activate white label feature
2023-05-16 13:50:58 +02:00
Maikel
16329e953f
Merge pull request #10844 from openfoodfoundation/dependabot/npm_and_yarn/jasmine-core-5.0.0
...
Bump jasmine-core from 4.6.0 to 5.0.0
2023-05-16 17:50:39 +10:00
Maikel
10c918be75
Merge pull request #10732 from mkllnk/report-email
...
[Hidden] Notify about completed report with download link via email
2023-05-16 10:25:23 +10:00
Maikel
a979f7c8df
Merge pull request #10587 from rioug/10432-vouchers-bare-minimum-checkout
...
10432 vouchers bare minimum checkout
2023-05-16 09:19:06 +10:00
Maikel Linke
08aff56e20
Expire report files after 1 week, maximum for S3
...
We didn't see this in tests which use disk storage. But AWS S3 has a
maximum of one week for URL expiry.
2023-05-15 19:41:45 +02:00
Maikel Linke
5ae04a5a3e
Hide report link which only works at unknown time
...
It was bad UX to show a link that doesn't work straight away. At the
time, it was the only way to download the report but now we send an
email which is a much better way to go.
I leave the rest of the code because we want to implement a reflex which
shows the download link once it's ready.
2023-05-15 19:41:45 +02:00
Maikel Linke
299bc253a4
Expire report download links in a month, not 5mins
2023-05-15 19:41:45 +02:00
Maikel Linke
8a8c53ceee
Add ReportMailer preview for devs
2023-05-15 19:41:45 +02:00
Maikel Linke
860fe85af9
Add report download link to email notification
...
I added a system spec to verify that the download link can be generated
within the mailer in a background job. ActiveStorage is a bit particular
when it comes to genererating URLs and depending on the situation it may
generate a redirect URL, a proxy URL or link directly to the storage.
But we want a redirect URL here.
2023-05-15 19:41:45 +02:00
Maikel Linke
cf5a8a26ce
Notify only about slow reports
...
It would be annoying to get an email for reports which display on the
screen immediately.
2023-05-15 19:41:45 +02:00
Maikel Linke
1f4af7f990
Send (dummy) email when background report is done
...
I'll fill it out in future commits.
2023-05-15 19:41:45 +02:00
Jean-Baptiste Bellet
aaa9bac4dd
Remove white_label feature toggle
...
White label is now activated for everyone.
+ add mock for `spec/controllers/spree/orders_controller_spec.rb`
2023-05-15 17:10:50 +02:00
jibees
d43678c68b
Merge pull request #10827 from filipefurtad0/logging_out_spec
...
Adds test case for logging out
2023-05-15 15:33:56 +02:00
Jean-Baptiste Bellet
ec0cbc5bf9
Avoid warning by being more precise about *.erb files
2023-05-15 15:29:28 +02:00
jibees
a1e4c45daa
Merge pull request #10843 from openfoodfoundation/dependabot/bundler/rubocop-1.51.0
...
Bump rubocop from 1.50.2 to 1.51.0
2023-05-15 15:03:24 +02:00
jibees
edeedc0704
Merge pull request #10841 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.8
...
Bump @floating-ui/dom from 1.2.7 to 1.2.8
2023-05-15 15:02:22 +02:00
jibees
d2539b34e0
Merge pull request #10840 from openfoodfoundation/dependabot/bundler/rails-i18n-7.0.7
...
Bump rails-i18n from 7.0.6 to 7.0.7
2023-05-15 15:01:12 +02:00
jibees
fea3957481
Merge pull request #10845 from openfoodfoundation/dependabot/bundler/test-unit-3.5.8
...
Bump test-unit from 3.5.7 to 3.5.8
2023-05-15 15:00:03 +02:00
jibees
b183832fbb
Merge pull request #10842 from openfoodfoundation/dependabot/bundler/capybara-3.39.1
...
Bump capybara from 3.39.0 to 3.39.1
2023-05-15 12:22:59 +02:00
dependabot[bot]
8a352132a0
Bump test-unit from 3.5.7 to 3.5.8
...
Bumps [test-unit](https://github.com/test-unit/test-unit ) from 3.5.7 to 3.5.8.
- [Release notes](https://github.com/test-unit/test-unit/releases )
- [Commits](https://github.com/test-unit/test-unit/compare/3.5.7...3.5.8 )
---
updated-dependencies:
- dependency-name: test-unit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:55 +00:00
dependabot[bot]
0e59a5db91
Bump jasmine-core from 4.6.0 to 5.0.0
...
Bumps [jasmine-core](https://github.com/jasmine/jasmine ) from 4.6.0 to 5.0.0.
- [Release notes](https://github.com/jasmine/jasmine/releases )
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md )
- [Commits](https://github.com/jasmine/jasmine/compare/v4.6.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: jasmine-core
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:22 +00:00
dependabot[bot]
340fe91e07
Bump rubocop from 1.50.2 to 1.51.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.2 to 1.51.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.2...v1.51.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 10:00:15 +00:00
dependabot[bot]
6c126cfc33
Bump capybara from 3.39.0 to 3.39.1
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.39.0 to 3.39.1.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.0...3.39.1 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:59:19 +00:00
dependabot[bot]
82c6eaab4e
Bump @floating-ui/dom from 1.2.7 to 1.2.8
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.7 to 1.2.8.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.8/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:51 +00:00
dependabot[bot]
d4918893a7
Bump rails-i18n from 7.0.6 to 7.0.7
...
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n ) from 7.0.6 to 7.0.7.
- [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/svenfuchs/rails-i18n/compare/v7.0.6...v7.0.7 )
---
updated-dependencies:
- dependency-name: rails-i18n
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-15 09:57:24 +00:00
jibees
1e05bc5b5c
Merge pull request #10789 from jibees/10770-bom-cancelling-an-order-always-restocks-the-line-item
...
BOM: when deleting the last item of order that leads to order cancellation, take into account the restock items checkbox
2023-05-15 09:50:13 +02:00
Mohamed ABDELLANI
7f52684488
add check_calculators_compatibility_with_taxes before running enterprise bulk update
2023-05-15 07:35:52 +01:00
Gaetan Craig-Riou
5eb6097101
Fix error handling when creating a voucher adjustment
...
I wrongly assumed that `voucher.create_adjustment` would return nil
if failing to create an adjustment. I will in fact return an
adjustment object with errors.
2023-05-15 13:42:40 +10:00
David Cook
ccff3379ea
Update schema.rb
...
On a freshly mirrored prod db, I found these changes.
I don't know why.. but hopefully this is correct.
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
d29119f5c5
Remove non need belongs_to associations from Adjustments
...
It turns out the "tax_rate" association isn't used and wasn't working.
Same for the "voucher" one, which I added to be consistent with existing
code.
Both of these weren't caught by the specs because you can't test associations
with a custome relation with 'shouda-matchers' see: https://github.com/thoughtbot/shoulda-matchers/issues/981
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b67f5ae154
Fixing Rubocop issue
...
My editor automatically remove blank character on empty line, that's
why rubocop got grumpy here.
2023-05-15 13:42:40 +10:00
Matt-Yorkley
9b1725d39f
Fix model name in adjustment association
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
b80274f49d
Per review comment, Use named value on voucher submit button to distinguish between submission types
...
The voucher apply button is inside form that has another a submit button,
it leads to a weird situation where either one will submit the whole
payments page form. Adding a named parameter on the voucher apply button
means we can distinguish between the two by checking for the presence
of params[:apply_voucher].
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
92bcd937dc
Per review comment, remove form object from the partial
...
This partial is rendered inside another <form> element, nested form
don't work.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
0a249d7722
Fix ButtonEnableToggleController to remove hacky button disable
...
As per review comment, use data-disable-with="false" do prevent Rails
from automatically enabling the "Apply" button. We can then remove
the timeout hack.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
236f6926d9
Cleaning up left over TODOs
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
aa526a639c
Checkout payment page, enable voucher "apply" button when code entered
...
The "apply" button is disabled by default. If left enabled, a customer
could try to apply an empty voucher, which results in system trying
to move to the order summary step, an unexpected behaviour!
We only enable the button when something is entered in the input.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
e5f14177d3
Fix rubocop warning
...
I guess the new cops are effective :)
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
815dcbcefe
Fix translations
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
a2e1e6ca33
Review comment, use dig to access voucher_code param
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
2f1fe6d096
Fix rubocop warning
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
17e32a89f8
Add VoucherAdjustmentsService to handle calculation
...
Refactor Voucher to move voucher adjustments calculation
to VoucherAdjustmentsService
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
56e981d300
Refactor Voucher to get rid of CalculatedAdjustments
...
Voucher adjustment have complicated calculation that prevent us from
using Spree::Calculator, and we need to override CalculatedAdjustments
method, so no point using it.
We still keep the same methods to stay as consitent as possible in
regards to adjustments
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
3f37554ff9
Add VoucherAdjustmentsController and specs
...
Refactor split checkout to use the new controller. But unfortunately
we can't have nested form, so adding a voucher is still handled by
SplitCheckoutController.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
43ab881181
Rename order association to voucher_adjustments
...
The name vouchers is a bit confusing as the order is linked to a
voucher adjutment and not the actual voucher
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
fe9b94a80e
Fix cart disappearing bug after adding a voucher
...
The split checkout page uses `mrujs` and `CableCar` to set the form as
a remote one and perform `CableCar` operation if any : https://mrujs.com/how-tos/integrate-cablecar
The previous solution broke the cart handled by angularJS, it looks like
`morpdom` (https://mrujs.com/references/remote-forms-and-links Navigation Adapter section )
was doing something that angularJS didn't like when redirecting to
the current page.
With the power of `CableCar`, we now replace the #voucher-section on the
split checkout page instead of doing a redirect.
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
94294fa161
Voucher adjustment, add ordering by created_at
...
It gives us a consistent result when calling #vouchers
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
a1ad25f217
Fix failing specs
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
bb9d835bd8
Fix rubocop warning
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
87cc525d27
Refactor #vouchers
...
Use "has_many" instead of a method
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
4b5d6d7eac
Fix voucher adjustments association
...
Add missing, "inverse_of" and "dependent" options. Use :nullify as
for "dependent" because we would want to keep the adjustments on order
even if the voucher is deleted.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
58469adfeb
Adjustments spec, add association test
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
5064bf5383
Allow voucher adjustment to be created with an amount of 0
...
Although unlikely, we should still be able to create a voucher amount
with. This can happen if the order.total is for instance.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
9789911523
Rework how voucher are applied to an order and handle tax calculation
...
At the time when we can apply a voucher to an order (payment step) we
don't have any data on possible taxes and payment fees. These are
calculated when we move to the summary step. So voucher are applied in
two step:
- create an "open" voucher adjustment on the order when a customer enters
a voucher code.
- when we move to the summary step, recalulate the amount and
possible tax for the voucher adjustment, once taxes and payment fees
have been included in the order. And then close the original and update
order to reflect the changes
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
d157d91054
When voucher cover more than order total, use only amount needed
...
The checkout payment step will also show a warning.
The amount used is stored in the adjustment created, so we will be able
to track how much has been used down the line.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
3f609d3842
Add error message if adding a voucher fails
...
It's not really useful to the user but better than failing silently
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
596c775af6
Add controller spec to cover voucher in split checkout
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74e0b0f6b5
Add voucher adjustment loading to CheckoutCallbacks
...
This is needed so the voucher is loaded properly when the "checkout"
partials are render via cable_car.
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
74a8730f04
Highlight voucher on order summary step
2023-05-15 13:42:38 +10:00
Gaetan Craig-Riou
856386fcb0
SplitCheckoutController refactor add_voucher
...
Now all redirection/render_error happen in #update, it makes it
easier to understand.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
e487ed0532
Add link to remove voucher when a voucher has been applied
...
Improve styling to match the design
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
b6213b25e9
add acts_as_paranoid to voucher
...
This is so the relation
`belongs_to :originator, -> { with_deleted }, polymorphic: true`
setup in Spree::Adjustement works as expected.
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
a9d9b33f7d
First take at adding a voucher to an order
...
Use voucher.create_adjustment to add an adjustment to the order
Currently doesn't take into account tax part
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
3ec58d8791
Add #vouchers, return an array of voucher adjustments
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
9b680e1a92
Add CalculatedAdjustments to Voucher
...
Vouchers are only flat rate of 10 for now, so we add a FlatRate
calculator in a before_validation callback
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
f7ee01b9f8
Add voucher input on checkout payment's step
...
Voucher input is displayed only if the distributor has any voucher
2023-05-15 13:42:37 +10:00
Maikel
4f7059d0c7
Merge pull request #10838 from filipefurtad0/fix_negative_adjustment_error
...
Adds minus sign to validation criteria
2023-05-15 11:07:45 +10:00
Gaetan Craig-Riou
d715b6b3bb
Spec fix LocalisedNumber validation to allow negative number
...
As part of this PR https://github.com/openfoodfoundation/openfoodnetwork/pull/10329
LocalisedNumber validation was tightened, but that means negative number
were not valid anymore.
This commit has been cherry-picked after this fix has already been
applied. Now we just change the order of characters in the regex because
humans are used to reading the minus at the beginning of the number. But
this change doesn't change the logic at all.
2023-05-15 10:55:59 +10:00
Maikel
5045e26792
Merge pull request #10834 from mkllnk/variant-spec
...
Improve readability and performance of variant spec
2023-05-15 09:48:06 +10:00
filipefurtad0
0442f2da7e
Fixes spec warning
...
An example was being ignored due to legacy syntax - WARNING: ignoring the provided expectation message argument since it is not a string or a proc.
2023-05-14 23:02:44 +01:00
filipefurtad0
e7ab839fb3
Adds minus sign as validation criteria
...
Removes pending from passing examples
2023-05-14 23:02:44 +01:00
filipefurtad0
596b318778
Adds spec on negative adjustment
...
with different localization settings
Using shared examples and setting failing
ones as pending
2023-05-14 23:02:00 +01:00
Filipe
3c7337b53a
Merge pull request #10836 from jibees/10835-on-small-width-screen-the-cart-element-is-missplaced
...
Fix bad indentation (and hierarchy) of DOM elements causing bad rendering on small width screens
2023-05-12 11:24:49 +01:00
Jean-Baptiste Bellet
60edb4363e
Fix bad indentation (and hierarchy)
...
`%section` must be siblings each others
introduced by https://github.com/openfoodfoundation/openfoodnetwork/pull/10772
2023-05-12 09:30:37 +02:00
Maikel Linke
6596225a99
Fix typo in VCR cassette name
2023-05-12 14:48:00 +10:00
Maikel Linke
87c4c5373b
Spec more variant naming with realistic data
2023-05-12 14:10:54 +10:00
Maikel Linke
f70607259a
Spec Variant#product_and_full_name with real data
...
Mocking skips a lot of code execution which we want to test as well.
2023-05-12 13:34:34 +10:00
Maikel Linke
ce180caad9
Test with in-memory data when possible
...
This should speed up specs but I observed only one second less run time.
2023-05-12 13:21:58 +10:00
Maikel Linke
01be934caf
Reduce spec run time by not creating unused subject
...
The `variant` instance isn't used in all specs and doesn't need to be
created every time. This reduced run time from 1min5sec to 43sec on my
machine.
2023-05-12 13:21:58 +10:00
Maikel Linke
54c6559b97
Move Spree::Variant spec out of Spree module
...
I also discovered that some specs were just in the Spee module and not
within the `describe Variant` block. I moved them inside the block.
2023-05-12 13:21:19 +10:00
Maikel
93c0a06403
Merge pull request #10829 from filipefurtad0/flaky_order_spec_error
...
Splits assertions to allow JS table populate
2023-05-12 11:49:06 +10:00
Maikel Linke
636b365304
Tell Rubocop and devs about bulk insert
2023-05-12 10:30:47 +10:00
Jean-Baptiste Bellet
51d6fb81dd
Fwd to request the restock_items input value when adjusting items qty
2023-05-11 22:58:44 +02:00
Jean-Baptiste Bellet
f679d8733e
Pass the restock_items params to each methods and request call
...
+ update spec to test whether the restock item checkbox is checked or not.
2023-05-11 22:58:44 +02:00
Matt-Yorkley
b139087c5f
Clone ExchangeVariant objects in bulk
...
An ExchangeVariant is a simple representation of a join table between Exchange and Variant. Previously this code was triggering an additional INSERT query for every variant added to the newly cloned exchange. Some exchanges have ~3000 variants! The code now creates them in bulk in a single INSERT statement. When cloning large order cycles this can improve performance by ~1000% or so.
2023-05-11 20:51:20 +01:00
Filipe
1bdb668cd3
Merge pull request #10769 from Matt-Yorkley/visible-line-items-query
...
Improve `Permissions::Order#visible_line_items` querying
2023-05-11 15:36:32 +01:00
filipefurtad0
d035d4bb87
Update all locales with the latest Transifex translations
2023-05-11 15:25:39 +01:00
Mohamed ABDELLANI
6771d2e7be
test enterprise fees creation with tax category inheritance flag
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
a22fe9f948
fix existing invalid enterprise fees
2023-05-11 12:46:17 +01:00
Maikel Linke
25b7f1749c
Simplify error when tax rate can't be inherited
...
I changed the text to focus on the resolution: the user needs to choose
a tax category or a different calculator.
I associated the error to the model to prevent the attribute name from
being included in the error message. Alternatively, we could have
changed the name of the attribute to match the UI. But this error
affects the combination of two attributes, none of them is invalid on
its own.
I'm using Rails' default lazy lookup for error messages which results in
shorter code and a standard structure.
I also added a simple spec.
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
89eb3a1967
fix existing tests
2023-05-11 12:46:17 +01:00
Mohamed ABDELLANI
7eca32e84f
prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-11 12:46:17 +01:00
filipefurtad0
f5eb72c804
Adds sleep(1)
2023-05-11 11:29:24 +01:00
Konrad
2836751698
Merge pull request #10805 from jibees/10717-bo-orders-changing-customer-does-not-update-customer_id
...
Admin, Edit customer details for an order: when changing to another customer, update `customer_id` as well
2023-05-10 19:08:57 +02:00
Filipe
bf7a559a32
Merge pull request #10772 from Matt-Yorkley/view-caching
...
Locale-aware Fragment Caching
2023-05-10 11:18:08 +01:00
filipefurtad0
82f307ae61
Adds test case for logging out
2023-05-10 10:41:43 +01:00
Matt-Yorkley
d90653c682
Merge pull request #10793 from jibees/fix-webpack-configuration-use-the-default-one
...
Use the default webpack configuration for dev env
2023-05-10 10:09:28 +01:00
jibees
ca5300284c
Merge pull request #10820 from Matt-Yorkley/js-dependencies
...
Remove indirect JS dependencies
2023-05-10 09:57:05 +02:00
Matt-Yorkley
406cb572ea
Remove indirect JS dependencies
2023-05-10 09:27:00 +02:00
jibees
ca90b5cee2
Merge pull request #10810 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.122.0
...
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
2023-05-10 09:23:44 +02:00
jibees
760860a06d
Merge pull request #10811 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.11.0
...
Bump knapsack_pro from 3.10.0 to 3.11.0
2023-05-10 09:21:46 +02:00
jibees
189207f751
Merge pull request #10822 from openfoodfoundation/dependabot/bundler/debug-1.8.0
...
Bump debug from 1.7.2 to 1.8.0
2023-05-10 09:20:34 +02:00
Matt-Yorkley
1bd9182cea
Update menu cache blocks
2023-05-09 16:46:09 +01:00
David Cook
04a5c7452e
Remove admin_style_v2 description
...
Partially reverts 9a1b1498bf
2023-05-09 21:26:47 +10:00
David Cook
e29df5ea8f
Remove unused secondary class
...
This partially reverts 97c3aaebb2 because it referred to the new feature toggle which has been removed.
2023-05-09 21:26:47 +10:00
David Cook
3ec659d82b
Revert pull #10025
...
[WIP 🚧 ] Admin, behind feature toggle admin_style_v2: adjust some colors
This reverts commits 60f0a58508ce77666fa96c73d76dc0620f23daaf~1..09bcc772ff089f911a56bb
2023-05-09 21:26:47 +10:00
David Cook
be70cd7893
Revert pull #10054
...
[WIP 🚧 ] Admin/Orders, behind feature toggle admin_style_v2: adjust colors
This reverts commits 5cab0f7f3d495daaeb97fd786208a24355b630fe..4ef5609b0eb08fe7e48803de166ae3e979103c1b
2023-05-09 21:26:47 +10:00
David Cook
0ff540e1e3
Revert pull #10080
...
[WIP 🚧 ] Admin - Order edition, behind feature toggle admin_style_v2: adjust colors
This reverts commits faf106b2824f248812f523c10b688bd9b254dc14..74b618230ff736ac7929246e2c83ed95067a4dd0
2023-05-09 21:25:29 +10:00
David Cook
c21ff075de
Revert pull #10131
...
[WIP 🚧 ] /admin/order_cycles behind feature toggle admin_style_v2
This reverts commits ccfc632149f062fca546784c7c2f14708d91a08e~1..e403a2c174def34cfa115eab038c86923482bfbf
2023-05-09 21:24:25 +10:00
dependabot[bot]
969d0b6687
Bump debug from 1.7.2 to 1.8.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-09 10:03:20 +00:00
Maikel Linke
3c6f55732d
Add dummy product type to DFC export
2023-05-09 17:01:00 +10:00
Maikel Linke
b2e8af0cd1
Add stock to DFC Offer as well
2023-05-09 16:51:26 +10:00
Maikel Linke
c81230d334
Add old DFC API name for prototype compatibility
2023-05-09 16:51:26 +10:00
Maikel Linke
54137067dd
Export variant's display_name if present
...
The `#name` method is simply delegated to a variant's product.
2023-05-09 16:51:26 +10:00
Maikel Linke
0c5ab783ca
Update DFC API route to reflect Connector version
2023-05-09 16:51:26 +10:00
Maikel Linke
80edc44ef5
Replace SuppliedProductSerializer with DFC Connector
...
And remove the BaseSerializer because this was the last serializer.
2023-05-09 16:51:26 +10:00
Maikel Linke
0b808a4b1e
Add product quantity to DFC export
2023-05-09 16:51:26 +10:00
Maikel Linke
1e23cf1c92
Replace EnterpriseSerializer with DFC Connector
...
And move same test coverage to a new builder spec.
2023-05-09 16:51:26 +10:00
Maikel Linke
683ad0f5b9
Replace PersonSerializer with DFC Connector
...
And the address serializer was just an empty placeholder.
2023-05-09 16:51:26 +10:00
Maikel Linke
c60d622818
List catalog items with DFC Connector
2023-05-09 16:51:25 +10:00
Maikel Linke
7f8ce08d4e
Include DFC Offer in the export with valid id
2023-05-09 16:51:25 +10:00
Maikel Linke
78cf3b5a1d
Serialize DFC catalog item with DFC Connector
...
This is work in progress. The DFC Connector uses a more recent DFC
version and other endpoints still use the old serializers. We need to
update those endpoints as well and update the version number in the API
URL.
2023-05-09 16:51:25 +10:00
Maikel Linke
5187201796
Add DFC vocabularies
...
- Add a script for downloading updated files.
- Add a service for easier loading of vocab files.
2023-05-09 16:51:25 +10:00
Maikel Linke
352c350840
Add gem datafoodconsortium-connector
...
We hope that replacing our own JSON generation with this gem will reduce
maintenance. Same for parsing DFC input.
2023-05-09 16:51:25 +10:00
David Cook
8fe20ecfbe
Merge pull request #10794 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.8
...
Bump @babel/core from 7.21.5 to 7.21.8
2023-05-09 16:37:42 +10:00
Maikel
83141ec05c
Merge pull request #10818 from mkllnk/schema-order
...
Fixup order of statements in db schema
2023-05-09 14:21:03 +10:00
Matt-Yorkley
4b707b9310
Extract locale file digest logic to a separate class and add tests
2023-05-08 14:09:00 +01:00
Matt-Yorkley
1c277e5547
Cache some html fragments
2023-05-08 14:07:50 +01:00
Matt-Yorkley
be48a6c295
Implement cache_with_locale helper for fragment caching with locales
2023-05-08 14:07:50 +01:00
Matt-Yorkley
11f45dc2f8
Give ContentConfig an updated_at attribute and a usable cache_key
2023-05-08 14:07:50 +01:00
Konrad
4303cabe56
Merge pull request #10792 from mkllnk/feature-deletion
...
Remove unknown (deleted) feature toggles at boot
2023-05-08 14:49:42 +02:00
Maikel Linke
f1f3ecc4f7
Fixup order of statements in db schema
...
It looks like the resolution of a merge conflict introduced the wrong
ordering of schema statements. Rails wants to sort tables alphabetically
and running `./bin/rails db:migrate` on a fresh database altered the
schema.rb file. This should be fixed here.
Rails also omits the default setting of `precision: 6` since Rails 7.
The vouchers feature was developed during the upgrade to Rails 7.
2023-05-08 14:37:33 +10:00
Maikel
ad033e8d44
Merge pull request #10767 from Matt-Yorkley/remove-session-cookie-upgrader
...
Remove SessionCookieUpgrader from middleware
2023-05-08 12:50:42 +10:00
Gaetan Craig-Riou
f25a3650bd
Merge pull request #10802 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.1
...
Bump ddtrace from 1.11.0 to 1.11.1
2023-05-08 11:45:07 +10:00
Konrad
e4d8dd9f87
Merge pull request #10780 from dacook/enable-prettier-css
...
Enable prettier for Admin SCSS
2023-05-06 18:24:58 +02:00
Matt-Yorkley
1995a44848
Improve eager-loading on admin products page adn resolve issue with serializer
...
For some reason eager-loaded data isn't passed to nested serializers when using associations. Defining the association as a method and passing in some optional paramaters resolves the issue.
This reduces queries run by the controller action by around 75%, as well as the response times.
2023-05-06 17:15:27 +01:00
dependabot[bot]
b29d38f3fb
Bump knapsack_pro from 3.10.0 to 3.11.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.10.0 to 3.11.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.10.0...v3.11.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 10:01:08 +00:00
dependabot[bot]
1c52fe1648
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.121.0 to 1.122.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 09:59:02 +00:00
David Cook
a170b93cc1
Simplify further
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-05 15:34:23 +10:00
Maikel Linke
2a943ecafb
Spec setting up all feature toggle names
2023-05-05 11:09:10 +10:00
Jean-Baptiste Bellet
3a1579104f
Submit customer_id as params when updating customer details on order
2023-05-04 16:40:58 +02:00
jibees
ec4c7b79bf
Merge pull request #10803 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.2
...
Bump rspec-rails from 6.0.1 to 6.0.2
2023-05-04 13:55:37 +02:00
dependabot[bot]
9f12295a89
Bump rspec-rails from 6.0.1 to 6.0.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:54 +00:00
dependabot[bot]
46fd6b1a3a
Bump ddtrace from 1.11.0 to 1.11.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:25 +00:00
Jean-Baptiste Bellet
8a5608435c
Update all locales with the latest Transifex translations
2023-05-03 17:30:48 +02:00
Konrad
d02d0b8847
Merge pull request #10763 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.0
...
Bump ddtrace from 1.10.1 to 1.11.0
2023-05-03 17:27:13 +02:00
Konrad
4b6ef7796e
Merge pull request #10762 from mkllnk/report-encoding
...
Preserve encoding of stored reports
2023-05-03 17:08:44 +02:00
Konrad
b60a6fbd05
Merge pull request #10329 from thejwuscript/9861-improve-input-validation
...
Improve input validation on new and edit Payment Method pages
2023-05-03 16:11:21 +02:00
jibees
2e267091f6
Merge pull request #10795 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.10.0
...
Bump knapsack_pro from 3.9.0 to 3.10.0
2023-05-03 14:31:11 +02:00
dependabot[bot]
eb3fe1b7a5
Bump knapsack_pro from 3.9.0 to 3.10.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.9.0...v3.10.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 10:06:11 +00:00
dependabot[bot]
61f34a23a7
Bump @babel/core from 7.21.5 to 7.21.8
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.5 to 7.21.8.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.8/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 09:57:57 +00:00
Jean-Baptiste Bellet
2d7356f2bb
Use the default webpack configuration for dev env
...
We used to override the output filename but this was a misunderstanding of an error (due to webpacke(r) incompatibles versions)
https://medium.com/@web_developer/hash-vs-chunkhash-vs-contenthash-e94d38a32208
https://github.com/webpack/webpack.js.org/issues/2096
Context: https://github.com/openfoodfoundation/openfoodnetwork/pull/10631#pullrequestreview-1410083331
2023-05-03 10:10:17 +02:00
jibees
62c2d9a290
Merge pull request #10782 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.0
...
Bump sidekiq from 7.0.9 to 7.1.0
2023-05-03 09:56:07 +02:00
jibees
a329aab007
Merge pull request #10774 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.5
...
Bump @babel/core and @babel/preset-env from 7.21.4 to 7.21.5
2023-05-03 09:26:10 +02:00
Maikel Linke
e24198fe85
Bump @babel/preset-env from 7.21.4 to 7.21.5
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-preset-env )
I did this manually:
```
$ yarn upgrade "@babel/preset-env"
yarn upgrade v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > stimulus_reflex@3.5.0-rc2" has unmet peer dependency "@hotwired/stimulus@>= 3.0".
[4/4] Rebuilding all packages...
success Saved lockfile.
success Saved 35 new dependencies.
info Direct dependencies
└─ @babel/preset-env@7.21 .5
info All dependencies
├─ @babel/code-frame@7.21 .4
├─ @babel/helper-builder-binary-assignment-operator-visitor@7.21 .5
├─ @babel/helper-function-name@7.21 .0
├─ @babel/helper-module-imports@7.21 .4
├─ @babel/helper-replace-supers@7.21 .5
├─ @babel/helper-string-parser@7.21 .5
├─ @babel/helper-wrap-function@7.20 .5
├─ @babel/highlight@7.18 .6
├─ @babel/parser@7.21 .5
├─ @babel/plugin-transform-arrow-functions@7.21 .5
├─ @babel/plugin-transform-computed-properties@7.21 .5
├─ @babel/plugin-transform-for-of@7.21 .5
├─ @babel/plugin-transform-modules-commonjs@7.21 .5
├─ @babel/plugin-transform-regenerator@7.21 .5
├─ @babel/plugin-transform-unicode-escapes@7.21 .5
├─ @babel/preset-env@7.21 .5
├─ @babel/regjsgen@0.8.0
├─ @babel/template@7.20 .7
├─ @babel/traverse@7.21 .5
├─ @jridgewell/resolve-uri@3.1.0
├─ color-convert@1.9.3
├─ escape-string-regexp@1.0.5
├─ is-core-module@2.12 .0
├─ js-tokens@4.0.0
├─ jsesc@2.5.2
├─ ms@2.1.2
├─ regenerate-unicode-properties@10.1.0
├─ regenerator-runtime@0.13.11
├─ regexpu-core@5.3.2
├─ regjsparser@0.9.1
├─ to-fast-properties@2.0.0
├─ unicode-canonical-property-names-ecmascript@2.0.0
├─ unicode-match-property-ecmascript@2.0.0
├─ unicode-match-property-value-ecmascript@2.1.0
└─ unicode-property-aliases-ecmascript@2.1.0
Done in 16.54s.
```
2023-05-03 15:33:57 +10:00
Maikel Linke
b30e962cdd
Remove unknown (deleted) feature toggles at boot
2023-05-03 15:20:26 +10:00
Maikel Linke
5f1f717974
Spec FeatureToggle.setup!
2023-05-03 15:02:08 +10:00
Maikel Linke
b6f2fe0e92
Avoid defining modules in specs
...
We avoid some indent and show how code outside of the module works.
2023-05-03 14:58:59 +10:00
dependabot[bot]
a9bf7a2498
Bump @babel/core from 7.21.4 to 7.21.5
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.4 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-03 12:18:41 +10:00
David Cook
e11518938f
Prettify admin components scss
...
Largely whitespace, but some other updates too, including uppercase colour codes and standardising numbers.
Best viewed with whitespace ignored.
2023-05-03 12:10:58 +10:00
David Cook
c4dc5e0718
Prettier: use double quotes by default
...
Unfortunately Prettier won't let you do one rule at a time (https://stackoverflow.com/q/63813336/421243 ), so I'll break it into file chunks.
2023-05-03 12:10:58 +10:00
David Cook
c67d61a376
Don't ignore admin scss for prettying
...
...and watch the changes flow in!
2023-05-03 12:09:22 +10:00
David Cook
0b4556e72b
Allow line length up to 100char
...
Same as we have for Ruby code: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/.rubocop_styleguide.yml#L78-L80
This will avoid unnecessary reformatting.
2023-05-03 12:09:22 +10:00
David Cook
8c7f92d42e
Explicitly ignore each css folder
...
With the goal to progressively un-ignore them.
2023-05-03 12:09:22 +10:00
Konrad
21a0017352
Merge pull request #10756 from jibees/10743-admin-add-unregistered-users-modal-some-html-is-rendered-as-plain-text-instead-of-being
...
Admin, Add unregistered user: Fix a reflex-morph issue that lead to a HTML escaping error
2023-05-02 19:28:48 +02:00
Konrad
d115c4ce2c
Merge pull request #10733 from jibees/9782-shops-list-overlapping-and-overflowing-texts-on-mobile2
...
Shops list: fix some overlapping and overflowing texts on mobile
2023-05-02 12:15:19 +02:00
dependabot[bot]
b05d46c3e3
Bump sidekiq from 7.0.9 to 7.1.0
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.9 to 7.1.0.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.9...v7.1.0 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-02 09:57:28 +00:00
jibees
aae0fc59fb
Merge pull request #10768 from Matt-Yorkley/query-logs
...
Improve query logging in development
2023-05-02 11:44:19 +02:00
Gaetan Craig-Riou
d1f7cc1b2a
Merge pull request #10764 from Matt-Yorkley/remove-data-hooks
...
Remove `data-hook` attributes
2023-05-02 16:35:46 +10:00
Gaetan Craig-Riou
964481f188
Merge pull request #10765 from Matt-Yorkley/update-webpack-packages
...
Update webpack packages
2023-05-02 15:19:37 +10:00
Maikel
9bca22ae3b
Merge pull request #10775 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.2
...
Bump mini_portile2 from 2.8.1 to 2.8.2
2023-05-02 11:54:37 +10:00
dependabot[bot]
064c843c90
Bump mini_portile2 from 2.8.1 to 2.8.2
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.1...v2.8.2 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-01 10:02:13 +00:00
Maikel
482d438ec9
Merge pull request #10766 from filipefurtad0/remove_asertion_on_js_element_loading_orders
...
Removes assertions on transient JS element - "Loading orders"
2023-05-01 13:36:44 +10:00
Maikel Linke
9f0a66659a
Delete now unused SessionCookieUpgrader
2023-05-01 13:35:52 +10:00
Konrad
1176ea2a5f
Merge pull request #9941 from basilawwad/conditionally-send-cancellation-email
...
Conditionally send cancellation email when cancelling order.
2023-04-28 21:54:42 +02:00
Matt-Yorkley
dfc651ed2c
Convert Permissions::Order#visible_line_items to a relation with or query
...
This change looks innocuous but the result of converting this into a nice relation instead of two queries stuck together with the pipe operator (|) can make a huge difference when chaining this into subqueries. The result set is ultimately the same, but the queries can be built without first returning all the ids and then sticking those ids in an array.
2023-04-28 19:13:22 +01:00
Matt-Yorkley
f42a9e3a66
Add query_count gem in development
...
A very simple gem that counts the total number of queries triggered by each request and displays a little number in the log. Nice.
2023-04-28 15:02:02 +01:00
Matt-Yorkley
8d9a8d8db5
Enable verbose query logs in development
...
This is a new feature in Rails 7. Whenever a query is triggered it not only show you the query (as before), but also tells you (directly in the logs) exactly which line of code was responsible for triggering the query. It's unbelievably useful for debugging and performance work.
2023-04-28 14:35:16 +01:00
Matt-Yorkley
84df1bfeab
Remove SessionCookieUpgrader from middleware
...
This was a transitional bit of code to allow us to rename our session cookies without killing active sessions and logging users out. It's done it's job, the transition is finished, and it isn't doing anything useful now. It can be removed from the middleware stack.
2023-04-28 14:01:15 +01:00
Matt-Yorkley
b9431cd121
Remove data-hook attributes
2023-04-28 13:03:13 +01:00
filipefurtad0
74d18fb6ff
Removes assertions on transient JS element
2023-04-28 12:48:59 +01:00
Matt-Yorkley
5e26e49764
Update webpack packages
...
`webpack-cli` is a dependency of `@rails/webpacker` but needs to be at version 3.x, we can just cut it from the explicit dependecy list and the correct version will be installed.
`webpack-dev-server` version 3.x corresponds (unhelpfully) to `webpacker` 4.x, and needs to be left that way. Dependabot tries to change it occasionally, but it should not be updated to 4.x
2023-04-28 12:48:21 +01:00
dependabot[bot]
c9dada4215
Bump ddtrace from 1.10.1 to 1.11.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.10.1 to 1.11.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.10.1...v1.11.0 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-28 10:00:28 +00:00
Maikel Linke
630169f8bb
Preserve encoding of stored reports
...
Active Storage reads stored strings as ASCII and that can clash with
Rails' default UTF-8 encoding when special characters are present.
2023-04-28 16:38:06 +10:00
Gaetan Craig-Riou
152af5e105
Merge pull request #10751 from mkllnk/mail-config
...
Remove unused feature to intercept emails
2023-04-28 16:28:41 +10:00
David Cook
918425fd93
Remove customised error message
...
We're now handling these values on the frontend, so can keep this simple.
fixes up:
Add numericality validation for *
Add translation for Active Record error message
2023-04-28 14:02:12 +10:00
David Cook
a46eef291c
Remove localized number logic from calculators
...
The browser is now responsible for dealing with the decimal separator, for all numeric preferences (as input[type=number]; see Spree::Admin::BaseHelper::preference_field_tag). Calculators are the only place that numeric preferences are used.
It will enforce that only one comma or dot (depending on user's locale) is entered, thus avoiding any ambiguity, and mis-interpretation (eg 100,001 could be interpreted as more than 100 thousand or 100 with a decimal place).
2023-04-28 13:54:16 +10:00
David Cook
d2fbb0bde2
Update translations
...
js: admin: orders: order_state: confirmation
2023-04-27 14:49:28 +10:00
David Cook
c42dfdde10
Merge pull request #10748 from openfoodfoundation/dependabot/bundler/view_component-3.0.0
...
Bump view_component from 2.82.0 to 3.0.0
2023-04-27 14:46:09 +10:00
Jean-Baptiste Bellet
959dcb82e1
Morph the form itself instead of morphing a parent DOM element
...
This seems to avoid HTML parsing error
2023-04-26 17:41:28 +02:00
jibees
51d5817665
Merge pull request #10755 from openfoodfoundation/dependabot/bundler/i18n-1.13.0
...
Bump i18n from 1.12.0 to 1.13.0
2023-04-26 15:45:59 +02:00
jibees
a8384b3155
Merge pull request #10754 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.7
...
Bump @floating-ui/dom from 1.2.6 to 1.2.7
2023-04-26 15:44:04 +02:00
Konrad
394bfd00d8
Merge pull request #10586 from jibees/10563-allow-custom-url-on-logo-click
...
White Label: can link an URL to the white label logo
2023-04-26 13:52:10 +02:00
dependabot[bot]
bda1a527d3
Bump i18n from 1.12.0 to 1.13.0
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.12.0...v1.13.0 )
---
updated-dependencies:
- dependency-name: i18n
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:48 +00:00
dependabot[bot]
77bd832dd6
Bump @floating-ui/dom from 1.2.6 to 1.2.7
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.7/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 09:57:09 +00:00
Jean-Baptiste Bellet
b1de28eeea
When there is a white_label_logo_link pref. use it!
...
+ update spec as well
+ use an an helper to get the main logo link for a shopfront
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
679fcc0114
When removing the logo, also delete white_label_logo_link preference
...
since it has no sense without the logo
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
35778ecf1d
If enterprise has a white_label_logo attached, then can edit its link
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
70a6e9f44b
Add a white_label_logo_link attribute to enterprise model
2023-04-26 11:04:47 +02:00
Jean-Baptiste Bellet
30ba29382a
Avoid name collision by renaming some classes with a prefix flex-
...
This classes should only be used with `.flex`
2023-04-26 09:52:24 +02:00
Jean-Baptiste Bellet
9584205a8e
Use .flex class in utilities.scss file
...
No need to have multiple definition as already included
2023-04-26 09:51:28 +02:00
Jean-Baptiste Bellet
3644dbc0fd
Small fix of a prettier formatter error
2023-04-26 09:51:17 +02:00
Jean-Baptiste Bellet
05a7276c9c
Create an utilities.scss file that contains some utility classes
...
Finally Tailwind is coming? ;)
2023-04-26 09:47:23 +02:00
David Cook
1fc60d498a
Merge pull request #10746 from openfoodfoundation/dependabot/bundler/rswag-specs-2.9.0
...
Bump rswag-specs from 2.8.0 to 2.9.0
2023-04-26 14:08:30 +10:00
Maikel Linke
dae8703b02
Remove unused feature to intercept emails
...
This option came from Spree and we never used it. The config input field
is disabled in the admin interface and I checked our managed databases.
I don't think that we will want this feature in the future either.
Staging sends unmodified emails which is more realistic and we haven't
had a use case to intercept those emails. There's still the BCC option
if we need additional access.
2023-04-26 13:50:31 +10:00
Maikel
3078c599f9
Merge pull request #10747 from openfoodfoundation/dependabot/bundler/rswag-ui-2.9.0
...
Bump rswag-ui from 2.8.0 to 2.9.0
2023-04-26 12:04:09 +10:00
dependabot[bot]
5d91ac217d
Bump rswag-specs from 2.8.0 to 2.9.0
...
Bumps [rswag-specs](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-specs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-26 02:03:53 +00:00
Maikel
f2edb6d404
Merge pull request #10745 from openfoodfoundation/dependabot/bundler/rswag-api-2.9.0
...
Bump rswag-api from 2.8.0 to 2.9.0
2023-04-26 12:02:38 +10:00
David Cook
7cd1b5d5db
Update link
...
The old project was closed in favour of a new one.
2023-04-26 09:44:58 +10:00
dependabot[bot]
ad82f66173
Bump rswag-api from 2.8.0 to 2.9.0
...
Bumps [rswag-api](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 10:10:17 +00:00
dependabot[bot]
62bfa9e04c
Bump view_component from 2.82.0 to 3.0.0
...
Bumps [view_component](https://github.com/viewcomponent/view_component ) from 2.82.0 to 3.0.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases )
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/viewcomponent/view_component/compare/v2.82.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:51 +00:00
dependabot[bot]
28c9d72342
Bump rswag-ui from 2.8.0 to 2.9.0
...
Bumps [rswag-ui](https://github.com/rswag/rswag ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/rswag/rswag/releases )
- [Changelog](https://github.com/rswag/rswag/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rswag/rswag/compare/2.8.0...2.9.0 )
---
updated-dependencies:
- dependency-name: rswag-ui
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 09:38:22 +00:00
jibees
7317d6ca34
Merge pull request #10742 from filipefurtad0/fix_broken_build
...
Considers recent changes on login test helpers
2023-04-25 11:36:56 +02:00
filipefurtad0
edb8da4b4d
Considers recent changes on login test helpers
...
PR #10696 introduced changes on the login helpers which were not considered, when merging a recent PR; This broke the build
2023-04-24 18:35:10 +01:00
Konrad
00d5bd9165
Merge pull request #10684 from MadisonBowron/master
...
Fix admin product variants form to close issues #10579 & Wishlist: 430
2023-04-24 18:18:01 +02:00
Jean-Baptiste Bellet
1730c9eb60
Fix one warning: Modal window with text has been opened, ...
...
```
Modal window with text `An invoice for this order will be sent to the customer. Are you sure you want to continue?` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
```
2023-04-24 15:18:35 +02:00
Jean-Baptiste Bellet
5b9815f4a3
Test that restock has been called or not, depending on checkbox checked
2023-04-24 15:03:14 +02:00
jibees
445eb45ad7
Merge pull request #10737 from openfoodfoundation/dependabot/npm_and_yarn/prettier-2.8.8
...
Bump prettier from 2.8.7 to 2.8.8
2023-04-24 14:43:20 +02:00
jibees
8770471ada
Merge pull request #10738 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.4.2
...
Bump karma from 6.4.1 to 6.4.2
2023-04-24 14:43:07 +02:00
dependabot[bot]
6d45940ca4
Bump karma from 6.4.1 to 6.4.2
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.4.1 to 6.4.2.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.4.1...v6.4.2 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:22 +00:00
dependabot[bot]
69383ac621
Bump prettier from 2.8.7 to 2.8.8
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.8.7 to 2.8.8.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.8.7...2.8.8 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-24 09:58:05 +00:00
Maikel
945cb84127
Merge pull request #10683 from filipefurtad0/update-the-build-env-to-ubuntu-2204
...
Updates build environment to Ubuntu 22.04
2023-04-24 15:27:05 +10:00
Maikel
343a2db1bf
Merge pull request #10722 from mkllnk/rubocop-autocorrect-script
...
Add script for bulk autocorrect with Rubocop
2023-04-24 10:58:43 +10:00
Maikel Linke
de8f5e13b3
Explain gotcha in case it breaks one day
2023-04-24 09:39:21 +10:00
Konrad
75b5d1fd6f
Merge pull request #10712 from jibees/6133-backoffice-orders-endless-spinner-and-error-500-after-skipping-oc-selector
...
Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step)
2023-04-22 16:04:15 +02:00
Konrad
0c1606e50c
Merge pull request #10728 from jibees/10718-missing-translation-confirmation-order-state
...
Admin, `/orders`: adds translation for order in `confirmation` state
2023-04-22 11:56:23 +02:00
jibees
fa05554f15
Merge pull request #10734 from openfoodfoundation/dependabot/npm_and_yarn/karma-chrome-launcher-3.2.0
...
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
2023-04-21 14:13:19 +02:00
Jean-Baptiste Bellet
2cc509de15
Do not check Metrics/BlockLength for shared_examples_for block
...
They can contains a lot of `it` tests
2023-04-21 11:59:24 +02:00
dependabot[bot]
41afad73e4
Bump karma-chrome-launcher from 3.1.1 to 3.2.0
...
Bumps [karma-chrome-launcher](https://github.com/karma-runner/karma-chrome-launcher ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/karma-runner/karma-chrome-launcher/releases )
- [Changelog](https://github.com/karma-runner/karma-chrome-launcher/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma-chrome-launcher/compare/v3.1.1...v3.2.0 )
---
updated-dependencies:
- dependency-name: karma-chrome-launcher
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-21 09:57:29 +00:00
Jean-Baptiste Bellet
b17b25516f
Use a UTF-8 character
2023-04-21 10:37:20 +02:00
Jean-Baptiste Bellet
8444fca19a
Fix syntax error
2023-04-21 10:36:47 +02:00
Jean-Baptiste Bellet
18d90114fe
Be more responsive: use flex, ellipsis, less columns
2023-04-21 10:36:21 +02:00
Gaetan Craig-Riou
2f17a02974
Merge pull request #10726 from mkllnk/spec-email-helper
...
Remove useless email test setup
2023-04-21 15:43:19 +10:00
Gaetan Craig-Riou
135bc7e2f8
Removing env variable $runs_on
...
Seting "env" under "jobs" doesn't work it gets picked up as a job. I moved
runs_on to the top level env. but I couldn't fine a way to get it to work.
I tried all syntax I could think of: $runs_on, ${{ runs_on }} env.runs_on,
${{ env.runs_on }} and their capitalized versions.
2023-04-21 15:14:20 +10:00
Gaetan Craig-Riou
3810d79cad
Merge pull request #10695 from macanudo527/rename_inversables
...
Rename Inversable Method Names
2023-04-21 11:38:58 +10:00
Jean-Baptiste Bellet
81606e841a
Canceling an order: clicking on cancel btn or cancel action in dropdown
2023-04-20 14:38:59 +02:00
basilawwad
e633670e01
Use a shared_examples for the order cancellation tests
2023-04-20 14:38:59 +02:00
basilawwad
fa373518fb
applied modal function
...
Update variant_autocomplete.js.erb
Applied modal function
refactored function
fix indentation and removed old function
2023-04-20 11:46:02 +02:00
Jean-Baptiste Bellet
76357789a3
Avoid line break between state wording and its little colored circle
2023-04-20 09:09:29 +02:00
Jean-Baptiste Bellet
5dd7246b85
Rename confirm to use confirmation
...
`confirmation` is the state used by order model
2023-04-20 09:07:01 +02:00
Maikel Linke
9b3cfe80ff
Remove useless clearing of test emails
...
They are cleared by the test environment anyway.
2023-04-20 13:35:40 +10:00
Maikel Linke
04d33adaf2
Remove duplicate declaration of test mail delivery
...
Our test environment sets the mail delivery method already. We don't
have to do it in individual spec files.
2023-04-20 13:28:59 +10:00
Maikel Linke
915bd19d7b
Remove useless email test setup
...
We always deliver emails these days.
2023-04-20 12:18:04 +10:00
Maikel Linke
9998025687
Remove useless test header setup for emails
...
Once upon a time we needed a helper to set the `from` header of emails.
This is now set in the ApplicationMailer and not necessary any more.
2023-04-20 12:15:34 +10:00
Maikel Linke
1955a6719c
Fix commit message formatting
...
Git needs a blank line between the summary and the longer description.
And `echo` doesn't interpret `\n` by default.
2023-04-20 11:19:32 +10:00
Maikel Linke
f71e5ee43c
Limit number of rubocop autocorrect runs
...
The typical use case is to create a small number of commits for a pull
request to ease the review. And you can still run it for all cops with
`-n 999` or `-n -0`.
2023-04-20 11:19:32 +10:00
Maikel Linke
0ac2358f2c
Regenerate Rubocop's TODO file without timestamp
2023-04-20 10:34:35 +10:00
Jean-Baptiste Bellet
a27b64a66b
Add confirmation state translation
2023-04-19 11:32:51 +02:00
Jean-Baptiste Bellet
0f54d3950d
Save can have a context: simplify then
2023-04-19 10:15:35 +02:00
Jean-Baptiste Bellet
7e306693a8
Use Rails standard naming: same name for the route and the method
2023-04-19 10:15:35 +02:00
Maikel Linke
213fb42a05
Safely autocorrect Gemspec/RequireMFA
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/catalog/catalog.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:9:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |spec| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:21:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |s| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
s.metadata['rubygems_mfa_required'] = 'true'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 8 offenses detected, 8 offenses corrected
2023-04-19 15:35:30 +10:00
Maikel Linke
bde46fa1e9
Safely autocorrect Gemspec/DeprecatedAttributeAssignment
...
Inspecting 1404 files
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
engines/catalog/catalog.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/dfc_provider/dfc_provider.gemspec:17:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
spec.test_files = Dir['spec/**/*']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/order_management/order_management.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["spec/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/web/web.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec.
s.test_files = Dir["test/**/*"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 4 offenses detected, 4 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
dc560d3793
Safely autocorrect Bundler/OrderedGems
...
Inspecting 1404 files
.C..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
Gemfile:18:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem angular-rails-templates should appear before rexml.
gem 'angular-rails-templates', '>= 0.3.0'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:19:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem awesome_nested_set should appear before rexml.
gem 'awesome_nested_set'
^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:20:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem ransack should appear before rexml.
gem 'ransack', '~> 2.6.0'
^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:21:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem responders should appear before rexml.
gem 'responders'
^^^^^^^^^^^^^^^^
Gemfile:74:1: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem omniauth-rails_csrf_protection should appear before openid_connect.
gem 'omniauth-rails_csrf_protection'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:154:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before factory_bot_rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:155:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before fuubar.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:156:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before json_spec.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:157:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before knapsack_pro.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:158:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before letter_opener.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:159:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-rails.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:160:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rspec-retry.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:161:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before rswag-specs.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:162:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before shoulda-matchers.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:163:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem debug should appear before timecop.
gem 'debug', '>= 1.0.0'
^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:179:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem foreman should appear before rails-erd.
gem 'foreman'
^^^^^^^^^^^^^
Gemfile:180:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem listen should appear before rails-erd.
gem 'listen'
^^^^^^^^^^^^
Gemfile:181:3: C: [Corrected] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem pry should appear before rails-erd.
gem 'pry', '~> 0.13.0'
^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 18 offenses detected, 18 offenses corrected
2023-04-19 15:35:29 +10:00
Maikel Linke
52f134fc9e
Regenerate Rubocop's TODO file
2023-04-19 15:35:29 +10:00
Maikel Linke
c08e264afa
Add script for bulk autocorrect with Rubocop
...
We also had an old script which wasn't used and needed manual steps.
2023-04-19 15:35:29 +10:00
Neal Chambers
4e32bfd70b
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
Jean-Baptiste Bellet
722c660697
Do not show any links to other steps when no distribution set
...
distribution means tuple: distributor + order cycle
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ac666a6fce
Validate presence of distributor and order_cycle in set_distribution step
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ba1d985932
update the set_distribution form on the same path
...
and use the same method `OrdersController#set_distribution`
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
0f28d318ac
Fix rubocop error and prefer using a return clause
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
6172d1f2e5
Extract method on_update that will be used elsewhere
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
05a040b4c3
No need to ensure if the distribution is set on new action
...
This will be handled by validation on set_distribution action
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
73a81310f8
Create a new url /orders/ORDER_ID/distribution
...
That handles the step when distributor and order_cycle must be selected
2023-04-18 14:21:23 +02:00
David Cook
43e51cb592
Simplify login spec helpers, avoid long lines
...
Follow on from 5c6d9a092e
2023-04-18 10:01:23 +10:00
David Cook
6570891349
Fix linter issues
...
Although I don't think the size was an issue here, small hashes can easily fit on one line.
2023-04-18 09:50:08 +10:00
David Cook
0f3e2ae572
Use browser validation for calculator values
...
They're all numbers, so we can reliably validate in the browser, removing the need for additional validation logic.
They will still be validated server-side, and in the unlikely even that there is an error, the generic 'Calculator is invalid' message will appear, with the relevant fields highlighted red. I think that's fine.
2023-04-18 09:50:08 +10:00
David Cook
f0110d20a2
Move config to base helper
...
This config is relevant for all specs, including system specs.
2023-04-18 09:50:08 +10:00
David Cook
353acfd6ae
Validate associated calculator with built in error handling
...
Except that pesky generic message was appearing. I still don't know how to control that so just deleted it.
2023-04-18 09:39:39 +10:00
David Cook
e43a018dc7
[wip] Copy each calculator error
...
But we still have the duplicate problem.
Wait a minute, it copies them in the same format that I am copying them. So.. I don't need to copy them at all!
Now I see that we just needed the right format in the translation file.
2023-04-18 09:39:39 +10:00
David Cook
f6fac018ea
[wip] Use a custom message format for associated errors
...
This is much simpler. Multiple messages get combined onto one line though, which is not perfect.
And.. it still seems to duplicate the errors. Weird, it's fine on my frontend though.
2023-04-18 09:39:39 +10:00
David Cook
ce1bd12760
Consolidate specs
...
It takes time to set up this test case. Given that there's no interactions in the expectations, we should save time to generate it only once.
2023-04-18 09:39:39 +10:00
David Cook
364ccc2146
Add comment
2023-04-18 09:39:39 +10:00
James Wu
2a7cb50fa9
Keep and display submitted data on new payment method page
2023-04-18 09:39:39 +10:00
James Wu
29ddc68d20
Fix duplicate validation error message
2023-04-18 09:39:39 +10:00
James Wu
d40f3414ea
fixup! Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
f5e2edb028
fixup! Modify Calculator validation error messages [wip]
...
DC: the error message has now become "Amount Invalid input".
2023-04-18 09:39:39 +10:00
James Wu
7af26e6579
Add errors for invalid input with number localization enabled
2023-04-18 09:39:39 +10:00
James Wu
824d4adf21
Rename spec file
2023-04-18 09:39:39 +10:00
James Wu
00cc8da2fc
Fix rubocop class length error
2023-04-18 09:39:39 +10:00
James Wu
ae5f2cc19d
Fix error saving data on new Calculator
2023-04-18 09:39:39 +10:00
James Wu
41ce4fbc16
Fix cache issue with invalid form data
2023-04-18 09:39:39 +10:00
James Wu
48753df5f0
Improve input validation and error notification
2023-04-18 09:39:39 +10:00
James Wu
1f3e66316b
Modify Calculator validation error messages
2023-04-18 09:39:39 +10:00
James Wu
6b1426d0c6
Add numericality validation for PriceSack
2023-04-18 09:39:39 +10:00
James Wu
c68987c0f2
Add numericality validation for PerItem
2023-04-18 09:39:39 +10:00
James Wu
2cb25e6366
Add numericality validation for FlexiRate
2023-04-18 09:39:39 +10:00
James Wu
073f46e590
Add numericality validation for FlatRate
2023-04-18 09:39:39 +10:00
James Wu
23beea8a13
Add numericality validation for FlatPercentPerItem
2023-04-18 09:39:39 +10:00
James Wu
096e388fdf
Add numericality validation for FlatPercentItemTotal
2023-04-18 09:39:39 +10:00
James Wu
3dfaf882a3
Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
7b51f45b4d
Fix spelling in test description
2023-04-18 09:39:39 +10:00
James Wu
b9b2fa7c94
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
James Wu
ee30d3d139
Fix PaymentMethodFactory creating extra Calculator
2023-04-18 09:39:39 +10:00
MadisonBowron
697f2795d4
Remove arbitrary comments
2023-04-14 01:25:14 -04:00
filipefurtad0
7d51979c06
Updates build environment to Ubuntu 22.04
...
Creates environment variable to set OS version
2023-04-12 09:19:14 +02:00
MadisonBowron
8c6e0a841c
Fix rubocop extra blank line error
2023-04-11 15:35:37 -04:00
MadisonBowron
9d0a69cceb
Fix admin product variants form to close issues #10579 & #430
2023-04-10 18:53:01 -04:00