Filipe
f1138b7a9d
Merge pull request #13349 from mkllnk/vine-error-message
...
Clarify voucher code not found can mean fully redeemed
2025-06-06 12:46:11 +01:00
Carlos Chitty
63d284e81a
Use Orders::WorkflowService#complete! and #advance_to_payment in specs to replace code causing Style/NestedModifier rubocop offenses
...
Rewrite the loop "break unless a = order.next! while !order.delivery?" to correct the offenses. Not adding a helper because the change was only needed in a couple of places.
2025-06-04 12:46:58 -04:00
Maikel Linke
ef22269324
Clarify voucher code not found can mean fully redeemed
2025-05-29 14:18:32 +10:00
Maikel Linke
c9ec7e13d3
Add missing spec cassette
2025-05-29 11:42:53 +10:00
cyrillefr
400f431f88
Importer goal is to dl a file over https instead of local file
2025-05-27 17:10:48 +02:00
Maikel
99bd0cd313
Merge pull request #13335 from cyrillefr/FixRSpecRailsInferredSpecType
...
Fixes RSpecRailsInferredSpecType offenses
2025-05-26 11:47:55 +10:00
Konrad
d7c39fcab7
Merge pull request #13297 from filipefurtad0/fix_#13264_BOM
...
Fixes bad display from Producer name on BOM page
2025-05-23 18:56:36 +02:00
cyrillefr
b431b414a1
Fixes RSpecRailsInferredSpecType on routing
2025-05-21 09:45:03 +02:00
cyrillefr
758d78bfe4
Fixes RSpecRailsInferredSpecType
2025-05-21 09:43:24 +02:00
cyrillefr
2f5981af59
Fixes RSpecRailsInferredSpecType on models
2025-05-21 09:41:00 +02:00
cyrillefr
5788698e8e
Fixes RSpecRailsInferredSpecType offenses in jobs & mailers
2025-05-20 12:57:11 +02:00
cyrillefr
8be1045f23
Fixes RSpecRailsInferredSpecType offenses in helpers
2025-05-20 12:54:04 +02:00
cyrillefr
67f5ae811b
Fixes RSpecRailsInferredSpecType offenses in remaining controllers
2025-05-20 12:51:50 +02:00
cyrillefr
cf9395f42f
Fixes RSpecRailsInferredSpecType in spree admin controllers
2025-05-20 12:45:34 +02:00
cyrillefr
a7eb95afc5
Fixes RSpecRailsInferredSpecType in base controllers
2025-05-20 12:45:34 +02:00
cyrillefr
90d8d9fc30
Fixes RSpecRailsInferredSpecType offense in api v0
2025-05-20 12:45:34 +02:00
cyrillefr
60413c2a12
Fixes RSpecRails InferredSpecType offenses in controller admin
2025-05-20 12:45:34 +02:00
Filipe
93ac10bb75
Merge pull request #13262 from cillian/remove-angular-on-enterprise-images-and-white-label-sections
...
Remove Angular from the Settings > Images section
2025-05-16 20:03:55 +01:00
Filipe
d6785b2f5a
Merge pull request #13312 from mkllnk/stock-movement
...
Stop creating stock movements
2025-05-16 19:30:31 +01:00
Konrad
c657e31d07
Merge pull request #13318 from dacook/fix-13315
...
Prevent error on inventory page when logged out
2025-05-16 20:23:17 +02:00
Konrad
6432eceee5
Merge pull request #13313 from cyrillefr/FilterSelectionListNotDisplayingFullNames
...
Fixes dotted shipping method names bad display in select (filters)
2025-05-16 19:58:13 +02:00
Konrad
af3bb4c419
Merge pull request #13310 from mkllnk/reset-products
...
Fix product reset on import
2025-05-16 18:49:20 +02:00
Filipe
97ceed6cbe
Merge pull request #13263 from chahmedejaz/bugfix/13180-oc-search-on-bom
...
Fix Order Cycle search on BOM page is not working for more than 5 OCs
2025-05-16 10:59:55 +01:00
Maikel
277c51cd51
Merge pull request #13327 from cyrillefr/FixRSpecRailsHttpStatus
...
Fixes RSpec Rails HttpStatus offenses
2025-05-16 15:41:06 +10:00
Filipe
3efa2832de
Merge pull request #13257 from ashishp91/13221-make-shipped-orders-uneditable
...
13221 - Don't allow shipped orders to be editable
2025-05-15 19:23:33 +01:00
cyrillefr
529f3b85eb
Fixes RSpec Rails HttpStatus offenses
2025-05-15 08:46:02 +02:00
cyrillefr
7f842d77ea
Fixes RSpec Rails HaveHttpStatus cop in services & support
2025-05-14 11:47:03 +02:00
cyrillefr
8135aeaeda
Fixes RSpec Rails HaveHttpStatus cop in requests
2025-05-14 11:04:01 +02:00
cyrillefr
5063a772f0
Fixes RSpec Rails HaveHttpStatus cop in controllers
2025-05-14 10:58:04 +02:00
cyrillefr
f810e500b5
Fixes RSpec Rails HaveHttpStatus cop in api v0
2025-05-14 10:46:36 +02:00
cyrillefr
b9e1eb2984
Fixes RSpecRails HaveHttpStatus cop in admin specs
2025-05-14 10:28:57 +02:00
Filipe
371d0fbf79
Merge pull request #13281 from rioug/13172-search-by-tags
...
[Variant tags] Search products by tags
2025-05-14 07:38:59 +01:00
David Cook
71b65b4b98
Merge pull request #13306 from cyrillefr/FixRubocopNamingVariableNumber
...
Fixes Rubocop naming variable number
2025-05-14 09:39:32 +10:00
Maikel Linke
d650d06049
Delete StockMovement model
...
I'm not dropping the database table just yet. Let's keep this change
reversible without data loss. And dropping the table would break the
currently running app code during deploy. We can do that another time.
2025-05-13 15:24:26 +10:00
Maikel Linke
be312246ec
Stop referring to stock movements
2025-05-13 15:24:26 +10:00
Maikel Linke
729e62d7db
Remove unused stock move originator parameter
2025-05-13 15:24:26 +10:00
David Cook
6a5faaef22
Add expectation for redirect
2025-05-13 15:20:07 +10:00
Maikel Linke
2197656606
Stop creating stock movements
...
Spree added stock movements to track the movements between stock
locations. But we got rid of stock locations and the only stock
movements we have now are just records of stock level changes.
These records were not created in all cases though and there were also
not created for variant overrides (inventory items). And since these
records aren't visible anywhere, I think it's best we remove them
altogether.
I do think that some kind of log would be useful but I don't think that
AR records like this are the best solution for that. And the
StockMovement model just added complexity to our already complex stock
level storage. The actual adjustment of the count_on_hand attribute of
the StockItem was performed in an after_create hook of the
StockMovement. Now we call it explicitely.
2025-05-13 14:56:29 +10:00
David Cook
ffea1cca81
Replace JB's method with mine
...
Obviously I'm biased, but I like mine better.
2025-05-13 14:52:20 +10:00
David Cook
d62740da10
Update helper to exclude line items
...
_scrolls down_ Oh... JB already did that 😆
Nice to see we were thinking along the same lines.
2025-05-13 14:52:06 +10:00
David Cook
fa9ed1a66b
Add expectation for other line items
2025-05-13 14:42:46 +10:00
David Cook
3b1f267465
Declare which line items are being expected.
2025-05-13 14:41:03 +10:00
David Cook
cf30b792f9
Refactor: move shared code to context
2025-05-13 14:40:41 +10:00
David Cook
6daf94875a
Rename varianbles based on OC number
...
It was a bit confusing that they don't line up.
2025-05-13 14:23:51 +10:00
cyrillefr
e61d951dcf
Requested changes - translation useless
...
- also useless in specs
2025-05-12 14:46:27 +02:00
David Cook
f199fb182b
Add specs
2025-05-12 17:35:10 +10:00
Ahmed Ejaz
db0922a7cf
13180: increase filter time to 1 year
2025-05-12 01:14:51 +05:00
Cillian O'Ruanaidh
119218b2b5
Don't try to render image preview if image is corrupt on S3 and its URL can be generated
2025-05-10 12:35:40 +01:00
Maikel Linke
524d6e87b7
Fix product reset on import
2025-05-09 11:27:10 +10:00
Ashish Gaur
71949701ac
Merge branch 'master' into 13221-make-shipped-orders-uneditable
2025-05-08 21:56:46 +05:30
