Fixes RSpecRailsInferredSpecType in spree admin controllers

.rubocop_todo.yml

@@ -221,30 +221,11 @@ Metrics/PerceivedComplexity:
     - 'app/models/spree/ability.rb'
     - 'app/models/spree/order/checkout.rb'
 
-# Offense count: 85
+# Offense count: 65
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Inferences.
 RSpecRails/InferredSpecType:
   Exclude:
-    - 'spec/controllers/spree/admin/adjustments_controller_spec.rb'
-    - 'spec/controllers/spree/admin/base_controller_spec.rb'
-    - 'spec/controllers/spree/admin/countries_controller_spec.rb'
-    - 'spec/controllers/spree/admin/general_settings_controller_spec.rb'
-    - 'spec/controllers/spree/admin/orders/customer_details_controller_spec.rb'
-    - 'spec/controllers/spree/admin/orders/invoices_spec.rb'
-    - 'spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb'
-    - 'spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb'
-    - 'spec/controllers/spree/admin/orders_controller_spec.rb'
-    - 'spec/controllers/spree/admin/overview_controller_spec.rb'
-    - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb'
-    - 'spec/controllers/spree/admin/products_controller_spec.rb'
-    - 'spec/controllers/spree/admin/return_authorizations_controller_spec.rb'
-    - 'spec/controllers/spree/admin/search_controller_spec.rb'
-    - 'spec/controllers/spree/admin/shipping_categories_controller_spec.rb'
-    - 'spec/controllers/spree/admin/shipping_methods_controller_spec.rb'
-    - 'spec/controllers/spree/admin/tax_rates_controller_spec.rb'
-    - 'spec/controllers/spree/admin/tax_settings_controller_spec.rb'
-    - 'spec/controllers/spree/admin/variants_controller_spec.rb'
     - 'spec/controllers/spree/api_keys_controller_spec.rb'
     - 'spec/controllers/spree/credit_cards_controller_spec.rb'
     - 'spec/controllers/spree/orders_controller_spec.rb'

spec/controllers/spree/admin/adjustments_controller_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 module Spree
-  RSpec.describe Admin::AdjustmentsController, type: :controller do
+  RSpec.describe Admin::AdjustmentsController do
     include AuthenticationHelper
 
     before { controller_login_as_admin }

spec/controllers/spree/admin/base_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::BaseController, type: :controller do
+RSpec.describe Spree::Admin::BaseController do
   controller(Spree::Admin::BaseController) do
     def index
       before_action :unauthorized

spec/controllers/spree/admin/countries_controller_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 module Spree
   module Admin
-    RSpec.describe CountriesController, type: :controller do
+    RSpec.describe CountriesController do
       include AuthenticationHelper
 
       describe "#update" do

spec/controllers/spree/admin/general_settings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::GeneralSettingsController, type: :controller do
+RSpec.describe Spree::Admin::GeneralSettingsController do
   include AuthenticationHelper
 
   describe 'updating general settings' do

spec/controllers/spree/admin/orders/customer_details_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::Orders::CustomerDetailsController, type: :controller do
+RSpec.describe Spree::Admin::Orders::CustomerDetailsController do
   include AuthenticationHelper
 
   describe "#update" do

spec/controllers/spree/admin/orders/invoices_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::OrdersController, type: :controller do
+RSpec.describe Spree::Admin::OrdersController do
   describe "#invoice" do
     let!(:user) { create(:user) }
     let!(:enterprise_user) { create(:user) }
@@ -106,7 +106,7 @@ RSpec.describe Spree::Admin::OrdersController, type: :controller do
   end
 end
 
-RSpec.describe Spree::Admin::InvoicesController, type: :controller do
+RSpec.describe Spree::Admin::InvoicesController do
   describe "#index" do
     let(:user) { create(:user) }
     let(:enterprise_user) { create(:user, enterprises: [create(:enterprise)]) }

spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::PaymentsController, type: :controller do
+RSpec.describe Spree::Admin::PaymentsController do
   include StripeHelper
   include StripeStubs
 

spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::PaymentsController, type: :controller do
+RSpec.describe Spree::Admin::PaymentsController do
   let!(:shop) { create(:enterprise) }
   let!(:user) { shop.owner }
   let!(:order) { create(:order, distributor: shop, state: 'complete') }

spec/controllers/spree/admin/orders_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::OrdersController, type: :controller do
+RSpec.describe Spree::Admin::OrdersController do
   describe "#edit" do
     let!(:order) { create(:order_with_totals_and_distribution, ship_address: create(:address)) }
 

spec/controllers/spree/admin/overview_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::OverviewController, type: :controller do
+RSpec.describe Spree::Admin::OverviewController do
   describe "#index" do
     before do
       allow(controller).to receive(:spree_current_user).and_return(user)

spec/controllers/spree/admin/payment_methods_controller_spec.rb

@@ -7,7 +7,7 @@ module Spree
     preference :password, :string, default: "password"
   end
 
-  RSpec.describe Admin::PaymentMethodsController, type: :controller do
+  RSpec.describe Admin::PaymentMethodsController do
     let(:user) {
       create(:user, enterprises: [create(:distributor_enterprise)])
     }

spec/controllers/spree/admin/products_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::ProductsController, type: :controller do
+RSpec.describe Spree::Admin::ProductsController do
   describe 'bulk_update' do
     context "updating a product we do not have access to" do
       let(:s_managed) { create(:enterprise) }

spec/controllers/spree/admin/return_authorizations_controller_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 module Spree
   module Admin
-    RSpec.describe ReturnAuthorizationsController, type: :controller do
+    RSpec.describe ReturnAuthorizationsController do
       include AuthenticationHelper
 
       let(:order) { create(:shipped_order, distributor: create(:distributor_enterprise)) }

spec/controllers/spree/admin/search_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::SearchController, type: :controller do
+RSpec.describe Spree::Admin::SearchController do
   context "Distributor Enterprise User" do
     let!(:owner) { create(:user, email: "test1@email.com" ) }
     let!(:manager) { create(:user, email: "test2@email.com" ) }

spec/controllers/spree/admin/shipping_categories_controller_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 module Spree
   module Admin
-    RSpec.describe ShippingCategoriesController, type: :controller do
+    RSpec.describe ShippingCategoriesController do
       include AuthenticationHelper
 
       describe "#create and #update" do

spec/controllers/spree/admin/shipping_methods_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::ShippingMethodsController, type: :controller do
+RSpec.describe Spree::Admin::ShippingMethodsController do
   include AuthenticationHelper
 
   describe "#update" do

spec/controllers/spree/admin/tax_rates_controller_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 module Spree
   module Admin
-    RSpec.describe TaxRatesController, type: :controller do
+    RSpec.describe TaxRatesController do
       include AuthenticationHelper
 
       let!(:default_tax_zone) { create(:zone, default_tax: true) }

spec/controllers/spree/admin/tax_settings_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Spree::Admin::TaxSettingsController, type: :controller do
+RSpec.describe Spree::Admin::TaxSettingsController do
   describe "#update" do
     let(:params) { { preferences: { products_require_tax_category: "1" } } }
 

spec/controllers/spree/admin/variants_controller_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 module Spree
   module Admin
-    RSpec.describe VariantsController, type: :controller do
+    RSpec.describe VariantsController do
       context "log in as admin user" do
         before { controller_login_as_admin }