diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2595d2040f..18d0a2b0ea 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -221,30 +221,11 @@ Metrics/PerceivedComplexity: - 'app/models/spree/ability.rb' - 'app/models/spree/order/checkout.rb' -# Offense count: 85 +# Offense count: 65 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpecRails/InferredSpecType: Exclude: - - 'spec/controllers/spree/admin/adjustments_controller_spec.rb' - - 'spec/controllers/spree/admin/base_controller_spec.rb' - - 'spec/controllers/spree/admin/countries_controller_spec.rb' - - 'spec/controllers/spree/admin/general_settings_controller_spec.rb' - - 'spec/controllers/spree/admin/orders/customer_details_controller_spec.rb' - - 'spec/controllers/spree/admin/orders/invoices_spec.rb' - - 'spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb' - - 'spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb' - - 'spec/controllers/spree/admin/orders_controller_spec.rb' - - 'spec/controllers/spree/admin/overview_controller_spec.rb' - - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' - - 'spec/controllers/spree/admin/products_controller_spec.rb' - - 'spec/controllers/spree/admin/return_authorizations_controller_spec.rb' - - 'spec/controllers/spree/admin/search_controller_spec.rb' - - 'spec/controllers/spree/admin/shipping_categories_controller_spec.rb' - - 'spec/controllers/spree/admin/shipping_methods_controller_spec.rb' - - 'spec/controllers/spree/admin/tax_rates_controller_spec.rb' - - 'spec/controllers/spree/admin/tax_settings_controller_spec.rb' - - 'spec/controllers/spree/admin/variants_controller_spec.rb' - 'spec/controllers/spree/api_keys_controller_spec.rb' - 'spec/controllers/spree/credit_cards_controller_spec.rb' - 'spec/controllers/spree/orders_controller_spec.rb' diff --git a/spec/controllers/spree/admin/adjustments_controller_spec.rb b/spec/controllers/spree/admin/adjustments_controller_spec.rb index 93837dbfb8..abccf7d87a 100644 --- a/spec/controllers/spree/admin/adjustments_controller_spec.rb +++ b/spec/controllers/spree/admin/adjustments_controller_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' module Spree - RSpec.describe Admin::AdjustmentsController, type: :controller do + RSpec.describe Admin::AdjustmentsController do include AuthenticationHelper before { controller_login_as_admin } diff --git a/spec/controllers/spree/admin/base_controller_spec.rb b/spec/controllers/spree/admin/base_controller_spec.rb index 7879b62d0b..2361da8565 100644 --- a/spec/controllers/spree/admin/base_controller_spec.rb +++ b/spec/controllers/spree/admin/base_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::BaseController, type: :controller do +RSpec.describe Spree::Admin::BaseController do controller(Spree::Admin::BaseController) do def index before_action :unauthorized diff --git a/spec/controllers/spree/admin/countries_controller_spec.rb b/spec/controllers/spree/admin/countries_controller_spec.rb index d5829a9149..7367e8d278 100644 --- a/spec/controllers/spree/admin/countries_controller_spec.rb +++ b/spec/controllers/spree/admin/countries_controller_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' module Spree module Admin - RSpec.describe CountriesController, type: :controller do + RSpec.describe CountriesController do include AuthenticationHelper describe "#update" do diff --git a/spec/controllers/spree/admin/general_settings_controller_spec.rb b/spec/controllers/spree/admin/general_settings_controller_spec.rb index 1a0e0b002f..a0b592a0a8 100644 --- a/spec/controllers/spree/admin/general_settings_controller_spec.rb +++ b/spec/controllers/spree/admin/general_settings_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::GeneralSettingsController, type: :controller do +RSpec.describe Spree::Admin::GeneralSettingsController do include AuthenticationHelper describe 'updating general settings' do diff --git a/spec/controllers/spree/admin/orders/customer_details_controller_spec.rb b/spec/controllers/spree/admin/orders/customer_details_controller_spec.rb index 44b595b8ab..e26a66c081 100644 --- a/spec/controllers/spree/admin/orders/customer_details_controller_spec.rb +++ b/spec/controllers/spree/admin/orders/customer_details_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::Orders::CustomerDetailsController, type: :controller do +RSpec.describe Spree::Admin::Orders::CustomerDetailsController do include AuthenticationHelper describe "#update" do diff --git a/spec/controllers/spree/admin/orders/invoices_spec.rb b/spec/controllers/spree/admin/orders/invoices_spec.rb index 3eda9051a2..1906e3a309 100644 --- a/spec/controllers/spree/admin/orders/invoices_spec.rb +++ b/spec/controllers/spree/admin/orders/invoices_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::OrdersController, type: :controller do +RSpec.describe Spree::Admin::OrdersController do describe "#invoice" do let!(:user) { create(:user) } let!(:enterprise_user) { create(:user) } @@ -106,7 +106,7 @@ RSpec.describe Spree::Admin::OrdersController, type: :controller do end end -RSpec.describe Spree::Admin::InvoicesController, type: :controller do +RSpec.describe Spree::Admin::InvoicesController do describe "#index" do let(:user) { create(:user) } let(:enterprise_user) { create(:user, enterprises: [create(:enterprise)]) } diff --git a/spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb b/spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb index 1e3b1cf8c6..2ab5e6a94c 100644 --- a/spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb +++ b/spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::PaymentsController, type: :controller do +RSpec.describe Spree::Admin::PaymentsController do include StripeHelper include StripeStubs diff --git a/spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb b/spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb index 4fc24e2a1c..6214e06af5 100644 --- a/spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb +++ b/spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::PaymentsController, type: :controller do +RSpec.describe Spree::Admin::PaymentsController do let!(:shop) { create(:enterprise) } let!(:user) { shop.owner } let!(:order) { create(:order, distributor: shop, state: 'complete') } diff --git a/spec/controllers/spree/admin/orders_controller_spec.rb b/spec/controllers/spree/admin/orders_controller_spec.rb index ea660bb479..34af692760 100644 --- a/spec/controllers/spree/admin/orders_controller_spec.rb +++ b/spec/controllers/spree/admin/orders_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::OrdersController, type: :controller do +RSpec.describe Spree::Admin::OrdersController do describe "#edit" do let!(:order) { create(:order_with_totals_and_distribution, ship_address: create(:address)) } diff --git a/spec/controllers/spree/admin/overview_controller_spec.rb b/spec/controllers/spree/admin/overview_controller_spec.rb index cb5f218f24..df4429c109 100644 --- a/spec/controllers/spree/admin/overview_controller_spec.rb +++ b/spec/controllers/spree/admin/overview_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::OverviewController, type: :controller do +RSpec.describe Spree::Admin::OverviewController do describe "#index" do before do allow(controller).to receive(:spree_current_user).and_return(user) diff --git a/spec/controllers/spree/admin/payment_methods_controller_spec.rb b/spec/controllers/spree/admin/payment_methods_controller_spec.rb index 7124e9fecd..6e14f8d3cd 100644 --- a/spec/controllers/spree/admin/payment_methods_controller_spec.rb +++ b/spec/controllers/spree/admin/payment_methods_controller_spec.rb @@ -7,7 +7,7 @@ module Spree preference :password, :string, default: "password" end - RSpec.describe Admin::PaymentMethodsController, type: :controller do + RSpec.describe Admin::PaymentMethodsController do let(:user) { create(:user, enterprises: [create(:distributor_enterprise)]) } diff --git a/spec/controllers/spree/admin/products_controller_spec.rb b/spec/controllers/spree/admin/products_controller_spec.rb index d98c7be540..af89e197fc 100644 --- a/spec/controllers/spree/admin/products_controller_spec.rb +++ b/spec/controllers/spree/admin/products_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::ProductsController, type: :controller do +RSpec.describe Spree::Admin::ProductsController do describe 'bulk_update' do context "updating a product we do not have access to" do let(:s_managed) { create(:enterprise) } diff --git a/spec/controllers/spree/admin/return_authorizations_controller_spec.rb b/spec/controllers/spree/admin/return_authorizations_controller_spec.rb index d76ee014bd..cbc69ec18b 100644 --- a/spec/controllers/spree/admin/return_authorizations_controller_spec.rb +++ b/spec/controllers/spree/admin/return_authorizations_controller_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' module Spree module Admin - RSpec.describe ReturnAuthorizationsController, type: :controller do + RSpec.describe ReturnAuthorizationsController do include AuthenticationHelper let(:order) { create(:shipped_order, distributor: create(:distributor_enterprise)) } diff --git a/spec/controllers/spree/admin/search_controller_spec.rb b/spec/controllers/spree/admin/search_controller_spec.rb index 2354e1869d..18fff364af 100644 --- a/spec/controllers/spree/admin/search_controller_spec.rb +++ b/spec/controllers/spree/admin/search_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::SearchController, type: :controller do +RSpec.describe Spree::Admin::SearchController do context "Distributor Enterprise User" do let!(:owner) { create(:user, email: "test1@email.com" ) } let!(:manager) { create(:user, email: "test2@email.com" ) } diff --git a/spec/controllers/spree/admin/shipping_categories_controller_spec.rb b/spec/controllers/spree/admin/shipping_categories_controller_spec.rb index e7df05f5f4..ca956713a1 100644 --- a/spec/controllers/spree/admin/shipping_categories_controller_spec.rb +++ b/spec/controllers/spree/admin/shipping_categories_controller_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' module Spree module Admin - RSpec.describe ShippingCategoriesController, type: :controller do + RSpec.describe ShippingCategoriesController do include AuthenticationHelper describe "#create and #update" do diff --git a/spec/controllers/spree/admin/shipping_methods_controller_spec.rb b/spec/controllers/spree/admin/shipping_methods_controller_spec.rb index efdb46d78c..422352542b 100644 --- a/spec/controllers/spree/admin/shipping_methods_controller_spec.rb +++ b/spec/controllers/spree/admin/shipping_methods_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::ShippingMethodsController, type: :controller do +RSpec.describe Spree::Admin::ShippingMethodsController do include AuthenticationHelper describe "#update" do diff --git a/spec/controllers/spree/admin/tax_rates_controller_spec.rb b/spec/controllers/spree/admin/tax_rates_controller_spec.rb index ad9bc2cb72..5a4fb2c6e2 100644 --- a/spec/controllers/spree/admin/tax_rates_controller_spec.rb +++ b/spec/controllers/spree/admin/tax_rates_controller_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' module Spree module Admin - RSpec.describe TaxRatesController, type: :controller do + RSpec.describe TaxRatesController do include AuthenticationHelper let!(:default_tax_zone) { create(:zone, default_tax: true) } diff --git a/spec/controllers/spree/admin/tax_settings_controller_spec.rb b/spec/controllers/spree/admin/tax_settings_controller_spec.rb index e41d1825a4..af804d4ba4 100644 --- a/spec/controllers/spree/admin/tax_settings_controller_spec.rb +++ b/spec/controllers/spree/admin/tax_settings_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Admin::TaxSettingsController, type: :controller do +RSpec.describe Spree::Admin::TaxSettingsController do describe "#update" do let(:params) { { preferences: { products_require_tax_category: "1" } } } diff --git a/spec/controllers/spree/admin/variants_controller_spec.rb b/spec/controllers/spree/admin/variants_controller_spec.rb index dda0c01dab..5ca4491838 100644 --- a/spec/controllers/spree/admin/variants_controller_spec.rb +++ b/spec/controllers/spree/admin/variants_controller_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' module Spree module Admin - RSpec.describe VariantsController, type: :controller do + RSpec.describe VariantsController do context "log in as admin user" do before { controller_login_as_admin }