Fixes RSpecRailsInferredSpecType in base controllers

.rubocop_todo.yml

@@ -221,22 +221,11 @@ Metrics/PerceivedComplexity:
     - 'app/models/spree/ability.rb'
     - 'app/models/spree/order/checkout.rb'
 
-# Offense count: 98
+# Offense count: 85
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Inferences.
 RSpecRails/InferredSpecType:
   Exclude:
-    - 'spec/controllers/base_controller_spec.rb'
-    - 'spec/controllers/cart_controller_spec.rb'
-    - 'spec/controllers/checkout_controller_spec.rb'
-    - 'spec/controllers/enterprises_controller_spec.rb'
-    - 'spec/controllers/groups_controller_spec.rb'
-    - 'spec/controllers/line_items_controller_spec.rb'
-    - 'spec/controllers/payment_gateways/paypal_controller_spec.rb'
-    - 'spec/controllers/payment_gateways/stripe_controller_spec.rb'
-    - 'spec/controllers/registration_controller_spec.rb'
-    - 'spec/controllers/shop_controller_spec.rb'
-    - 'spec/controllers/shops_controller_spec.rb'
     - 'spec/controllers/spree/admin/adjustments_controller_spec.rb'
     - 'spec/controllers/spree/admin/base_controller_spec.rb'
     - 'spec/controllers/spree/admin/countries_controller_spec.rb'
@@ -263,10 +252,6 @@ RSpecRails/InferredSpecType:
     - 'spec/controllers/spree/users_controller_spec.rb'
     - 'spec/controllers/stripe/callbacks_controller_spec.rb'
     - 'spec/controllers/stripe/webhooks_controller_spec.rb'
-    - 'spec/controllers/user_confirmations_controller_spec.rb'
-    - 'spec/controllers/user_passwords_controller_spec.rb'
-    - 'spec/controllers/user_registrations_controller_spec.rb'
-    - 'spec/controllers/webhook_endpoints_controller_spec.rb'
     - 'spec/helpers/admin/enterprises_helper_spec.rb'
     - 'spec/helpers/admin/orders_helper_spec.rb'
     - 'spec/helpers/admin/reports_helper_spec.rb'

spec/controllers/base_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe BaseController, type: :controller do
+RSpec.describe BaseController do
   let(:oc)    { instance_double(OrderCycle, id: 1) }
   let(:order) { instance_double(Spree::Order) }
   controller(BaseController) do

spec/controllers/cart_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe CartController, type: :controller do
+RSpec.describe CartController do
   let(:order) { create(:order) }
 
   describe "basic behaviour" do

spec/controllers/checkout_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe CheckoutController, type: :controller do
+RSpec.describe CheckoutController do
   let(:user) { order.user }
   let(:address) { create(:address) }
   let(:distributor) { create(:distributor_enterprise, with_payment_and_shipping: true) }

spec/controllers/enterprises_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe EnterprisesController, type: :controller do
+RSpec.describe EnterprisesController do
   describe "shopping for a distributor" do
     let(:user) { create(:user) }
     let(:order) { controller.current_order(true) }

spec/controllers/groups_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe GroupsController, type: :controller do
+RSpec.describe GroupsController do
   render_views
 
   let!(:enterprise) { create(:distributor_enterprise) }

spec/controllers/line_items_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe LineItemsController, type: :controller do
+RSpec.describe LineItemsController do
   let(:user) { create(:user) }
   let(:distributor) { create(:distributor_enterprise) }
   let(:order_cycle) { create(:simple_order_cycle) }

spec/controllers/registration_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe RegistrationController, type: :controller do
+RSpec.describe RegistrationController do
   describe "redirecting when user not logged in" do
     it "index" do
       get :index

spec/controllers/shop_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ShopController, type: :controller do
+RSpec.describe ShopController do
   let!(:pm) { create(:payment_method) }
   let!(:sm) { create(:shipping_method) }
   let(:distributor) {

spec/controllers/shops_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ShopsController, type: :controller do
+RSpec.describe ShopsController do
   include WebHelper
   render_views
 

spec/controllers/user_confirmations_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe UserConfirmationsController, type: :controller do
+RSpec.describe UserConfirmationsController do
   let!(:user) { create(:user) }
   let!(:confirmed_user) { create(:user, confirmed_at: nil) }
   let!(:unconfirmed_user) { create(:user, confirmed_at: nil) }

spec/controllers/user_passwords_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe UserPasswordsController, type: :controller do
+RSpec.describe UserPasswordsController do
   render_views
 
   let(:user) { create(:user) }

spec/controllers/user_registrations_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe UserRegistrationsController, type: :controller do
+RSpec.describe UserRegistrationsController do
   before do
     @request.env["devise.mapping"] = Devise.mappings[:spree_user]
   end

spec/controllers/webhook_endpoints_controller_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require 'open_food_network/order_cycle_permissions'
 
-RSpec.describe WebhookEndpointsController, type: :controller do
+RSpec.describe WebhookEndpointsController do
   let(:user) { create(:admin_user) }
 
   before { allow(controller).to receive(:spree_current_user) { user } }