Fixes RSpecRailsInferredSpecType on models

This commit is contained in:
cyrillefr
2025-05-21 09:41:00 +02:00
parent 5788698e8e
commit 2f5981af59
17 changed files with 17 additions and 33 deletions

View File

@@ -221,27 +221,11 @@ Metrics/PerceivedComplexity:
- 'app/models/spree/ability.rb'
- 'app/models/spree/order/checkout.rb'
# Offense count: 34
# Offense count: 18
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Inferences.
RSpecRails/InferredSpecType:
Exclude:
- 'spec/models/column_preference_spec.rb'
- 'spec/models/connected_app_spec.rb'
- 'spec/models/customer_spec.rb'
- 'spec/models/invoice_spec.rb'
- 'spec/models/oidc_account_spec.rb'
- 'spec/models/proxy_order_spec.rb'
- 'spec/models/report_blob_spec.rb'
- 'spec/models/semantic_link_spec.rb'
- 'spec/models/spree/gateway/stripe_sca_spec.rb'
- 'spec/models/subscription_spec.rb'
- 'spec/models/tag_rule/filter_order_cycles_spec.rb'
- 'spec/models/tag_rule/filter_payment_methods_spec.rb'
- 'spec/models/tag_rule/filter_products_spec.rb'
- 'spec/models/tag_rule/filter_shipping_methods_spec.rb'
- 'spec/models/tag_rule_spec.rb'
- 'spec/models/webhook_endpoint_spec.rb'
- 'spec/requests/admin/images_spec.rb'
- 'spec/requests/admin/product_import_spec.rb'
- 'spec/requests/admin/vouchers_spec.rb'

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe ColumnPreference, type: :model do
RSpec.describe ColumnPreference do
subject {
ColumnPreference.new(
user:, action_name: :customers_index, column_name: :email

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe ConnectedApp, type: :model do
RSpec.describe ConnectedApp do
it { is_expected.to belong_to :enterprise }
it "stores data as json hash" do

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe Customer, type: :model do
RSpec.describe Customer do
it { is_expected.to belong_to(:enterprise).required }
it { is_expected.to belong_to(:user).optional }
it { is_expected.to belong_to(:bill_address).optional }

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe Invoice, type: :model do
RSpec.describe Invoice do
let(:distributor) { create(:distributor_enterprise) }
let(:order) { create(:order, :with_line_item, :completed, distributor:) }
describe 'presenter' do

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe OidcAccount, type: :model do
RSpec.describe OidcAccount do
describe "associations and validations" do
subject {
OidcAccount.new(

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe ProxyOrder, type: :model do
RSpec.describe ProxyOrder do
describe "cancel" do
let(:order_cycle) { create(:simple_order_cycle) }
let(:subscription) { create(:subscription) }

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe ReportBlob, type: :model do
RSpec.describe ReportBlob do
it "preserves UTF-8 content" do
content = "This works. ✓"

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe SemanticLink, type: :model do
RSpec.describe SemanticLink do
it { is_expected.to belong_to :subject }
it { is_expected.to validate_presence_of(:semantic_id) }
end

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe Spree::Gateway::StripeSCA, :vcr, :stripe_version, type: :model do
RSpec.describe Spree::Gateway::StripeSCA, :vcr, :stripe_version do
let(:order) { create(:order_ready_for_payment) }
let(:year_valid) { Time.zone.now.year.next }

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe Subscription, type: :model do
RSpec.describe Subscription do
describe "associations" do
it { expect(subject).to belong_to(:shop).optional }
it { expect(subject).to belong_to(:customer).optional }

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe TagRule::FilterOrderCycles, type: :model do
RSpec.describe TagRule::FilterOrderCycles do
let!(:tag_rule) { build_stubbed(:filter_order_cycles_tag_rule) }
describe "determining whether tags match for a given exchange" do

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe TagRule::FilterPaymentMethods, type: :model do
RSpec.describe TagRule::FilterPaymentMethods do
let!(:tag_rule) { build_stubbed(:filter_payment_methods_tag_rule) }
describe "determining whether tags match for a given payment method" do

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe TagRule::FilterProducts, type: :model do
RSpec.describe TagRule::FilterProducts do
let!(:tag_rule) { build_stubbed(:filter_products_tag_rule) }
describe "determining whether tags match for a given variant" do

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe TagRule::FilterShippingMethods, type: :model do
RSpec.describe TagRule::FilterShippingMethods do
let!(:tag_rule) { build_stubbed(:filter_shipping_methods_tag_rule) }
describe "determining whether tags match for a given shipping method" do

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe TagRule, type: :model do
RSpec.describe TagRule do
describe "validations" do
it "requires a enterprise" do
expect(subject).to belong_to(:enterprise)

View File

@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe WebhookEndpoint, type: :model do
RSpec.describe WebhookEndpoint do
describe "validations" do
it { is_expected.to validate_presence_of(:url) }
end