diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2bcf3553b2..6e471c16a1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -221,27 +221,11 @@ Metrics/PerceivedComplexity: - 'app/models/spree/ability.rb' - 'app/models/spree/order/checkout.rb' -# Offense count: 34 +# Offense count: 18 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpecRails/InferredSpecType: Exclude: - - 'spec/models/column_preference_spec.rb' - - 'spec/models/connected_app_spec.rb' - - 'spec/models/customer_spec.rb' - - 'spec/models/invoice_spec.rb' - - 'spec/models/oidc_account_spec.rb' - - 'spec/models/proxy_order_spec.rb' - - 'spec/models/report_blob_spec.rb' - - 'spec/models/semantic_link_spec.rb' - - 'spec/models/spree/gateway/stripe_sca_spec.rb' - - 'spec/models/subscription_spec.rb' - - 'spec/models/tag_rule/filter_order_cycles_spec.rb' - - 'spec/models/tag_rule/filter_payment_methods_spec.rb' - - 'spec/models/tag_rule/filter_products_spec.rb' - - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' - - 'spec/models/tag_rule_spec.rb' - - 'spec/models/webhook_endpoint_spec.rb' - 'spec/requests/admin/images_spec.rb' - 'spec/requests/admin/product_import_spec.rb' - 'spec/requests/admin/vouchers_spec.rb' diff --git a/spec/models/column_preference_spec.rb b/spec/models/column_preference_spec.rb index 99f6402987..b043bd53db 100644 --- a/spec/models/column_preference_spec.rb +++ b/spec/models/column_preference_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe ColumnPreference, type: :model do +RSpec.describe ColumnPreference do subject { ColumnPreference.new( user:, action_name: :customers_index, column_name: :email diff --git a/spec/models/connected_app_spec.rb b/spec/models/connected_app_spec.rb index 57dd56d4c3..b8d5749443 100644 --- a/spec/models/connected_app_spec.rb +++ b/spec/models/connected_app_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe ConnectedApp, type: :model do +RSpec.describe ConnectedApp do it { is_expected.to belong_to :enterprise } it "stores data as json hash" do diff --git a/spec/models/customer_spec.rb b/spec/models/customer_spec.rb index bb488b6993..4aaf749067 100644 --- a/spec/models/customer_spec.rb +++ b/spec/models/customer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Customer, type: :model do +RSpec.describe Customer do it { is_expected.to belong_to(:enterprise).required } it { is_expected.to belong_to(:user).optional } it { is_expected.to belong_to(:bill_address).optional } diff --git a/spec/models/invoice_spec.rb b/spec/models/invoice_spec.rb index b5a3fd94a8..35b8aab258 100644 --- a/spec/models/invoice_spec.rb +++ b/spec/models/invoice_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Invoice, type: :model do +RSpec.describe Invoice do let(:distributor) { create(:distributor_enterprise) } let(:order) { create(:order, :with_line_item, :completed, distributor:) } describe 'presenter' do diff --git a/spec/models/oidc_account_spec.rb b/spec/models/oidc_account_spec.rb index f6eb2d792d..7ce379d299 100644 --- a/spec/models/oidc_account_spec.rb +++ b/spec/models/oidc_account_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe OidcAccount, type: :model do +RSpec.describe OidcAccount do describe "associations and validations" do subject { OidcAccount.new( diff --git a/spec/models/proxy_order_spec.rb b/spec/models/proxy_order_spec.rb index 7fe6b76620..dbec3b6833 100644 --- a/spec/models/proxy_order_spec.rb +++ b/spec/models/proxy_order_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe ProxyOrder, type: :model do +RSpec.describe ProxyOrder do describe "cancel" do let(:order_cycle) { create(:simple_order_cycle) } let(:subscription) { create(:subscription) } diff --git a/spec/models/report_blob_spec.rb b/spec/models/report_blob_spec.rb index 32cfd69a9d..1622b77c6f 100644 --- a/spec/models/report_blob_spec.rb +++ b/spec/models/report_blob_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe ReportBlob, type: :model do +RSpec.describe ReportBlob do it "preserves UTF-8 content" do content = "This works. ✓" diff --git a/spec/models/semantic_link_spec.rb b/spec/models/semantic_link_spec.rb index 6d881980ea..ac82a766e1 100644 --- a/spec/models/semantic_link_spec.rb +++ b/spec/models/semantic_link_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe SemanticLink, type: :model do +RSpec.describe SemanticLink do it { is_expected.to belong_to :subject } it { is_expected.to validate_presence_of(:semantic_id) } end diff --git a/spec/models/spree/gateway/stripe_sca_spec.rb b/spec/models/spree/gateway/stripe_sca_spec.rb index 1b9c28863e..489c9fc90f 100644 --- a/spec/models/spree/gateway/stripe_sca_spec.rb +++ b/spec/models/spree/gateway/stripe_sca_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Spree::Gateway::StripeSCA, :vcr, :stripe_version, type: :model do +RSpec.describe Spree::Gateway::StripeSCA, :vcr, :stripe_version do let(:order) { create(:order_ready_for_payment) } let(:year_valid) { Time.zone.now.year.next } diff --git a/spec/models/subscription_spec.rb b/spec/models/subscription_spec.rb index b4e3eee043..13a320cf45 100644 --- a/spec/models/subscription_spec.rb +++ b/spec/models/subscription_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Subscription, type: :model do +RSpec.describe Subscription do describe "associations" do it { expect(subject).to belong_to(:shop).optional } it { expect(subject).to belong_to(:customer).optional } diff --git a/spec/models/tag_rule/filter_order_cycles_spec.rb b/spec/models/tag_rule/filter_order_cycles_spec.rb index da96f716e2..ed9529ab8b 100644 --- a/spec/models/tag_rule/filter_order_cycles_spec.rb +++ b/spec/models/tag_rule/filter_order_cycles_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe TagRule::FilterOrderCycles, type: :model do +RSpec.describe TagRule::FilterOrderCycles do let!(:tag_rule) { build_stubbed(:filter_order_cycles_tag_rule) } describe "determining whether tags match for a given exchange" do diff --git a/spec/models/tag_rule/filter_payment_methods_spec.rb b/spec/models/tag_rule/filter_payment_methods_spec.rb index a371c38c04..633a65a3f2 100644 --- a/spec/models/tag_rule/filter_payment_methods_spec.rb +++ b/spec/models/tag_rule/filter_payment_methods_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe TagRule::FilterPaymentMethods, type: :model do +RSpec.describe TagRule::FilterPaymentMethods do let!(:tag_rule) { build_stubbed(:filter_payment_methods_tag_rule) } describe "determining whether tags match for a given payment method" do diff --git a/spec/models/tag_rule/filter_products_spec.rb b/spec/models/tag_rule/filter_products_spec.rb index 9b96c4b35d..61aace0e28 100644 --- a/spec/models/tag_rule/filter_products_spec.rb +++ b/spec/models/tag_rule/filter_products_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe TagRule::FilterProducts, type: :model do +RSpec.describe TagRule::FilterProducts do let!(:tag_rule) { build_stubbed(:filter_products_tag_rule) } describe "determining whether tags match for a given variant" do diff --git a/spec/models/tag_rule/filter_shipping_methods_spec.rb b/spec/models/tag_rule/filter_shipping_methods_spec.rb index d7c8b37c39..8e53c51eb0 100644 --- a/spec/models/tag_rule/filter_shipping_methods_spec.rb +++ b/spec/models/tag_rule/filter_shipping_methods_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe TagRule::FilterShippingMethods, type: :model do +RSpec.describe TagRule::FilterShippingMethods do let!(:tag_rule) { build_stubbed(:filter_shipping_methods_tag_rule) } describe "determining whether tags match for a given shipping method" do diff --git a/spec/models/tag_rule_spec.rb b/spec/models/tag_rule_spec.rb index 738263cf34..b3dac6ac20 100644 --- a/spec/models/tag_rule_spec.rb +++ b/spec/models/tag_rule_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe TagRule, type: :model do +RSpec.describe TagRule do describe "validations" do it "requires a enterprise" do expect(subject).to belong_to(:enterprise) diff --git a/spec/models/webhook_endpoint_spec.rb b/spec/models/webhook_endpoint_spec.rb index 0150037a3f..2aba887175 100644 --- a/spec/models/webhook_endpoint_spec.rb +++ b/spec/models/webhook_endpoint_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe WebhookEndpoint, type: :model do +RSpec.describe WebhookEndpoint do describe "validations" do it { is_expected.to validate_presence_of(:url) } end