mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-03-01 02:03:22 +00:00
Fixes RSpecRails InferredSpecType offenses in controller admin
This commit is contained in:
@@ -221,30 +221,11 @@ Metrics/PerceivedComplexity:
|
||||
- 'app/models/spree/ability.rb'
|
||||
- 'app/models/spree/order/checkout.rb'
|
||||
|
||||
# Offense count: 134
|
||||
# Offense count: 115
|
||||
# This cop supports unsafe autocorrection (--autocorrect-all).
|
||||
# Configuration parameters: Inferences.
|
||||
RSpecRails/InferredSpecType:
|
||||
Exclude:
|
||||
- 'spec/controllers/admin/bulk_line_items_controller_spec.rb'
|
||||
- 'spec/controllers/admin/column_preferences_controller_spec.rb'
|
||||
- 'spec/controllers/admin/customers_controller_spec.rb'
|
||||
- 'spec/controllers/admin/enterprises_controller_spec.rb'
|
||||
- 'spec/controllers/admin/inventory_items_controller_spec.rb'
|
||||
- 'spec/controllers/admin/invoice_settings_controller_spec.rb'
|
||||
- 'spec/controllers/admin/matomo_settings_controller_spec.rb'
|
||||
- 'spec/controllers/admin/order_cycles_controller_spec.rb'
|
||||
- 'spec/controllers/admin/product_import_controller_spec.rb'
|
||||
- 'spec/controllers/admin/proxy_orders_controller_spec.rb'
|
||||
- 'spec/controllers/admin/reports_controller_spec.rb'
|
||||
- 'spec/controllers/admin/schedules_controller_spec.rb'
|
||||
- 'spec/controllers/admin/stripe_accounts_controller_spec.rb'
|
||||
- 'spec/controllers/admin/stripe_connect_settings_controller_spec.rb'
|
||||
- 'spec/controllers/admin/subscription_line_items_controller_spec.rb'
|
||||
- 'spec/controllers/admin/subscriptions_controller_spec.rb'
|
||||
- 'spec/controllers/admin/tag_rules_controller_spec.rb'
|
||||
- 'spec/controllers/admin/terms_of_service_files_controller_spec.rb'
|
||||
- 'spec/controllers/admin/variant_overrides_controller_spec.rb'
|
||||
- 'spec/controllers/api/v0/customers_controller_spec.rb'
|
||||
- 'spec/controllers/api/v0/enterprise_fees_controller_spec.rb'
|
||||
- 'spec/controllers/api/v0/enterprises_controller_spec.rb'
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::BulkLineItemsController, type: :controller do
|
||||
RSpec.describe Admin::BulkLineItemsController do
|
||||
describe '#index' do
|
||||
render_views
|
||||
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::ColumnPreferencesController, type: :controller do
|
||||
RSpec.describe Admin::ColumnPreferencesController do
|
||||
include AuthenticationHelper
|
||||
|
||||
describe "bulk_update" do
|
||||
|
||||
@@ -3,7 +3,7 @@
|
||||
require 'spec_helper'
|
||||
|
||||
module Admin
|
||||
RSpec.describe CustomersController, type: :controller do
|
||||
RSpec.describe CustomersController do
|
||||
include AuthenticationHelper
|
||||
|
||||
describe "index" do
|
||||
|
||||
@@ -3,7 +3,7 @@
|
||||
require 'spec_helper'
|
||||
require 'open_food_network/order_cycle_permissions'
|
||||
|
||||
RSpec.describe Admin::EnterprisesController, type: :controller do
|
||||
RSpec.describe Admin::EnterprisesController do
|
||||
let(:user) { create(:user) }
|
||||
let(:admin_user) { create(:admin_user) }
|
||||
let(:distributor_manager) { create(:user, enterprise_limit: 10, enterprises: [distributor]) }
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::InventoryItemsController, type: :controller do
|
||||
RSpec.describe Admin::InventoryItemsController do
|
||||
describe "create" do
|
||||
context "json" do
|
||||
let(:format) { :json }
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::InvoiceSettingsController, type: :controller do
|
||||
RSpec.describe Admin::InvoiceSettingsController do
|
||||
describe "#update" do
|
||||
let(:params) {
|
||||
{
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::MatomoSettingsController, type: :controller do
|
||||
RSpec.describe Admin::MatomoSettingsController do
|
||||
describe "#update" do
|
||||
let(:params) {
|
||||
{
|
||||
|
||||
@@ -3,7 +3,7 @@
|
||||
require 'spec_helper'
|
||||
|
||||
module Admin
|
||||
RSpec.describe OrderCyclesController, type: :controller do
|
||||
RSpec.describe OrderCyclesController do
|
||||
let!(:distributor_owner) { create(:user) }
|
||||
let(:datetime_confirmation_attrs) {
|
||||
{ confirm_datetime_change: nil,
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::ProductImportController, type: :controller do
|
||||
RSpec.describe Admin::ProductImportController do
|
||||
describe 'validate_file_path' do
|
||||
let(:tmp_directory_base) { Rails.root.join("tmp/product_import-") }
|
||||
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::ProxyOrdersController, type: :controller do
|
||||
RSpec.describe Admin::ProxyOrdersController do
|
||||
include AuthenticationHelper
|
||||
|
||||
describe 'cancel' do
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::ReportsController, type: :controller do
|
||||
RSpec.describe Admin::ReportsController do
|
||||
# Given two distributors and two suppliers
|
||||
let(:bill_address) { create(:address) }
|
||||
let(:ship_address) { create(:address) }
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::SchedulesController, type: :controller do
|
||||
RSpec.describe Admin::SchedulesController do
|
||||
include AuthenticationHelper
|
||||
|
||||
describe "index" do
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::StripeAccountsController, type: :controller do
|
||||
RSpec.describe Admin::StripeAccountsController do
|
||||
let(:enterprise) { create(:distributor_enterprise) }
|
||||
|
||||
describe "#connect" do
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::StripeConnectSettingsController, type: :controller do
|
||||
RSpec.describe Admin::StripeConnectSettingsController do
|
||||
let(:user) { create(:user) }
|
||||
let(:admin) { create(:admin_user) }
|
||||
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::SubscriptionLineItemsController, type: :controller do
|
||||
RSpec.describe Admin::SubscriptionLineItemsController do
|
||||
include AuthenticationHelper
|
||||
|
||||
describe "build" do
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::SubscriptionsController, type: :controller do
|
||||
RSpec.describe Admin::SubscriptionsController do
|
||||
include AuthenticationHelper
|
||||
|
||||
describe 'index' do
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::TagRulesController, type: :controller do
|
||||
RSpec.describe Admin::TagRulesController do
|
||||
describe "destroy" do
|
||||
context "json" do
|
||||
let(:format) { :json }
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::TermsOfServiceFilesController, type: :controller do
|
||||
RSpec.describe Admin::TermsOfServiceFilesController do
|
||||
context "a non-admin user" do
|
||||
let(:user) { create(:user) }
|
||||
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
RSpec.describe Admin::VariantOverridesController, type: :controller do
|
||||
RSpec.describe Admin::VariantOverridesController do
|
||||
describe "index" do
|
||||
context "not logged in" do
|
||||
it "redirects to login" do
|
||||
|
||||
Reference in New Issue
Block a user