diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 342b5a58f9..410348d6e4 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -221,30 +221,11 @@ Metrics/PerceivedComplexity: - 'app/models/spree/ability.rb' - 'app/models/spree/order/checkout.rb' -# Offense count: 134 +# Offense count: 115 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpecRails/InferredSpecType: Exclude: - - 'spec/controllers/admin/bulk_line_items_controller_spec.rb' - - 'spec/controllers/admin/column_preferences_controller_spec.rb' - - 'spec/controllers/admin/customers_controller_spec.rb' - - 'spec/controllers/admin/enterprises_controller_spec.rb' - - 'spec/controllers/admin/inventory_items_controller_spec.rb' - - 'spec/controllers/admin/invoice_settings_controller_spec.rb' - - 'spec/controllers/admin/matomo_settings_controller_spec.rb' - - 'spec/controllers/admin/order_cycles_controller_spec.rb' - - 'spec/controllers/admin/product_import_controller_spec.rb' - - 'spec/controllers/admin/proxy_orders_controller_spec.rb' - - 'spec/controllers/admin/reports_controller_spec.rb' - - 'spec/controllers/admin/schedules_controller_spec.rb' - - 'spec/controllers/admin/stripe_accounts_controller_spec.rb' - - 'spec/controllers/admin/stripe_connect_settings_controller_spec.rb' - - 'spec/controllers/admin/subscription_line_items_controller_spec.rb' - - 'spec/controllers/admin/subscriptions_controller_spec.rb' - - 'spec/controllers/admin/tag_rules_controller_spec.rb' - - 'spec/controllers/admin/terms_of_service_files_controller_spec.rb' - - 'spec/controllers/admin/variant_overrides_controller_spec.rb' - 'spec/controllers/api/v0/customers_controller_spec.rb' - 'spec/controllers/api/v0/enterprise_fees_controller_spec.rb' - 'spec/controllers/api/v0/enterprises_controller_spec.rb' diff --git a/spec/controllers/admin/bulk_line_items_controller_spec.rb b/spec/controllers/admin/bulk_line_items_controller_spec.rb index a69798da31..840df6e506 100644 --- a/spec/controllers/admin/bulk_line_items_controller_spec.rb +++ b/spec/controllers/admin/bulk_line_items_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::BulkLineItemsController, type: :controller do +RSpec.describe Admin::BulkLineItemsController do describe '#index' do render_views diff --git a/spec/controllers/admin/column_preferences_controller_spec.rb b/spec/controllers/admin/column_preferences_controller_spec.rb index c29153534d..d8d5bcc389 100644 --- a/spec/controllers/admin/column_preferences_controller_spec.rb +++ b/spec/controllers/admin/column_preferences_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::ColumnPreferencesController, type: :controller do +RSpec.describe Admin::ColumnPreferencesController do include AuthenticationHelper describe "bulk_update" do diff --git a/spec/controllers/admin/customers_controller_spec.rb b/spec/controllers/admin/customers_controller_spec.rb index 4a153c1410..9d3265af9a 100644 --- a/spec/controllers/admin/customers_controller_spec.rb +++ b/spec/controllers/admin/customers_controller_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' module Admin - RSpec.describe CustomersController, type: :controller do + RSpec.describe CustomersController do include AuthenticationHelper describe "index" do diff --git a/spec/controllers/admin/enterprises_controller_spec.rb b/spec/controllers/admin/enterprises_controller_spec.rb index 415f75cc2a..3806969b49 100644 --- a/spec/controllers/admin/enterprises_controller_spec.rb +++ b/spec/controllers/admin/enterprises_controller_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' require 'open_food_network/order_cycle_permissions' -RSpec.describe Admin::EnterprisesController, type: :controller do +RSpec.describe Admin::EnterprisesController do let(:user) { create(:user) } let(:admin_user) { create(:admin_user) } let(:distributor_manager) { create(:user, enterprise_limit: 10, enterprises: [distributor]) } diff --git a/spec/controllers/admin/inventory_items_controller_spec.rb b/spec/controllers/admin/inventory_items_controller_spec.rb index 58650e4aa5..7c5395dc16 100644 --- a/spec/controllers/admin/inventory_items_controller_spec.rb +++ b/spec/controllers/admin/inventory_items_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::InventoryItemsController, type: :controller do +RSpec.describe Admin::InventoryItemsController do describe "create" do context "json" do let(:format) { :json } diff --git a/spec/controllers/admin/invoice_settings_controller_spec.rb b/spec/controllers/admin/invoice_settings_controller_spec.rb index de8edc2a62..8ee561adb5 100644 --- a/spec/controllers/admin/invoice_settings_controller_spec.rb +++ b/spec/controllers/admin/invoice_settings_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::InvoiceSettingsController, type: :controller do +RSpec.describe Admin::InvoiceSettingsController do describe "#update" do let(:params) { { diff --git a/spec/controllers/admin/matomo_settings_controller_spec.rb b/spec/controllers/admin/matomo_settings_controller_spec.rb index f488bd9637..d3b5924e90 100644 --- a/spec/controllers/admin/matomo_settings_controller_spec.rb +++ b/spec/controllers/admin/matomo_settings_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::MatomoSettingsController, type: :controller do +RSpec.describe Admin::MatomoSettingsController do describe "#update" do let(:params) { { diff --git a/spec/controllers/admin/order_cycles_controller_spec.rb b/spec/controllers/admin/order_cycles_controller_spec.rb index 59f848f53e..bd0c911011 100644 --- a/spec/controllers/admin/order_cycles_controller_spec.rb +++ b/spec/controllers/admin/order_cycles_controller_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' module Admin - RSpec.describe OrderCyclesController, type: :controller do + RSpec.describe OrderCyclesController do let!(:distributor_owner) { create(:user) } let(:datetime_confirmation_attrs) { { confirm_datetime_change: nil, diff --git a/spec/controllers/admin/product_import_controller_spec.rb b/spec/controllers/admin/product_import_controller_spec.rb index ac6cf560f1..6e3a63b43b 100644 --- a/spec/controllers/admin/product_import_controller_spec.rb +++ b/spec/controllers/admin/product_import_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::ProductImportController, type: :controller do +RSpec.describe Admin::ProductImportController do describe 'validate_file_path' do let(:tmp_directory_base) { Rails.root.join("tmp/product_import-") } diff --git a/spec/controllers/admin/proxy_orders_controller_spec.rb b/spec/controllers/admin/proxy_orders_controller_spec.rb index 78cb77d343..ddd4158266 100644 --- a/spec/controllers/admin/proxy_orders_controller_spec.rb +++ b/spec/controllers/admin/proxy_orders_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::ProxyOrdersController, type: :controller do +RSpec.describe Admin::ProxyOrdersController do include AuthenticationHelper describe 'cancel' do diff --git a/spec/controllers/admin/reports_controller_spec.rb b/spec/controllers/admin/reports_controller_spec.rb index 81eeccbf77..d0b6104d8c 100644 --- a/spec/controllers/admin/reports_controller_spec.rb +++ b/spec/controllers/admin/reports_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::ReportsController, type: :controller do +RSpec.describe Admin::ReportsController do # Given two distributors and two suppliers let(:bill_address) { create(:address) } let(:ship_address) { create(:address) } diff --git a/spec/controllers/admin/schedules_controller_spec.rb b/spec/controllers/admin/schedules_controller_spec.rb index 01d85ab693..ee15ea1a61 100644 --- a/spec/controllers/admin/schedules_controller_spec.rb +++ b/spec/controllers/admin/schedules_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::SchedulesController, type: :controller do +RSpec.describe Admin::SchedulesController do include AuthenticationHelper describe "index" do diff --git a/spec/controllers/admin/stripe_accounts_controller_spec.rb b/spec/controllers/admin/stripe_accounts_controller_spec.rb index 93774422fa..19a199b12d 100644 --- a/spec/controllers/admin/stripe_accounts_controller_spec.rb +++ b/spec/controllers/admin/stripe_accounts_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::StripeAccountsController, type: :controller do +RSpec.describe Admin::StripeAccountsController do let(:enterprise) { create(:distributor_enterprise) } describe "#connect" do diff --git a/spec/controllers/admin/stripe_connect_settings_controller_spec.rb b/spec/controllers/admin/stripe_connect_settings_controller_spec.rb index ac56335e2d..fa6d800916 100644 --- a/spec/controllers/admin/stripe_connect_settings_controller_spec.rb +++ b/spec/controllers/admin/stripe_connect_settings_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::StripeConnectSettingsController, type: :controller do +RSpec.describe Admin::StripeConnectSettingsController do let(:user) { create(:user) } let(:admin) { create(:admin_user) } diff --git a/spec/controllers/admin/subscription_line_items_controller_spec.rb b/spec/controllers/admin/subscription_line_items_controller_spec.rb index 5926abf23d..03955d13a3 100644 --- a/spec/controllers/admin/subscription_line_items_controller_spec.rb +++ b/spec/controllers/admin/subscription_line_items_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::SubscriptionLineItemsController, type: :controller do +RSpec.describe Admin::SubscriptionLineItemsController do include AuthenticationHelper describe "build" do diff --git a/spec/controllers/admin/subscriptions_controller_spec.rb b/spec/controllers/admin/subscriptions_controller_spec.rb index a929c9509c..ceb18d03df 100644 --- a/spec/controllers/admin/subscriptions_controller_spec.rb +++ b/spec/controllers/admin/subscriptions_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::SubscriptionsController, type: :controller do +RSpec.describe Admin::SubscriptionsController do include AuthenticationHelper describe 'index' do diff --git a/spec/controllers/admin/tag_rules_controller_spec.rb b/spec/controllers/admin/tag_rules_controller_spec.rb index 66930b43ce..5e9cb14ab2 100644 --- a/spec/controllers/admin/tag_rules_controller_spec.rb +++ b/spec/controllers/admin/tag_rules_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::TagRulesController, type: :controller do +RSpec.describe Admin::TagRulesController do describe "destroy" do context "json" do let(:format) { :json } diff --git a/spec/controllers/admin/terms_of_service_files_controller_spec.rb b/spec/controllers/admin/terms_of_service_files_controller_spec.rb index dac296ea95..0a2e4e8099 100644 --- a/spec/controllers/admin/terms_of_service_files_controller_spec.rb +++ b/spec/controllers/admin/terms_of_service_files_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::TermsOfServiceFilesController, type: :controller do +RSpec.describe Admin::TermsOfServiceFilesController do context "a non-admin user" do let(:user) { create(:user) } diff --git a/spec/controllers/admin/variant_overrides_controller_spec.rb b/spec/controllers/admin/variant_overrides_controller_spec.rb index 97e917da19..096e5a40e7 100644 --- a/spec/controllers/admin/variant_overrides_controller_spec.rb +++ b/spec/controllers/admin/variant_overrides_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::VariantOverridesController, type: :controller do +RSpec.describe Admin::VariantOverridesController do describe "index" do context "not logged in" do it "redirects to login" do