David Cook
81796db6e5
Fix date-dependent spec
2025-11-04 15:17:45 +00:00
David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
Rachel Arnould
c4c266246c
Merge pull request #13507 from rioug/tag-rules-remove-angular
...
[Variant Tags] Remove angular from tag rule admin page
2025-10-15 23:16:05 +02:00
Gaetan Craig-Riou
6790cad089
Add deleting tag rule
...
TagRuleController is now a subclass of Spree::Admin::BaseController
because Admin::ResourceController did not play well with turbo_stream.
And to be honest we did not need all the functionality provided by the
ResourceController
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
7087d1b290
Add default tag rule
...
I tried to leverage turbo as much as possible
2025-09-24 10:38:53 +10:00
Ahmed Ejaz
ac06126f59
replace cvv_response_message usage with redirect_auth_url
2025-09-22 11:55:43 +05:00
Maikel
bdae8e6478
Merge pull request #13475 from mkllnk/dfc-sib-tokens
...
Accept tokens from Startin'Blox OIDC server
2025-08-27 14:55:30 +10:00
Maikel Linke
1d2115766a
Show product groups to platform user
...
I removed the caching of `managed_enterprises` in Permissions because
it's just a scope and calling it again is very cheap. And that makes the
method a lot easier to read now that we have a conditional here.
Accessing the managed enterprises via the user instead of a separate
scope on the Enterprise model also reduce the SQL queries. We may want
to use this method in more places. I prefer to keep the
admin-conditional in a permissions class instead of in the model.
2025-08-13 15:06:31 +10:00
Gaetan Craig-Riou
66041061fb
Redeem VINE voucher before redirecting to payment url
...
When using paypal, we need to redeem the voucher before redirecting to
the payment gateway url, otherwise the voucher will never get redeemed.
2025-08-11 16:28:04 +10:00
Ahmed Ejaz
75b2fe1dd4
revert API removals
2025-08-01 01:48:21 +05:00
Ahmed Ejaz
df4cf4b768
Fix specs
2025-07-27 07:58:04 +05:00
Gaetan Craig-Riou
7450f8a530
Fix spec, enable inventory when needed
2025-07-09 13:43:18 +10:00
Gaetan Craig-Riou
ddc45e1cd8
Post rebase, fix inventory landing page spec
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
29a24b7305
Scope variant to hub only when inventory enabled
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
7c31c951a1
Refactor spec to use instance_double
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
33bac6f816
Fix specs to take into account inventory feature
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
a6f0a36b6d
Enable inventory feature for inventory related specs
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
f30b899569
Disable inventory option for product import
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
cd8b7cd239
First step disable inventory
2025-07-09 11:35:26 +10:00
Ahmed Ejaz
1b9d64ad5e
Refactor search functionality in variants controller spec to include order_id for improved filtering
2025-06-21 16:39:15 +05:00
Ahmed Ejaz
8e8878e43a
Add search_variants_as parameter to variant search functionality
2025-06-21 16:19:31 +05:00
Maikel Linke
da5b147d29
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:51:50 +10:00
Maikel Linke
b2fd4ccb11
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:50:38 +10:00
Maikel Linke
5a497bc6ee
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:46:30 +10:00
Maikel Linke
77b7b5ea47
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:45:00 +10:00
Maikel Linke
035e67c33f
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:43:47 +10:00
Maikel Linke
8e1fb76327
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:13:11 +10:00
Maikel Linke
441844dd79
Style Metrics/ModuleLength in spec file
...
Best viewed without whitespace changes.
2025-06-16 16:11:08 +10:00
Carlos Chitty
63d284e81a
Use Orders::WorkflowService#complete! and #advance_to_payment in specs to replace code causing Style/NestedModifier rubocop offenses
...
Rewrite the loop "break unless a = order.next! while !order.delivery?" to correct the offenses. Not adding a helper because the change was only needed in a couple of places.
2025-06-04 12:46:58 -04:00
cyrillefr
67f5ae811b
Fixes RSpecRailsInferredSpecType offenses in remaining controllers
2025-05-20 12:51:50 +02:00
cyrillefr
cf9395f42f
Fixes RSpecRailsInferredSpecType in spree admin controllers
2025-05-20 12:45:34 +02:00
cyrillefr
a7eb95afc5
Fixes RSpecRailsInferredSpecType in base controllers
2025-05-20 12:45:34 +02:00
cyrillefr
90d8d9fc30
Fixes RSpecRailsInferredSpecType offense in api v0
2025-05-20 12:45:34 +02:00
cyrillefr
60413c2a12
Fixes RSpecRails InferredSpecType offenses in controller admin
2025-05-20 12:45:34 +02:00
Konrad
c657e31d07
Merge pull request #13318 from dacook/fix-13315
...
Prevent error on inventory page when logged out
2025-05-16 20:23:17 +02:00
Maikel
277c51cd51
Merge pull request #13327 from cyrillefr/FixRSpecRailsHttpStatus
...
Fixes RSpec Rails HttpStatus offenses
2025-05-16 15:41:06 +10:00
Filipe
3efa2832de
Merge pull request #13257 from ashishp91/13221-make-shipped-orders-uneditable
...
13221 - Don't allow shipped orders to be editable
2025-05-15 19:23:33 +01:00
cyrillefr
529f3b85eb
Fixes RSpec Rails HttpStatus offenses
2025-05-15 08:46:02 +02:00
cyrillefr
5063a772f0
Fixes RSpec Rails HaveHttpStatus cop in controllers
2025-05-14 10:58:04 +02:00
cyrillefr
f810e500b5
Fixes RSpec Rails HaveHttpStatus cop in api v0
2025-05-14 10:46:36 +02:00
cyrillefr
b9e1eb2984
Fixes RSpecRails HaveHttpStatus cop in admin specs
2025-05-14 10:28:57 +02:00
David Cook
6a5faaef22
Add expectation for redirect
2025-05-13 15:20:07 +10:00
David Cook
f199fb182b
Add specs
2025-05-12 17:35:10 +10:00
cyrillefr
42daf314c4
Fixes variable number naming offenses in spec variables
2025-05-08 09:28:01 +02:00
Ashish Gaur
5fc3fe03ee
13221 Add spec for checking flash error is shown when editing a shipped order
2025-05-05 20:37:59 +05:30
Carlos Chitty
446be6e127
Fix test failure due to hash interpreted as block in matcher
...
Wrap hash in parentheses to ensure it's passed as an argument rather than a block.
2025-04-29 15:16:29 -04:00
Carlos Chitty
63168086e7
Autocorrect Style/HashConversion offenses
2025-04-29 14:27:31 -04:00
cyrillefr
7812d5f58a
Replace set_methods in order model
2025-04-24 09:29:40 +02:00
Ahmed Ejaz
eee5d5c8ad
fix buggy spec:
...
- this before block was causing multiple nevigation to the index
- one from the spec itself, one from here.
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
b803e18f42
fix lint issues
2025-04-13 21:35:55 +05:00
