mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-02-27 01:43:22 +00:00
Style Metrics/ModuleLength in spec file
Best viewed without whitespace changes.
This commit is contained in:
Maikel Linke
@@ -171,7 +171,6 @@ Metrics/ModuleLength:
|
||||
- 'engines/order_management/spec/services/order_management/subscriptions/validator_spec.rb'
|
||||
- 'engines/order_management/spec/services/order_management/subscriptions/variants_list_spec.rb'
|
||||
- 'lib/open_food_network/column_preference_defaults.rb'
|
||||
- 'spec/controllers/spree/admin/variants_controller_spec.rb'
|
||||
- 'spec/lib/open_food_network/address_finder_spec.rb'
|
||||
- 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb'
|
||||
- 'spec/lib/open_food_network/order_cycle_permissions_spec.rb'
|
||||
|
||||
@@ -2,205 +2,201 @@
|
||||
|
||||
require 'spec_helper'
|
||||
|
||||
module Spree
|
||||
module Admin
|
||||
RSpec.describe VariantsController do
|
||||
context "log in as admin user" do
|
||||
before { controller_login_as_admin }
|
||||
RSpec.describe Spree::Admin::VariantsController do
|
||||
context "log in as admin user" do
|
||||
before { controller_login_as_admin }
|
||||
|
||||
describe "#index" do
|
||||
describe "deleted variants" do
|
||||
let(:product) { create(:product, name: 'Product A') }
|
||||
let(:deleted_variant) do
|
||||
deleted_variant = product.variants.create(
|
||||
unit_value: "2", variant_unit: "weight", variant_unit_scale: 1, price: 1,
|
||||
primary_taxon: create(:taxon), supplier: create(:supplier_enterprise)
|
||||
)
|
||||
deleted_variant.delete
|
||||
deleted_variant
|
||||
end
|
||||
|
||||
it "lists only non-deleted variants with params[:deleted] == off" do
|
||||
spree_get :index, product_id: product.id, deleted: "off"
|
||||
expect(assigns(:variants)).to eq(product.variants)
|
||||
end
|
||||
|
||||
it "lists only deleted variants with params[:deleted] == on" do
|
||||
spree_get :index, product_id: product.id, deleted: "on"
|
||||
expect(assigns(:variants)).to eq([deleted_variant])
|
||||
end
|
||||
end
|
||||
describe "#index" do
|
||||
describe "deleted variants" do
|
||||
let(:product) { create(:product, name: 'Product A') }
|
||||
let(:deleted_variant) do
|
||||
deleted_variant = product.variants.create(
|
||||
unit_value: "2", variant_unit: "weight", variant_unit_scale: 1, price: 1,
|
||||
primary_taxon: create(:taxon), supplier: create(:supplier_enterprise)
|
||||
)
|
||||
deleted_variant.delete
|
||||
deleted_variant
|
||||
end
|
||||
|
||||
describe "#update" do
|
||||
let!(:variant) {
|
||||
create(
|
||||
:variant,
|
||||
display_name: "Tomatoes",
|
||||
sku: 123,
|
||||
supplier: producer
|
||||
)
|
||||
}
|
||||
let(:producer) { create(:enterprise) }
|
||||
|
||||
it "updates the variant" do
|
||||
expect {
|
||||
spree_put(
|
||||
:update,
|
||||
id: variant.id,
|
||||
product_id: variant.product.id,
|
||||
variant: { display_name: "Better tomatoes", sku: 456 }
|
||||
)
|
||||
variant.reload
|
||||
}.to change { variant.display_name }.to("Better tomatoes")
|
||||
.and change { variant.sku }.to(456.to_s)
|
||||
end
|
||||
|
||||
context "when updating supplier" do
|
||||
let(:new_producer) { create(:enterprise) }
|
||||
|
||||
it "updates the supplier" do
|
||||
expect {
|
||||
spree_put(
|
||||
:update,
|
||||
id: variant.id,
|
||||
product_id: variant.product.id,
|
||||
variant: { supplier_id: new_producer.id }
|
||||
)
|
||||
variant.reload
|
||||
}.to change { variant.supplier_id }.to(new_producer.id)
|
||||
end
|
||||
|
||||
it "removes associated product from existing Order Cycles" do
|
||||
distributor = create(:distributor_enterprise)
|
||||
order_cycle = create(
|
||||
:simple_order_cycle,
|
||||
variants: [variant],
|
||||
coordinator: distributor,
|
||||
distributors: [distributor]
|
||||
)
|
||||
|
||||
spree_put(
|
||||
:update,
|
||||
id: variant.id,
|
||||
product_id: variant.product.id,
|
||||
variant: { supplier_id: new_producer.id }
|
||||
)
|
||||
|
||||
expect(order_cycle.reload.distributed_variants).not_to include variant
|
||||
end
|
||||
end
|
||||
it "lists only non-deleted variants with params[:deleted] == off" do
|
||||
spree_get :index, product_id: product.id, deleted: "off"
|
||||
expect(assigns(:variants)).to eq(product.variants)
|
||||
end
|
||||
|
||||
describe "#search" do
|
||||
let(:supplier) { create(:supplier_enterprise) }
|
||||
let!(:p1) { create(:simple_product, name: 'Product 1', supplier_id: supplier.id) }
|
||||
let!(:p2) { create(:simple_product, name: 'Product 2', supplier_id: supplier.id) }
|
||||
let!(:v1) { p1.variants.first }
|
||||
let!(:v2) { p2.variants.first }
|
||||
let!(:vo) { create(:variant_override, variant: v1, hub: d, count_on_hand: 44) }
|
||||
let!(:d) { create(:distributor_enterprise) }
|
||||
let!(:oc) { create(:simple_order_cycle, distributors: [d], variants: [v1]) }
|
||||
|
||||
it "filters by distributor" do
|
||||
spree_get :search, q: 'Prod', distributor_id: d.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
end
|
||||
|
||||
it "applies variant overrides" do
|
||||
spree_get :search, q: 'Prod', distributor_id: d.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
expect(assigns(:variants).first.on_hand).to eq(44)
|
||||
end
|
||||
|
||||
it "filters by order cycle" do
|
||||
spree_get :search, q: 'Prod', order_cycle_id: oc.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
end
|
||||
|
||||
it "does not filter when no distributor or order cycle is specified" do
|
||||
spree_get :search, q: 'Prod'
|
||||
expect(assigns(:variants)).to match_array [v1, v2]
|
||||
end
|
||||
end
|
||||
|
||||
describe '#destroy' do
|
||||
let(:variant) { create(:variant) }
|
||||
|
||||
context 'when requesting with html' do
|
||||
before do
|
||||
allow(Spree::Variant).to receive(:find).with(variant.id.to_s) { variant }
|
||||
allow(variant).to receive(:destroy).and_call_original
|
||||
end
|
||||
|
||||
it 'deletes the variant' do
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(variant).to have_received(:destroy)
|
||||
end
|
||||
|
||||
it 'shows a success flash message' do
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(flash[:success]).to be
|
||||
end
|
||||
|
||||
it 'redirects to admin_product_variants_url' do
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(response).to redirect_to spree.admin_product_variants_url(variant.product.id)
|
||||
end
|
||||
|
||||
it 'destroys all its exchanges' do
|
||||
exchange = create(:exchange)
|
||||
variant.exchanges << exchange
|
||||
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(variant.exchanges.reload).to be_empty
|
||||
end
|
||||
end
|
||||
it "lists only deleted variants with params[:deleted] == on" do
|
||||
spree_get :index, product_id: product.id, deleted: "on"
|
||||
expect(assigns(:variants)).to eq([deleted_variant])
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context "log in as supplier and distributor enable_producers_to_edit_orders" do
|
||||
let(:supplier1) { create(:supplier_enterprise) }
|
||||
let(:supplier2) { create(:supplier_enterprise) }
|
||||
let!(:p1) { create(:simple_product, name: 'Product 1', supplier_id: supplier1.id) }
|
||||
let!(:p2) { create(:simple_product, name: 'Product 2', supplier_id: supplier2.id) }
|
||||
let!(:v1) { p1.variants.first }
|
||||
let!(:v2) { p2.variants.first }
|
||||
let!(:d) { create(:distributor_enterprise, enable_producers_to_edit_orders: true) }
|
||||
let!(:oc) { create(:simple_order_cycle, distributors: [d], variants: [v1, v2]) }
|
||||
describe "#update" do
|
||||
let!(:variant) {
|
||||
create(
|
||||
:variant,
|
||||
display_name: "Tomatoes",
|
||||
sku: 123,
|
||||
supplier: producer
|
||||
)
|
||||
}
|
||||
let(:producer) { create(:enterprise) }
|
||||
|
||||
it "updates the variant" do
|
||||
expect {
|
||||
spree_put(
|
||||
:update,
|
||||
id: variant.id,
|
||||
product_id: variant.product.id,
|
||||
variant: { display_name: "Better tomatoes", sku: 456 }
|
||||
)
|
||||
variant.reload
|
||||
}.to change { variant.display_name }.to("Better tomatoes")
|
||||
.and change { variant.sku }.to(456.to_s)
|
||||
end
|
||||
|
||||
context "when updating supplier" do
|
||||
let(:new_producer) { create(:enterprise) }
|
||||
|
||||
it "updates the supplier" do
|
||||
expect {
|
||||
spree_put(
|
||||
:update,
|
||||
id: variant.id,
|
||||
product_id: variant.product.id,
|
||||
variant: { supplier_id: new_producer.id }
|
||||
)
|
||||
variant.reload
|
||||
}.to change { variant.supplier_id }.to(new_producer.id)
|
||||
end
|
||||
|
||||
it "removes associated product from existing Order Cycles" do
|
||||
distributor = create(:distributor_enterprise)
|
||||
order_cycle = create(
|
||||
:simple_order_cycle,
|
||||
variants: [variant],
|
||||
coordinator: distributor,
|
||||
distributors: [distributor]
|
||||
)
|
||||
|
||||
spree_put(
|
||||
:update,
|
||||
id: variant.id,
|
||||
product_id: variant.product.id,
|
||||
variant: { supplier_id: new_producer.id }
|
||||
)
|
||||
|
||||
expect(order_cycle.reload.distributed_variants).not_to include variant
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe "#search" do
|
||||
let(:supplier) { create(:supplier_enterprise) }
|
||||
let!(:p1) { create(:simple_product, name: 'Product 1', supplier_id: supplier.id) }
|
||||
let!(:p2) { create(:simple_product, name: 'Product 2', supplier_id: supplier.id) }
|
||||
let!(:v1) { p1.variants.first }
|
||||
let!(:v2) { p2.variants.first }
|
||||
let!(:vo) { create(:variant_override, variant: v1, hub: d, count_on_hand: 44) }
|
||||
let!(:d) { create(:distributor_enterprise) }
|
||||
let!(:oc) { create(:simple_order_cycle, distributors: [d], variants: [v1]) }
|
||||
|
||||
it "filters by distributor" do
|
||||
spree_get :search, q: 'Prod', distributor_id: d.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
end
|
||||
|
||||
it "applies variant overrides" do
|
||||
spree_get :search, q: 'Prod', distributor_id: d.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
expect(assigns(:variants).first.on_hand).to eq(44)
|
||||
end
|
||||
|
||||
it "filters by order cycle" do
|
||||
spree_get :search, q: 'Prod', order_cycle_id: oc.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
end
|
||||
|
||||
it "does not filter when no distributor or order cycle is specified" do
|
||||
spree_get :search, q: 'Prod'
|
||||
expect(assigns(:variants)).to match_array [v1, v2]
|
||||
end
|
||||
end
|
||||
|
||||
describe '#destroy' do
|
||||
let(:variant) { create(:variant) }
|
||||
|
||||
context 'when requesting with html' do
|
||||
before do
|
||||
order = create(:order_with_line_items, distributor: d, line_items_count: 1)
|
||||
order.line_items.take.variant.update_attribute(:supplier_id, supplier1.id)
|
||||
controller_login_as_enterprise_user([supplier1])
|
||||
allow(Spree::Variant).to receive(:find).with(variant.id.to_s) { variant }
|
||||
allow(variant).to receive(:destroy).and_call_original
|
||||
end
|
||||
|
||||
describe "#search" do
|
||||
it "filters by distributor and supplier1 products" do
|
||||
spree_get :search, q: 'Prod', distributor_id: d.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
end
|
||||
it 'deletes the variant' do
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(variant).to have_received(:destroy)
|
||||
end
|
||||
|
||||
describe "#update" do
|
||||
it "updates the variant" do
|
||||
expect {
|
||||
spree_put(
|
||||
:update,
|
||||
id: v1.id,
|
||||
product_id: v1.product.id,
|
||||
variant: { display_name: "Better tomatoes", sku: 456 }
|
||||
)
|
||||
v1.reload
|
||||
}.to change { v1.display_name }.to("Better tomatoes")
|
||||
.and change { v1.sku }.to(456.to_s)
|
||||
end
|
||||
it 'shows a success flash message' do
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(flash[:success]).to be
|
||||
end
|
||||
|
||||
it 'redirects to admin_product_variants_url' do
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(response).to redirect_to spree.admin_product_variants_url(variant.product.id)
|
||||
end
|
||||
|
||||
it 'destroys all its exchanges' do
|
||||
exchange = create(:exchange)
|
||||
variant.exchanges << exchange
|
||||
|
||||
spree_delete :destroy, id: variant.id, product_id: variant.product.id,
|
||||
format: 'html'
|
||||
expect(variant.exchanges.reload).to be_empty
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context "log in as supplier and distributor enable_producers_to_edit_orders" do
|
||||
let(:supplier1) { create(:supplier_enterprise) }
|
||||
let(:supplier2) { create(:supplier_enterprise) }
|
||||
let!(:p1) { create(:simple_product, name: 'Product 1', supplier_id: supplier1.id) }
|
||||
let!(:p2) { create(:simple_product, name: 'Product 2', supplier_id: supplier2.id) }
|
||||
let!(:v1) { p1.variants.first }
|
||||
let!(:v2) { p2.variants.first }
|
||||
let!(:d) { create(:distributor_enterprise, enable_producers_to_edit_orders: true) }
|
||||
let!(:oc) { create(:simple_order_cycle, distributors: [d], variants: [v1, v2]) }
|
||||
|
||||
before do
|
||||
order = create(:order_with_line_items, distributor: d, line_items_count: 1)
|
||||
order.line_items.take.variant.update_attribute(:supplier_id, supplier1.id)
|
||||
controller_login_as_enterprise_user([supplier1])
|
||||
end
|
||||
|
||||
describe "#search" do
|
||||
it "filters by distributor and supplier1 products" do
|
||||
spree_get :search, q: 'Prod', distributor_id: d.id.to_s
|
||||
expect(assigns(:variants)).to eq([v1])
|
||||
end
|
||||
end
|
||||
|
||||
describe "#update" do
|
||||
it "updates the variant" do
|
||||
expect {
|
||||
spree_put(
|
||||
:update,
|
||||
id: v1.id,
|
||||
product_id: v1.product.id,
|
||||
variant: { display_name: "Better tomatoes", sku: 456 }
|
||||
)
|
||||
v1.reload
|
||||
}.to change { v1.display_name }.to("Better tomatoes")
|
||||
.and change { v1.sku }.to(456.to_s)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user