Matt-Yorkley
ddf6e7eadd
Use proper module/namespace
2022-01-14 19:41:08 +00:00
Matt-Yorkley
48c4ecde08
Update checkout specs using deleted OrderCompletionReset
2022-01-14 19:41:08 +00:00
Matt-Yorkley
410485fbf4
Use #order_failed_route in #process_order_completion!
2022-01-14 19:41:08 +00:00
Matt-Yorkley
072f4f4c60
Use new stripe confirm path and remove dead code
2022-01-14 19:41:08 +00:00
Matt-Yorkley
3f3bfadb59
Simplify StripeScaPaymentAuthorize and clarify both return URL types (checkout and off-session)
2022-01-14 19:41:08 +00:00
Matt-Yorkley
7b8e1f5c30
Update/improve paypal controller specs
2022-01-14 19:41:08 +00:00
Matt-Yorkley
9583a3cc3d
Use order token param in specs
2022-01-14 19:41:08 +00:00
Matt-Yorkley
9b2801db24
Fix calls to private method #expire_current_order in specs
2022-01-14 19:41:08 +00:00
Matt-Yorkley
7fe770a855
Add route to catch pre-existing payments which may still use Checkout#edit as return URL
2022-01-14 19:41:08 +00:00
Matt-Yorkley
789c29f678
Extract #load_checkout_order
2022-01-14 19:41:08 +00:00
Matt-Yorkley
daee5b49b5
Extract #process_payment_completion!
2022-01-14 19:41:08 +00:00
Matt-Yorkley
76647863e8
Add new Stripe controller
2022-01-14 19:41:08 +00:00
Matt-Yorkley
28d89103eb
Extract #gateway_error
2022-01-14 19:41:08 +00:00
Matt-Yorkley
7633255bea
Extract #order_failed_route
2022-01-14 19:41:08 +00:00
Matt-Yorkley
414e1eb299
Tidy up OrdersController#load_order
2022-01-14 19:41:08 +00:00
Matt-Yorkley
6385d9a782
Simplify interface of #order_completion_route
2022-01-14 19:41:08 +00:00
Matt-Yorkley
7cbdb7c1a2
Remove paypal-specific workaround from OrdersController
...
The previous commit means this is no longer needed here.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
1b459b2491
Extract #processing_failed
2022-01-14 19:41:08 +00:00
Matt-Yorkley
c1defdb1ff
Extract #order_processing_error
2022-01-14 19:41:08 +00:00
Matt-Yorkley
5c44614a8d
Extract and standardise payment/checkout #processing_succeeded
2022-01-14 19:41:08 +00:00
Matt-Yorkley
96f30133a7
Don't reset order for split checkout
...
The various places where we "reset" an order to cart state if a checkout submission does not succeed are an artifact of the process-all-the-steps-at-once approach of the current checkout.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
1e21a6a32f
Extract and standardise use of #handle_insufficient_stock
2022-01-14 19:41:08 +00:00
Matt-Yorkley
b6cf6483f2
Extract and standardise use of order loading around checkout processing
2022-01-14 19:41:08 +00:00
Matt-Yorkley
4d6c4f850f
Remove pointless callbacks in CheckoutController
...
These exact same checks are already made in #load_order (and #order_invalid_for_checkout?), which is called before these other two (later) callbacks.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
77d89ec7d0
Extract and standardise use of #order_completion_route
2022-01-14 19:41:08 +00:00
Matt-Yorkley
4c1fc2b326
Standardise use of #order_completion_reset
2022-01-14 19:41:08 +00:00
Matt-Yorkley
124b63fad0
Remove unused flash assignment
2022-01-14 19:41:08 +00:00
Matt-Yorkley
01bd77e437
Remove duplicate translation key
2022-01-14 19:41:08 +00:00
Matt-Yorkley
e58b1b1094
Tidy up before and after callbacks
2022-01-14 19:41:08 +00:00
Matt-Yorkley
9b6d4da8d5
Pull related lines into OrderCompletion#order_completion_reset
2022-01-14 19:41:08 +00:00
Matt-Yorkley
02995530e2
Pull apart OrderCompletionReset service
2022-01-14 19:41:08 +00:00
Matt-Yorkley
67b8a55273
Separate OrderCompletionReset from Checkout::PostCheckoutActions and don't pass controller objects to Checkout::PostCheckoutActions
...
We need to separate some of these bits to make them easier to call in different contexts. Also there's some weird stuff happening here with the controller being passed in to the service, and it seems like a code smell to me...
2022-01-14 19:41:08 +00:00
Matt-Yorkley
ad60f2392a
Delete unused return statement
2022-01-14 19:41:08 +00:00
Matt-Yorkley
06eb98bdf4
Extract #valid_order_line_items?
2022-01-14 19:41:08 +00:00
Transifex-Openfoodnetwork
3daaa9d50b
Updating translations for config/locales/es.yml
2022-01-15 05:45:15 +11:00
Matt-Yorkley
c5c5738382
Merge pull request #8706 from openfoodfoundation/mkllnk-pr-template
...
Change instructions to move release notes to the title of a new pull request
2022-01-14 13:57:28 +00:00
Matt-Yorkley
2d746a5f30
Merge pull request #8723 from cillian/remove-unused-js-from-general-settings-edit
...
Remove unused code for currency select menu which no longer exists
2022-01-14 13:54:45 +00:00
Cillian O'Ruanaidh
22a48de033
Remove unused code for currency select menu which no longer exists
...
This removes inline JavaScript for #8699 . This code was for the old currency select menu which was removed in 4839b7bd63
2022-01-14 12:33:30 +00:00
Cillian O'Ruanaidh
bc33df6659
Remove unused inline JavaScript from products/_form.html.haml
...
For #8699 . This code, which was introduced in 1309d80f65 , does not appear to be used. The CSS at https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/webpacker/css/admin/sections/products.scss#L6 is used instead.
2022-01-14 12:07:33 +00:00
Matt-Yorkley
534354a177
Add data migration
2022-01-14 11:23:41 +00:00
Transifex-Openfoodnetwork
93ecc894c6
Updating translations for config/locales/de_DE.yml
2022-01-14 07:09:03 +11:00
Transifex-Openfoodnetwork
f374186b8d
Updating translations for config/locales/fr_CA.yml
2022-01-14 05:20:05 +11:00
Transifex-Openfoodnetwork
883e137a43
Updating translations for config/locales/en_CA.yml
2022-01-14 04:27:24 +11:00
Transifex-Openfoodnetwork
d89bfd30c9
Updating translations for config/locales/en_CA.yml
2022-01-14 03:57:37 +11:00
Matt-Yorkley
1d4803c31a
Whitelist valid step param values
2022-01-13 13:55:33 +00:00
Matt-Yorkley
b850fd6fda
Add controller spec for split checkout
2022-01-13 13:55:33 +00:00
Matt-Yorkley
f378a9a0cb
Merge pull request #8715 from openfoodfoundation/dependabot/npm_and_yarn/karma-6.3.11
...
Bump karma from 6.3.10 to 6.3.11
2022-01-13 13:25:04 +00:00
Transifex-Openfoodnetwork
646bd05973
Updating translations for config/locales/en_FR.yml
2022-01-13 23:00:00 +11:00
Transifex-Openfoodnetwork
2cc1b6a2f8
Updating translations for config/locales/fr.yml
2022-01-13 22:43:21 +11:00
dependabot[bot]
a869388759
Bump karma from 6.3.10 to 6.3.11
...
Bumps [karma](https://github.com/karma-runner/karma ) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/karma-runner/karma/releases )
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.10...v6.3.11 )
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-01-13 10:51:41 +00:00