Simplify interface of #order_completion_route

app/controllers/checkout_controller.rb

@@ -128,7 +128,7 @@ class CheckoutController < ::BaseController
 
     if OrderWorkflow.new(@order).next && order_complete?
       processing_succeeded
-      redirect_to order_completion_route(@order)
+      redirect_to order_completion_route
     else
       processing_failed
     end
@@ -181,10 +181,10 @@ class CheckoutController < ::BaseController
   def update_succeeded_response
     respond_to do |format|
       format.html do
-        respond_with(@order, location: order_completion_route(@order))
+        respond_with(@order, location: order_completion_route)
       end
       format.json do
-        render json: { path: order_completion_route(@order) }, status: :ok
+        render json: { path: order_completion_route }, status: :ok
       end
     end
   end

app/controllers/concerns/order_completion.rb

@@ -31,8 +31,8 @@ module OrderCompletion
     new_order.tokenized_permission.save!
   end
 
-  def order_completion_route(order)
-    main_app.order_path(order, order_token: order.token)
+  def order_completion_route
+    main_app.order_path(@order, order_token: @order.token)
   end
 
   def order_invalid_for_checkout?

app/controllers/payment_gateways/paypal_controller.rb

@@ -54,7 +54,7 @@ module PaymentGateways
 
       if @order.complete?
         processing_succeeded
-        redirect_to order_completion_route(@order)
+        redirect_to order_completion_route
       else
         processing_failed
         redirect_to main_app.checkout_state_path(@order.state)