raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-26 20:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
ae63a507199754f4facd7a00546366178cc2bed8
openfoodnetwork/spec/services
History
Neal Chambers afdddc9237 Safely autocorrect Style/FileRead 
Inspecting 1488 files
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................

Offenses:

lib/tasks/karma.rake:33:15: C: [Corrected] Style/FileRead: Use File.read.
    unit_js = File.open('config/ng-test.conf.js', 'r').read
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/services/upload_sanitizer_spec.rb:13:41: C: [Corrected] Style/FileRead: Use File.read.
    let(:service) { UploadSanitizer.new(File.open(upload).read) }
                                        ^^^^^^^^^^^^^^^^^^^^^^

1488 files inspected, 2 offenses detected, 2 offenses corrected
2023-09-01 08:55:56 +09:00
..
checkout
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
permissions
Safely autocorrect Rails/DurationArithmetic
2023-08-01 22:50:21 +09:00
permitted_attributes
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
sets
Aggregate errors
2023-08-22 11:40:58 +10:00
shop
An order cycle isn't ready for checkout if a tag rule means no payment/shipping methods are available to the customer
2022-10-21 17:21:31 +01:00
variant_units
Guard against unsaved variant's product in OptionValueNamer for product import
2023-06-01 10:12:19 +01:00
address_geocoder_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
cache_service_spec.rb
Fix flaky spec: use milliseconds in cache service and remove sleep
2023-06-16 21:23:44 +01:00
cap_quantity_spec.rb
Fix subscription spec and add more coverage
2023-08-20 12:33:43 +09:00
cart_service_spec.rb
Safely autocorrect Layout/ExtraSpacing
2023-07-20 14:01:44 +10:00
content_sanitizer_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
customer_order_cancellation_spec.rb
When an order is cancelled by a customer send an email to the shop.
2021-01-29 11:23:05 +00:00
default_shipping_category_spec.rb
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
default_stock_location_spec.rb
Remove unused method loading default country
2022-11-02 16:21:15 +11:00
embedded_page_service_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
exchange_products_renderer_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
exchange_variant_bulk_updater_spec.rb
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
file_path_sanitizer_spec.rb
extract file path sanitizer to an independent class
2023-05-17 15:09:48 +10:00
image_importer_spec.rb
Migrate product image from master variant to product
2023-06-16 21:23:44 +01:00
invoice_data_generator_spec.rb
Use the same sorting when choosing a line item to update
2023-08-15 11:33:02 +10:00
invoice_renderer_spec.rb
Rename payments helper
2021-05-03 14:17:54 +01:00
mail_configuration_spec.rb
Remove unused feature to intercept emails
2023-04-26 13:50:31 +10:00
order_available_payment_methods_spec.rb
test when two distributors support the same PMs, and only one PM is checked for a distributor in the OC
2022-11-25 10:04:29 +01:00
order_available_shipping_methods_spec.rb
Update OrderAvailableShippingMethods service
2023-08-14 21:02:47 +01:00
order_cart_reset_spec.rb
Break OrderCartReset in two steps so that memoized method current_customer (that uses memoized current_distributor) is called after reset_distributor
2020-05-26 11:13:16 +01:00
order_checkout_restart_spec.rb
Update Checkout Restart spec
2021-03-23 18:19:06 +00:00
order_cycle_clone_spec.rb
Extract a OrderCycleClone service
2022-10-21 17:21:31 +01:00
order_cycle_distributed_products_spec.rb
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
2021-06-17 22:19:26 +01:00
order_cycle_distributed_variants_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
order_cycle_form_spec.rb
Sorts plucked shipping/payment methods
2023-04-04 09:30:36 +01:00
order_cycle_warning_spec.rb
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
order_cycle_webhook_service_spec.rb
Also send webhook payloads for distributor owners
2023-03-07 15:38:50 +11:00
order_data_masker_spec.rb
Remove I18n keys in service specs
2023-02-16 14:28:14 +01:00
order_factory_spec.rb
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
2021-06-17 22:19:26 +01:00
order_fees_handler_spec.rb
Relocate specs for #provided_by_order_cycle? method extracted from Order class to service
2021-01-29 21:53:11 +00:00
order_invoice_comparator_spec.rb
extract methods related to invoices from the order model to the OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
order_invoice_generator_spec.rb
fix order invoice generator must update the latest invoice
2023-08-21 16:10:05 +01:00
order_payment_finder_spec.rb
Add a :captured_at column on payments to store when they are captured
2021-12-17 14:45:47 +00:00
order_syncer_spec.rb
Merge pull request #10966 from macanudo527/fix_linelength_bundle3
2023-07-20 10:04:24 +10:00
order_tax_adjustments_fetcher_spec.rb
Update tax category specs
2023-07-31 09:23:20 +10:00
order_workflow_spec.rb
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
path_checker_spec.rb
Fix menu indicator on bulk order page
2021-10-26 06:41:30 +09:00
paypal_items_builder_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
place_proxy_order_spec.rb
Remove useless clearing of test emails
2023-04-20 13:35:40 +10:00
process_payment_intent_spec.rb
Fix ProcessPaymentIntent service
2023-06-13 10:14:09 +01:00
product_filters_spec.rb
move product filter helper to a service
2020-08-21 10:29:07 +10:00
product_tag_rules_filterer_spec.rb
Fix Layout/LineLength
2023-07-19 08:39:26 +09:00
products_renderer_spec.rb
Fix Layout/LineLength
2023-08-03 09:49:47 +09:00
search_orders_spec.rb
Update test to add more case with finalized order with no line items
2021-09-23 11:06:58 +02:00
stripe_payment_status_spec.rb
Extract Stripe payment helper methods to a service
2021-07-09 13:42:40 +01:00
tax_rate_finder_spec.rb
Handle tax rates for ShippingMethod
2022-02-15 15:16:58 +01:00
tax_rate_updater_spec.rb
Extract tax rate transition logic to service
2021-01-21 14:50:14 +00:00
terms_of_service_spec.rb
Safely autocorrect Rails/DurationArithmetic
2023-08-01 22:50:21 +09:00
unit_prices_spec.rb
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
2021-06-17 22:19:26 +01:00
upload_sanitizer_spec.rb
Safely autocorrect Style/FileRead
2023-09-01 08:55:56 +09:00
url_generator_spec.rb
Update spec/services/url_generator_spec.rb
2022-01-18 08:45:46 +00:00
user_default_address_setter_spec.rb
Add spec for user default address setter
2020-02-05 14:49:17 +00:00
user_locale_setter_spec.rb
Fix issue Layout/SpaceInsideHashLiteralBraces
2020-10-30 16:50:37 +00:00
variant_overrides_indexed_spec.rb
Run rubocop autocorrect
2020-06-22 12:23:10 +01:00
variants_stock_levels_spec.rb
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
voucher_adjustments_service_spec.rb
Add calculation for percentage voucher
2023-08-11 14:30:48 +10:00
weights_and_measures_spec.rb
guard against variants that use items but have scales
2021-04-07 18:31:15 -07:00