David Cook
f199fb182b
Add specs
2025-05-12 17:35:10 +10:00
Filipe
d8fa3e2a19
Merge pull request #13292 from mkllnk/oc-notify
...
Process order cycle emails individually to avoid duplicates
2025-05-08 13:15:00 +01:00
Maikel
5d4f8313f3
Merge pull request #13305 from filipefurtad0/split_system_specs
...
Split system specs
2025-05-08 10:40:57 +10:00
Maikel
4ef17d3794
Merge pull request #13300 from filipefurtad0/fix_flaky_simple_spec_again
...
Adds tests to toggle the css sections (distributed products)
2025-05-08 10:39:17 +10:00
Maikel
bc3f847a9d
Merge pull request #13299 from cyrillefr/FixRubocopNamingMethodParameterName
...
Fixes NamingMethodParameterName rubocop offense
2025-05-08 10:34:50 +10:00
Gaetan Craig-Riou
532ce7a4d7
Merge pull request #13298 from dacook/cleanup-address-finder
...
Cleanup AddressFinder
2025-05-07 12:16:04 +10:00
filipefurtad0
af8059c22f
Splits shopping_spec
2025-05-06 18:08:51 +01:00
filipefurtad0
e7edc068ef
Splits order_spec
2025-05-06 17:25:01 +01:00
filipefurtad0
81d35741a1
Adds tests to toggle the css sections
...
It's a lucky guess, but the idea is that pre-loading the CSS sections and its contents makes it slightly faster, for following assertions, which are the flaky offenders
2025-05-05 19:50:32 +01:00
cyrillefr
f6df412355
Fixes NamingMethodParameterName rubocop offense
2025-05-05 10:39:15 +02:00
Maikel
45a0185744
Merge pull request #13279 from filipefurtad0/reproduce_12933_stock_reset
...
Reproduces bug #12933 , setting the test case as pending
2025-05-05 14:58:41 +10:00
David Cook
0225db6840
Refactor without setter methods
...
This class was originally built to flexibly accept paramters in any order. It also allowed you to specify multiple of the same type of parameter, with the later one overriding the earlier.
This is too flexible and likely to cause mistakes. And besides, we don't use that feature!
2025-05-05 12:59:27 +10:00
David Cook
3ec14607a6
Merge pull request #13286 from chitty/apr29-rubocop-style-corrections
...
Rubocop Style corrections
2025-05-05 12:53:57 +10:00
David Cook
eadfa8c965
Update from code review
...
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2025-05-05 12:09:58 +10:00
Filipe
846cb4dd89
Merge pull request #13252 from rioug/13159-add-tag-variant
...
[Variant tags] Add variant tag on Bulk Edit Product screen
2025-05-03 17:34:51 +01:00
Maikel Linke
8daa01e228
Process OC emails individually to avoid duplicates
...
Errors or delays can cause multiple duplicate emails to the same
suppliers.
2025-05-02 16:58:00 +10:00
Carlos Chitty
d0c687650e
Autocorrect Style/HashEachMethods offenses
2025-04-29 15:16:34 -04:00
Carlos Chitty
446be6e127
Fix test failure due to hash interpreted as block in matcher
...
Wrap hash in parentheses to ensure it's passed as an argument rather than a block.
2025-04-29 15:16:29 -04:00
Carlos Chitty
63168086e7
Autocorrect Style/HashConversion offenses
2025-04-29 14:27:31 -04:00
Carlos Chitty
17a5b5e620
autocorrect Style/ArrayIntersect offenses
2025-04-29 14:20:50 -04:00
Filipe
69bb78e39c
Merge pull request #13213 from chahmedejaz/task/13128-add-order-number-to-notify-producer-email
...
Add order number to notify producer emails and make customer code available for everyone
2025-04-29 18:22:06 +01:00
Ahmed Ejaz
6f9b5e2c54
fix specs
...
- add a new class .line-items in the orders-summary to better differentiate the line-items summary vs customer-details. This css class is not defined, just .customer-order for customer details. It's only used to make a differentiation in the specs
- use the updated `parsed_email` memoized helper method for mail body content
2025-04-28 15:11:54 +05:00
Ahmed Ejaz
57c30591bc
13128: add order number in OC report
...
- Make Customer Code independant of Customer Names setting
2025-04-28 15:11:52 +05:00
piyush828-design
0bb6860343
Merge branch 'master' into pagy_upgrade
2025-04-28 11:23:44 +05:30
David Cook
e900c95213
Merge pull request #13276 from filipefurtad0/pagy_pagination_spec
...
Adds coverage to pagination (pagy bump)
2025-04-28 13:18:58 +10:00
David Cook
7ed5ca8e1c
Clarify number of users expected
2025-04-28 12:23:53 +10:00
filipefurtad0
ff9e2a33ce
Reproduces bug #12933 , setting the test case as pending
2025-04-27 14:17:28 +01:00
piyush828-design
5e890bb361
Merge branch 'master' into pagy_upgrade
2025-04-24 17:46:39 +05:30
filipefurtad0
1d0d294a09
Adds coverage related to S1 regression #13002
2025-04-24 10:24:13 +01:00
cyrillefr
6fb1737672
Rename get method in spec web helper
2025-04-24 09:29:40 +02:00
cyrillefr
8d5292c4ed
Rename set method in spec helper and calls
2025-04-24 09:29:40 +02:00
cyrillefr
7812d5f58a
Replace set_methods in order model
2025-04-24 09:29:40 +02:00
Gaetan Craig-Riou
bb882ddfa3
Per review, simplify disabling of default action
...
Turns out you can just call `event.preventDefault()` on the action and
there is no need actually use hotkeys to do that.
2025-04-24 13:53:23 +10:00
Filipe
40d4b0c811
Merge pull request #13269 from drummer83/remove_txt-mails
...
Remove text versions of emails
2025-04-23 22:44:39 +01:00
filipefurtad0
e3fff0869e
Adds test case on pagination for zones index page
2025-04-23 19:45:06 +01:00
filipefurtad0
a84c0ffd73
Adds test case on pagination for users index page
2025-04-23 19:45:06 +01:00
Filipe
07842bf5eb
Merge pull request #13081 from pacodelaluna/do-not-allow-spaces-in-external-billing-id
...
Do not allow spaces in external billing
2025-04-23 12:20:02 +01:00
piyush828-design
8c564d344b
Merge branch 'master' into add_coverage_10597
2025-04-22 11:37:54 +05:30
piyush828-design
ed0b7f88a4
updated specs
2025-04-22 11:26:56 +05:30
Gaetan Craig-Riou
b29345007d
Increase query count to take into account tag query
2025-04-22 13:57:55 +10:00
Gaetan Craig-Riou
1479be787b
Prevent adding empty tag
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
31afdfd8c4
Disable "enter" hotkeys only on tag input element
...
We are still able to use enter to submit the form on anyother input.The
tag input creates a new tag when enter is pressed
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
034feabcff
Javascript code linting
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
aba6240736
Per review, use css :has() pseudo class
...
It saves writing some custom javascript, less code to maintain!
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
6417c87047
Add visual feedback when adding tag errors
...
Highlight the tag name in red, if trying to add a tag that already
exists.
2025-04-22 13:42:08 +10:00
Gaetan Craig-Riou
157de25f36
Prettyfy code
2025-04-22 13:41:02 +10:00
Gaetan Craig-Riou
9e1a80c327
Mock hotkeys.js
2025-04-22 13:41:02 +10:00
Gaetan Craig-Riou
94cc774f27
Fix html used in test
...
It get rids of errors, even if they didn't affect the test result it's
noise we don't need
2025-04-22 13:41:02 +10:00
Gaetan Craig-Riou
559249b621
Improve tagListInputController to integrate with bulkFormController
...
tagListInputController is not a standard form controller so we had to
make a few changes to integrate with the change tracking used int
bulkFormController. Mainly we make sure to manually trigger event when
deleting a tags, and we handle the change highlight.
2025-04-22 13:41:01 +10:00
Gaetan Craig-Riou
c15e16900d
Add stimulus tag list input controller
...
It handles the UI to display the list of tags, and lets you add and
remove tags from the list.
2025-04-22 13:41:01 +10:00
