raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-10 23:07:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent adding empty tag

Browse Source
This commit is contained in:
Gaetan Craig-Riou
2025-04-15 15:31:31 +10:00
parent 31afdfd8c4
commit 1479be787b
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/components/tag_list_input_component/tag_list_input_controller.js
View File

@@ -13,7 +13,11 @@ export default class extends Controller {
addTag() {
// Check if tag already exist
const newTagName = this.newTagTarget.value;
const newTagName = this.newTagTarget.value.trim();
if (newTagName.length == 0) {
return;
}
const tags = this.tagListTarget.value.split(",");
const index = tags.indexOf(newTagName);
if (index != -1) {

12
spec/javascripts/stimulus/tag_list_input_controller_test.js
View File

@@ -103,6 +103,18 @@ describe("TagListInputController", () => {
expect(variant_add_tag.value).toBe("");
});
describe("with an empty new tag", () => {
it("doesn't add the tag", () => {
variant_add_tag.value = " ";
variant_add_tag.dispatchEvent(new KeyboardEvent("keydown", { key: "Enter" }));
const tagList = document.getElementsByClassName("tag-list")[0];
// 1 template + 3 tags + new tag (added in the beforeEach)
expect(tagList.childElementCount).toBe(5);
});
});
describe("when tag already exist", () => {
beforeEach(() => {
// Trying to add an existing tag