Javascript code linting

This commit is contained in:
Gaetan Craig-Riou
2025-04-15 13:15:49 +10:00
parent aba6240736
commit 034feabcff
2 changed files with 11 additions and 11 deletions

View File

@@ -5,15 +5,15 @@ export default class extends Controller {
addTag() {
// Check if tag already exist
const newTagName = this.newTagTarget.value
const newTagName = this.newTagTarget.value;
const tags = this.tagListTarget.value.split(",");
const index = tags.indexOf(newTagName);
if (index != -1) {
// highlight the value in red
this.newTagTarget.classList.add("tag-error")
return
}
this.newTagTarget.classList.add("tag-error");
return;
}
// add to tagList
this.tagListTarget.value = this.tagListTarget.value.concat(`,${newTagName}`);
@@ -47,9 +47,9 @@ export default class extends Controller {
filterInput(event) {
// clear error class if key is not enter
if (event.key !== "Enter") {
this.newTagTarget.classList.remove("tag-error")
this.newTagTarget.classList.remove("tag-error");
}
// Strip comma from tag name
if (event.key === ",") {
event.srcElement.value = event.srcElement.value.replace(",", "");

View File

@@ -111,9 +111,9 @@ describe("TagListInputController", () => {
});
it("highlights the new tag name in red", () => {
expect(variant_add_tag.classList).toContain("tag-error")
expect(variant_add_tag.classList).toContain("tag-error");
});
})
});
});
describe("removeTag", () => {
@@ -144,11 +144,11 @@ describe("TagListInputController", () => {
it("removes error highlight", () => {
variant_add_tag.value = "text";
variant_add_tag.classList.add("tag-error")
variant_add_tag.classList.add("tag-error");
variant_add_tag.dispatchEvent(new KeyboardEvent("keyup", { key: "a" }));
expect(variant_add_tag.classList).not.toContain("tag-error")
expect(variant_add_tag.classList).not.toContain("tag-error");
});
});
});