Pau Pérez Fabregat
d4d72c6c6c
Merge pull request #5036 from luisramos0/strong_params_users
...
[Spree 2.1] Implement strong params in user related controllers
2020-03-25 09:48:52 +01:00
Pau Pérez Fabregat
b323364661
Merge pull request #5035 from luisramos0/strong_params_checkout
...
[Spree 2.1] Implement strong params in checkout controller
2020-03-25 09:46:53 +01:00
Pau Pérez Fabregat
e70daf53ce
Merge pull request #4876 from luisramos0/strong_params_oc
...
[Spree 2.1] Implement strong params in admin Order cycles controller
2020-03-25 09:44:13 +01:00
Luis Ramos
0ee562c718
Add test coverage for PermittedAttributes::User
2020-03-21 18:48:04 +00:00
Luis Ramos
5af27bb14e
Make checkout controller handle strong parameters
2020-03-21 16:30:20 +00:00
Luis Ramos
fd2cf7295e
Extract permitted_attributes from order_cycle_controller into a specific service
2020-03-21 16:17:20 +00:00
Luis Ramos
1a46e7b7ee
Improve strong params implementation on order_cycle controller and fix corresponding specs
2020-03-21 14:45:51 +00:00
Luis Ramos
1c628fac58
Merge branch 'master' into 3-0-stable-mar20
2020-03-20 11:28:06 +00:00
Pau Pérez Fabregat
d09b0849e4
Merge pull request #4936 from luisramos0/fix_order_syncer
...
Fixes spec/services/order_syncer_spec in rails 4
2020-03-17 09:56:17 +01:00
Luis Ramos
5da47b3f19
Merge pull request #4757 from luisramos0/stripe_sca_extra
...
StripeSCA - Handle further SCA auth request when checking out
2020-03-16 16:45:28 +00:00
Luis Ramos
d3f498f5b1
The shipping rates refresh process changed a little in spree 2.1 and the selection is and was random, it picks the first acceptable
...
In this case we need to specifically select one shipping method so that the test is valid
2020-03-06 16:39:20 +00:00
Luis Ramos
0815068050
Merge branch 'master' into 3-0-stable-mar6
2020-03-06 09:20:03 +00:00
Luis Ramos
a180576c0a
Make cart_service spec green in rails 4 branch
2020-03-03 17:29:38 +00:00
Luis Ramos
d5287026f8
Add spec for Checkout::PostCheckoutActions
2020-03-02 17:30:12 +00:00
luisramos0
e3ffe8fe6b
Add Checkout Stripe redirect logic to get users redirected to stripe authentication pages provided by the stripe API
2020-03-02 17:30:12 +00:00
luisramos0
d91578ab80
Rename checkout payment redirect to checkout paypal redirect
2020-03-02 17:30:12 +00:00
Matt-Yorkley
53645517af
Update deprecated #find_by_* methods
2020-02-22 11:06:51 +00:00
Luis Ramos
c38c7c35bc
Add spec for user default address setter
2020-02-05 14:49:17 +00:00
luisramos0
2663f74767
Add specs for new services
2020-02-05 14:49:17 +00:00
Pau Pérez Fabregat
246235b921
Merge pull request #4667 from Matt-Yorkley/rails-4-prep
...
Rails 4 prep
2020-02-04 15:20:28 +01:00
luisramos0
b5004f1cbf
Add specs for ExchangeProductsRenderer#exchange_variants
2020-01-28 18:02:58 +00:00
Matt-Yorkley
5f3abbf00e
Refactor BaseController
2020-01-22 12:17:23 +01:00
luisramos0
3264355f12
Add some basic test coverage to exchange_products_controller and exchange_products_renderer
2019-12-12 18:48:36 +00:00
luisramos0
8d16f496f4
Move Permissions::Order specs to its specific spec file
2019-11-29 10:49:59 +00:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
luisramos0
0fe4edfbf5
Make product_tag_rules_filterer_spec a bit more flexible and not test for the order of the elements
2019-10-30 11:06:25 +00:00
Luis Ramos
02c0b89fa0
Merge pull request #4345 from Matt-Yorkley/shopfront_pagination
...
Shopfront pagination
2019-10-21 16:02:12 +01:00
Matt-Yorkley
b3c89a9d6c
Move OpenFoodNetwork::ProductsRenderer (lib) to ProductsRenderer (service) and refactor
2019-10-18 21:15:13 +01:00
Matt-Yorkley
f134cd9473
Extract tag_rule filtering into separate service
2019-10-09 17:26:58 +01:00
Dan Ingenthron
543e275d2e
Add custom shipping category to pass package spec
2019-10-08 18:37:16 -05:00
Dan Ingenthron
560fa6b949
Update shipping category factory with default
2019-10-08 18:37:16 -05:00
Dan Ingenthron
dbf34da87b
Rubocop fixes
2019-10-08 18:37:16 -05:00
Dan Ingenthron
48cd542138
Service spec
2019-10-08 18:37:15 -05:00
Matt-Yorkley
e96252f2ed
Add tag_rules logic to main query before pagination
2019-10-08 10:11:24 +01:00
Matt-Yorkley
c038b485b1
Rename service and methods to remove use of "shop" term
2019-10-01 14:43:47 +01:00
Matt-Yorkley
032741c54f
Refactor ProductsRenderer variants queries
...
This removes another N+1 and allows pagination applied to the inital query to also affect the returned variants
2019-09-29 17:41:58 +01:00
Matt-Yorkley
d5e90c3c6c
Extract #load_products logic into a new service
2019-09-29 00:10:47 +01:00
Matt-Yorkley
cecebb82f4
Move distributed products relation out from OrderCycleDistributedProducts
2019-09-27 17:25:50 +01:00
Luis Ramos
746c4f03f6
Merge pull request #4261 from jasonk357/3979-malformed-referer-error
...
Guard against malformed request referer
2019-09-19 17:29:18 +01:00
JASON KNOEPFLER
91a52ead58
Guard against malformed request referer
2019-09-14 09:13:44 -07:00
luisramos0
c4d5eec7fd
Covering restart_checkout code with more tests to clarify behaviour with different order.ship_address objects
...
The edge case here is when ship_address is present but empty, on the checkout_controller we are going to move from using an empty ship_address to using a non-empty one. We keep the original case where this spec was testing with a nil order.ship_address
2019-09-09 17:48:04 +01:00
luisramos0
3b467dbae8
Adapt line_item_syncer to the case where item is not added to the completed order because of insufficient stock and the subscription quantity is updated for that item afterwards
2019-07-16 12:08:08 +01:00
luisramos0
306390440a
Revert "Swith line_item_syncer.create_new_items from deleting line item in the case of stock issue, to simply set the quantity to zero. This makes things easier later as the line item is already present if the user tries to change quantity of the subscription_line_item"
...
This reverts commit d153e58933
2019-07-16 11:00:21 +01:00
luisramos0
267131626e
Fix typo and add test case to cover out of stock case
2019-07-16 10:58:25 +01:00
luisramos0
02099ebdae
Remove details about stock in line_item_syncer so that we avoid confusing the user with stock numbers, this way the user will know what is the problem and can check stock levels and the order for more details
2019-07-14 21:40:57 +01:00
luisramos0
d153e58933
Swith line_item_syncer.create_new_items from deleting line item in the case of stock issue, to simply set the quantity to zero. This makes things easier later as the line item is already present if the user tries to change quantity of the subscription_line_item
2019-07-14 20:59:42 +01:00
luisramos0
2a1011921b
Reuse line_item_syncer.add_order_update_issue in line_item_syncer.update_item_quantities to add stock info to the update_quantity order issues
2019-07-14 16:43:46 +01:00
luisramos0
c2851015ce
Fix deleting created item (destroy doesnt work before save) and add order_update_issue with message so that user can understand what happened
2019-07-14 15:58:00 +01:00
luisramos0
6aed9ba549
Make line_item_syncer delete new line items if stock is insufficient
2019-07-13 22:57:13 +01:00
luisramos0
4f2bc33ec3
Change line_item_syncer to verify stock if order is already complete, this will happen for orders in the current OC when a subscription is changed
2019-07-13 20:56:34 +01:00
