raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-23 05:28:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix typo and add test case to cover out of stock case

Browse Source
This commit is contained in:
luisramos0
2019-07-16 10:58:25 +01:00
parent 02099ebdae
commit 267131626e
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/services/line_item_syncer.rb
View File

@@ -78,7 +78,7 @@ class LineItemSyncer
if line_item.variant.in_stock?
I18n.t("admin.subscriptions.stock.insufficient_stock")
else
I18n.t("admin.subscriptions.stock..out_of_stock")
I18n.t("admin.subscriptions.stock.out_of_stock")
end
end
end

15
spec/services/order_syncer_spec.rb
View File

@@ -407,9 +407,9 @@ describe OrderSyncer do
end
context "when order is complete" do
before { AdvanceOrderService.new(order).call }
it "does not update the line_item quantities and adds the order to order_update_issues with insufficient stock" do
AdvanceOrderService.new(order).call
it "does not update the line_item quantities and adds the order to order_update_issues" do
expect(syncer.sync!).to be true
line_items = Spree::LineItem.where(order_id: subscription.orders, variant_id: sli.variant_id)
@@ -418,6 +418,17 @@ describe OrderSyncer do
line_item = order.line_items.find_by_variant_id(sli.variant_id)
expect(syncer.order_update_issues[order.id]).to include "#{line_item.product.name} - #{line_item.variant.full_name} - Insufficient stock available"
end
it "does not update the line_item quantities and adds the order to order_update_issues with out of stock" do
# this single item available is used when the order is completed below, making the item out of stock
variant.update_attribute(:on_hand, 1)
AdvanceOrderService.new(order).call
expect(syncer.sync!).to be true
line_item = order.line_items.find_by_variant_id(sli.variant_id)
expect(syncer.order_update_issues[order.id]).to include "#{line_item.product.name} - #{line_item.variant.full_name} - Out of Stock"
end
end
end