Rubocop fixes

This commit is contained in:
Dan Ingenthron
2019-09-18 19:19:17 -05:00
parent d6022062e1
commit dbf34da87b
3 changed files with 33 additions and 34 deletions

View File

@@ -1,13 +1,13 @@
# Encapsulates the concept of default stock location in creation of a product or a shipping method.
class DefaultShippingCategory
NAME = 'Default'.freeze
NAME = 'Default'.freeze
def self.create!
Spree::ShippingCategory.create!(name: NAME)
end
def self.create!
Spree::ShippingCategory.create!(name: NAME)
end
def self.find_or_create
Spree::ShippingCategory.find_or_create_by_name(NAME)
end
end
def self.find_or_create
Spree::ShippingCategory.find_or_create_by_name(NAME)
end
end

View File

@@ -52,4 +52,4 @@ end
require File.join(File.dirname(__FILE__), 'default', 'users')
DefaultStockLocation.find_or_create
DefaultShippingCategory.find_or_create
DefaultShippingCategory.find_or_create

View File

@@ -1,18 +1,18 @@
require 'spec_helper'
describe DefaultShippingCategory do
describe '.create!' do
it "names the location 'Default'" do
shipping_category = described_class.create!
expect(shipping_category.name).to eq('Default')
end
end
describe '.create!' do
it "names the location 'Default'" do
shipping_category = described_class.create!
expect(shipping_category.name).to eq('Default')
end
end
describe 'find_or_create' do
context 'when a Default category already exists' do
let!(:category) do
Spree::ShippingCategory.create!(name: 'Default')
end
describe 'find_or_create' do
context 'when a Default category already exists' do
let!(:category) do
Spree::ShippingCategory.create!(name: 'Default')
end
it 'returns the category' do
expect(described_class.find_or_create).to eq(category)
@@ -21,19 +21,18 @@ describe DefaultShippingCategory do
it 'does not create another category' do
expect { described_class.find_or_create }.not_to change(Spree::ShippingCategory, :count)
end
end
end
context 'when a Default category does not exist' do
it 'returns the category' do
category = described_class.find_or_create
expect(category.name).to eq('Default')
end
context 'when a Default category does not exist' do
it 'returns the category' do
category = described_class.find_or_create
expect(category.name).to eq('Default')
end
it 'does not create another category' do
expect { described_class.find_or_create }
.to change(Spree::ShippingCategory, :count).from(0).to(1)
end
end
end
end
it 'does not create another category' do
expect { described_class.find_or_create }
.to change(Spree::ShippingCategory, :count).from(0).to(1)
end
end
end
end