From dbf34da87b245fa4bc6d6b99d50203c4ce1edb01 Mon Sep 17 00:00:00 2001 From: Dan Ingenthron Date: Wed, 18 Sep 2019 19:19:17 -0500 Subject: [PATCH] Rubocop fixes --- app/services/default_shipping_category.rb | 16 +++--- db/seeds.rb | 2 +- .../default_shipping_category_spec.rb | 49 +++++++++---------- 3 files changed, 33 insertions(+), 34 deletions(-) diff --git a/app/services/default_shipping_category.rb b/app/services/default_shipping_category.rb index ae515fa59a..10959de659 100644 --- a/app/services/default_shipping_category.rb +++ b/app/services/default_shipping_category.rb @@ -1,13 +1,13 @@ # Encapsulates the concept of default stock location in creation of a product or a shipping method. class DefaultShippingCategory - NAME = 'Default'.freeze + NAME = 'Default'.freeze - def self.create! - Spree::ShippingCategory.create!(name: NAME) - end + def self.create! + Spree::ShippingCategory.create!(name: NAME) + end - def self.find_or_create - Spree::ShippingCategory.find_or_create_by_name(NAME) - end -end \ No newline at end of file + def self.find_or_create + Spree::ShippingCategory.find_or_create_by_name(NAME) + end +end diff --git a/db/seeds.rb b/db/seeds.rb index 75d351b054..e6cac36c2c 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -52,4 +52,4 @@ end require File.join(File.dirname(__FILE__), 'default', 'users') DefaultStockLocation.find_or_create -DefaultShippingCategory.find_or_create \ No newline at end of file +DefaultShippingCategory.find_or_create diff --git a/spec/services/default_shipping_category_spec.rb b/spec/services/default_shipping_category_spec.rb index a2e3dd0ad1..24a718a262 100644 --- a/spec/services/default_shipping_category_spec.rb +++ b/spec/services/default_shipping_category_spec.rb @@ -1,18 +1,18 @@ require 'spec_helper' describe DefaultShippingCategory do - describe '.create!' do - it "names the location 'Default'" do - shipping_category = described_class.create! - expect(shipping_category.name).to eq('Default') - end - end + describe '.create!' do + it "names the location 'Default'" do + shipping_category = described_class.create! + expect(shipping_category.name).to eq('Default') + end + end - describe 'find_or_create' do - context 'when a Default category already exists' do - let!(:category) do - Spree::ShippingCategory.create!(name: 'Default') - end + describe 'find_or_create' do + context 'when a Default category already exists' do + let!(:category) do + Spree::ShippingCategory.create!(name: 'Default') + end it 'returns the category' do expect(described_class.find_or_create).to eq(category) @@ -21,19 +21,18 @@ describe DefaultShippingCategory do it 'does not create another category' do expect { described_class.find_or_create }.not_to change(Spree::ShippingCategory, :count) end - end + end - context 'when a Default category does not exist' do - it 'returns the category' do - category = described_class.find_or_create - expect(category.name).to eq('Default') - end + context 'when a Default category does not exist' do + it 'returns the category' do + category = described_class.find_or_create + expect(category.name).to eq('Default') + end - it 'does not create another category' do - expect { described_class.find_or_create } - .to change(Spree::ShippingCategory, :count).from(0).to(1) - end - end - end - -end \ No newline at end of file + it 'does not create another category' do + expect { described_class.find_or_create } + .to change(Spree::ShippingCategory, :count).from(0).to(1) + end + end + end +end