David Cook
8696e05e66
Move index and bulk_update actions to good ol' HTTP requests
...
We've found that we just can't rely in StimulusReflex (and the underlying WebSockets stack) to guarantee a response to a request.
Because of this, there was intermittent issues when the server was overloaded with large requests, and the response never arrived, leaving an infinite loader, and a poor user wondering if anything was still happening.
2024-04-10 15:17:56 +01:00
Maikel Linke
3382a62eb5
Simplify BulkInvoiceJob by removing checks
...
The check for invoiceability is already done by the reflex triggering
the job. Let's DRY the code, save time and be more flexible in the
future.
Also checking the order of actually generated PDF pages.
2024-04-10 16:52:56 +10:00
Maikel Linke
48b447500f
Move selection of invoicable orders to database
...
It's more efficient and should allow for further optimisations.
2024-04-10 16:52:56 +10:00
Maikel Linke
16c877f7cb
Fix: preserve order of invoices in bulk print
2024-04-10 14:51:55 +10:00
Maikel Linke
1d8b942acd
Fix spec for invoice ordering
2024-04-10 14:03:25 +10:00
David Cook
ade4e855dc
Merge pull request #12341 from mkllnk/connected-app-url
...
Make URL to connect app translatable
2024-04-10 10:36:49 +10:00
David Cook
d4da684f4a
Merge pull request #12349 from openfoodfoundation/dependabot/bundler/rubocop-1.63.0
...
chore(deps-dev): bump rubocop from 1.62.1 to 1.63.0
2024-04-10 10:32:32 +10:00
cyrillefr
404fcf1f72
Fix FixRailsWhereEquals
...
- fixes offenses caused by RuboCop::Cop::Rails::WhereEquals cop
2024-04-09 10:44:02 +02:00
Maikel
a40b9eb44e
Merge pull request #12316 from anansilva/6055-fix-rubocop-lint-constant-definition-in-block
...
Fix rubocop Lint/ConstantDefinitionInBlock group
2024-04-09 12:52:06 +10:00
Maikel Linke
c0010319af
Avoid duplicate loading of task in spec
...
The new product image import spec was loading rake tasks multiple times.
That make the spec for enterprise deletion fail when executed afterwards
because the deletion task was executed twice and failed the second time.
2024-04-09 12:04:42 +10:00
Maikel
c9c94fcaa5
Merge pull request #12337 from cyrillefr/FixRailsNegateIncludeRubocopIssue
...
Fix Rubocop Rails/NegateInclude issues
2024-04-09 10:40:47 +10:00
Gaetan Craig-Riou
103c6e7fc0
Remove debugging line
2024-04-09 10:30:46 +10:00
Gaetan Craig-Riou
1509066b85
Apply new cop Style/MapIntoArray fix
2024-04-09 10:29:30 +10:00
Maikel
169df3fb8b
Merge pull request #12343 from filipefurtad0/spec_regression_s2_12340
...
Adds regression spec for S2 bug #12340
2024-04-09 10:16:09 +10:00
Ana Nunes da Silva
061ff91786
Fix offense constant definition in block in validators/integer_array_validator_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
0aea14832a
Fix offense constant definition in block in validators/date_time_string_validator_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
939605cb7a
Fix offense constant definition in block in models/spree/preferences/preferable_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
b18fe8ce35
Fix offense constant definition in block in models/spree/preferences/configuration_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
fc3d7f8496
Fix offense constant definition in block in models/spree/gateway_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
3bd6c85f3b
Fix offense constant definition in block in models/spree/ability_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
0726e4c1d0
Fix offense constant definition in block in reports/line_items_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
cfca7816d5
Fix offense constant definition in block in serializer_helper_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
f1309db0f0
Fix offense constant definition in block in spree base_controller_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
d726a0e3cb
Fix offense constant definition in block in users.rake
...
This rake has tests
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
5415fa2db8
Fix offense constant definition in block in import_product_images_rake.rb
...
Add a test to import product images rake
2024-04-08 11:16:38 +01:00
filipefurtad0
8ad4f885a0
Adds shared example for descending name ordering
2024-04-07 17:15:12 +01:00
Ahmed Ejaz
870e2b447c
12294 - add specs
...
- display none if no tax category is selected
- add a tax_category_column css selector for future related specs
2024-04-05 23:49:52 +05:00
cyrillefr
f57d44ba24
Fix Lint/DuplicateRequire issue
...
- updates the todo list
2024-04-05 17:09:14 +02:00
filipefurtad0
f618ef1201
Adds regression spec for S2 bug #12340
2024-04-05 14:46:52 +01:00
cyrillefr
2877c793f8
Attempt to get rid of flaky spec #10027
2024-04-05 10:07:06 +02:00
Maikel Linke
91803953fe
Point connect app URL to new n8n server
2024-04-05 15:35:03 +11:00
filipefurtad0
0f3b502ca6
Re-records cassettes after Stripe bump
2024-04-04 14:40:49 +01:00
cyrillefr
84747ea064
Fix Rails::NegateInclude issues
...
- cop class: RuboCop::Cop::Rails::NegateInclude
- replaced !array.include?(2) by array.exclude?(2)
2024-04-04 14:42:42 +02:00
Maikel
cf9414a352
Merge pull request #12329 from openfoodfoundation/dependabot/bundler/rubocop-rspec-2.28.0
...
chore(deps-dev): bump rubocop-rspec from 2.27.1 to 2.28.0
2024-04-04 13:43:02 +11:00
David Cook
6cff5c81fe
Fix RSpecRails/NegationBeValid
...
Another cop that only supports not_to instead of to_not.
2024-04-04 09:41:05 +11:00
David Cook
af2e3ca703
Merge pull request #12326 from filipefurtad0/deletes_connected_accounts_after_specs
...
Removes Stripe accounts created for testing purposes
2024-04-03 10:37:17 +11:00
Gaetan Craig-Riou
52bc88bbd8
Merge pull request #11369 from Matt-Yorkley/product-taxon
...
[Product Refactor] Primary Taxon
2024-04-03 10:31:49 +11:00
Ana Nunes da Silva
eaf32226a4
Fix duplicate branches in Spree::Admin::BaseHelper
...
:string case already handled by the else case
2024-04-02 10:20:17 +01:00
Gaetan Craig-Riou
100239c4e6
Fix #bulk_product duplicate
...
Remove duplicate when a product has mutiple variant in the same category
(taxon)
2024-04-02 09:59:16 +11:00
Gaetan Craig-Riou
678fa37df9
Fix duplication issue
...
When a product had mutiple variant assigned to the same category it
should only return the product one
2024-04-02 09:57:36 +11:00
Matt-Yorkley
d3e62c4390
Add test for persisting taxon on variant during product creation
2024-04-02 09:43:24 +11:00
Matt-Yorkley
ac4ec36b3b
Update ProductScopeQuery spec
2024-04-02 09:43:24 +11:00
Matt-Yorkley
8a364a5f48
Fix product touch spec
2024-04-02 09:43:24 +11:00
Matt-Yorkley
d959ee2358
Fix rubocop warnings
2024-04-02 09:43:24 +11:00
Matt-Yorkley
a55931c081
Reinstate sorting by arbitrary list of product categories
2024-04-02 09:42:43 +11:00
Maikel
eac278ea1f
Merge pull request #12262 from filipefurtad0/vcr_stripe_accounts_controller_spec
...
Vcr stripe accounts controller spec
2024-04-02 09:39:53 +11:00
Matt-Yorkley
2743a8183d
Disable sorting by user-defined product category order
2024-04-02 09:33:34 +11:00
Matt-Yorkley
fb09a7f1e6
Fix product filtering
2024-04-02 09:27:37 +11:00
Matt-Yorkley
6025491f94
Update product serializer
2024-04-02 09:27:37 +11:00
Matt-Yorkley
c5ec7e361b
Update product import
2024-04-02 09:27:36 +11:00
