cyrillefr
9b10b73a65
Delete Button missing before saving variant
...
- used the remove option of stimulus-components/rails-nested-form lib
- add the Remove option in the menu
- the corresponding spec
- the locale
2024-05-14 11:25:22 +10:00
David Cook
1f91c2e4b5
Merge pull request #12417 from filipefurtad0/migrate_legacy_specs
...
Removes unused spec related to legacy checkout
2024-05-14 09:42:23 +10:00
Rachel Arnould
bd83977bf2
Merge pull request #12449 from chahmedejaz/feature/11058-change-products-order-by-name
...
Feature/11058 change products order by name
2024-05-13 15:29:33 +02:00
filipefurtad0
a1e2d3a93b
Removes negative expect
...
Removes unused error message
2024-05-13 12:55:55 +01:00
David Cook
62fefd5d49
Implement required method
...
Most of the time this doesn't get called because source_required: false.
But sometimes it [does happen](https://app.bugsnag.com/yaycode/openfoodnetwork-uk/errors/66329690f4b6380007e8a4f8)
I have a feeling that source_required? could be moved to the superclass as payment_source_class.present?. But I don't know enough about this area of the system to try it...
2024-05-13 12:55:55 +01:00
filipefurtad0
ffdbd0d7d4
Reproduces Bugsnag error
...
For details see: https://app.bugsnag.com/open-food-network-canada-1/open-food-network-canada/errors/66314b2e78673c00073d2de9?filters[event.since]=30d&filters[error.status]=open&filters[search]=payment_source_class&event_id=66314b2e00e6e45d746f0000
Adds test case for Cash and Stripe payment methods
With no source
2024-05-13 12:55:55 +01:00
filipefurtad0
282acd256b
Undoes changes: removes unecessary test
2024-05-13 12:55:55 +01:00
filipefurtad0
d520e3838c
Removes unused spec related to legacy checkout
...
We can see on the respective controller spec, that having a Stripe SCA payment, with no source does not trigger the error 400, observed on the legacy checkout.
2024-05-13 12:55:52 +01:00
Ahmed Ejaz
881da0f9ac
11058: add get_all_input_values
2024-05-10 04:05:29 +05:00
Maikel Linke
bc27e4bbdd
Re-instate spec which uses invalid mocking
...
I removed it because it needed a complete rewrite and I didn't think it
was valuable enough to do so. But now that I deactivated RSpecs
validating mocks again, this spec passes and we can do that work another
time.
2024-05-10 08:56:06 +10:00
Ahmed Ejaz
b5fe19cb7d
11058: add specs
2024-05-10 02:52:57 +05:00
Maikel Linke
8362c4a7bd
Detailed output when running only one spec file
2024-05-09 12:24:42 +10:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
9ca6519fb1
Recommended RSpec option: shared_context_metadata_behavior
...
One spec failed due to this new behaviour. Converting the shared
examples to simple blocks solved this. But the specs could probably be
written better now. I didn't invest this time.
2024-05-09 11:14:13 +10:00
Maikel Linke
6b2bb0bd32
Don't verify partial doubles because we can't fix all specs now
2024-05-09 11:14:13 +10:00
Maikel Linke
d6318b7194
Remove mocking of deleted Order methods
2024-05-09 11:14:13 +10:00
Maikel Linke
9320ed0559
And less stubbing is better.
...
[skip ci]
2024-05-09 11:14:13 +10:00
Maikel Linke
9c402fbdb2
Verify partial doubles
...
And look, we were stubbing deleted code.
2024-05-09 11:14:13 +10:00
Maikel Linke
a65189c43e
Improve failure messages of chained expectations
2024-05-09 11:14:13 +10:00
Maikel Linke
5f07a7f390
Check for asset compilation before each spec file
...
The KnapsackPro queue mode can't predict which specs it will run. So we
need to check on each file (top-level describe block) which type of spec
it is and if we need to compile assets for it.
Old versions of KnapsackPro would execute the `before(:suite)` hooks on
every batch, but now it's only run once. With this change, we do the
same as before.
2024-05-08 13:36:41 +10:00
cyrillefr
271d50e5ab
Fix Ship Order Button: modal should close itself
...
- returns to the same processing for customer, invoices etc.
that edit
- need a bit of sleep in spec bc 2 tasks are asynchroneous
2024-05-07 19:15:00 +02:00
cyrillefr
34bb05e681
Fix 'Ship Order': integrating non regression spec
...
- removes the pending
- add the click to go to the 'Order Details' page
to check for the 'shipped' status
- from enqueued to have_been_enqueued so the spec
is flaky-free
2024-05-07 19:15:00 +02:00
cyrillefr
901c29c97b
Fix Ship Order menu choice not working
...
- Front End ShipOrderComponent was missed for the menu to work
- updated spec to test for a specific case
2024-05-07 19:15:00 +02:00
Ahmed Ejaz
b1f20ffc14
11060: create tomselect helper module
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
f07900ca4a
11060: refactor specs to have better separation of concerns
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
3d60d84fc7
add wait for flaky specs
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
227b677e4d
11060: fix specs
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
15ee4f6619
11060: add specs
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
c12d6ab7f0
11060: revert 33b947be00563b67ca36475f277ceceaf8c68378
2024-05-07 14:59:14 +02:00
Maikel
dd4fe86e9f
Merge pull request #12423 from filipefurtad0/legacy_checkout_migrate_checkout_spec
...
Updates checkout tests to cover for out of stock variant
2024-05-07 14:07:43 +10:00
David Cook
11507ba036
Merge pull request #12432 from mkllnk/migrate-n8n
...
Update links to n8n server
2024-05-07 09:31:26 +10:00
Gaetan Craig-Riou
f1f5e6d659
Merge pull request #12111 from openfoodfoundation/dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
...
chore(deps): bump flipper, flipper-active_record and flipper-ui
2024-05-06 10:45:39 +10:00
Maikel
a75f3245a0
Revert "Fix Duplicate Language Display on New User Creation"
2024-05-03 15:07:47 +10:00
Maikel Linke
b0a89372ab
Update links to n8n server
2024-05-02 15:55:16 +10:00
Maikel Linke
ea0558c70e
Replace Flipper's built-in test helper
...
It fails in CI and features are not seen as enabled. So we copy the
important part of the test helper into our code, which works.
It's probably about the point in time when the adapter is instantiated.
2024-05-02 11:23:30 +10:00
filipefurtad0
0583888963
Removes legacy checkout spec
...
All test cases are covered within the respective checkout step specs
2024-04-30 14:23:33 +01:00
filipefurtad0
34bde1caa9
Reverts changes on checkout steps specs
...
This can be squashed with the first commit of this PR
2024-04-30 14:22:30 +01:00
filipefurtad0
729c5f01d4
Adds out of stock check as helper
...
As shared examoples, in guest_spec.rb
2024-04-30 14:18:23 +01:00
filipefurtad0
0f80aca675
Updates checkout tests
...
Adds out of stock check as helper
2024-04-30 12:23:39 +01:00
filipefurtad0
fb5f31375a
Adds localization test for checkout steps
...
As a logged user
2024-04-29 19:42:49 +01:00
filipefurtad0
1763c516ec
Adds localization test for checkout as a guest
2024-04-29 17:44:42 +01:00
kellyzhangg
f1f60a0a00
Merge branch 'master' into 8633-payments-controller-test
2024-04-25 12:24:31 -04:00
Kelly
ccf3d5873a
style fix - remove type
2024-04-25 12:24:19 -04:00
Kelly
6b5be213a3
changed location - now in requests folder
2024-04-25 12:10:32 -04:00
Filipe
e99b072442
Merge pull request #12313 from anthonyms/11482-fix-rubocop-rails-issue-has_many
...
Fix Rubocop Rails: Rails/HasManyOrHasOneDependent
2024-04-25 16:24:47 +01:00
Filipe
f269584b8e
Merge pull request #12392 from sergioosouzaa/fix/duplicate-language-display-new-user-11513
...
Fix Duplicate Language Display on New User Creation
2024-04-25 16:01:09 +01:00
Filipe
4ff832693c
Merge pull request #12412 from dacook/buu/fix-non-admin-saving-12403
...
[BUU] Fix non-admin saving
2024-04-25 12:37:11 +01:00
Rachel Arnould
09354dc80e
Merge pull request #12219 from abdellani/prevent-generate-invoices-when-distributor-cannot-invoice
...
prevent generating invoices when order's distributor can't generate invoices
2024-04-25 12:18:49 +02:00
Kelly
eda97ef3f7
fixed path
2024-04-23 22:18:45 -04:00
kellyzhangg
00742f6f0b
Merge branch 'openfoodfoundation:master' into 8633-payments-controller-test
2024-04-23 22:15:58 -04:00
