raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-19 04:49:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

11060: refactor specs to have better separation of concerns

Browse Source
This commit is contained in:
Ahmed Ejaz
2024-04-30 14:08:30 +05:00
committed by Rachel Arnould
parent 269e69852c
commit f07900ca4a
2 changed files with 30 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/support/request/web_helper.rb
View File

@@ -112,6 +112,20 @@ module WebHelper
tomselect_wrapper.find(:css, '.ts-dropdown .ts-dropdown-content .option', text: value).click
end
def open_tomselect_to_validate!(page, field_name)
tomselect_wrapper = page.find_field(field_name).sibling(".ts-wrapper")
tomselect_wrapper.find(".ts-control").click # open the dropdown
raise 'Please pass the block for expectations' unless block_given?
# execute block containing expectations
yield
tomselect_wrapper.find(
'.ts-dropdown .ts-dropdown-content .option.active',
).click # close the dropdown by selecting the already selected value
end
def request_monitor_finished(controller = nil)
page.evaluate_script("#{angular_scope(controller)}.scope().RequestMonitor.loading == false")
end

38
spec/system/admin/products_v3/products_spec.rb
View File

@@ -699,22 +699,23 @@ describe 'As an enterprise user, I can manage my products', feature: :admin_styl
within row_containing_name(product_a.name) do
validate_tomselect_without_search!(
page, "Producer",
producer_to_select,
producer_search_selector
)
tomselect_select(producer_to_select, from: "Producer")
end
within row_containing_name(variant_a1.display_name) do
validate_tomselect_without_search!(
page, "Category",
category_to_select,
categories_search_selector
)
tomselect_select(category_to_select, from: "Category")
validate_tomselect_without_search!(
page, "Tax Category",
tax_category_to_select,
tax_categories_search_selector
)
tomselect_select(tax_category_to_select, from: "Tax Category")
end
click_button "Save changes"
@@ -746,24 +747,25 @@ describe 'As an enterprise user, I can manage my products', feature: :admin_styl
within row_containing_name(product_a.name) do
validate_tomselect_with_search!(
page, "Producer",
producer_to_select,
producer_search_selector
)
tomselect_search_and_select(producer_to_select, from: "Producer")
end
within row_containing_name(variant_a1.display_name) do
sleep(0.1)
validate_tomselect_with_search!(
page, "Category",
category_to_select,
categories_search_selector
)
tomselect_search_and_select(category_to_select, from: "Category")
sleep(0.1)
validate_tomselect_with_search!(
page, "Tax Category",
tax_category_to_select,
tax_categories_search_selector
)
tomselect_search_and_select(tax_category_to_select, from: "Tax Category")
end
click_button "Save changes"
@@ -1146,24 +1148,16 @@ describe 'As an enterprise user, I can manage my products', feature: :admin_styl
@tax_category_column ||= '[data-controller="variant"] > td:nth-child(10)'
end
def validate_tomselect_without_search!(page, field_name, value, search_selector)
tomselect_wrapper = page.find_field(field_name).sibling(".ts-wrapper")
tomselect_wrapper.find(".ts-control").click
expect(page).not_to have_selector(search_selector)
tomselect_wrapper.find(:css, '.ts-dropdown .ts-dropdown-content .option',
text: value).click
def validate_tomselect_without_search!(page, field_name, search_selector)
open_tomselect_to_validate!(page, field_name) do
expect(page).not_to have_selector(search_selector)
end
end
def validate_tomselect_with_search!(page, field_name, value, search_selector)
tomselect_wrapper = page.find_field(field_name).sibling(".ts-wrapper")
tomselect_wrapper.find(".ts-control").click
expect(page).to have_selector(search_selector)
tomselect_wrapper.find(:css, '.ts-dropdown input.dropdown-input').send_keys(value)
tomselect_wrapper.find(:css, '.ts-dropdown .ts-dropdown-content .option', text: value).click
def validate_tomselect_with_search!(page, field_name, search_selector)
open_tomselect_to_validate!(page, field_name) do
expect(page).to have_selector(search_selector)
end
end
def random_producer(product)