Apply new cop Style/MapIntoArray fix

This commit is contained in:
Gaetan Craig-Riou
2024-04-09 10:29:30 +10:00
parent 2772dd2e78
commit 1509066b85
2 changed files with 4 additions and 10 deletions

View File

@@ -78,12 +78,11 @@ module Reporting
end
def group_and_sort(rule, remaining_rules, datas)
result = []
groups = group_data_with_rule(datas, rule)
sorted_groups = sort_groups_with_rule(groups, rule)
sorted_groups.each do |group_value, group_datas|
result << {
sorted_groups.map do |group_value, group_datas|
{
is_group: true,
header: @builder.build_header(rule, group_value, group_datas),
header_class: rule[:header_class],
@@ -92,7 +91,6 @@ module Reporting
data: build_tree(group_datas, remaining_rules)
}
end
result
end
def group_data_with_rule(datas, rule)

View File

@@ -53,13 +53,9 @@ describe Api::V0::ReportsController, type: :controller do
private
def report_output(order, user_type)
results = []
order.line_items.each do |line_item|
results << __send__("#{user_type}_report_row", line_item)
results = order.line_items.map do |line_item|
__send__("#{user_type}_report_row", line_item)
end
results
end
def distributor_report_row(line_item)