From 1509066b85a1059bd68e9afbf7d3726e304f06ea Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Tue, 9 Apr 2024 10:29:30 +1000 Subject: [PATCH] Apply new cop Style/MapIntoArray fix --- lib/reporting/report_rows_builder.rb | 6 ++---- spec/controllers/api/v0/reports/packing_report_spec.rb | 8 ++------ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/reporting/report_rows_builder.rb b/lib/reporting/report_rows_builder.rb index f8b09488b0..4da6c969c3 100644 --- a/lib/reporting/report_rows_builder.rb +++ b/lib/reporting/report_rows_builder.rb @@ -78,12 +78,11 @@ module Reporting end def group_and_sort(rule, remaining_rules, datas) - result = [] groups = group_data_with_rule(datas, rule) sorted_groups = sort_groups_with_rule(groups, rule) - sorted_groups.each do |group_value, group_datas| - result << { + sorted_groups.map do |group_value, group_datas| + { is_group: true, header: @builder.build_header(rule, group_value, group_datas), header_class: rule[:header_class], @@ -92,7 +91,6 @@ module Reporting data: build_tree(group_datas, remaining_rules) } end - result end def group_data_with_rule(datas, rule) diff --git a/spec/controllers/api/v0/reports/packing_report_spec.rb b/spec/controllers/api/v0/reports/packing_report_spec.rb index 4cee3984f4..a88a26c7d0 100644 --- a/spec/controllers/api/v0/reports/packing_report_spec.rb +++ b/spec/controllers/api/v0/reports/packing_report_spec.rb @@ -53,13 +53,9 @@ describe Api::V0::ReportsController, type: :controller do private def report_output(order, user_type) - results = [] - - order.line_items.each do |line_item| - results << __send__("#{user_type}_report_row", line_item) + results = order.line_items.map do |line_item| + __send__("#{user_type}_report_row", line_item) end - - results end def distributor_report_row(line_item)