Luis Ramos
|
5a05a21dad
|
Revert to false so strings can be mutated in this class
|
2021-06-17 23:07:54 +01:00 |
|
Luis Ramos
|
e52937c113
|
Use rubocop auto correct to add frozen string literal to all files
This is an unsafe auto corection, we will need to trust our build here
|
2021-06-17 23:07:26 +01:00 |
|
Luis Ramos
|
ed5fc29c44
|
Fix hash alignment issue
|
2020-06-22 17:39:20 +01:00 |
|
Luis Ramos
|
f848a89a00
|
Rename update_attributes to update #rails4
|
2020-06-22 16:51:43 +01:00 |
|
Matt-Yorkley
|
53645517af
|
Update deprecated #find_by_* methods
|
2020-02-22 11:06:51 +00:00 |
|
luisramos0
|
3b467dbae8
|
Adapt line_item_syncer to the case where item is not added to the completed order because of insufficient stock and the subscription quantity is updated for that item afterwards
|
2019-07-16 12:08:08 +01:00 |
|
luisramos0
|
306390440a
|
Revert "Swith line_item_syncer.create_new_items from deleting line item in the case of stock issue, to simply set the quantity to zero. This makes things easier later as the line item is already present if the user tries to change quantity of the subscription_line_item"
This reverts commit d153e58933.
|
2019-07-16 11:00:21 +01:00 |
|
luisramos0
|
267131626e
|
Fix typo and add test case to cover out of stock case
|
2019-07-16 10:58:25 +01:00 |
|
luisramos0
|
02099ebdae
|
Remove details about stock in line_item_syncer so that we avoid confusing the user with stock numbers, this way the user will know what is the problem and can check stock levels and the order for more details
|
2019-07-14 21:40:57 +01:00 |
|
luisramos0
|
d153e58933
|
Swith line_item_syncer.create_new_items from deleting line item in the case of stock issue, to simply set the quantity to zero. This makes things easier later as the line item is already present if the user tries to change quantity of the subscription_line_item
|
2019-07-14 20:59:42 +01:00 |
|
luisramos0
|
c2a59a374c
|
Fix rubocop issues by simplifying method
|
2019-07-14 17:21:15 +01:00 |
|
luisramos0
|
2a1011921b
|
Reuse line_item_syncer.add_order_update_issue in line_item_syncer.update_item_quantities to add stock info to the update_quantity order issues
|
2019-07-14 16:43:46 +01:00 |
|
luisramos0
|
df27ee0d3e
|
Refactor line_item_syncer.add_order_update_issue out of line_item_syncer.create_new_items
|
2019-07-14 16:06:09 +01:00 |
|
luisramos0
|
c2851015ce
|
Fix deleting created item (destroy doesnt work before save) and add order_update_issue with message so that user can understand what happened
|
2019-07-14 15:58:00 +01:00 |
|
luisramos0
|
d0c246c345
|
Fix some rubocop issues
|
2019-07-14 12:28:32 +01:00 |
|
luisramos0
|
6aed9ba549
|
Make line_item_syncer delete new line items if stock is insufficient
|
2019-07-13 22:57:13 +01:00 |
|
luisramos0
|
4f2bc33ec3
|
Change line_item_syncer to verify stock if order is already complete, this will happen for orders in the current OC when a subscription is changed
|
2019-07-13 20:56:34 +01:00 |
|
Rob Harrington
|
7017c8540c
|
Replace references to 'standing line item' with 'subscription line item'
|
2018-02-09 14:44:15 +11:00 |
|
Rob Harrington
|
672f96b85b
|
Replace references to 'standing order' with 'subscription'
|
2018-02-09 14:44:13 +11:00 |
|
Rob Harrington
|
88a5d4be47
|
Reduce cognitive complexity of LineItemSyncer#update_item_quantities
|
2018-02-09 14:44:12 +11:00 |
|
Rob Harrington
|
bbc3cad67d
|
Refactor large StandingOrderUpdater#update! method
Note: extracted line items logic into separate class
|
2018-02-09 14:44:11 +11:00 |
|