Gaetan Craig-Riou
bb882ddfa3
Per review, simplify disabling of default action
...
Turns out you can just call `event.preventDefault()` on the action and
there is no need actually use hotkeys to do that.
2025-04-24 13:53:23 +10:00
Gaetan Craig-Riou
1479be787b
Prevent adding empty tag
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
31afdfd8c4
Disable "enter" hotkeys only on tag input element
...
We are still able to use enter to submit the form on anyother input.The
tag input creates a new tag when enter is pressed
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
034feabcff
Javascript code linting
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
aba6240736
Per review, use css :has() pseudo class
...
It saves writing some custom javascript, less code to maintain!
2025-04-22 13:42:09 +10:00
Gaetan Craig-Riou
6417c87047
Add visual feedback when adding tag errors
...
Highlight the tag name in red, if trying to add a tag that already
exists.
2025-04-22 13:42:08 +10:00
Gaetan Craig-Riou
157de25f36
Prettyfy code
2025-04-22 13:41:02 +10:00
Gaetan Craig-Riou
9e1a80c327
Mock hotkeys.js
2025-04-22 13:41:02 +10:00
Gaetan Craig-Riou
94cc774f27
Fix html used in test
...
It get rids of errors, even if they didn't affect the test result it's
noise we don't need
2025-04-22 13:41:02 +10:00
Gaetan Craig-Riou
559249b621
Improve tagListInputController to integrate with bulkFormController
...
tagListInputController is not a standard form controller so we had to
make a few changes to integrate with the change tracking used int
bulkFormController. Mainly we make sure to manually trigger event when
deleting a tags, and we handle the change highlight.
2025-04-22 13:41:01 +10:00
Gaetan Craig-Riou
c15e16900d
Add stimulus tag list input controller
...
It handles the UI to display the list of tags, and lets you add and
remove tags from the list.
2025-04-22 13:41:01 +10:00
Filipe
cf3213cf96
Merge pull request #13168 from dacook/dfc-product-import-select-all-12301
...
[DFC Orders] Select/deselect all on DFC Product Import
2025-02-27 16:43:37 -06:00
David Cook
b370b207b5
Automatically bind toggleCheckbox action
2025-02-20 12:14:49 +11:00
David Cook
b92c046119
Automatically bind toggleAll action
...
We are already specifying the element's role ('all') in the HTML. Its behaviour should be predefined; there's no need to also specify in the HTML.
The eventhandler doesn't need to be cleand up on disconnect, because they are removed along with the DOM object.
2025-02-20 11:24:21 +11:00
Gaetan Craig-Riou
4a2f22e56d
Add OutOfStockModalComponent
...
It encapsulate the logic for the out of stock modal
2025-02-18 10:47:03 +11:00
Maikel Linke
be98544537
Remove unused AngularJS service KeyValueMapStore
2025-01-02 15:19:55 +11:00
Gaetan Craig-Riou
83a619b097
Fix bulk order management page
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
8ec1f61cd7
Fix legacy bulk edit product system spec
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
893b541dca
Fix product system spec
...
The pending spec are to be fix after a rebase, master currently as
some changes which will make this easier
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
cc85fed7cc
Add localizeCurrency and specs
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
45b0686130
Add PriceParser and UnitPrices and specs
...
This is in preparation for removing angular from the variant update
page.
Converted using https://www.codeconvert.ai/coffeescript-to-javascript-converter
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
4cd83d3fd4
Prettify javascript
...
Also update .prettierignore so that spec files get prettified as well
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
e8234ee4a0
Fix Bulk products edit page , part 1
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
6ff9650eaf
Fix legacy bulk edit products UI
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
cd74a73680
Consolidate angular option value namer spec
...
Merge the two spec files into the correct one.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
36c4d24c93
Fix angular option value namer
2024-10-14 15:01:18 +11:00
Cillian O'Ruanaidh
f474afaceb
Merge in latest :master and resolve conflict in app/models/enterprise.rb
2024-09-27 10:11:26 +01:00
Gaetan Craig-Riou
703ad26773
Fix spec to make the test usefull
2024-09-02 12:23:27 +10:00
Gaetan Craig-Riou
627c9eede2
Fix spec using confirm pop up
...
For some reason, karma hang and fails with a timeout error if javascrpit
`confirm` pop up isn't mocked.
Plus fix spec to actually check the pop up has been displayed
2024-09-02 12:18:44 +10:00
Cillian O'Ruanaidh
a6d3909e95
Replace text-angular editor with trix editor in fields for shop messages and about fields for enterprises and enterprise groups
2024-08-09 10:37:23 +01:00
Konrad
1a72b5b227
Merge pull request #12563 from abdulazizali77/bugfix/11326-incoming-exchange-per-item-calculator
...
Display only per_item fees for oc incoming exchange #11326
2024-08-02 03:11:27 +02:00
wandji20
0376c04ad5
Fix failing specs [OFN-12666]
2024-07-30 12:07:50 +01:00
Abdul Aziz Ali
8a1e61fd60
Fix incoming_controller_spec. Remove .order_cycle_id usage #11326
2024-07-27 17:54:39 +08:00
Konrad
d60d29b685
Merge pull request #12634 from chahmedejaz/bugfix/12632-voucher-field-focus-issue
...
Fix Voucher Code Field Focus Issue
2024-07-08 12:19:19 +02:00
Gaetan Craig-Riou
6538c7adca
Fix shopping system spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
b156f722f1
Fix variant override spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
9f612270c7
Fix bulk update product page old style
...
and related product pages
2024-07-03 11:05:01 +10:00
Ahmed Ejaz
ced3408aaa
12632 - add specs
2024-07-02 15:50:55 +05:00
David Cook
4f287ffe05
When dropdown fields don't allow blank, but are blank, show as changed
...
They were already counted as changed by the javascript, but didn't have a 'changed' class to indicate it.
The reason they are 'changed', is because the dropdown has no blank option, and is forced to select the first item in the list.
This is purely to cover the case of invalid data, but should help a lot when debugging data issues. I don't think it's any less efficient, because the extra 'classList.toggle' calls don't do anything on unchanged fields.
2024-05-27 17:14:18 +10:00
Matt-Yorkley
c0864405a1
Update bulk products JS spec
2024-04-02 09:27:36 +11:00
David Cook
b9b2c876cc
Ensure value always shows
...
Even thought it's not valid (you can't save items with an empty name), it's disconcerting when the value suddenly disappears from view.
2024-03-27 20:20:20 +11:00
David Cook
99121943a7
Fix bug
...
I missed a bit in a refactor, and it wasn't covered by the spec.
2024-03-27 20:20:20 +11:00
David Cook
b2881bb169
Add JS specs
...
Converted using https://www.codeconvert.ai/coffeescript-to-javascript-converter
With plenty of manual fixes required too..
2024-03-27 20:20:20 +11:00
David Cook
9beaf0a0c2
Use textContent FTW
...
Oh look, the test works better now too.
2024-03-27 17:35:09 +11:00
David Cook
26723194d5
Prevent popout from updating display value
...
Watch out, HAML will strip an attribute with boolean false, so we need to use a string. Or reconsider using false as a default value..
I wish Jest had the rspec concept of `let`.
2024-03-27 14:34:31 +11:00
David Cook
a5741a1ca8
Sync hidden variant unit fields
...
This will be necessary for managing the 'display as' state.
..or is it?
2024-03-27 14:34:19 +11:00
David Cook
38766f5256
Show variant_unit_name for 'items'
2024-03-06 13:41:22 +11:00
David Cook
bfd6319cf2
Mark tom-select as changed
...
Thankfully I was able to use basic DOM features, so there's no coupling of the logic with tom-select.
It wasn't going to be simple to get tom-select to listen for the 'changed' class on the original select, so I found a simple solution with a CSS sibling selector instead.
2024-03-06 13:41:22 +11:00
cyrillefr
b08623df23
Sytem specs + controller spec
...
- controller spec is lighter since it is based on an html element
2024-02-25 16:43:57 +01:00
David Cook
915a5ce66b
Listen for changes on added fields
...
Finally, we can add new variants!
Requires updated stimulus-rails-nested-form
2024-02-16 08:51:49 +11:00
