Maikel Linke
a41019fbff
Simplify SMTP auth method selection
...
Instead of using the auth method name, let's just not supply username
and password when we don't want to authenticate. The two affected
servers AU and CA don't have credentials set anyway. This is compatible.
The specs needed changing though.
2024-04-16 16:40:50 +10:00
Maikel Linke
d6f2a531aa
Don't pass invalid auth method "None" to net-smtp
...
It's our magic word to not pass username and password on.
2024-04-16 16:18:49 +10:00
Gaetan Craig-Riou
5371258125
Merge pull request #12366 from openfoodfoundation/dependabot/bundler/stripe-11.0.0
...
chore(deps): bump stripe from 10.15.0 to 11.0.0
2024-04-16 09:16:49 +10:00
Maikel Linke
d9ec6e2ca3
Wait longer for real Stripe responses
...
When we re-record cassettes, I noticed this spec failing. We may need to
add this parameter to more specs.
2024-04-12 12:34:26 +10:00
Maikel Linke
e5323c8e82
Update Stripe API recordings for new version
2024-04-12 12:27:02 +10:00
filipefurtad0
fd54a12bcb
Moves methods to end of the file
2024-04-11 12:36:47 +01:00
filipefurtad0
f4108e97c7
Improves regression spec after reviewer feedback
...
Removes shared_examples, defines a separate method
Removes pending to bring spec to green
2024-04-11 12:33:10 +01:00
Konrad
27a4202fa4
Merge pull request #12357 from mkllnk/fix-invoice-order
...
Fix: preserve order of invoices in bulk print
2024-04-11 12:47:14 +02:00
Maikel
dc7c5b6748
Merge pull request #12359 from openfoodfoundation/dependabot/bundler/stripe-10.15.0
...
chore(deps): bump stripe from 10.14.0 to 10.15.0
2024-04-11 16:25:04 +10:00
Maikel
082b1f9411
Merge pull request #12300 from mkllnk/checkout-steps
...
Remove unnecessary method checkout_steps
2024-04-11 15:57:45 +10:00
Maikel Linke
2f3b8c8573
Re-record Stripe cassettes
2024-04-11 11:45:14 +10:00
David Cook
3318c2622d
Merge pull request #12352 from cyrillefr/FixRailsWhereEquals
...
Fix rubocop FixRailsWhereEquals
2024-04-11 11:43:03 +10:00
Maikel Linke
c2c7910357
Reset I18n.local for each spec
...
This avoids a locale setting leaking from one spec to another. It also
means that we don't have to reset the locale in individual specs.
Also:
- `cookies` is reset automatically and we don't need to do that.
- Removed some unused code (German number format and helper methods).
2024-04-11 10:14:52 +10:00
Ahmed Ejaz
b2172ef8d8
12332 - Add around block to apply default_locale on specs
2024-04-11 10:14:52 +10:00
Ahmed Ejaz
693b9bd171
12332 - Fix rubocop Rails/I18nLocaleAssignment errors
...
- use I18n.with_locale method rather than direct locale assignment
2024-04-11 10:13:50 +10:00
Filipe
89033579bd
Merge pull request #12328 from dacook/buu/remove-stimulus-reflex
...
[BUU] Remove Stimulus Reflex from Products screen
2024-04-10 21:59:59 +01:00
Konrad
b3dd51d6ac
Merge pull request #12324 from chahmedejaz/task/12314-fix-rubocop-rails-helper-instance-variable
...
Fix Rubocop Rails/HelperInstanceVariable
2024-04-10 20:17:06 +02:00
David Cook
e78ef120f4
TODO
...
I think this case got lost.
2024-04-10 15:17:56 +01:00
David Cook
129ceb01f0
Fix spec
2024-04-10 15:17:56 +01:00
David Cook
fd8be37a62
Use shared page controls on products screen
...
This has an auto submit and can potentially work with Turbo, like on the Orders screen.
2024-04-10 15:17:56 +01:00
David Cook
0fc3d39106
Ensure pagination is retained when saving or discarding
...
But we have more work to do.
2024-04-10 15:17:56 +01:00
David Cook
2c71f7f1ed
Discard changes by reloading the page
...
Now there's a popup asking to confirm, which I think is worth keeping!
2024-04-10 15:17:56 +01:00
David Cook
8696e05e66
Move index and bulk_update actions to good ol' HTTP requests
...
We've found that we just can't rely in StimulusReflex (and the underlying WebSockets stack) to guarantee a response to a request.
Because of this, there was intermittent issues when the server was overloaded with large requests, and the response never arrived, leaving an infinite loader, and a poor user wondering if anything was still happening.
2024-04-10 15:17:56 +01:00
Maikel Linke
3382a62eb5
Simplify BulkInvoiceJob by removing checks
...
The check for invoiceability is already done by the reflex triggering
the job. Let's DRY the code, save time and be more flexible in the
future.
Also checking the order of actually generated PDF pages.
2024-04-10 16:52:56 +10:00
Maikel Linke
48b447500f
Move selection of invoicable orders to database
...
It's more efficient and should allow for further optimisations.
2024-04-10 16:52:56 +10:00
Maikel Linke
16c877f7cb
Fix: preserve order of invoices in bulk print
2024-04-10 14:51:55 +10:00
Maikel Linke
1d8b942acd
Fix spec for invoice ordering
2024-04-10 14:03:25 +10:00
David Cook
ade4e855dc
Merge pull request #12341 from mkllnk/connected-app-url
...
Make URL to connect app translatable
2024-04-10 10:36:49 +10:00
David Cook
d4da684f4a
Merge pull request #12349 from openfoodfoundation/dependabot/bundler/rubocop-1.63.0
...
chore(deps-dev): bump rubocop from 1.62.1 to 1.63.0
2024-04-10 10:32:32 +10:00
cyrillefr
404fcf1f72
Fix FixRailsWhereEquals
...
- fixes offenses caused by RuboCop::Cop::Rails::WhereEquals cop
2024-04-09 10:44:02 +02:00
Maikel
a40b9eb44e
Merge pull request #12316 from anansilva/6055-fix-rubocop-lint-constant-definition-in-block
...
Fix rubocop Lint/ConstantDefinitionInBlock group
2024-04-09 12:52:06 +10:00
Maikel Linke
c0010319af
Avoid duplicate loading of task in spec
...
The new product image import spec was loading rake tasks multiple times.
That make the spec for enterprise deletion fail when executed afterwards
because the deletion task was executed twice and failed the second time.
2024-04-09 12:04:42 +10:00
Maikel
c9c94fcaa5
Merge pull request #12337 from cyrillefr/FixRailsNegateIncludeRubocopIssue
...
Fix Rubocop Rails/NegateInclude issues
2024-04-09 10:40:47 +10:00
Gaetan Craig-Riou
103c6e7fc0
Remove debugging line
2024-04-09 10:30:46 +10:00
Gaetan Craig-Riou
1509066b85
Apply new cop Style/MapIntoArray fix
2024-04-09 10:29:30 +10:00
Maikel
169df3fb8b
Merge pull request #12343 from filipefurtad0/spec_regression_s2_12340
...
Adds regression spec for S2 bug #12340
2024-04-09 10:16:09 +10:00
Ana Nunes da Silva
061ff91786
Fix offense constant definition in block in validators/integer_array_validator_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
0aea14832a
Fix offense constant definition in block in validators/date_time_string_validator_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
939605cb7a
Fix offense constant definition in block in models/spree/preferences/preferable_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
b18fe8ce35
Fix offense constant definition in block in models/spree/preferences/configuration_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
fc3d7f8496
Fix offense constant definition in block in models/spree/gateway_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
3bd6c85f3b
Fix offense constant definition in block in models/spree/ability_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
0726e4c1d0
Fix offense constant definition in block in reports/line_items_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
cfca7816d5
Fix offense constant definition in block in serializer_helper_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
f1309db0f0
Fix offense constant definition in block in spree base_controller_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
d726a0e3cb
Fix offense constant definition in block in users.rake
...
This rake has tests
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
5415fa2db8
Fix offense constant definition in block in import_product_images_rake.rb
...
Add a test to import product images rake
2024-04-08 11:16:38 +01:00
filipefurtad0
8ad4f885a0
Adds shared example for descending name ordering
2024-04-07 17:15:12 +01:00
cyrillefr
f57d44ba24
Fix Lint/DuplicateRequire issue
...
- updates the todo list
2024-04-05 17:09:14 +02:00
filipefurtad0
f618ef1201
Adds regression spec for S2 bug #12340
2024-04-05 14:46:52 +01:00
