raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't pass invalid auth method "None" to net-smtp

Browse Source 
It's our magic word to not pass username and password on.
This commit is contained in:
Maikel Linke
2024-04-16 15:34:24 +10:00
parent 2adb69edb0
commit d6f2a531aa
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/spree/core/mail_settings.rb
View File

@@ -38,7 +38,13 @@ module Spree
{ address: Config.mail_host,
domain: Config.mail_domain,
port: Config.mail_port,
authentication: Config.mail_auth_type }
authentication: }
end
def authentication
return unless need_authentication?
Config.mail_auth_type.presence
end
def need_authentication?

2
spec/lib/spree/core/mail_settings_spec.rb
View File

@@ -23,7 +23,7 @@ module Spree
it { expect(ActionMailer::Base.smtp_settings[:address]).to eq "smtp.example.com" }
it { expect(ActionMailer::Base.smtp_settings[:domain]).to eq "example.com" }
it { expect(ActionMailer::Base.smtp_settings[:port]).to eq 123 }
it { expect(ActionMailer::Base.smtp_settings[:authentication]).to eq "None" }
it { expect(ActionMailer::Base.smtp_settings[:authentication]).to eq nil }
it { expect(ActionMailer::Base.smtp_settings[:enable_starttls_auto]).to be_truthy }
it "doesnt touch user name config" do