Mohamed ABDELLANI
a3fd7b77c8
notify if any distributors doesn't have an abn
2024-06-24 14:46:01 +01:00
Gaetan Craig-Riou
c4470f76e3
Merge pull request #12593 from filipefurtad0/regression_spec_12591
...
Adds regression spec for #12591
2024-06-24 14:46:29 +10:00
Gaetan Craig-Riou
cd768a1fe9
Merge pull request #12585 from mkllnk/flaky-caching
...
Ensure all assets are compiled on test page visit
2024-06-24 14:44:11 +10:00
Gaetan Craig-Riou
c756afa1cc
Merge pull request #12571 from filipefurtad0/adds_spec_on_abn_restriction
...
Adds test case to assure acceptance criteria from #12374 and #12373
2024-06-24 14:41:31 +10:00
Maikel
0dd7f264b9
Merge pull request #12542 from anansilva/12448-sanitise-html-custom-tab
...
Sanitize HTML in custom tab content [read only]
2024-06-21 08:35:26 +10:00
filipefurtad0
1d55c05900
Update all locales with the latest Transifex translations
v4.4.53
2024-06-20 11:17:26 -06:00
Konrad
f9e1ff9238
Merge pull request #12567 from mkllnk/flash-css-fix-v3
...
Error messages don't block bottom of page clicks
2024-06-20 17:22:02 +02:00
Ana Nunes da Silva
d2c6db0d04
Sanitize CustomTab#content
2024-06-20 11:56:09 +02:00
Konrad
25d375bf8e
Merge pull request #12577 from cyrillefr/WhiteLabelButtonAlwaysInactive
...
Update button should change status on modified white label
2024-06-20 11:39:58 +02:00
filipefurtad0
48a39f20e8
Adds regression spec for #12591
2024-06-19 19:30:42 -06:00
filipefurtad0
d1560ce15e
Adds shared examples for bulk send invoices in PDF
2024-06-19 17:58:58 -06:00
David Cook
0e0a7d9d3e
Merge pull request #12589 from cyrillefr/FixRailsRedundantActiveRecordAllMethodIssue
...
Fixes Rails/RedundantActiveRecordAllMethod issues
2024-06-20 09:40:56 +10:00
David Cook
66606eeeab
Merge pull request #12584 from mkllnk/spec-refactor
...
Update spec for quotation mark replacement
2024-06-20 09:37:09 +10:00
David Cook
ef195876fa
Merge pull request #12590 from abdellani/12452-improve-logging
...
update message logged when a product is deleted
2024-06-20 09:27:51 +10:00
Maikel
f933ae83c8
Merge pull request #12581 from dacook/cache-ci-yarn
...
Cache yarn global package data in CI
2024-06-20 09:01:05 +10:00
filipefurtad0
3380175c30
Restructures spec to accommodate shared example on bulk printing
2024-06-19 16:52:36 -06:00
Maikel
a9225543da
Merge pull request #12554 from mkllnk/dfc-logo
...
Add enterprise logo and contact name to DFC API with standard attributes
2024-06-20 08:49:27 +10:00
filipefurtad0
59b6cdaf01
Extends tests to cases where ABN is an empty string
...
Removes pending and changes testcase
As discussed on Slack we will not fix old invoice model, for ref. see: https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1718781775612759?thread_ts=1718249609.127149&cid=CG7NJ966B
2024-06-19 16:42:10 -06:00
Abdellani
0337464291
update logged message when a product is deleted
2024-06-19 15:15:04 +01:00
Abdellani
7a015bad96
populate destroyed_by on produce_v3_controller#destory
2024-06-19 15:14:32 +01:00
cyrillefr
654fda89ca
Fix Rails/RedundantActiveRecordAllMethod issues
...
- Cop: Rails/RedundantActiveRecordAllMethod
- if receiver is an Active Record object, ".all" can be safely removed
- There are 2 allowed receivers that are listed in the
styleguide file (those are defaults cf. cop documentation).
2024-06-19 14:32:21 +02:00
Maikel
ef7f1d335f
Merge pull request #12587 from openfoodfoundation/revert-12536-stock-levels
...
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:46:54 +10:00
Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Maikel Linke
d5b77a4f80
Ensure all assets are compiled on test page visit
2024-06-19 11:45:28 +10:00
Maikel Linke
10f0eeef0b
Update spec for quotation mark replacement
...
I'm not sure why, but the pre-compiling of assets triggered Rails to
render `style="..."` instead of `style='...'` in this case. But when
assets are compiled on-demand, we get the single quotes. So I changed
the spec to be agnostic of this detail. We actually just want to know
about the link and its href.
2024-06-19 11:40:09 +10:00
filipefurtad0
fe93e3ed97
Restructures spec
...
Separating into different contexts, with and without invoices feature enabled
2024-06-18 19:32:44 -06:00
Maikel
1e189207ed
Merge pull request #12583 from dacook/add-attachment-translation
...
Add translation key for Spree::Image#attachment
2024-06-19 11:20:07 +10:00
Maikel
af2e7db155
Merge pull request #12582 from cyrillefr/FixRails_UnusedRenderContentIssues
...
Fixes offenses raised by Rails/UnusedRenderContent
2024-06-19 11:19:22 +10:00
Maikel
2188e96dfb
Merge pull request #12575 from zanetagebka/RedundantInterpolationCops
...
Solve Rubocop RedundantInterpolation cops
2024-06-19 11:01:42 +10:00
David Cook
6ce442a42e
Add translation key for Spree::Image#attachment
2024-06-19 09:49:15 +10:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
Gaetan Craig-Riou
55ae1ba29f
Merge pull request #12579 from openfoodfoundation/dependabot/npm_and_yarn/ws-6.2.3
...
chore(deps): bump ws from 6.2.2 to 6.2.3
2024-06-19 09:17:53 +10:00
David Cook
6fd3cada8c
Fix classname
2024-06-19 09:13:53 +10:00
zanetagebka
b4bfcb7cc8
rubocop_todo recreate
2024-06-18 14:34:03 +02:00
zaneta.gebka
5cc33d1e0c
Merge branch 'master' into RedundantInterpolationCops
2024-06-18 14:33:12 +02:00
zanetagebka
c6254a5b7e
rubocop_todo recreate
2024-06-18 14:32:41 +02:00
cyrillefr
a155630b1c
Fixes offenses raised by Rails/UnusedRenderContent
...
- in any cases, adding status: :no_content dropes content from response
- replaced by head :no_content (HTTP 204)
2024-06-18 13:33:19 +02:00
Rachel Arnould
0c6cc9b822
Merge pull request #12558 from cyrillefr/BUUUploadingCorruptProductImagesFailsSilently
...
BUU Display error messages when file not valid
2024-06-18 12:12:51 +02:00
David Cook
b8f8d6d042
Show/hide columns with CSS selectors instead
...
Well, that made the JS way simpler.
Adds a lot of classes though. Maybe we could do it based on column index instead, but this will do for now.
table.hide-col0 { td:nth-child(0) { display: none; } }
2024-06-18 15:35:53 +10:00
David Cook
4023dc2265
Cache yarn dependencies
...
I don't know what this actually does, because it doesn't install the dependencies, that still needs to happen next.
But surely any cache is a good thing?
2024-06-18 13:09:45 +10:00
dependabot[bot]
9543b597d0
chore(deps): bump ws from 6.2.2 to 6.2.3
...
Bumps [ws](https://github.com/websockets/ws ) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/6.2.2...6.2.3 )
---
updated-dependencies:
- dependency-name: ws
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-18 02:16:27 +00:00
cyrillefr
8616847793
Update button should change status on modified white label
...
- swap position between users & white label so that user's inner form
- does not interfere with white_label own position in outer form
- modified spec so that lowermost user is clickable
2024-06-17 17:11:19 +02:00
zanetagebka
dd7ae1330f
Merge remote-tracking branch 'origin/RedundantInterpolationCops' into RedundantInterpolationCops
...
# Conflicts:
# .rubocop_todo.yml
2024-06-17 15:40:03 +02:00
zanetagebka
93eda48138
recreate rubocop_todo
2024-06-17 15:39:29 +02:00
zanetagebka
ad92d4b129
Solve Rubocop RedundantInterpolation cops
2024-06-17 15:37:39 +02:00
zanetagebka
422965748f
Solve Rubocop RedundantInterpolation cops
2024-06-17 15:32:25 +02:00
David Cook
aff50f66c4
Name and Producer columns grow to fill and other tweaks
...
If neither are visible, the first column on the left (eg image) will grow. But that's not a likely scenario.
Min-widths help manage sizes on smaller screens in Chrome.
The title for Inherits Properties gets cut off, but I think it's better than cutting off content.
Oh look, it fixed a spec too!
2024-06-17 12:27:06 +10:00
Gaetan Craig-Riou
cc45b9a0d3
Merge pull request #12557 from filipefurtad0/feature_parity_buu
...
Updating specs for BUU (feature parity)
2024-06-17 09:39:01 +10:00
cyrillefr
e07cf6c628
Do not use rescue as control flow
2024-06-16 23:38:38 +02:00
Maikel Linke
885f679eb1
Update all locales with the latest Transifex translations
v4.4.51
2024-06-14 11:26:09 +10:00