raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not use rescue as control flow

Browse Source
This commit is contained in:
cyrillefr
2024-06-16 23:38:38 +02:00
parent 0470efa502
commit e07cf6c628
1 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
app/controllers/spree/admin/images_controller.rb
View File

@@ -35,30 +35,32 @@ module Spree
@object.attributes = permitted_resource_params
@object.save!
flash[:success] = flash_message_for(@object, :successfully_created)
if @object.save
flash[:success] = flash_message_for(@object, :successfully_created)
respond_to do |format|
format.html { redirect_to location_after_save }
format.turbo_stream { render :update }
respond_to do |format|
format.html { redirect_to location_after_save }
format.turbo_stream { render :update }
end
else
respond_with_error(@object.errors)
end
rescue ActiveRecord::RecordInvalid => e
respond_with_error(e)
end
def update
@url_filters = ::ProductFilters.new.extract(request.query_parameters)
set_viewable
@object.update!(permitted_resource_params)
flash[:success] = flash_message_for(@object, :successfully_updated)
if @object.update(permitted_resource_params)
flash[:success] = flash_message_for(@object, :successfully_updated)
respond_to do |format|
format.html { redirect_to location_after_save }
format.turbo_stream
respond_to do |format|
format.html { redirect_to location_after_save }
format.turbo_stream
end
else
respond_with_error(@object.errors)
end
rescue ActiveRecord::RecordInvalid => e
respond_with_error(e)
end
def destroy
@@ -109,8 +111,8 @@ module Spree
)
end
def respond_with_error(error)
@errors = error.record.errors.map(&:full_message)
def respond_with_error(errors)
@errors = errors.map(&:full_message)
respond_to do |format|
format.html { respond_with(@object) }
format.turbo_stream { render :edit }