Gaetan Craig-Riou
e1c3f0a31c
Fix product scope query
...
Plus a small name refactor
2024-07-03 10:17:49 +10:00
Konrad
5bb47823c6
Merge pull request #12619 from rioug/12559-disable-report-button
...
[Reports] Disable GO button once clicked
2024-06-28 17:11:29 +02:00
David Cook
d799230440
Update controller to catch more specific error
...
We now know which errors to expect. We still let other unknown errors raise higher up, where they will be logged with BugSnag, and treated as internal_server_error.
2024-06-27 12:51:28 +10:00
David Cook
92bd7a5d37
Revert new product duplicator behaviour
2024-06-27 11:39:49 +10:00
Ahmed Ejaz
5a259f1b91
Merge branch 'master' into task/11987-remove-SR-from-clone
2024-06-26 16:18:42 +05:00
Ahmed Ejaz
9f832e6743
11987: update code as per new product duplicator behavior
2024-06-26 16:16:13 +05:00
Ahmed Ejaz
95972c75c6
11987: remove rescue StandardError from controller
2024-06-26 16:10:31 +05:00
David Cook
0001ffa970
Fix product index
...
The param product_index wasn't present, so it was always choosing 1.
The products on page are indexed 0-14, so of course it would always conflict.
It would be simpler if we just used product IDs as the index, I think I did earlier but don't remember why not.
Anyway, using a negative number seems to work.
If there's an error, there will only be one at a time.
2024-06-26 17:04:49 +10:00
Gaetan Craig-Riou
74fb6c3143
Disable GO button once clicked
...
It is disabled both on client side and server side, so even if the
server takes a while to respond the button is disabled
2024-06-26 16:01:05 +10:00
Ahmed Ejaz
98e0b0e703
12346 - fix rubocop rails/pluck errors
2024-06-22 01:45:58 +05:00
Abdellani
7a015bad96
populate destroyed_by on produce_v3_controller#destory
2024-06-19 15:14:32 +01:00
Maikel
af2e7db155
Merge pull request #12582 from cyrillefr/FixRails_UnusedRenderContentIssues
...
Fixes offenses raised by Rails/UnusedRenderContent
2024-06-19 11:19:22 +10:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
cyrillefr
a155630b1c
Fixes offenses raised by Rails/UnusedRenderContent
...
- in any cases, adding status: :no_content dropes content from response
- replaced by head :no_content (HTTP 204)
2024-06-18 13:33:19 +02:00
Rachel Arnould
0c6cc9b822
Merge pull request #12558 from cyrillefr/BUUUploadingCorruptProductImagesFailsSilently
...
BUU Display error messages when file not valid
2024-06-18 12:12:51 +02:00
Ahmed Ejaz
d2737bd8b0
11987: refactored code
2024-06-18 00:44:10 +05:00
Ahmed Ejaz
05fe7cd4b9
11987: add flash messages for product clone
2024-06-17 23:17:32 +05:00
Ahmed Ejaz
fa3b84b71f
11987: add clone action
2024-06-17 21:58:07 +05:00
cyrillefr
e07cf6c628
Do not use rescue as control flow
2024-06-16 23:38:38 +02:00
cyrillefr
0470efa502
Requested changes: turbo_stream for success
...
- must respond via turbo for create and update for success
- changed the spec accordingly
2024-06-13 15:22:54 +02:00
David Cook
b25d2ed32a
Refactor to fix Metrics/AbcSize linter
2024-06-13 10:51:35 +10:00
David Cook
db27fc5a2b
Remove dead code
...
I'm pretty sure that case doesn't happen, and besides there's no spec for it.
2024-06-13 10:51:00 +10:00
David Cook
e7774d7a24
Lint fix
...
Sorry didn't have time to go back and rebase
2024-06-13 10:39:19 +10:00
Maikel
5b95ef3bd9
Merge pull request #12525 from mkllnk/fdc-import
...
Add compatibility to the DFC product import for FDC (Shopify) API
2024-06-13 09:51:05 +10:00
David Cook
ae66a85cc5
Show error messages
...
There shouldn't normally be errors, but I got one due to bad data during development, and this helped sort it out.
2024-06-12 14:58:09 +10:00
David Cook
89cedc4287
Submit and render with Turbo Stream
2024-06-12 14:49:59 +10:00
David Cook
68da9c9e04
Add form to save column preferences
2024-06-12 14:49:53 +10:00
cyrillefr
c5decfc58b
Bugfix introduced by last commit
...
- fixed bug created by last commit
- refactored to new method respond_with_error
- need for 2 cases in request spec: html & turbo
2024-06-12 00:31:19 +02:00
cyrillefr
942990612b
Requested changes
...
- refined the code and applied it to create method too
- modified one request spec to work with turbo_stream
- added 2 examples in system specs
2024-06-11 22:29:12 +02:00
zanetagebka
a2a670c848
Fix cops StringConcatenation
2024-06-11 15:17:32 +10:00
Gaetan Craig-Riou
8b31fa1ee5
Merge pull request #12541 from openfoodfoundation/dependabot/bundler/rubocop-1.64.1
...
chore(deps-dev): bump rubocop from 1.63.5 to 1.64.1
2024-06-11 10:30:28 +10:00
cyrillefr
01612843b4
BUU Display error messages when file not valid
...
- implements a turbo response in controller
- display error messages on modal -> able for user to re upload
- removes a pending in spec that now tests error message
2024-06-10 14:32:08 +02:00
David Cook
9c0f55ad22
Refactor
2024-06-05 09:45:30 +10:00
Maikel Linke
d9f013abbc
Style/SendWithLiteralMethodName
...
Use method call directly instead of `public_send` with fixed argument.
The cop is declared unsafe. I think that is because it can also replace
`send` but we replace only `public_send` here.
2024-06-05 09:38:21 +10:00
Maikel Linke
e6ac2f0d88
Style/SuperArguments
...
Call super without arguments and parentheses when the signature is identical.
2024-06-05 09:29:42 +10:00
Ahmed Ejaz
ce60a2a1e0
12398: add lazylookup for translations
2024-05-30 14:44:34 +05:00
Ahmed Ejaz
c2fa993432
12398: fix lint issues
2024-05-30 14:24:51 +05:00
Ahmed Ejaz
8ee833d2d8
12398: add flash.now
2024-05-29 01:19:50 +05:00
Maikel Linke
fae7a089ee
Import products from the FDC (Shopify) API
2024-05-28 17:00:06 +10:00
Maikel Linke
635234a889
Enable POSTing DFC data
2024-05-28 15:10:05 +10:00
Ahmed Ejaz
fb07794cf3
12398: add slide-out animation
2024-05-28 01:10:30 +05:00
Ahmed Ejaz
a0f290c09f
12398: add turbo stream to delete variants
2024-05-24 02:41:51 +05:00
Ahmed Ejaz
2bdf8e2853
rename destroy.turbo_stream to make it more generic
2024-05-24 02:40:34 +05:00
Ahmed Ejaz
039b0d80ee
12398: implement the destroy action for products
2024-05-24 01:55:21 +05:00
Ahmed Ejaz
53fb77eb23
12398: add destroy action with turbo stream
2024-05-24 01:16:14 +05:00
Filipe
88baf5e1de
Merge pull request #12496 from isidzukuri/12355-remove-unused-discourse
...
[12355] Remove discourse
2024-05-23 19:28:02 +01:00
Filipe
5455e68620
Merge pull request #12504 from dacook/buu/edit-image-turbo-12399
...
[BUU] Remove StimulusReflex from Image Edit
2024-05-23 17:32:59 +01:00
David Cook
665273ce2f
[wip] Attempt to update edited image in-place with Turbo Stream
...
but it doesn't quite work.
Maybe we can force it with JS (https://www.writesoftwarewell.com/process-turbo-stream-javascript/ )
2024-05-23 11:55:29 +10:00
Maikel
32eb9c5504
Merge pull request #12481 from mkllnk/connect-app-once
...
Avoid submitting duplicate Connected Apps
2024-05-23 08:50:34 +10:00
David Cook
536b5608ab
Show edit form for new images
2024-05-22 17:08:58 +10:00
