Merge pull request #12541 from openfoodfoundation/dependabot/bundler/rubocop-1.64.1

chore(deps-dev): bump rubocop from 1.63.5 to 1.64.1

Gemfile.lock

@@ -494,7 +494,7 @@ GEM
     parallel (1.24.0)
     paranoia (2.6.3)
       activerecord (>= 5.1, < 7.2)
-    parser (3.3.1.0)
+    parser (3.3.2.0)
       ast (~> 2.4.1)
       racc
     paypal-sdk-core (0.3.4)
@@ -604,7 +604,7 @@ GEM
       redis-client (>= 0.22.0)
     redis-client (0.22.1)
       connection_pool
-    regexp_parser (2.9.0)
+    regexp_parser (2.9.2)
     reline (0.5.0)
       io-console (~> 0.5)
     request_store (1.5.1)
@@ -667,7 +667,7 @@ GEM
     rswag-ui (2.13.0)
       actionpack (>= 3.1, < 7.2)
       railties (>= 3.1, < 7.2)
-    rubocop (1.63.5)
+    rubocop (1.64.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)

app/components/help_modal_component.rb

@@ -2,6 +2,6 @@
 
 class HelpModalComponent < ModalComponent
   def initialize(id:, close_button: true)
-    super(id:, close_button:)
+    super
   end
 end

app/controllers/admin/resource_controller.rb

@@ -146,7 +146,7 @@ module Admin
       return nil if parent_data.blank?
 
       @parent ||= parent_data[:model_class].
-        public_send("find_by", parent_data[:find_by] => params["#{model_name}_id"])
+        find_by(parent_data[:find_by] => params["#{model_name}_id"])
       instance_variable_set("@#{model_name}", @parent)
     end
 

app/controllers/application_controller.rb

@@ -60,7 +60,7 @@ class ApplicationController < ActionController::Base
     rescue StandardError
       'unknown'
     end}")
-    super(options, response_status)
+    super
   end
 
   def set_checkout_redirect

app/helpers/bulk_form_builder.rb

@@ -8,6 +8,6 @@ class BulkFormBuilder < ActionView::Helpers::FormBuilder
       opts[:class] = "#{opts[:class]} changed".strip
     end
 
-    super(field, **opts)
+    super
   end
 end

app/models/concerns/file_preferences.rb

@@ -22,7 +22,7 @@ module FilePreferences
     if has_preference?("#{key}_blob_id")
       :file
     else
-      super(key)
+      super
     end
   end
 

lib/reporting/queries/query_builder.rb

@@ -15,7 +15,7 @@ module Reporting
       end
 
       def selecting(lambda)
-        fields = instance_exec(&lambda).map{ |key, value| value.public_send(:as, key.to_s) }
+        fields = instance_exec(&lambda).map{ |key, value| value.as(key.to_s) }
 
         reflect query.project(*fields)
       end

lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_order.rb

@@ -7,7 +7,7 @@ module Reporting
         attr_accessor :parameters
 
         def initialize(user, params = {}, render: false)
-          super(user, params, render:)
+          super
         end
 
         def search

lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_producer.rb

@@ -7,7 +7,7 @@ module Reporting
         attr_accessor :permissions
 
         def initialize(user, params = {}, render: false)
-          super(user, params, render:)
+          super
           @permissions = Permissions.new(user)
         end
 

lib/reporting/reports/enterprise_fee_summary/fee_summary.rb

@@ -7,7 +7,7 @@ module Reporting
         attr_accessor :permissions, :parameters
 
         def initialize(user, params = {}, render: false)
-          super(user, params, render:)
+          super
           @parameters = Parameters.new(params.fetch(:q, {}))
           @parameters.validate!
           @permissions = Permissions.new(user)

lib/reporting/reports/enterprise_fee_summary/parameters.rb

@@ -28,7 +28,7 @@ module Reporting
           self.shipping_method_ids = []
           self.payment_method_ids = []
 
-          super(attributes)
+          super
 
           cleanup_arrays
         end

lib/spree/authentication_helpers.rb

@@ -3,9 +3,9 @@
 module Spree
   module AuthenticationHelpers
     def self.included(receiver)
-      receiver.public_send :helper_method, :spree_current_user
-      receiver.public_send :helper_method, :spree_login_path
-      receiver.public_send :helper_method, :spree_logout_path
+      receiver.helper_method :spree_current_user
+      receiver.helper_method :spree_login_path
+      receiver.helper_method :spree_logout_path
     end
 
     def spree_current_user

spec/swagger_helper.rb

@@ -75,7 +75,7 @@ end
 
 module RswagExtension
   def param(args, &)
-    public_send(:let, args) { instance_eval(&) }
+    let(args) { instance_eval(&) }
   end
 end
 Rswag::Specs::ExampleGroupHelpers.prepend RswagExtension