Luis Ramos
7ccfdc8d21
Merge pull request #4546 from kshlyk/fix_cart_link_on_mobile
...
Cart link in header on mobile leads to cart page instead of checkout …
2019-12-11 13:45:56 +00:00
Luis Ramos
4799293996
Merge pull request #4518 from Matt-Yorkley/ruby-2.3.7
...
Bump Ruby to 2.3.7
2019-12-11 13:29:01 +00:00
Luis Ramos
58a93c27ae
Merge pull request #4539 from luisramos0/subs_s3
...
Make weight calculator work for SubscriptionLineItems
2019-12-11 11:20:53 +00:00
Luis Ramos
9f351607d1
Merge pull request #4538 from mkllnk/4537-paginated-product-order
...
Make product order deterministic
2019-12-10 18:00:45 +00:00
Maikel
c45e3c9cca
Merge pull request #4543 from openfoodfoundation/transifex
...
Transifex
2019-12-10 20:10:23 +11:00
Luis Ramos
71bf3f5f71
Merge pull request #4514 from luisramos0/backend_ctrl_overview
...
Bring spree_backend overview controller to OFN
2019-12-09 23:36:32 +00:00
Konstantin Shlyk
ef142de5f2
Cart link in header on mobile leads to cart page instead of checkout page
2019-12-09 22:58:00 +03:00
luisramos0
f64e8bf50e
Make user aware of server side errors when saving subscription products and unit test products_panel_controller
2019-12-09 17:49:38 +00:00
luisramos0
1b29d474d0
Add specs to cover case where updating subscriptions products quantity fails
2019-12-09 15:11:32 +00:00
Luis Ramos
baae58ecb6
Merge pull request #4288 from luisramos0/oc_serializer_spec
...
Add spec for api/admin/order_cycle_serializer
2019-12-09 11:16:04 +00:00
Pau Pérez Fabregat
6411871ecb
Merge pull request #4540 from openfoodfoundation/dependabot/bundler/ddtrace-0.30.0
...
Bump ddtrace from 0.29.1 to 0.30.0
2019-12-09 09:48:27 +01:00
Transifex-Openfoodnetwork
22833ae79b
Updating translations for config/locales/it.yml
2019-12-09 19:28:13 +11:00
Transifex-Openfoodnetwork
ac20b0e7fb
Updating translations for config/locales/it.yml
2019-12-09 19:25:06 +11:00
luisramos0
e9e6aa77d8
Make weight calculator work for SubscriptionLineItems by making it test if line_item responds to final_weight_volume field (final_weight_volume_present?)
...
We also add logic to weight_per_variant so that we use variant.unit_value if final_weight_volume is not available but variant_unit is weight
Adapt some test case to test unit_value (in grams) instead of weight (in kgs)
2019-12-08 17:36:21 +00:00
dependabot-preview[bot]
7840118dea
Bump ddtrace from 0.29.1 to 0.30.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.29.1 to 0.30.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.29.1...v0.30.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-06 19:18:08 +00:00
luisramos0
5e27bd6d6d
Add for now very basic spec to api/admin/order_cycle_serializer
2019-12-06 16:41:54 +00:00
Maikel Linke
d4512904ea
Make product order deterministic
...
When products are sorted by name and two products have the same name,
their order is undefined. With pagination, two pages can have a
different order of products with the same name which then means that two
pages can return the same product.
Sorting by product id makes sure that the result is always in the same
order, for every page.
2019-12-05 15:37:10 +11:00
Maikel
52dc288470
Merge pull request #4530 from openfoodfoundation/transifex
...
Transifex
2019-12-05 11:01:30 +11:00
Luis Ramos
302de04e73
Merge pull request #4526 from kristinalim/fix/3149-fix_tool_tips_in_orders_list
...
3149 Fix tooltips in orders list
2019-12-04 10:38:28 +00:00
Transifex-Openfoodnetwork
41767936d6
Updating translations for config/locales/ca.yml
2019-12-03 22:50:13 +11:00
Transifex-Openfoodnetwork
0ccf30202e
Updating translations for config/locales/ca.yml
2019-12-03 22:47:06 +11:00
Transifex-Openfoodnetwork
00f36e4686
Updating translations for config/locales/ca.yml
2019-12-03 22:43:57 +11:00
Maikel
4d77f30bc0
Merge pull request #4506 from openfoodfoundation/dependabot/bundler/ddtrace-0.29.1
...
Bump ddtrace from 0.29.0 to 0.29.1
2019-12-03 20:39:58 +11:00
Maikel
f38b1b95f0
Merge pull request #4525 from kristinalim/fix/4489-flaky_spec_for_editing_oc
...
4489 Improve waiting in feature spec for edit Order Cycle page
2019-12-03 20:36:37 +11:00
Luis Ramos
97ef93b840
Merge pull request #4516 from openfoodfoundation/transifex
...
Transifex
v2.6.6
2019-12-02 17:50:26 +00:00
Luis Ramos
6db15a0a20
Merge pull request #4524 from Matt-Yorkley/packing_reports
...
Packing reports performance
2019-12-02 17:32:52 +00:00
Luis Ramos
c8395a487a
Merge pull request #4523 from luisramos0/permissions_improve
...
Replace pluck with select in permissions to avoid extra queries and extract Permissions::Orders from Permissions
2019-12-02 16:31:04 +00:00
Kristina Lim
852adfd436
Improve waiting in feature spec for order cycle page
2019-12-02 20:06:43 +08:00
luisramos0
1e948735fb
Fix major performance problem by inverting the logic, instead of looking for line_items that are hidden, it looks for line items that are not editable using a merge statement that performs much better
...
Also, remove unnecessary if clause, merge will return an empty relation if no items are found, no need to test for empty.
The test report runs in a little over one minute instead of 8minutes
2019-11-30 22:38:03 +00:00
luisramos0
0ef4247914
Convert Report::LineItems to class and memoize orders so it's only executed once (this improves the report in 3secs for the case I am testing)
2019-11-29 21:51:54 +00:00
Kristina Lim
2673a6efee
Fix Angular tracking of row in orders list
...
The tooltip content for the order in index n in page x was being used
for the order in index n in page y.
This was because ng-repeat was tracking the items/rows by index.
As far as ng-repeat is aware, rows with the same index in any page
were the same items/rows, so it didn't bother relinking the ofn-with-tip
directive.
2019-11-30 03:53:20 +08:00
Kristina Lim
6ffe7f1a99
Set width and enable wrapping for tooltips
2019-11-30 03:53:16 +08:00
Matt-Yorkley
6d1fb63a21
Eager-load option_values on line_item objects instead of variants in packing reports.
2019-11-29 20:16:48 +01:00
Matt-Yorkley
9bcd303f4f
Remove shipping_category N+1 from packing reports
2019-11-29 20:16:48 +01:00
Matt-Yorkley
38c327dae0
Improve N+1 issues around #suppliers_of_products_distributed_by
...
There's still some real mess here with repeating queries, but resolving it is out of scope for this quick PR
2019-11-29 20:16:03 +01:00
Matt-Yorkley
51177b833e
Remove customer_code N+1 from packing reports
2019-11-29 17:09:12 +01:00
luisramos0
cc3368704a
Fix rubocop issues in reports_controller_decorator and in report line_items
2019-11-29 13:54:30 +00:00
Pau Pérez Fabregat
2d53fbbe8c
Merge pull request #4520 from kristinalim/fix/4238-flaky_spec_in_api_taxons_index
...
4238 Do not assume order in spec for taxons list
2019-11-29 13:23:51 +01:00
luisramos0
3959f16d65
Switch some more references from Permissions to Permissions::Order
2019-11-29 12:22:50 +00:00
Pau Pérez Fabregat
fb28826d92
Merge pull request #4522 from kristinalim/fix/4239-flaky_spec_in_bulk_product_clone
...
4239 Do one thing at a time in feature spec for product cloning
2019-11-29 13:22:42 +01:00
luisramos0
beaa8ffa27
Use more specific selector to avoid ambigous column error
2019-11-29 11:45:22 +00:00
luisramos0
da6d035a1d
Rename some reports permissions to order_permissions
2019-11-29 11:23:17 +00:00
luisramos0
5cb77c443b
Fix rubocop issues
2019-11-29 10:53:40 +00:00
luisramos0
8d16f496f4
Move Permissions::Order specs to its specific spec file
2019-11-29 10:49:59 +00:00
luisramos0
82b274e522
Make selector more specific to avoid sql error 'ambiguos column'
2019-11-29 10:49:58 +00:00
luisramos0
484cdd1e07
Make managed_and_related_enterprises public so they can be used by other permissions classes
2019-11-29 10:49:27 +00:00
luisramos0
bb2e6324bd
Rename order permissions to just order
2019-11-29 10:49:27 +00:00
luisramos0
89056e13ed
Extract order permissions to a separate class
2019-11-29 10:48:58 +00:00
luisramos0
df0458743b
Replace pluck with select in permissions to avoid extra queries
2019-11-28 23:37:49 +00:00
luisramos0
ba1ad0a6dd
Rename decorator to controller so that the rubocop exception for the index action keeps being seen by code climate
2019-11-28 16:47:02 +00:00