Luis Ramos
c75341838e
Bring core.rb from spree_core
2020-07-11 15:41:26 +01:00
Luis Ramos
84d7538b1b
Bring i18n code from spree
2020-07-11 15:41:26 +01:00
Luis Ramos
388d575cc8
Remove strong parameters and search helpers, they are not used in OFN
2020-07-11 15:41:26 +01:00
Luis Ramos
fdd21d7d7d
Fix easy rubocop issues
2020-07-11 15:41:26 +01:00
Luis Ramos
ab67a4f80c
Bring base controller from spree
2020-07-11 15:41:26 +01:00
Matt-Yorkley
f450c21308
Merge pull request #5759 from luisramos0/vo_spec
...
Comment very flaky spec
2020-07-10 21:44:03 +02:00
Luis Ramos
eb4d648a23
Comment this very flaky spec for now
2020-07-10 19:27:31 +01:00
Pau Perez
cf64d3a290
Merge skipped callback from decorator into model
...
If we don't want that callback we can just as well remove it now that we
own that code.
2020-07-10 15:07:12 +02:00
Pau Perez
55d52b875f
Run rubocop autocorrect on payment model
2020-07-10 15:04:29 +02:00
Luis Ramos
5afb862ce1
Extract setup and authorize to a new method called prepare_for_payment to fix rubocop ABCsize issue
...
It looks like this rubocop rule weights a raise over a return...
2020-07-10 13:14:07 +01:00
Pau Perez
6389fdb16e
Simplify code related to error handling
2020-07-10 13:14:07 +01:00
Luis Ramos
01ab974a3b
Add rescue statment to failed payment email so that the processing of other orders continues if there is a problem while sending the email
2020-07-10 13:14:07 +01:00
Luis Ramos
7a9f9a5624
Log bugsnag and still send failed payment email when any exception is caught during the confirmation process
2020-07-10 13:14:05 +01:00
Transifex-Openfoodnetwork
50427472c4
Updating translations for config/locales/en_NZ.yml
2020-07-10 20:25:20 +10:00
Pau Perez
683794636b
Rename spec file
2020-07-10 11:57:36 +02:00
Pau Perez
2f4648342f
Merge decorator specs with Spree's ones
...
They are now isolated from each other.
2020-07-10 11:50:20 +02:00
Pau Perez
562f397b22
Isolate Spree's specs into their own context
...
This way we don't mix contexts while merging in our own decorator tests.
2020-07-10 11:46:59 +02:00
Pau Perez
8fbbb0bb64
Bring back our card factory modification
...
Merging Spree's an our factory didn't really work.
2020-07-10 11:42:56 +02:00
Pau Perez
d8b748a851
Merge alias_method method and its original version
2020-07-10 10:41:44 +02:00
Pau Perez
d49068ce66
Move method delegation from decorator to model
2020-07-10 10:41:44 +02:00
Pau Perez
cf6138da66
Replace model method with its decorated version
2020-07-10 10:41:44 +02:00
Pau Perez
3fb6193098
Move adjustments logic from decorator into model
2020-07-10 10:41:44 +02:00
Pau Perez
861726200c
Move localize_number from decorator to model
2020-07-10 10:41:44 +02:00
Pau Perez
48910aeb77
Move #refund! to the processing.rb
2020-07-10 10:41:44 +02:00
Pau Perez
6d9a518616
Move method from decorator to model
2020-07-10 10:41:44 +02:00
Pau Perez
322c4d0f3f
Move decorator's callbacks to model
2020-07-10 10:41:44 +02:00
Pau Perez
eafaa97b0e
Temporarily skip spec
...
I'll move on to other easier issues and get back to it when we're in
a better position.
2020-07-10 10:41:44 +02:00
Pau Perez
31d0d4bcae
Fix error "no parent is saved"
...
The exact error is
```
ActiveRecord::RecordNotSaved:
You cannot call create unless the parent is saved
```
raised from app/models/spree/payment_decorator.rb:29:in `ensure_correct_adjustment'
2020-07-10 10:41:44 +02:00
Pau Perez
9935df9f2d
Move Pin payment method from decorator into model
2020-07-10 10:41:44 +02:00
Pau Perez
0ad8dcc2c5
Fix payment log entries specs
...
The tight coupling between doesn't give other option but to check the
private method is called. The specs successfully stub
`log_entries#create` but for some reason the model instance that gets
evaluated it's not the stubbed one.
2020-07-10 10:41:44 +02:00
Pau Perez
a01f601363
Fix yet another spec
2020-07-10 10:41:44 +02:00
Pau Perez
34de219233
Bring in missing translation
2020-07-10 10:41:44 +02:00
Pau Perez
e1ea5dbcb3
Fix all but the 7 last payment specs
2020-07-10 10:41:44 +02:00
Pau Perez
abacd06f6b
Fix credit card instance in specs
2020-07-10 10:41:44 +02:00
Pau Perez
06aa56164f
Bring in Payment model from Spree
2020-07-10 10:41:44 +02:00
Maikel
c1d700196b
Merge pull request #5739 from Matt-Yorkley/flaky-spec-complex-oc
...
Flaky spec order_cycles/complex_updating_specific_time
2020-07-10 14:59:59 +10:00
Luis Ramos
cc3361aaac
Merge pull request #5659 from dmarcoux/issue-5555
...
Filter orders on inclusive dates in admin/orders
2020-07-09 20:40:45 +01:00
Luis Ramos
ed915006fa
Merge pull request #5738 from openfoodfoundation/dependabot/bundler/wicked_pdf-2.1.0
...
Bump wicked_pdf from 1.4.0 to 2.1.0
2020-07-09 20:40:11 +01:00
Matt-Yorkley
1a132924d2
Fix StrongParameters for groups images
2020-07-09 10:00:02 +02:00
Transifex-Openfoodnetwork
e3980521ea
Updating translations for config/locales/fr_CA.yml
2020-07-09 07:58:41 +10:00
Transifex-Openfoodnetwork
e6a2eb8af9
Updating translations for config/locales/en_CA.yml
2020-07-09 07:53:34 +10:00
Luis Ramos
5648b2e281
Add rescue statements to subs jobs so that when an order placement or confirmation fails, there's a bugsnag alert for it and the job continues processing the rest of the orders
2020-07-08 18:41:14 +01:00
Luis Ramos
fabddbd1c0
Merge pull request #5746 from coopdevs/remove-specs-dead-code
...
Remove dead specs helper method
2020-07-08 12:38:24 +01:00
Steve Roberts
2f562809c0
Ensure the hero image doesn't attempt to use the full height of all page content
...
Not sure exactly why this happens, but when the mobile nav is opened the hero image at #tagline:before uses the height of the full window - often around 4000px. Adding max-height of 100% to the nearest safe parent prevents this behaviour.
2020-07-08 21:31:52 +10:00
Matt-Yorkley
a763a5ee0b
Update all locales with the latest Transifex translations
v3.1.0
2020-07-08 12:49:20 +02:00
Matt-Yorkley
d718eb9a23
Merge pull request #5726 from openfoodfoundation/transifex
...
Transifex
2020-07-08 12:33:09 +02:00
Matt-Yorkley
d78db16abe
Merge pull request #5718 from Matt-Yorkley/available-locales-bug
...
Available locales bug
2020-07-08 12:30:18 +02:00
Steve Roberts
eda9293619
Change to new directive that prevents enter default and blurs the input field
2020-07-08 19:19:46 +10:00
Matt-Yorkley
e742069959
Refactor UI interactions for opening exchange product tabs in OC edit
2020-07-08 11:11:39 +02:00
Matt-Yorkley
c8254b8338
Adjust exchange_row assertion to use slightly more specific criteria
2020-07-08 11:11:39 +02:00