Extract setup and authorize to a new method called prepare_for_payment to fix rubocop ABCsize issue

It looks like this rubocop rule weights a raise over a return...
This commit is contained in:
Luis Ramos
2020-07-10 12:44:55 +01:00
parent 6389fdb16e
commit 5afb862ce1

View File

@@ -61,14 +61,17 @@ class SubscriptionConfirmJob
raise if order.errors.present?
return unless order.payment_required?
prepare_for_payment!(order)
order.process_payments!
raise if order.errors.any?
end
def prepare_for_payment!(order)
setup_payment!(order)
raise if order.errors.any?
authorize_payment!(order)
raise if order.errors.any?
order.process_payments!
raise if order.errors.any?
end
def setup_payment!(order)