David Cook
4bf65e330b
Enable master variants with associated order cycles
...
There's only 5 in UK prod. keeping them is easier than figuring out if it's safe to delete.
2023-06-23 11:50:26 +10:00
David Cook
2025a98f58
Delete stock_items for master variants
...
All variants have stock_items records, but master variants never use them, so these were always redundant.
2023-06-23 11:49:29 +10:00
Matt-Yorkley
c88799618f
Set master variants which are associated to line items to non-master
...
Line items which reference a master variant is a scenario that in theory shouldn't have been valid or even possible for at least 5-6 years, and these old bits of data in theory should have been cleaned up at the time those changes were made. But a couple of servers have some really old data that's not in a nice state.
Here we can just flip the is_master flag to false for those specific (legacy data) cases before deleting any other master variants, to keep the legacy line item data intact.
2023-06-22 13:10:47 +01:00
Matt-Yorkley
f9185ea56e
Remove line items related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 18:08:21 +01:00
Matt-Yorkley
6f5d3ceacc
Remove inventory units related to master variants
...
These shouldn't technically exist, but apparently they can be present if the dataset is old enough. They can trigger a foreign key violation if they are present when a master variant is deleted, so they need to be dropped if present.
2023-06-21 17:20:28 +01:00
Matt-Yorkley
24aa55e053
Remove array syntax on new product form for product image
2023-06-20 13:14:52 +01:00
Matt-Yorkley
ae24b2d688
Update ScopeVariantsForSearch logic to match both product and variant SKUs
2023-06-16 21:26:28 +01:00
Matt-Yorkley
0f253bb2a0
Blank out product SKU when cloning a product
...
This was effectively being done before for the product's sku (stored on the master variant) via the #duplicate_variant method, but now it needs to be done explicitly on the product in #duplicate_product
2023-06-16 21:26:28 +01:00
Matt-Yorkley
15000c7ed1
Remove unnecessary iterator
2023-06-16 21:26:28 +01:00
Matt-Yorkley
733dd3c428
Disable variant is_master column
2023-06-16 21:23:44 +01:00
Matt-Yorkley
be72bbebb9
Remove master images data migration tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
fbd09869bb
Remove is_master from variant serializer
2023-06-16 21:23:44 +01:00
Matt-Yorkley
ced60d4382
Remove superfluous method from products controller
2023-06-16 21:23:44 +01:00
Matt-Yorkley
b59bdc75e9
Delete master variants
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1daab8994d
Remove is_master and not_master scopes
2023-06-16 21:23:44 +01:00
Matt-Yorkley
0703bb4583
Remove unused is_master references in tests
2023-06-16 21:23:44 +01:00
Matt-Yorkley
85059bfb26
Remove master variant validation conditionals
2023-06-16 21:23:44 +01:00
Matt-Yorkley
8247dce2dc
Improve validation feedback on new variant page and add test coverage
2023-06-16 21:23:44 +01:00
Matt-Yorkley
618900767f
Fix flaky spec: use milliseconds in cache service and remove sleep
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1e36043a2e
Set unit_value to true when cloning a product
...
This value doesn't get persisted, but it's presence is validated. The product's duplicated variants store the actual :unit_value attribute
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1922598d2d
Reorganise associations, validations, scopes and callbacks for clarity
2023-06-16 21:23:44 +01:00
Matt-Yorkley
3ef7d2c9ff
Remove master variant from product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
21cba0aa13
Migrate first master variant image to product image
2023-06-16 21:23:44 +01:00
Matt-Yorkley
7dc1091bc2
Migrate product image from master variant to product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
d8649fc9fb
Migrate master variant :sku to product
2023-06-16 21:21:40 +01:00
Matt-Yorkley
6b9b5ea347
Stop storing unit_value and unit_description on master variant
2023-06-16 21:21:40 +01:00
Matt-Yorkley
8c0b8dad85
Stop using master variant for storing :display_as value
2023-06-16 21:21:40 +01:00
Matt-Yorkley
1b06c20197
Stop using master variant as a potential store for prices
2023-06-16 21:21:40 +01:00
Matt-Yorkley
80a0138b48
Update old specs that rely on master variant instead of real variants
2023-06-16 21:21:40 +01:00
Matt-Yorkley
d4188da7c1
Simplify product images delegation mess
2023-06-16 21:21:40 +01:00
Matt-Yorkley
42a5a48816
Remove dead code
2023-06-16 21:21:40 +01:00
Matt-Yorkley
dd224b953d
Update stage.yml
2023-06-16 14:24:23 +01:00
Matt-Yorkley
cfe5d9a740
Update stage.yml
2023-06-16 14:00:30 +01:00
Matt-Yorkley
09bfe14ae9
Update stage.yml
2023-06-16 13:39:12 +01:00
Maikel
4e1f735630
Include feature toggle heading in release notes
2023-06-16 14:13:41 +10:00
Maikel Linke
2453084a6b
Update translations
v4.3.13
2023-06-16 14:02:47 +10:00
Maikel
39183547aa
Merge pull request #11033 from openfoodfoundation/revert-10455-dependabot/bundler/redis-5.0.6
...
Revert "Fix `redis` and `hiredis-client` version requirements "
2023-06-16 13:42:55 +10:00
Maikel
24000b2ce3
Revert "Fix redis and hiredis-client version requirements "
2023-06-16 13:09:25 +10:00
Maikel
8e86f76278
Merge pull request #11018 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.2
...
chore(deps): bump sidekiq from 7.1.1 to 7.1.2
2023-06-16 12:08:25 +10:00
Maikel
4a91c180a3
Merge pull request #11017 from openfoodfoundation/dependabot/bundler/ddtrace-1.12.1
...
chore(deps): bump ddtrace from 1.12.0 to 1.12.1
2023-06-16 11:14:10 +10:00
Maikel
d192024786
Merge pull request #11019 from filipefurtad0/flaky_cache_spec
...
Clears cache around examples
2023-06-16 11:12:24 +10:00
Maikel
ec7de516aa
Merge pull request #11011 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.124.0
...
chore(deps): bump aws-sdk-s3 from 1.123.1 to 1.124.0
2023-06-16 10:59:56 +10:00
David Cook
47745b5e49
Merge pull request #11004 from dacook/show-current-version
...
Show current version at bottom of admin dashboard
2023-06-16 09:26:00 +10:00
Matt-Yorkley
3301c7cabc
Update stage.yml
2023-06-16 00:18:36 +01:00
David Cook
35d9837f24
Show current version at bottom of admin dashboard
...
With generic link to the releases page. We could provide a link to latest tag with `git describe --tags --abbrev=0`. But I thought it better to keep things simple.
2023-06-16 09:11:59 +10:00
Matt-Yorkley
436deb9797
Update stage.yml
2023-06-16 00:03:16 +01:00
Matt-Yorkley
57451f2639
Update stage.yml
2023-06-15 23:26:27 +01:00
Matt-Yorkley
d56ad66ab8
Update stage.yml
2023-06-15 20:57:40 +01:00
Matt-Yorkley
fc5a53ebd9
Update stage.yml
2023-06-15 20:53:20 +01:00
Matt-Yorkley
f27472106e
Update stage.yml
2023-06-15 20:52:07 +01:00