Maikel Linke
d602482d91
Fix report spec referencing distributor
2024-07-05 12:08:33 +10:00
Rachel Arnould
2c41d065df
Merge pull request #12594 from dacook/12559-fix-orders-and-distributors-report
...
Hide customer data on orders_and_distributors report
2024-07-03 13:12:42 +02:00
Gaetan Craig-Riou
f60a79437e
Reworked the test to use variant factory
...
Creating a variant actually create an extra one via the associated
product, as it will create a "standard variant".
As far as I can see there is no way around it, but it should be fixed
once the Product refactor is finished, and product becomes product
group.
Added a comment on the variant factory to explain the problem.
It's not ideal as it will slow down the test suite a little, but I think
it's better to write the code the way you would expect it, and it will
eventually get fixed.
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
6ee77fa406
Fix sales tax totals by order report
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
83fa080f76
Fix product and inventory report
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
17793e7b12
Fix packing report spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
45f4365385
Fix order cycle management report
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
c273c6b155
Fix enterprise fee with tax report specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
40892580cd
Fix enterprise fee summary report spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
323602abbb
Fix customer report specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
fddfd0dbfb
Fix bulk coop report
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
6d1a6c6d0e
Fix orders and fulfillment reports
...
Plus specs
2024-07-03 10:17:49 +10:00
Ahmed Ejaz
98e0b0e703
12346 - fix rubocop rails/pluck errors
2024-06-22 01:45:58 +05:00
David Cook
d80e1efa7b
Add includes for more efficient querying
2024-06-20 17:02:47 +10:00
David Cook
54d068ee08
Add spec for db queries
2024-06-20 17:02:47 +10:00
David Cook
141a883e4d
Refactor report
...
So it turns out that all these features are built into the report framework.
LineItems includes complete_not_canceled_visible_orders.
It even takes care of masking non-editable orders.
2024-06-20 17:02:47 +10:00
David Cook
5b8f590520
Add spec for bug
...
You wouldn't believe how long it took me to figure out all the bits and pieces.
But now you don't have to!
2024-06-20 17:01:14 +10:00
David Cook
0cff734b86
Refactor spec
...
Linter said module was too big. I agreed, so made it smaller.
Best viewed with whitespace ignored.
2024-06-20 16:58:09 +10:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Ana Nunes da Silva
0726e4c1d0
Fix offense constant definition in block in reports/line_items_spec.rb
2024-04-08 11:16:38 +01:00
Matt-Yorkley
d9899e8af6
Update more specs
2024-04-02 09:27:36 +11:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
Feruz Oripov
c2d8bdd414
cops
2024-02-27 01:01:22 +05:00
Feruz Oripov
ff6830f954
Update OutstandingBalanceQuery
2024-02-26 23:37:11 +05:00
Feruz Oripov
81f40a99d9
Update CustomersWithBalanceQuery
2024-02-26 23:25:33 +05:00
David Cook
47418d9873
Merge pull request #12014 from mkllnk/voucher-on
...
Remove feature toggle for vouchers, they are always on
2024-01-10 09:58:35 +11:00
Konrad
591885610a
Merge branch 'master' into task/11923-add-vouchers-to-oc-customer-total-report
2024-01-09 18:51:47 +01:00
Maikel Linke
a8c83b670b
Remove superfluous feature tag from specs
2024-01-08 15:53:50 +11:00
Ahmed Ejaz
3a957fb988
11923: add specs
2024-01-03 15:46:16 +05:00
Mohamed ABDELLANI
d239beb226
remove unnecessary require instructions
2024-01-03 11:34:57 +01:00
Maikel Linke
d841b1dae2
DRY feature activation in specs
...
It's simple this way and we have one place to add logic to when needed
(see next commit).
2023-11-17 13:17:27 +11:00
Maikel Linke
b83651a7ae
Avoid error when generating fee report
...
Instead some data is missing from the report. A slightly better outcome
but still wrong. This is tracked in another issue though.
2023-10-20 15:45:32 +11:00
Maikel Linke
4fc66f6585
Spec fee report failing on removed variant
...
Well, creating a unit test level spec in the first place. Edge cases
like this don't need to be tested in slow system specs.
2023-10-20 15:35:17 +11:00
Maikel Linke
43b1eca026
Remove unneeded report spec
...
Testing for the absence of behaviour is useful when changing code to
assert that the change is successful but in the long term, it doesn't
add any value. If you don't have any reason to believe that the report
may delete parameters then we don't need to test for that.
2023-10-20 14:22:43 +11:00
Maikel Linke
228f69f13e
Test customer report filtering without sorting
...
The report doesn't seem to sort. So the specs don't expect that either
now. These specs were flaky before, depending on the random order in the
database query result.
2023-10-09 12:05:24 +11:00
Çağrı Özkan
f93fcd347b
Rubocop fix
2023-10-04 02:00:21 +03:00
Çağrı Özkan
a5a13761a8
Filter with open ended boundaries upon missing params
2023-10-04 01:05:41 +03:00
Konrad
06ebeeac0f
Merge pull request #11543 from rioug/11364-Voucher-fix-tax-report
...
[Vouchers] Fix Sales Tax Totals By Order report
2023-10-01 02:09:33 +02:00
Gaetan Craig-Riou
33f3c660a4
Fix rubocop warning
2023-09-26 11:21:05 +02:00
Gaetan Craig-Riou
e9051f5c58
As per review comment, clarify specs
...
And some DRYing
2023-09-26 10:26:06 +02:00
Jean-Baptiste Bellet
2803f1c6b2
Group all orders by customer_id, email and distributor_id
...
Therefore have one (and only) row per customer
Co-Authored-By: Maikel <maikel@email.org.au >
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
9ce89125a4
Fix linter error: line is too long
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
d6c10170da
Use plain text instead of computed date in specs
...
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Code-Conventions#prefer-plain-text-over-method-calls-in-expected-values
2023-09-22 16:44:33 +01:00
jibees
5eab033a80
Improve indentation
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
82ccdcca70
Customers report has only one report: Customers
...
No more `addresses` report
+ Fix pre-existing rubocop issues
+ Create method to simplify and remove CyclomaticComplexity error
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
5edc8d8ce1
Delete Mailing List report
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
c6c9cdca65
Add last completed order date
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
d2fbaa7cfd
Add total amount spent at the shop for the customer
2023-09-22 16:44:33 +01:00
Jean-Baptiste Bellet
d55098f94f
Add the number of orders for the customer
2023-09-22 16:44:33 +01:00
