Remove unused Product#on_demand

This commit is contained in:
Maikel Linke
2025-03-28 14:00:40 +11:00
parent 9e1a66c1e5
commit d55d4dd8ed
2 changed files with 0 additions and 20 deletions

View File

@@ -5,13 +5,6 @@ require 'active_support/concern'
module ProductStock
extend ActiveSupport::Concern
def on_demand
raise 'Cannot determine product on_demand value of product with multiple variants' if
variants.size > 1
variants.first.on_demand
end
def on_hand
variants.map(&:on_hand).reduce(:+)
end

View File

@@ -6,12 +6,6 @@ RSpec.describe ProductStock do
let(:product) { create(:simple_product) }
context "when product has one variant" do
describe "product.on_demand" do
it "is the products first variant on_demand" do
expect(product.on_demand).to eq(product.variants.first.on_demand)
end
end
describe "product.on_hand" do
it "is the products first variant on_hand" do
expect(product.on_hand).to eq(product.variants.first.on_hand)
@@ -24,13 +18,6 @@ RSpec.describe ProductStock do
product.variants << create(:variant, product:)
end
describe "product.on_demand" do
it "raises error" do
expect { product.on_demand }
.to raise_error(StandardError, /Cannot determine product on_demand value/)
end
end
describe "product.on_hand" do
it "is the sum of the products variants on_hand values" do
expect(product.on_hand)