From d55d4dd8ed9c4bb9b66079bca4bf58e3808e133e Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 28 Mar 2025 14:00:40 +1100 Subject: [PATCH] Remove unused Product#on_demand --- app/models/concerns/product_stock.rb | 7 ------- spec/models/concerns/product_stock_spec.rb | 13 ------------- 2 files changed, 20 deletions(-) diff --git a/app/models/concerns/product_stock.rb b/app/models/concerns/product_stock.rb index 9c66e5e066..df7f55c949 100644 --- a/app/models/concerns/product_stock.rb +++ b/app/models/concerns/product_stock.rb @@ -5,13 +5,6 @@ require 'active_support/concern' module ProductStock extend ActiveSupport::Concern - def on_demand - raise 'Cannot determine product on_demand value of product with multiple variants' if - variants.size > 1 - - variants.first.on_demand - end - def on_hand variants.map(&:on_hand).reduce(:+) end diff --git a/spec/models/concerns/product_stock_spec.rb b/spec/models/concerns/product_stock_spec.rb index 751f57058a..70168671a6 100644 --- a/spec/models/concerns/product_stock_spec.rb +++ b/spec/models/concerns/product_stock_spec.rb @@ -6,12 +6,6 @@ RSpec.describe ProductStock do let(:product) { create(:simple_product) } context "when product has one variant" do - describe "product.on_demand" do - it "is the products first variant on_demand" do - expect(product.on_demand).to eq(product.variants.first.on_demand) - end - end - describe "product.on_hand" do it "is the products first variant on_hand" do expect(product.on_hand).to eq(product.variants.first.on_hand) @@ -24,13 +18,6 @@ RSpec.describe ProductStock do product.variants << create(:variant, product:) end - describe "product.on_demand" do - it "raises error" do - expect { product.on_demand } - .to raise_error(StandardError, /Cannot determine product on_demand value/) - end - end - describe "product.on_hand" do it "is the sum of the products variants on_hand values" do expect(product.on_hand)