raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid translation errors by hardcoding symbols

Browse Source 
The fullwidth plus and minus signs are well understood in all countries
(that participate in the development of OFN). It's more likely that a
translator enters a normal plus or minus than that they want to change
the symbol. A normal + or - sign doesn't fill a whole character space
and is therefore not well aligned in the design.
This commit is contained in:
Maikel Linke
2020-07-08 10:37:21 +10:00
parent b79d9bd75b
commit d2600b1d40
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/templates/bulk_buy_modal.html.haml
View File

@@ -14,20 +14,20 @@
{{ "js.bulk_buy_modal.min_quantity" | t }}
%div
%button.bulk-buy-add.variant-quantity{type: "button", ng: {click: "add(-1)", disabled: "!canAdd(-1)"}}>
{{ "js.shop_variant_no_group_buy.decrement" | t }}
－
%span.bulk-buy.variant-quantity>
{{ variant.line_item.quantity }}
%button.bulk-buy-add.variant-quantity{type: "button", ng: {click: "add(1)", disabled: "!canAdd(1)"}}
{{ "js.shop_variant_no_group_buy.increment" | t }}
＋
.columns.small-6
.variant-bulk-buy-quantity-label
{{ "js.bulk_buy_modal.max_quantity" | t }}
%div
%button.bulk-buy-add.variant-quantity{type: "button", ng: {click: "addMax(-1)", disabled: "!canAddMax(-1)"}}>
{{ "js.shop_variant_no_group_buy.decrement" | t }}
－
%span.bulk-buy.variant-quantity>
{{ variant.line_item.max_quantity }}
%button.bulk-buy-add.variant-quantity{type: "button", ng: {click: "addMax(1)", disabled: "!canAddMax(1)"}}
{{ "js.shop_variant_no_group_buy.increment" | t }}
＋
%ng-include{src: "'partials/close.html'"}

4
app/assets/javascripts/templates/partials/shop_variant_no_group_buy.html.haml
View File

@@ -3,9 +3,9 @@
%button.add-variant{type: "button", ng: {if: "!variant.line_item.quantity", click: "add(1)", disabled: "!canAdd(1)"}}
{{ "js.shop_variant_no_group_buy.add" | t }}
%button.variant-quantity{type: "button", ng: {if: "variant.line_item.quantity", click: "add(-1)"}}>
{{ "js.shop_variant_no_group_buy.decrement" | t }}
－
%button.variant-quantity{type: "button", ng: {if: "variant.line_item.quantity", click: "add(1)", disabled: "!canAdd(1)"}}
{{ "js.shop_variant_no_group_buy.increment" | t }}
＋
%br
.variant-quantity-display{ng: {class: "{visible: variant.line_item.quantity}"}}
{{ "js.shop_variant_no_group_buy.in_cart" | t:{quantity: variant.line_item.quantity || 0} }}

2
config/locales/en.yml
View File

@@ -2728,8 +2728,6 @@ See the %{link} to find out more about %{sitename}'s features and to start using
only_n_remainging: "now only has %{num} remaining."
shop_variant_no_group_buy:
add: "Add"
increment: "＋" # U+FF0B Fullwidth Plus Sign
decrement: "－" # U+FF0D Fullwidth Hyphen-Minus
in_cart: "%{quantity} in cart"
bulk_buy_modal:
min_quantity: "Min quantity"