mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-24 20:36:49 +00:00
Remove retries from previously flaky specs
It's not acceptable to have flaky specs that only pass once in three tries. Our specs might be more stable now that we use Chrome as test browser. Otherwise we have to find out why these specs are not stable. It might be an important bug that happens only sometimes.
This commit is contained in:
@@ -84,7 +84,7 @@ feature '
|
||||
expect(o.order_cycle).to eq(@order_cycle)
|
||||
end
|
||||
|
||||
scenario "can add a product to an existing order", retry: 3 do
|
||||
scenario "can add a product to an existing order" do
|
||||
quick_login_as_admin
|
||||
visit '/admin/orders'
|
||||
|
||||
|
||||
@@ -426,7 +426,7 @@ feature "
|
||||
select2_select hub.name, from: 'hub_id'
|
||||
end
|
||||
|
||||
it "alerts the user to the presence of new products, and allows them to be added or hidden", retry: 3 do
|
||||
it "alerts the user to the presence of new products, and allows them to be added or hidden" do
|
||||
expect(page).to have_no_selector "table#variant-overrides tr#v_#{variant1.id}"
|
||||
expect(page).to have_no_selector "table#variant-overrides tr#v_#{variant2.id}"
|
||||
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
require 'spec_helper'
|
||||
|
||||
feature "As a consumer I want to check out my cart", js: true, retry: 3 do
|
||||
feature "As a consumer I want to check out my cart", js: true do
|
||||
include AuthenticationWorkflow
|
||||
include ShopWorkflow
|
||||
include CheckoutWorkflow
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
require 'spec_helper'
|
||||
|
||||
feature "shopping with variant overrides defined", js: true, retry: 3 do
|
||||
feature "shopping with variant overrides defined", js: true do
|
||||
include AuthenticationWorkflow
|
||||
include WebHelper
|
||||
include ShopWorkflow
|
||||
|
||||
Reference in New Issue
Block a user