From cccd35fdf3744ce27a18b8fc84f8e2763606b70d Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 19 Jun 2019 16:48:04 +1000 Subject: [PATCH] Remove retries from previously flaky specs It's not acceptable to have flaky specs that only pass once in three tries. Our specs might be more stable now that we use Chrome as test browser. Otherwise we have to find out why these specs are not stable. It might be an important bug that happens only sometimes. --- spec/features/admin/orders_spec.rb | 2 +- spec/features/admin/variant_overrides_spec.rb | 2 +- spec/features/consumer/shopping/checkout_spec.rb | 2 +- spec/features/consumer/shopping/variant_overrides_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb index 3b54d31cdb..d9c018e499 100644 --- a/spec/features/admin/orders_spec.rb +++ b/spec/features/admin/orders_spec.rb @@ -84,7 +84,7 @@ feature ' expect(o.order_cycle).to eq(@order_cycle) end - scenario "can add a product to an existing order", retry: 3 do + scenario "can add a product to an existing order" do quick_login_as_admin visit '/admin/orders' diff --git a/spec/features/admin/variant_overrides_spec.rb b/spec/features/admin/variant_overrides_spec.rb index dd0457b7e2..a2598be6f1 100644 --- a/spec/features/admin/variant_overrides_spec.rb +++ b/spec/features/admin/variant_overrides_spec.rb @@ -426,7 +426,7 @@ feature " select2_select hub.name, from: 'hub_id' end - it "alerts the user to the presence of new products, and allows them to be added or hidden", retry: 3 do + it "alerts the user to the presence of new products, and allows them to be added or hidden" do expect(page).to have_no_selector "table#variant-overrides tr#v_#{variant1.id}" expect(page).to have_no_selector "table#variant-overrides tr#v_#{variant2.id}" diff --git a/spec/features/consumer/shopping/checkout_spec.rb b/spec/features/consumer/shopping/checkout_spec.rb index a9a23512e8..5635316150 100644 --- a/spec/features/consumer/shopping/checkout_spec.rb +++ b/spec/features/consumer/shopping/checkout_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature "As a consumer I want to check out my cart", js: true, retry: 3 do +feature "As a consumer I want to check out my cart", js: true do include AuthenticationWorkflow include ShopWorkflow include CheckoutWorkflow diff --git a/spec/features/consumer/shopping/variant_overrides_spec.rb b/spec/features/consumer/shopping/variant_overrides_spec.rb index ca08f5f1df..fb9d448c8f 100644 --- a/spec/features/consumer/shopping/variant_overrides_spec.rb +++ b/spec/features/consumer/shopping/variant_overrides_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature "shopping with variant overrides defined", js: true, retry: 3 do +feature "shopping with variant overrides defined", js: true do include AuthenticationWorkflow include WebHelper include ShopWorkflow