Per review, fix a some minor issues

This commit is contained in:
Gaetan Craig-Riou
2024-11-11 16:19:54 +11:00
committed by Rachel Arnould
parent d413a142c9
commit 9ab2a3ae3d
2 changed files with 2 additions and 2 deletions

View File

@@ -80,7 +80,7 @@ class CheckoutController < BaseController
# Redeem VINE voucher
vine_voucher_redeemer = Vine::VoucherRedeemerService.new(order: @order)
if vine_voucher_redeemer.redeem == false
unless vine_voucher_redeemer.redeem
# rubocop:disable Rails/DeprecatedActiveModelErrorsMethods
flash[:error] = if vine_voucher_redeemer.errors.keys.include?(:redeeming_failed)
vine_voucher_redeemer.errors[:redeeming_failed]

View File

@@ -47,7 +47,7 @@ RSpec.describe Spree::Admin::PaymentsController, type: :request do
end
end
context "when a getway error happens" do
context "when a gateway error happens" do
let(:payment_method) do
create(:stripe_sca_payment_method, distributors: [order.distributor])
end